mboehme created this revision. Herald added a subscriber: JDevlieghere. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.
See discussion here: https://github.com/llvm/llvm-project/issues/55982 We don't generally expect test files to be formatted according to the style guide. Indeed, some tests may require specific formatting for the purposes of the test. When tests intentionally do not conform to the "correct" formatting, this causes errors in the CI, which can drown out real errors and causes people to stop trusting the CI over time. >From the history of the clang/test/.clang-format file, it looks as if there have been attempts to make clang-format do a subset of formatting that would be useful for tests. However, it looks as if it's hard to make clang-format do exactly the right thing -- see the back-and-forth between 13316a7 <https://github.com/llvm/llvm-project/commit/13316a77053514be552a0dad932e3455413b4f82> and 7b5bddf <https://github.com/llvm/llvm-project/commit/7b5bddfd034ef42c92c67731743399df844d5f43>. Instead, I think the best choice is to entirely disable clang-format on the clang/test directory. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D128706 Files: clang/test/.clang-format Index: clang/test/.clang-format =================================================================== --- clang/test/.clang-format +++ clang/test/.clang-format @@ -1,3 +1 @@ -BasedOnStyle: LLVM -ColumnLimit: 0 -AlwaysBreakTemplateDeclarations: No +DisableFormat: true
Index: clang/test/.clang-format =================================================================== --- clang/test/.clang-format +++ clang/test/.clang-format @@ -1,3 +1 @@ -BasedOnStyle: LLVM -ColumnLimit: 0 -AlwaysBreakTemplateDeclarations: No +DisableFormat: true
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
