[PATCH] D128056: [clang][dataflow] Singleton pointer values for null pointers.

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:164-166 + /// Returns a pointer value that represents a null pointer. Calls + /// with `PointeeType` that are canonically equivalent wi

[PATCH] D128328: [C++20][Modules] Improve handing of Private Module Fragment diagnostics.

iains added a comment. In D128328#3602646 , @iains wrote: > In D128328#3601080 , @ChuanqiXu > wrote: > >> It looks like we need to handle inline variable as well to match the >> intention. > > can you construct

[PATCH] D128328: [C++20][Modules] Improve handing of Private Module Fragment diagnostics.

ChuanqiXu added a comment. In D128328#3603940 , @iains wrote: > In D128328#3602646 , @iains wrote: > >> In D128328#3601080 , @ChuanqiXu >> wrote: >> >>> It looks like we

[PATCH] D128328: [C++20][Modules] Improve handing of Private Module Fragment diagnostics.

iains added a comment. In D128328#3603942 , @ChuanqiXu wrote: > In D128328#3603940 , @iains wrote: > >> In D128328#3602646 , @iains wrote: >> >>> In D128328#3601080

[PATCH] D128097: [Clang] Fix compile time regression caused by D126061.

mboehme added a comment. Unfortunately, it looks as if this patch did not fix the compile-time regression entirely. It did so for the particular source file I tested above, but other source files are still slower to compile than before D126061 . For reference,

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

mboehme added a comment. https://reviews.llvm.org/D128097 is now submitted. Unfortunately, it didn't fix the compile-time regression entirely (see detailed comments there). I'll do some more investigation to see where the rest of the slowdown is coming from. Repository: rG LLVM Github Monor

[PATCH] D128328: [C++20][Modules] Improve handing of Private Module Fragment diagnostics.

ChuanqiXu added a comment. In D128328#3603945 , @iains wrote: > In D128328#3603942 , @ChuanqiXu > wrote: > >> In D128328#3603940 , @iains wrote: >> >>> In D128328#3602646

[PATCH] D128328: [C++20][Modules] Improve handing of Private Module Fragment diagnostics.

iains added a comment. In D128328#3603953 , @ChuanqiXu wrote: > In D128328#3603945 , @iains wrote: > >> In D128328#3603942 , @ChuanqiXu >> wrote: >> >>> In D128328#360394

[PATCH] D128328: [C++20][Modules] Improve handing of Private Module Fragment diagnostics.

ChuanqiXu added a comment. In D128328#3603967 , @iains wrote: > In D128328#3603953 , @ChuanqiXu > wrote: > >> In D128328#3603945 , @iains wrote: >> >>> In D128328#3603942

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

thieta created this revision. thieta added reviewers: hans, mstorsjo. Herald added a project: All. thieta requested review of this revision. Herald added a subscriber: MaskRay. Herald added a project: clang. Also make the output of -emit-ast end up where /Fo or /o points. The same with .plist file

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

thieta added inline comments. Comment at: clang/include/clang/Driver/Options.td:834 def Xoffload_linker : JoinedAndSeparate<["-"], "Xoffload-linker">, - HelpText<"Pass to the offload linkers or the ones idenfied by -">, + HelpText<"Pass to the offload linkers or the ones i

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

rovka added a comment. I just realized I haven't pestered you enough about testing :) Can you add a test that -O4 indeed warns and uses -O3? Also, the summary says this should work in both the compilation and the frontend driver, but you're only testing with %flang_fc1. Comm

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

cor3ntin updated this revision to Diff 439276. cor3ntin added a comment. - Remove explicit load instruction - cleanup extra braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128059/new/ https://reviews.llvm.org/D128059 Files: clang/docs/Relea

[PATCH] D113107: Support of expression granularity for _Float16.

pengfei added a comment. @zahiraam, community requires to enable the `_Float16` support in FE, see https://discourse.llvm.org/t/how-to-build-compiler-rt-for-new-x86-half-float-abi/63366 Is there any blocking issue to land it soon? Otherwise, we can split the changes in `X86.cpp`, `LanguageExtens

[PATCH] D126461: [RISCV] Extract and store new vl of vleff/vlsegff iff new_vl output pointer isn't null

pcwang-thead abandoned this revision. pcwang-thead added a comment. After discussion, we decide to not change anything right now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126461/new/ https://reviews.llvm.org/D126461 __

[PATCH] D128411: [syntax] Introduce a BaseToken class.

hokein created this revision. hokein added reviewers: sammccall, ilya-biryukov. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. This enables us to use a different underlying token implementation for the syntax Leaf node -- in clang pseudoparser

[PATCH] D128328: [C++20][Modules] Improve handing of Private Module Fragment diagnostics.

iains added a comment. In D128328#3603980 , @ChuanqiXu wrote: > >>> Also, **if** [module.private.frag]p2.1 is changed into: >>> the point by which the definition of an [exported] inline function or variable is required >>> >>> The test abov

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

awarzynski added a comment. In D128043#3604037 , @rovka wrote: > I just realized I haven't pestered you enough about testing :) I did feel like I was missing something here, haha! Updates arriving shortly! Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

awarzynski updated this revision to Diff 439285. awarzynski added a comment. Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128043/new/ https://reviews.llvm.org/D128043 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Too

[clang] 7dc81c6 - [clang][analyzer] Fix StdLibraryFunctionsChecker 'mkdir' return value.

Author: Balázs Kéri Date: 2022-06-23T11:27:26+02:00 New Revision: 7dc81c624433627e6811801b5a7e53d77c216616 URL: https://github.com/llvm/llvm-project/commit/7dc81c624433627e6811801b5a7e53d77c216616 DIFF: https://github.com/llvm/llvm-project/commit/7dc81c624433627e6811801b5a7e53d77c216616.diff L

[PATCH] D127277: [clang][analyzer] Fix StdLibraryFunctionsChecker 'mkdir' return value.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7dc81c624433: [clang][analyzer] Fix StdLibraryFunctionsChecker 'mkdir' return value. (authored by balazske). Repository: rG LLVM Github Monorepo

[PATCH] D128415: [ARM] Add Support for Cortex-M85 r=MarkMurrayARM,dmgreen,tmatheson

lenary created this revision. lenary added reviewers: MarkMurrayARM, dmgreen, tmatheson. Herald added subscribers: jdoerfert, hiraditya, kristof.beyls. Herald added a project: All. lenary requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits,

[clang] 8ef6280 - [analyzer] Structured binding to arrays

Author: isuckatcs Date: 2022-06-23T11:38:21+02:00 New Revision: 8ef628088b54aebd4a8317ce3a0029e3283b3aa0 URL: https://github.com/llvm/llvm-project/commit/8ef628088b54aebd4a8317ce3a0029e3283b3aa0 DIFF: https://github.com/llvm/llvm-project/commit/8ef628088b54aebd4a8317ce3a0029e3283b3aa0.diff LOG

[PATCH] D126613: [Static Analyzer] Structured binding to arrays

This revision was automatically updated to reflect the committed changes. Closed by commit rG8ef628088b54: [analyzer] Structured binding to arrays (authored by isuckatcs). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

jspam updated this revision to Diff 439300. jspam added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128157/new/ https://reviews.llvm.org/D128157 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/VirtualClassDestructorChe

[PATCH] D128328: [C++20][Modules] Improve handing of Private Module Fragment diagnostics.

ChuanqiXu added a comment. In D128328#3604110 , @iains wrote: > In D128328#3603980 , @ChuanqiXu > wrote: > >> > > > Also, **if** [module.private.frag]p2.1 is changed into: > the point by which the

[PATCH] D128097: [Clang] Fix compile time regression caused by D126061.

yurai007 added a comment. Disclaimer: I'm not front-end guy. After running 7zip benchmark under perf and comparing origin (7acc88be031 ) with fix (0d300da799b0

[PATCH] D125669: Adding support for target in_reduction

RitanyaB marked an inline comment as done. RitanyaB added a comment. In D125669#3599134 , @ABataev wrote: > What about the description? Shall we still emit ` if(0)`? Can you please elaborate for more clarity? Comment at: clang/lib/Cod

[clang] 6f258c0 - [Clang] Don't test register allocation

Author: Nikita Popov Date: 2022-06-23T12:46:00+02:00 New Revision: 6f258c0fd34cf4001ffa08c61f6e4e0f1254c50f URL: https://github.com/llvm/llvm-project/commit/6f258c0fd34cf4001ffa08c61f6e4e0f1254c50f DIFF: https://github.com/llvm/llvm-project/commit/6f258c0fd34cf4001ffa08c61f6e4e0f1254c50f.diff

[PATCH] D125669: Adding support for target in_reduction

ABataev added a comment. In D125669#3604302 , @RitanyaB wrote: > In D125669#3599134 , @ABataev wrote: > >> What about the description? Shall we still emit ` if(0)`? > > Can you please elaborate for more clarity?

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

hans added a comment. I'm unfamiliar with -emit-ast. Can you add some background on what this is for? What's CTU? In any case this needs a test. Comment at: clang/include/clang/Driver/Options.td:834 def Xoffload_linker : JoinedAndSeparate<["-"], "Xoffload-linker">, - HelpTe

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaExprMember.cpp:1873-1877 +if (auto *PrivateCopy = +isOpenMPFDCaptureDecl(Field, Base.get(), IsArrow, OpLoc, &SS, + /*TemplateKWLoc=*/SourceLocation(), Field, +

[PATCH] D128256: [Clang][AArch64] Limit arm_locally_streaming to function definitions only.

sdesmalen added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:9835-9839 + if (D.isFunctionDefinition()) { +NewFD->setWillHaveBody(); +ProcessDeclAttributes(S, NewFD, D); +NewFD->setWillHaveBody(false); + } else aaron.ballman wrote: > This

[clang-tools-extra] e36535f - Fix sphinx build for clang-tools-extra

Author: Aaron Ballman Date: 2022-06-23T07:22:00-04:00 New Revision: e36535f99cd4caa3773089a60eee26ad535a923d URL: https://github.com/llvm/llvm-project/commit/e36535f99cd4caa3773089a60eee26ad535a923d DIFF: https://github.com/llvm/llvm-project/commit/e36535f99cd4caa3773089a60eee26ad535a923d.diff

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

sdesmalen updated this revision to Diff 439330. sdesmalen marked 7 inline comments as done. sdesmalen added a comment. - Limited attribute to GNU spelling __attribute__((...)) - Changed `arm_locally_streaming` attribute to be `DeclOrStmtAttr` because it does not apply to type (only the definition

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

sdesmalen added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2322 +def ArmStreamingCompatible : DeclOrTypeAttr, TargetSpecificAttr { + let Spellings = [Clang<"arm_streaming_compatible">]; aaron.ballman wrote: > sdesmalen wrote: > > aaron.bal

[clang] cdc59e2 - [tbaa] Handle base classes in struct tbaa

Author: Bruno De Fraine Date: 2022-06-23T13:39:49+02:00 New Revision: cdc59e2202c11a6a5dfd2ec83531523c58eaae45 URL: https://github.com/llvm/llvm-project/commit/cdc59e2202c11a6a5dfd2ec83531523c58eaae45 DIFF: https://github.com/llvm/llvm-project/commit/cdc59e2202c11a6a5dfd2ec83531523c58eaae45.dif

[PATCH] D126956: [tbaa] Handle base classes in struct tbaa

This revision was automatically updated to reflect the committed changes. Closed by commit rGcdc59e2202c1: [tbaa] Handle base classes in struct tbaa (authored by brunodf, committed by jeroen.dobbelaere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D128299: [pseudo] Add a fast-path to GLR reduce when both pop and push are trivial

hokein added inline comments. Comment at: clang-tools-extra/pseudo/lib/GLR.cpp:268 + // However in trivial cases (only pop that yields only one push) we can + // bypass all these fancy queues and pop+push directly. This is very common. + auto PopAndPushTrivial = [&]() -> bool

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a comment. In D113107#3603761 , @pengfei wrote: >> Supporting the lowering in the backend is sensible in order to support >> -fexcess-precision=16, because I agree that the most reasonable IR output in >> that configuration is to simply g

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a comment. In D113107#3604048 , @pengfei wrote: > @zahiraam, community requires to enable the `_Float16` support in FE, see > https://discourse.llvm.org/t/how-to-build-compiler-rt-for-new-x86-half-float-abi/63366 > Is there any blocking is

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

thieta added a comment. In D128409#3604460 , @hans wrote: > I'm unfamiliar with -emit-ast. Can you add some background on what this is > for? What's CTU? CTU is cross translation unit. In this case the clang-static-analyzer can do analysis over several

[PATCH] D127448: [wip][pseudo] Implement guard extension.

sammccall added a comment. The ParseLang + CLI library seem clearly separate from everything else, I think this patch should be split. Comments on that part first... Comment at: clang-tools-extra/pseudo/benchmarks/Benchmark.cpp:68 for (auto _ : State) -LRTable::buildSL

[clang] b6a33ce - [NFC] remove trailing whitespace

Author: Tobias Hieta Date: 2022-06-23T14:04:23+02:00 New Revision: b6a33cec3830b6c9ea35faf35b4a5889c22c6ae9 URL: https://github.com/llvm/llvm-project/commit/b6a33cec3830b6c9ea35faf35b4a5889c22c6ae9 DIFF: https://github.com/llvm/llvm-project/commit/b6a33cec3830b6c9ea35faf35b4a5889c22c6ae9.diff

[PATCH] D112579: Allow non-variadic functions to be attributed with `__attribute__((format))`

aaron.ballman added a comment. In D112579#3603629 , @fcloutier wrote: > Would it be better if I asked a colleague to finish the review? Typically, you should try to get a LG from the reviewers who have been active on the review in the past (assuming the

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

thieta updated this revision to Diff 439341. thieta added a comment. Removed unintentional whitespace removal and landed that as a NFC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128409/new/ https://reviews.llvm.org/D128409 Files: clang/includ

[PATCH] D128282: [WebAssembly] Update test to run it in opaque pointers mode

pmatos updated this revision to Diff 439345. pmatos added a comment. Remove extraneous whitespace. Make equal CHECK lines use WEBASSEMBLY: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128282/new/ https://reviews.llvm.org/D128282 Files: clang/te

[clang] 0fdfeb0 - [WebAssembly] Update test to run it in opaque pointers mode

Author: Paulo Matos Date: 2022-06-23T14:16:33+02:00 New Revision: 0fdfeb0847dfbce9d5734f61c9fc16ed6f7dc17e URL: https://github.com/llvm/llvm-project/commit/0fdfeb0847dfbce9d5734f61c9fc16ed6f7dc17e DIFF: https://github.com/llvm/llvm-project/commit/0fdfeb0847dfbce9d5734f61c9fc16ed6f7dc17e.diff L

[PATCH] D128282: [WebAssembly] Update test to run it in opaque pointers mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0fdfeb0847df: [WebAssembly] Update test to run it in opaque pointers mode (authored by pmatos). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 8999b74 - Revert "[tbaa] Handle base classes in struct tbaa"

Author: Jeroen Dobbelaere Date: 2022-06-23T14:18:49+02:00 New Revision: 8999b745bc4ecae5ac74f5c4d06f40e317ddb12c URL: https://github.com/llvm/llvm-project/commit/8999b745bc4ecae5ac74f5c4d06f40e317ddb12c DIFF: https://github.com/llvm/llvm-project/commit/8999b745bc4ecae5ac74f5c4d06f40e317ddb12c.d

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

hans added a comment. In D128409#3604570 , @thieta wrote: > In D128409#3604460 , @hans wrote: > >> I'm unfamiliar with -emit-ast. Can you add some background on what this is >> for? What's CTU? > > CTU is cross t

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas updated this revision to Diff 439356. pratlucas added a comment. Fixing use-after-poison issue detected by ASAN buildbot. When popping LR on thumb it's value is popped into PC and used as a return. The original return instruction gets erased, invalidating the MachineInstr iterator. This

[PATCH] D128434: [OpenCL] Remove half scalar vload/vstore builtins

svenvh created this revision. svenvh added reviewers: Anastasia, stuart, azabaznov. svenvh added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. Herald added a project: All. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. These are not mentio

[PATCH] D128436: [OpenCL] Remove fast_ half geometric builtins

svenvh created this revision. svenvh added reviewers: Anastasia, stuart, azabaznov. svenvh added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. Herald added a project: All. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. These are not mentio

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp:28 +const Expr *RHSExpr = llvm::dyn_cast(RHS); +if (LHSExpr->containsErrors() && RHSExpr->containsErrors()) { + return false; njames93 wrote: >

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:236 +- Fixed a false positive in :doc:`bugprone-branch-clone + ` when the branches ishaangandhi wrote: > Eugene.Zelenko wrote: > > Documentation path was changed recently.

[PATCH] D128439: [Clang][WIP] Don't call distributeTypeAttrsFromDeclarator() on empty list.

mboehme created this revision. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This check was present before https://reviews.llvm.org/D126061. I eliminated it as part of that patch because it seemed supe

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi updated this revision to Diff 439369. ishaangandhi added a comment. Use `auto` instead of `Expr` and `llvm::cast` instead of `llvm::dyn_cast`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 Files: clang-tools-extra/clang-tidy/b

[PATCH] D128356: [clang][dataflow] Use NoopLattice in optional model

samestep added a comment. @xazax.hun After this patch, `SourceLocationsLattice` is still used by `clang/unittests/Analysis/FlowSensitive/UncheckedOptionalAccessModelTest.cpp`. I'm currently working on a patch to change the way we write unit tests in that file, after which I'll make a followup p

[PATCH] D128439: [Clang][WIP] Don't call distributeTypeAttrsFromDeclarator() on empty list.

mboehme added a comment. Marking as {WIP] for the time being because I'm uploading this change for discussion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128439/new/ https://reviews.llvm.org/D128439

[PATCH] D127898: [clang][dataflow] Add API to separate analysis from diagnosis

samestep updated this revision to Diff 439372. samestep added a comment. - Merge branch 'main' into diagnose-api - Incorporate Gábor's suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127898/new/ https://reviews.llvm.org/D127898 Files:

[PATCH] D128352: [clang][dataflow] Use diagnosis API in optional checker

samestep updated this revision to Diff 439373. samestep added a comment. - Merge branch 'diagnose-api' into optional-check-diagnose Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128352/new/ https://reviews.llvm.org/D128352 Files: clang-tools-ext

[PATCH] D128356: [clang][dataflow] Use NoopLattice in optional model

samestep updated this revision to Diff 439374. samestep added a comment. - Merge branch 'optional-check-diagnose' into optional-model-noop-lattice Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128356/new/ https://reviews.llvm.org/D128356 Files:

[PATCH] D128097: [Clang] Fix compile time regression caused by D126061.

mboehme added a comment. In D128097#3604295 , @yurai007 wrote: > Disclaimer: I'm not front-end guy. > > After running 7zip benchmark under perf and comparing origin (7acc88be031 > ) wit

[PATCH] D127448: [wip][pseudo] Implement guard extension.

sammccall added a comment. (comments for guard part) Comment at: clang-tools-extra/pseudo/include/clang-pseudo/Language.h:22 + +// Interface for implementing the grammar "guard" attribute. +// nit: I think the first sentence should try to describe what this *is

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:236 +- Fixed a false positive in :doc:`bugprone-branch-clone + ` when the branches ishaangandhi wrote: > ishaangandhi wrote: > > Eugene.Zelenko wrote: > > > Documentation

[PATCH] D126956: [tbaa] Handle base classes in struct tbaa

fhahn added a comment. It looks like this commit is breaking bootstrap builds of LLVM/Clang, e.g. https://lab.llvm.org/buildbot/#/builders/37/builds/14224 FAILED: lib/Bitcode/Reader/CMakeFiles/LLVMBitReader.dir/BitcodeReader.cpp.o /b/sanitizer-x86_64-linux-autoconf/build/tsan_debug_build/bi

[PATCH] D126956: [tbaa] Handle base classes in struct tbaa

jeroen.dobbelaere added a comment. In D126956#3604978 , @fhahn wrote: > Please take a look and revert the patch if the fix isn't trivial. the patch has already been reverted so Bruno can investigate. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D128411: [syntax] Introduce a BaseToken class.

sammccall added a comment. As discussed offline this has some problems: - putting virtual methods on BaseToken gives it a vtable, which makes it (and syntax::Token) large - being able to use ArrayRef but not ArrayRef is a bit weird - unusual uses of inheritance can be hard to reason about We s

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos created this revision. pmatos added reviewers: asb, tlively. Herald added subscribers: mattd, gchakrabarti, asavonic, StephenFan, wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added a reviewer: aaron.ballman. Herald added a project: All. pmatos requested re

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos planned changes to this revision. pmatos added a comment. Draft patch as some tests still fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm.org/D128440 ___ cfe-c

[PATCH] D127400: [pseudo] Add xfail tests for a simple-declaration/function-definition ambiguity

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/pseudo/test/cxx/declarator-var.cpp:10 +void (*s)(){}; +// CHECK-NOT: function-definition +// CHECK: init-declarator := declarator initializer

[clang-tools-extra] 6b187fd - [pseudo] Add xfail tests for a simple-declaration/function-definition ambiguity

Author: Sam McCall Date: 2022-06-23T15:52:22+02:00 New Revision: 6b187fdf3bb409061b6a235487517f478b09afed URL: https://github.com/llvm/llvm-project/commit/6b187fdf3bb409061b6a235487517f478b09afed DIFF: https://github.com/llvm/llvm-project/commit/6b187fdf3bb409061b6a235487517f478b09afed.diff LO

[PATCH] D127400: [pseudo] Add xfail tests for a simple-declaration/function-definition ambiguity

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG6b187fdf3bb4: [pseudo] Add xfail tests for a simple-declaration/function-definition ambiguity (authored by sammccall). Changed prior to commit: https://review

[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/Diagnostics.cpp:928 +std::tie(Module, Check) = Name.split('-'); +assert(!Module.empty() && !Check.empty()); +re

[PATCH] D128441: [CUDA] Do not embed a fatbinary when using the new driver

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tra, yaxunl. Herald added subscribers: mattd, carlosgalvezp. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project: clang. Previousl

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 439383. pmatos added a comment. Remove conflict marker Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm.org/D128440 Files: clang/include/clang/AST/ASTContext.h clang/include/cl

[PATCH] D128441: [CUDA] Do not embed a fatbinary when using the new driver

jhuber6 updated this revision to Diff 439384. jhuber6 added a comment. Remove comment that is no longer true now that `getInputFilename` always returns a `.cubin` variant for object types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128441/new/

[PATCH] D128401: [Clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp:159 +llvm::SmallSet &Callees) { +if (const CallExpr *Call = dyn_cast(StmtNode)) { +const Decl *Callee = Call->getDirectCallee(); -

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam updated this revision to Diff 439385. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113107/new/ https://reviews.llvm.org/D113107 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/include/clang/Basic/TargetInfo.h clang/lib/Basic/Targets/X86.cpp

[clang] 342e649 - [Sema] Fix assertion failure when instantiating requires expression

Author: Ilya Biryukov Date: 2022-06-23T16:20:30+02:00 New Revision: 342e64979afe0b3859462397c4a8abba6faa9de0 URL: https://github.com/llvm/llvm-project/commit/342e64979afe0b3859462397c4a8abba6faa9de0 DIFF: https://github.com/llvm/llvm-project/commit/342e64979afe0b3859462397c4a8abba6faa9de0.diff

[PATCH] D127487: [Sema] Fix assertion failure when instantiating requires expression

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG342e64979afe: [Sema] Fix assertion failure when instantiating requires expression (authored by ilya-biryukov). Changed prior to commit: https://re

[PATCH] D128048: Add a new clang option "-ftime-trace-path"

dongjunduo updated this revision to Diff 439389. dongjunduo added a comment. [Clang] change directory-store to path-store Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128048/new/ https://reviews.llvm.org/D128048 Files: clang/include/clang/Drive

[PATCH] D128097: [Clang] Fix compile time regression caused by D126061.

mboehme added a comment. To add to the points that @yurai007 pointed out, I’ve done some more investigation of my own. **Compile-time regression does not seem to reproduce locally** Unfortunately, I still haven’t been able to get the test suite running locally. However, I’ve looked at some ind

[PATCH] D128048: Add a new clang option "-ftime-trace-path"

dongjunduo added a comment. Hi @jamieschmeiser @Whitney , I have changed the approach from directory-store to path-store, so that the user can specify the aim path to store the time trace json file. If "-ftime-trace-path" is not specified, it will follow the default behavior. In addition, I a

[PATCH] D127976: [IR] Move vector.insert/vector.extract out of experimental namespace

paulwalker-arm accepted this revision. paulwalker-arm added inline comments. Comment at: llvm/docs/LangRef.rst:17282 + declare @llvm.vector.insert.nxv4f32.v4f32( %vec, <4 x float> %subvec, i64 %idx) + declare @llvm.vector.insert.nxv2f64.v2f64( %vec, <2 x double> %subv

[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp:159 +llvm::SmallSet &Callees) { +if (const CallExpr *Call

[PATCH] D128446: [clang][dataflow] Use annotations for optional diagnostic tests

samestep created this revision. Herald added subscribers: martong, tschuett, xazax.hun. Herald added a project: All. samestep requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D1

[PATCH] D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL

beanz added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:1697 +// HLSL +LANGBUILTIN(WaveActiveCountBits, "Uib", "nc", HLSL_LANG) + python3kgae wrote: > Anastasia wrote: > > python3kgae wrote: > > > Anastasia wrote: > > > > FYI we most of ti

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

kees added a comment. In D126864#3598257 , @serge-sans-paille wrote: > @kees does the new version looks good to you? Hi, yes, this is working as expected in my kernel builds. Yay! :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126864/new/ h

[PATCH] D128448: [clang][dataflow] Delete SourceLocationsLattice

samestep created this revision. Herald added subscribers: martong, tschuett, mgrang, xazax.hun, mgorny. Herald added a project: All. samestep requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Mon

[PATCH] D128415: [ARM] Add Support for Cortex-M85

dmgreen added inline comments. Comment at: llvm/lib/Target/ARM/ARM.td:1443 +def : ProcessorModel<"cortex-m85", CortexM4Model, [ARMv81mMainline, + FeatureDSP, Please use the CortexM7 schedule - it is

[PATCH] D124790: [HLSL] Enable half type for hlsl.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some minor changes. Comment at: clang/lib/AST/ASTContext.cpp:1712 + case BuiltinType::Half: +// For HLSL, when not enable native half type,

[PATCH] D128439: [Clang][WIP] Don't call distributeTypeAttrsFromDeclarator() on empty list.

nikic added a comment. Not seeing a statistically significant impact from this change: http://llvm-compile-time-tracker.com/compare.php?from=8b6f69a4da5baaf3748798a84dd16a2481b7ca7f&to=797ba50f5fd88017925fe765427b1f5f136c3310&stat=instructions Maybe it's an improvement at the 0.05% level, but it

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

miyuki added a comment. Hi Martin, I think this patch caused a regression. Clang used to warn about the following code: struct X { [[deprecated]] struct Y {}; }; $ clang -std=c++17 -Wall test.cpp :2:7: warning: attribute 'deprecated' is ignored, place it after "struct" to appl

[PATCH] D128449: [clang] Introduce -Warray-parameter

serge-sans-paille created this revision. serge-sans-paille added reviewers: RKSimon, aaron.ballman, tstellar. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This warning exist in GCC[0] and wa

[clang] 9ec7e4d - [clang][driver] NFC, test: Make test output order-independent

Author: Jan Svoboda Date: 2022-06-23T17:15:28+02:00 New Revision: 9ec7e4df57f3716018cc0ef60c5d37c8cf6a7cbc URL: https://github.com/llvm/llvm-project/commit/9ec7e4df57f3716018cc0ef60c5d37c8cf6a7cbc DIFF: https://github.com/llvm/llvm-project/commit/9ec7e4df57f3716018cc0ef60c5d37c8cf6a7cbc.diff L

[PATCH] D128097: [Clang] Fix compile time regression caused by D126061.

nikic added a comment. @mboehme Cycle counts are very noisy, and it's pretty much impossible to determine whether they changed by looking at a single commit, unless the differences are huge (like 10%). In this case, the commit got "lucky" and the next commit goes back to the previous level. Thi

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

aaron.ballman added a comment. In D126061#3605276 , @miyuki wrote: > Hi Martin, > > I think this patch caused a regression in diagnostics. Clang used to warn > about the following code: > > struct X { > [[deprecated]] struct Y {}; > }; > > > >

[PATCH] D128297: [pseudo] Track heads as GSS nodes, rather than as "pending actions".

sammccall marked 6 inline comments as done. sammccall added a comment. As discussed offline, I'm going to land this patch as other approved optimizations are based on it, and there are no big objections. Please feel free to keep discussing details here and I'll land followups. ===

  1   2   3   >