[PATCH] D128204: [clangd] Add fix-it for inserting IWYU pragma: keep

kadircet added a comment. > I had another idea about offering the export pragma when in a header file but > I don't know if that's going too far There are definitely cases where this is conceptually "right" fix, but it's hard to guess that in clangd (well at least without having some codebase w

[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

ChuanqiXu updated this revision to Diff 438929. ChuanqiXu added a comment. Add test from https://eel.is/c++draft/module.context#example-1 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113545/new/ https://reviews.llvm.org/D113545 Files: clang/include/clang/AST/DeclBase.h clang/inclu

[PATCH] D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct

jackhong12 updated this revision to Diff 438921. jackhong12 marked an inline comment as done. jackhong12 added a comment. I have added a variable for `MatchingLBrace->getPreviousNonComment()`. Thanks. I am not sure which modification will be better, the patch I submitted or the following code.

[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

ChuanqiXu added a comment. In D113545#3598412 , @iains wrote: > As for review, I can try to pick up the "nits" but not sure that I know the > instantiation sub=system too well, so it would be better if @rsmith could > cast an eye over those parts. Yeah

[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

ChuanqiXu updated this revision to Diff 438930. ChuanqiXu added a comment. Update comments for the test of [module.context]p7. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113545/new/ https://reviews.llvm.org/D113545 Files: clang/include/clang/AST/DeclBase.h clang/include/clang/Ba

[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

iains added a comment. I think it is helpful to collect the standard examples into one place (i.e. test/Modules) and name them for the standard version (i.e. cxx20-N-M-exO.cpp) .. because - the details of the examples do change from one version of the standard to the next, because of changes i

[clang] 706e89d - Fix interaction of pragma FENV_ACCESS with other pragmas

Author: Serge Pavlov Date: 2022-06-22T15:13:54+07:00 New Revision: 706e89db97d3dea63dac1ee2c5a26cb2af9651a2 URL: https://github.com/llvm/llvm-project/commit/706e89db97d3dea63dac1ee2c5a26cb2af9651a2 DIFF: https://github.com/llvm/llvm-project/commit/706e89db97d3dea63dac1ee2c5a26cb2af9651a2.diff

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG706e89db97d3: Fix interaction of pragma FENV_ACCESS with other pragmas (authored by sepavloff). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

ChuanqiXu added a comment. In D113545#3601031 , @iains wrote: > I think it is helpful to collect the standard examples into one place (i.e. > test/Modules) and name them for the standard version (i.e. cxx20-N-M-exO.cpp) > .. because > > - the details of

[PATCH] D128328: [C++20][Modules] Improve handing of Private Module Fragment diagnostics.

iains created this revision. Herald added a project: All. iains added reviewers: urnathan, ChuanqiXu. iains added a subscriber: clang-modules. iains published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds a check for exported inline func

[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

iains added a comment. In D113545#3601050 , @ChuanqiXu wrote: > In D113545#3601031 , @iains wrote: > >> I think it is helpful to collect the standard examples into one place (i.e. >> test/Modules) and name them f

[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

ChuanqiXu added a comment. In D113545#3601069 , @iains wrote: > In D113545#3601050 , @ChuanqiXu > wrote: > >> In D113545#3601031 , @iains wrote: >> >>> I think it is help

[PATCH] D128328: [C++20][Modules] Improve handing of Private Module Fragment diagnostics.

ChuanqiXu added a comment. It looks like we need to handle inline variable as well to match the intention. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11155 +def err_export_inline_not_defined : Error< + "exported inline functions must be defined within the mod

[PATCH] D128329: [clangd] Also mark output arguments of operator call expressions

ckandeler created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. There's no reason that argum

[PATCH] D128282: [WebAssembly] Update test to run it in opaque pointers mode

asb added a comment. In D128282#3600355 , @tlively wrote: > I think the lines still differ in that one tests wasm32 and the other tests > wasm64 (the triples are different). Yeah, but the convention used elsewhere in this test file is to use `WEBASSEMB

[PATCH] D112916: [clang-tidy] Confusable identifiers detection

whisperity accepted this revision. whisperity added a comment. This revision is now accepted and ready to land. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112916/new/ https://reviews.llvm.org/D112916 ___ cfe-commits mailing l

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

GuillaumeGomez marked an inline comment as done. GuillaumeGomez added a comment. Is there anything else for me to do in here so it gets merged? (Sorry if I missed it but I couldn't find out the exact merge process in the documentation) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D127184: [clangd] Add to header map

falbrechtskirchinger added a comment. In D127184#3588226 , @nridge wrote: > In D127184#3577165 , > @falbrechtskirchinger wrote: > >> bits/mofunc_impl.h > > I see this included from `bits/move_only_function.h`, so

[PATCH] D128204: [clangd] Add fix-it for inserting IWYU pragma: keep

njames93 added a comment. In D128204#3600973 , @kadircet wrote: >> One of the main issues I have is due to templates not being instantiated >> which can result in symbols that are actually used not being picked up as >> the template instantiation that u

[PATCH] D127446: [clang-tidy] Add `-verify-config` command line argument

njames93 marked 4 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:263 +Check the config files to ensure each check and +option is recognised. +)"), aaron.ballman wrote: > :) =

[PATCH] D127446: [clang-tidy] Add `-verify-config` command line argument

njames93 updated this revision to Diff 438953. njames93 marked an inline comment as done. njames93 added a comment. Address reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127446/new/ https://reviews.llvm.org/D127446 Files: clan

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

RKSimon added a comment. It looks like this is good to go - do you have commit access? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127460/new/ https://reviews.llvm.org/D127460 ___ cfe-commits mailing l

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

GuillaumeGomez added a comment. This is my first LLVM contribution so I don't think I do? If I do have a commit access anyway, do you have a link to the documentation where it explains what I'm supposed to do by any chance? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D126859: [clangd] Validate clang-tidy CheckOptions in clangd config

njames93 added a comment. In D126859#3599340 , @kadircet wrote: > I also agree with the typo correction verdict. In theory there'll be two > cases: > > - typo correction helps, in which case it'll be obvious from the warning > itself. > - typo correcti

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

xbolva00 requested changes to this revision. xbolva00 added a comment. This revision now requires changes to proceed. Patch description needs to be added, especially answer the question why we should rename it, why we want it.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128314: [Clang-tidy] Fixing bugs in clang-tidy infinite-loop checker

njames93 added a comment. Can this patch be split in two, it seems strange to be fixing 2 unrelated bugs in one patch. One fix for the ObjC nodes and another for the patch for the static local variables. Also please can you run git clang-format over this patch. Comment at: c

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

xbolva00 added a comment. In D127460#3601152 , @GuillaumeGomez wrote: > This is my first LLVM contribution so I don't think I do? If I do have a > commit access anyway, do you have a link to the documentation where it > explains what I'm supposed to do

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed updated this revision to Diff 438962. omarahmed added a comment. Format files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127270/new/ https://reviews.llvm.org/D127270 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/tools/d

[PATCH] D127446: [clang-tidy] Add `-verify-config` command line argument

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/infrastructure/verify-config.cpp:12 + +// CHECK-VERIFY-DAG: command-line option '-config': warning: Unknown Check 'readability-else-after-ret'; did you mean 'readability-else-after-return' +// CH

[PATCH] D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang

awarzynski created this revision. awarzynski added reviewers: rovka, MaskRay, schweitz, Leporacanthicus. Herald added subscribers: jsji, StephenFan, pengfei, kristof.beyls. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. awarzynski requested review of this revision. Herald ad

[PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

iains updated this revision to Diff 438968. iains marked 2 inline comments as done. iains added a comment. reabsed onto latest version of D113545 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126694/new/ https://

[PATCH] D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang

kiranchandramohan added a comment. Is the longer-term plan to support this in Flang as well? Does this affect building object files too or is it just the executable? How would this affect mixed C++/Fortran programs if the Clang and Flang settings are different? Repository: rG LLVM Github Mo

[PATCH] D128297: [pseudo] Track heads as GSS nodes, rather than as "pending actions".

hokein added a comment. Thanks, this looks a reasonable change to me. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/GLR.h:140 + const ForestNode &NextTok, const ParseParams &Params, + std::vector &NewHeads); +// Applies available reductions

[PATCH] D127976: [IR] Move vector.insert/vector.extract out of experimental namespace

bsmith updated this revision to Diff 438975. bsmith added a comment. - Further improve clarity on usable types in LangRef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127976/new/ https://reviews.llvm.org/D127976 Files: clang/include/clang/Basic

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

aaron.ballman added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:2702-2703 // (probably ending) '/' character. -if (CurPtr + 24 < BufferEnd && +// When diagnosing invalid UTF-8 sequences we always skip the fast +// vectorized path. +if (!WarnOnInvalid

[PATCH] D127923: [Diagnostics] Accept newline and format diag opts on first line

aaron.ballman added a comment. In D127923#3600422 , @vangthao wrote: > In D127923#3599451 , @aaron.ballman > wrote: > >> Is there a reason the remarks can't use individual diagnostic emissions to >> simulate new

[PATCH] D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang

awarzynski added a comment. In D128333#3601299 , @kiranchandramohan wrote: > Is the longer-term plan to support this in Flang as well? I don't see why not. AFAIK, the switch in Clang took a while and happened gradually - so we probably shouldn't rush t

[PATCH] D128207: [clang-doc][NFC] Fix reference invalidation assertion failure.

MTC added a comment. Sorry for the delayed response. Adding the regression test is not as simple as I thought, **first of all clang-tools-extra does not enable the //assert//**, see https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/test/lit.site.cfg.py.in . And add the clang-doc

[PATCH] D127487: [Sema] Fix assertion failure when instantiating requires expression

ilya-biryukov updated this revision to Diff 438977. ilya-biryukov added a comment. - Update test, check error messages Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127487/new/ https://reviews.llvm.org/D127487 Files: clang/lib/Sema/SemaConcept.c

[PATCH] D127487: [Sema] Fix assertion failure when instantiating requires expression

ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. @erichkeane could you take another look at this? Comment at: clang/test/SemaTemplate/concepts-PR54629.cpp:10 +int main() { + A a; +} ilya-biryukov wrote: > erichkeane wrote: > > Sim

[PATCH] D128337: [clang-tidy] Extend spelling for CheckOptions

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh. Herald added subscribers: carlosgalvezp, arphaman, xazax.hun. Herald added a project: All. njames93 requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang-tools

[PATCH] D127446: [clang-tidy] Add `-verify-config` command line argument

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/infrastructure/verify-config.cpp:12 + +// CHECK-VERIFY-DAG: command-line option '-config': warning: Unknown Check 'readability-else-after-ret'; did you mean 'readability-else-after-return' +// CHECK-V

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

cor3ntin updated this revision to Diff 438984. cor3ntin added a comment. s/UnicodeDecodeFailed/UnicodeDecodingAlreadyDiagnosed/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128059/new/ https://reviews.llvm.org/D128059 Files: clang/docs/ReleaseN

[PATCH] D125916: [PowerPC] Defined and lowered llvm.ppc.kill.canary intrinsic

pscoro updated this revision to Diff 438985. pscoro added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. [PowerPC] implemented kill_canary intrinsic and tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125916/ne

[PATCH] D128299: [pseudo] Add a fast-path to GLR reduce when both pop and push are trivial

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/pseudo/lib/GLR.cpp:269 + // bypass all these fancy queues and pop+push directly. This is very common. + auto PopAndPushTrivial = [&]() ->

[PATCH] D125916: [PowerPC] Defined and lowered llvm.ppc.kill.canary intrinsic

pscoro updated this revision to Diff 438987. pscoro added a comment. [PowerPC] Removed accidental patch files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125916/new/ https://reviews.llvm.org/D125916 Files: clang/include/clang/Basic/BuiltinsPPC

[PATCH] D125916: [PowerPC] Defined and lowered llvm.ppc.kill.canary intrinsic

pscoro updated this revision to Diff 438988. pscoro added a comment. [PowerPC] Removed commented change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125916/new/ https://reviews.llvm.org/D125916 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

GuillaumeGomez updated this revision to Diff 438989. GuillaumeGomez added a comment. Rename GCCBuiltin into ClangBuiltin. This patch is needeed because developers expect "GCCBuiltin" items to be the GCC intrinsics equivalent and not the Clang internals. Repository: rG LLVM Github Monorepo C

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

GuillaumeGomez added a comment. In D127460#3601193 , @xbolva00 wrote: > Patch description needs to be added, especially answer the question why we > should rename it, why we want it.. I updated the description to explain why it is needed. I'm not sure h

[PATCH] D125916: [PowerPC] Defined and lowered llvm.ppc.kill.canary intrinsic

pscoro added a comment. @shchenz I have added the test cases. This intrinsic is defined in order to test the stackprotect functionality on xlf. Use the -qdebug=smashstack flag to use it, make sure that -qstackprotect=all is also set Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam marked 7 inline comments as done. zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGExprComplex.cpp:896 + +ComplexPairTy ComplexExprEmitter::EmitPromoted(const Expr *E) { + if (auto *BinOp = dyn_cast(E->IgnoreParens())) { pengfei wrote: >

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

cor3ntin updated this revision to Diff 438990. cor3ntin added a comment. Make sure the warning is off by default. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128059/new/ https://reviews.llvm.org/D128059 Files: clang/docs/ReleaseNotes.rst cla

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

rovka added inline comments. Comment at: flang/include/flang/Frontend/CodeGenOptions.def:12 +// Optionally, the user may also define ENUM_CODEGENOPT (for options +// that have enumeration type and VALUE_CODEGENOPT is a code +// generation option that describes a value rather than

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

GuillaumeGomez added a comment. So from the documentation: > Prior to obtaining commit access, it is common practice to request that > someone with commit access commits on your behalf. When doing so, please > provide the name and email address you would like to use in the Author > property of

[PATCH] D127812: [AArch64] Function multiversioning support added.

danielkiss added a comment. In D127812#3599530 , @aaron.ballman wrote: > In D127812#3587223 , @ilinpv wrote: > >> In D127812#3585249 , @erichkeane >> wrote: >> >>> I'm c

[clang-tools-extra] bb29702 - Don't treat invalid parameters as being unused

Author: Aaron Ballman Date: 2022-06-22T08:56:38-04:00 New Revision: bb297024fad2f6c3ccaaa6a5c3a270f73f15f3ac URL: https://github.com/llvm/llvm-project/commit/bb297024fad2f6c3ccaaa6a5c3a270f73f15f3ac DIFF: https://github.com/llvm/llvm-project/commit/bb297024fad2f6c3ccaaa6a5c3a270f73f15f3ac.diff

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

awarzynski added a comment. Thanks for taking a look, @peixin! Just to clarify - I'm not really looking into `-Os`, `-Ofast` or `-Oz` at the moment. But I'm always happy to review driver patches :) Comment at: clang/include/clang/Driver/Options.td:732 +def O_flag : Flag<["-"]

[PATCH] D127446: [clang-tidy] Add `-verify-config` command line argument

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/test/clang-tidy/infrastructure/verify-config.cpp:12 + +// CHECK-VERIFY-DAG: command-line option '-config': warning: Unknown

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane marked an inline comment as done. erichkeane added a comment. In D126907#3600876 , @ChuanqiXu wrote: > Great progress! > > In D126907#3599835 , @erichkeane > wrote: > >> Note that the failure comes dow

[PATCH] D127446: [clang-tidy] Add `-verify-config` command line argument

njames93 added subscribers: kadircet, sammccall. njames93 added a comment. Before this lands @sammccall @kadircet Do you have any concerns about this API for getting the options not building a static instance here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D122677: [prototype] include-cleaner library

serge-sans-paille added a comment. Hey Sam, any update on this one? How can I help? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122677/new/ https://reviews.llvm.org/D122677 ___ cfe-commits mailing list

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

awarzynski updated this revision to Diff 438995. awarzynski marked 3 inline comments as done. awarzynski added a comment. Address comments from Peixin and Diana Main change - removed ENUM_CODEGENOPT and VALUE_CODEGENOPT from CodeGenOptions.dev. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D127923: [Diagnostics] Accept newline and format diag opts on first line

arsenm added a comment. My objection to the original patch was including things like the "" lines as remarks to mark a section. I don't think these should be emitted as remarks and are a display function the frontend should take care of if we want any kind of grouping Repository: rG LLV

[clang] 958a885 - [LinkerWrapper] Rework the linker wrapper and use owning binaries

Author: Joseph Huber Date: 2022-06-22T09:24:10-04:00 New Revision: 958a8850508088766fe19202037e2f46805e2c65 URL: https://github.com/llvm/llvm-project/commit/958a8850508088766fe19202037e2f46805e2c65 DIFF: https://github.com/llvm/llvm-project/commit/958a8850508088766fe19202037e2f46805e2c65.diff

[PATCH] D127246: [LinkerWrapper] Rework the linker wrapper and use owning binaries

This revision was automatically updated to reflect the committed changes. Closed by commit rG958a88505080: [LinkerWrapper] Rework the linker wrapper and use owning binaries (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127246/n

[clang] 21e29b6 - [Clang] Allow multiple comma separated arguments to `--offload-arch=`

Author: Joseph Huber Date: 2022-06-22T09:25:04-04:00 New Revision: 21e29b6ce734cca1557aa801740078d98c3ff447 URL: https://github.com/llvm/llvm-project/commit/21e29b6ce734cca1557aa801740078d98c3ff447 DIFF: https://github.com/llvm/llvm-project/commit/21e29b6ce734cca1557aa801740078d98c3ff447.diff

[PATCH] D128206: [Clang] Allow multiple comma separated arguments to `--offload-arch=`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG21e29b6ce734: [Clang] Allow multiple comma separated arguments to `--offload-arch=` (authored by jhuber6). Repository: rG LLVM Github Monorepo CH

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

peixin accepted this revision. peixin added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/Driver/Options.td:732 +def O_flag : Flag<["-"], "O">, Flags<[CC1Option,FC1Option]>, Alias, AliasArgs<["1"]>; def Ofast : Joined<["-"],

[PATCH] D127487: [Sema] Fix assertion failure when instantiating requires expression

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:2039 TransConstraint = TransformExpr(Req->getConstraintExpr()); +if (!TransConstraint.isInvalid()) { + bool CheckSucceeded = I think I'd rather collapse this in

[PATCH] D113107: Support of expression granularity for _Float16.

pengfei added inline comments. Comment at: clang/lib/CodeGen/CGExprComplex.cpp:896 + +ComplexPairTy ComplexExprEmitter::EmitPromoted(const Expr *E) { + if (auto *BinOp = dyn_cast(E->IgnoreParens())) { zahiraam wrote: > pengfei wrote: > > rjmccall wrote: > > > pe

[clang] a9fd8b9 - [LinkerWrapper] Fix calls to deleted Error constructor on older compilers

Author: Joseph Huber Date: 2022-06-22T09:39:23-04:00 New Revision: a9fd8b911331dad1b5f94e3aba5ce0927e632ade URL: https://github.com/llvm/llvm-project/commit/a9fd8b911331dad1b5f94e3aba5ce0927e632ade DIFF: https://github.com/llvm/llvm-project/commit/a9fd8b911331dad1b5f94e3aba5ce0927e632ade.diff

[PATCH] D128048: Add a new clang option "-ftime-trace-path"

jamieschmeiser added a comment. Can you please use git rebase -i to collapse all the changes into a single change? If this isn't done, it is difficult to know what is being reviewed as the changes only show the differences since your last revision, not all of the changes. Repository: rG LL

[PATCH] D128048: Add a new clang option "-ftime-trace-path"

Whitney added a comment. In D128048#3601579 , @jamieschmeiser wrote: > Can you please use git rebase -i to collapse all the changes into a single > change? If this isn't done, it is difficult to know what is being reviewed > as the changes only show t

[PATCH] D128048: Add a new clang option "-ftime-trace-path"

dongjunduo marked 4 inline comments as done. dongjunduo added a comment. In D128048#3601579 , @jamieschmeiser wrote: > Can you please use git rebase -i to collapse all the changes into a single > change? If this isn't done, it is difficult to know what

[PATCH] D127803: Generate the capture for field when the field is used with implicit default.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaExprMember.cpp:1873-1877 +if (auto *PrivateCopy = +isOpenMPFDCaptureDecl(Field, Base.get(), IsArrow, OpLoc, &SS, + /*TemplateKWLoc=*/SourceLocation(), Field, +

[clang] 17e2702 - Clang AttributeReference: emit entries for "Undocumented" attributes.

Author: James Y Knight Date: 2022-06-22T09:55:05-04:00 New Revision: 17e27025287b96026a4351e1d73931bb0c76dac2 URL: https://github.com/llvm/llvm-project/commit/17e27025287b96026a4351e1d73931bb0c76dac2 DIFF: https://github.com/llvm/llvm-project/commit/17e27025287b96026a4351e1d73931bb0c76dac2.diff

[PATCH] D126859: [clangd] Validate clang-tidy CheckOptions in clangd config

njames93 updated this revision to Diff 439004. njames93 added a comment. Remove typo correction support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126859/new/ https://reviews.llvm.org/D126859 Files: clang-tools-extra/clangd/ConfigCompile.cpp

[PATCH] D112916: [clang-tidy] Confusable identifiers detection

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc3574ef739fb: [clang-tidy] Confusable identifiers detection (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D128307: [pseudo] Store reduction sequences by pointer in heaps, instead of by value.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/pseudo/lib/GLR.cpp:208 + // Underlying storage for sequences pointed to by stored SequenceRefs. + std::deque SequenceStorage; + // We don

[PATCH] D128337: [clang-tidy] Extend spelling for CheckOptions

njames93 updated this revision to Diff 439018. njames93 added a comment. Herald added subscribers: usaxena95, kadircet. Update some test files using new syntax. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128337/new/ https://reviews.llvm.org/D128

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam updated this revision to Diff 439020. zahiraam marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113107/new/ https://reviews.llvm.org/D113107 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Target

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGExprComplex.cpp:896 + +ComplexPairTy ComplexExprEmitter::EmitPromoted(const Expr *E) { + if (auto *BinOp = dyn_cast(E->IgnoreParens())) { pengfei wrote: > zahiraam wrote: > > pengfei wrote: > > > rj

[clang-tools-extra] 721875d - Reland "[gn build] (manually) port b94db7ed7eaf (Confusables.inc)"

Author: Nico Weber Date: 2022-06-22T10:38:14-04:00 New Revision: 721875db2b8a1bff8ac2ed353aca7809904d7187 URL: https://github.com/llvm/llvm-project/commit/721875db2b8a1bff8ac2ed353aca7809904d7187 DIFF: https://github.com/llvm/llvm-project/commit/721875db2b8a1bff8ac2ed353aca7809904d7187.diff LO

[PATCH] D128119: [clang] enforce instantiation of constexpr template functions

serge-sans-paille updated this revision to Diff 439022. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128119/new/ https://reviews.llvm.org/D128119 Files: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp clang/test/SemaCXX/constexpr-late-instantiation.cpp Index: clang/test/SemaCXX/con

[PATCH] D125916: [PowerPC] Defined and lowered llvm.ppc.kill.canary intrinsic

shchenz added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:11136 +MachineFrameInfo &MFI = MF.getFrameInfo(); +int SPI = MFI.getStackProtectorIndex(); // should return -1 + Why should return -1? Comment a

[PATCH] D127142: [HIP] Link with clang_rt.builtins

yaxunl added a comment. In D127142#3600809 , @MaskRay wrote: > Magically deciding a default value for --unwindlib or --rtlib is not nice. > You may emit a warning if the selected default happens to be incompatible > with HIP. We build clang not just fo

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added a comment. Supporting the lowering in the backend is sensible in order to support `-fexcess-precision=16`, because I agree that the most reasonable IR output in that configuration is to simply generate `half` operations. But under `-fexcess-precision=32`, I do not want the front

[PATCH] D127898: [clang][dataflow] Add API to separate analysis from diagnosis

sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Diagnosis.h:26 +template +using Diagnosis = +std::function; Let's add some documentation for `Diagnosis` and `diagnoseCFG`. Comment at: clang/include/clan

[PATCH] D128351: [clang] missing outer template levels when checking template constraints

Lancern created this revision. Lancern added reviewers: Richard, smith. Herald added a project: All. Lancern requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When checking constraint satisfaction on template arguments, the outer template lev

[PATCH] D128352: [clang][dataflow] Use diagnosis API in optional checker

samestep created this revision. Herald added subscribers: martong, tschuett, carlosgalvezp, xazax.hun. Herald added a project: All. samestep requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D128048: Add a new clang option "-ftime-trace-path"

jamieschmeiser added a comment. In D128048#3601588 , @Whitney wrote: > In D128048#3601579 , > @jamieschmeiser wrote: > >> Can you please use git rebase -i to collapse all the changes into a single >> change? If

[PATCH] D126164: [flang][Driver] Refine _when_ driver diagnostics are formatted

This revision was automatically updated to reflect the committed changes. Closed by commit rG430841605d49: [flang][Driver] Refine _when_ driver diagnostics are formatted (authored by peixin). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monor

[clang] 4308416 - [flang][Driver] Refine _when_ driver diagnostics are formatted

Author: Peixin Qiao Date: 2022-06-22T23:56:34+08:00 New Revision: 430841605d49f515b6a671ec772135cf67ca9506 URL: https://github.com/llvm/llvm-project/commit/430841605d49f515b6a671ec772135cf67ca9506 DIFF: https://github.com/llvm/llvm-project/commit/430841605d49f515b6a671ec772135cf67ca9506.diff L

[PATCH] D128352: [clang][dataflow] Use diagnosis API in optional checker

samestep updated this revision to Diff 439042. samestep added a comment. Remove unnecessary ExitBlock code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128352/new/ https://reviews.llvm.org/D128352 Files: clang-tools-extra/clang-tidy/bugprone/Un

[PATCH] D127487: [Sema] Fix assertion failure when instantiating requires expression

ilya-biryukov added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:2039 TransConstraint = TransformExpr(Req->getConstraintExpr()); +if (!TransConstraint.isInvalid()) { + bool CheckSucceeded = erichkeane wrote: > I think I'd

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

peixin added a comment. LGTM Comment at: clang/lib/Driver/ToolChains/Flang.cpp:133 + CmdArgs.push_back("-O3"); + TC.getDriver().Diag(diag::warn_O4_is_O3); +} else { Nit: I have committed D126164, and you can rebase and use D directly, which is th

[PATCH] D127487: [Sema] Fix assertion failure when instantiating requires expression

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Ah, i see! Thanks for the explanation! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127487/new/ https://reviews.llvm.org/D127487

[PATCH] D128354: Comment Diagnosis.h and add missing headers

samestep created this revision. Herald added a project: All. samestep requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D128354 Files: clang/include/clang/Analysis/FlowSensiti

[PATCH] D127898: [clang][dataflow] Add API to separate analysis from diagnosis

samestep updated this revision to Diff 439045. samestep added a comment. Comment Diagnosis.h and add missing headers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127898/new/ https://reviews.llvm.org/D127898 Files: clang/include/clang/Analysis/F

[PATCH] D127898: [clang][dataflow] Add API to separate analysis from diagnosis

samestep marked 4 inline comments as done. samestep added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/MatchSwitch.h:49 +template struct DiagnoseState { + DiagnoseState(DiagsT &Diags, const Environment &Env) + : Diags(Diags), Env(Env) {}

  1   2   3   >