iains added a comment. In D113545#3601050 <https://reviews.llvm.org/D113545#3601050>, @ChuanqiXu wrote:
> In D113545#3601031 <https://reviews.llvm.org/D113545#3601031>, @iains wrote: > >> I think it is helpful to collect the standard examples into one place (i.e. >> test/Modules) and name them for the standard version (i.e. >> cxx20-N-M-exO.cpp) .. because >> >> - the details of the examples do change from one version of the standard to >> the next, because of changes in the normative text >> - some of the examples illustrate more than one bullet point >> - it makes it easier to find them for someone who is starting work on this >> area. >> >> (not a big deal, but now we have some on one place and some in another - >> which is why I had missed that you already had one of the cases) > I prefer to put them under test/CXX/module/xxx. Since it looks like test/CXX > is intended to match the standard wording. Another reason is that it looks > like we prefer to cite standard in the style of [module.context]p7 instead of > 10.6-p7 since the number might change. And you mentioned it too. What I was referring to is that the content of the example. the bullet point(s) and even whether the example exists could change between c++20 and, say, c++23 ... but as noted this is not a big deal :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113545/new/ https://reviews.llvm.org/D113545 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
