[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

sepavloff updated this revision to Diff 437807. sepavloff added a comment. Remade the patch according to the review notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126364/new/ https://reviews.llvm.org/D126364 Files: clang/include/clang/Basic

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

sepavloff added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:622 setFPContractMode(LangOptions::FPM_Off); setRoundingMode(static_cast(LangOptions::FPR_ToNearest)); setFPExceptionMode(LangOptions::FPE_Ignore); efriedma wrote:

[clang-tools-extra] 5ea341d - [clang] Fix trivially copyable for copy constructor and copy assignment operator

Author: Javier Alvarez Date: 2022-06-17T10:35:01+03:00 New Revision: 5ea341d7c4f9cc4933adc04ff74d59e26ad2f306 URL: https://github.com/llvm/llvm-project/commit/5ea341d7c4f9cc4933adc04ff74d59e26ad2f306 DIFF: https://github.com/llvm/llvm-project/commit/5ea341d7c4f9cc4933adc04ff74d59e26ad2f306.diff

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ea341d7c4f9: [clang] Fix trivially copyable for copy constructor and copy assignment operator (authored by Javier-varez, committed by royjacobson).

[PATCH] D122931: [CMake][compiler-rt] Support for using in-tree libc++

phosek added inline comments. Herald added a subscriber: Enna1. Comment at: compiler-rt/CMakeLists.txt:513-515 +# Don't use libcxx if LLVM_ENABLE_PROJECTS does not enable it. +set(COMPILER_RT_LIBCXX_PATH ${LLVM_EXTERNAL_LIBCXX_SOURCE_DIR}) +set(COMPILER_RT_LIBCXXABI_P

[PATCH] D126291: [flang][Driver] Update link job on windows

rovka added a comment. I'm going to go ahead and commit this on Monday if nobody raises any objections until then. Thanks again to everyone for all the help & feedback! Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:773 + // TODO: Make this work unconditionally once F

[PATCH] D126194: [Concepts] Implement overload resolution for destructors (P0848)

royjacobson added inline comments. Comment at: clang/docs/ReleaseNotes.rst:434 +- As per "Conditionally Trivial Special Member Functions" (P0848), it is + now possible to overload destructors using concepts. Note that the rest erichkeane wrote: > Do we have en

[PATCH] D126291: [flang][Driver] Update link job on windows

mstorsjo added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:773 + // TODO: Make this work unconditionally once Flang is mature enough. + if (!Args.hasArg(options::OPT_flang_experimental_exec)) +return; rovka wrote: > mstorsjo wrot

[PATCH] D127579: [clang][WIP] add option to keep types of ptr args for non-kernel functions in metadata

Anastasia added a comment. In D127579#3590632 , @aeubanks wrote: > If I'm understanding correctly, previously the LLVM pointee type was used to > represent a frontend OpenCL type. An alternative to marking everything with > `elementtype` or adding metad

[PATCH] D127579: [clang][WIP] add option to keep types of ptr args for non-kernel functions in metadata

Anastasia added a comment. In D127579#3585537 , @nikic wrote: > In D127579#3585516 , @beanz wrote: > >> > > Clang is only permitted to encode pointer type information if that pointer > type has some kind of dire

[clang] 2d9c891 - [OpenCL] Fix atomic_fetch_add/sub half overloads

Author: Sven van Haastregt Date: 2022-06-17T09:53:45+01:00 New Revision: 2d9c891cd949a4e6f15c35bd565b3d3588819e85 URL: https://github.com/llvm/llvm-project/commit/2d9c891cd949a4e6f15c35bd565b3d3588819e85 DIFF: https://github.com/llvm/llvm-project/commit/2d9c891cd949a4e6f15c35bd565b3d3588819e85.

[PATCH] D127860: [msan] Allow KMSAN to use -fsanitize-memory-param-retval

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7ab44b5c2155: [msan] Allow KMSAN to use -fsanitize-memory-param-retval (authored by glider). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang] 7ab44b5 - [msan] Allow KMSAN to use -fsanitize-memory-param-retval

Author: Alexander Potapenko Date: 2022-06-17T10:54:20+02:00 New Revision: 7ab44b5c2155245d115ba8642fcaabe65b54e44b URL: https://github.com/llvm/llvm-project/commit/7ab44b5c2155245d115ba8642fcaabe65b54e44b DIFF: https://github.com/llvm/llvm-project/commit/7ab44b5c2155245d115ba8642fcaabe65b54e44b

[PATCH] D128036: [CMake] Option to select C++ library for runtimes that use it

phosek created this revision. phosek added reviewers: ldionne, smeenai, mstorsjo. Herald added subscribers: Enna1, abrachet, mgorny. Herald added a project: All. phosek requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. W

[PATCH] D128036: [CMake] Option to select C++ library for runtimes that use it

phosek added a comment. I'm aware of the duplication of logic for handling of `COMPILER_RT_CXX_LIBRARY` and `SANITIZER_TEST_CXX_LIBNAME`. Right now my goal is to make the use of in-tree libc++ in compiler-rt explicit, and then cleaning up the handling logic in follow up changes. Repository:

[PATCH] D128036: [CMake] Option to select C++ library for runtimes that use it

mstorsjo added inline comments. Comment at: compiler-rt/CMakeLists.txt:534 +if (COMPILER_RT_CXX_LIBRARY STREQUAL "libcxx") + # We are using the in-tree libc++ so avoid including the default one. + append_list_if(COMPILER_RT_HAS_NOSTDINCXX_FLAG -nostdinc++ COMPILER_RT_COMMON_CF

[PATCH] D128036: [CMake] Option to select C++ library for runtimes that use it

phosek added inline comments. Comment at: compiler-rt/CMakeLists.txt:534 +if (COMPILER_RT_CXX_LIBRARY STREQUAL "libcxx") + # We are using the in-tree libc++ so avoid including the default one. + append_list_if(COMPILER_RT_HAS_NOSTDINCXX_FLAG -nostdinc++ COMPILER_RT_COMMON_CFLA

[PATCH] D128036: [CMake] Option to select C++ library for runtimes that use it

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM Comment at: compiler-rt/CMakeLists.txt:534 +if (COMPILER_RT_CXX_LIBRARY STREQUAL "libcxx") + # We are using the in-tree libc++ so avoid including the default one. +

[PATCH] D128008: [clang][deps] Sort submodules when calculating dependencies

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. Interesting edge-case. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128008/new/ https://reviews.llvm.org/D128008 ___

[clang] 32805e6 - [clang] Dont print implicit forrange initializer

Author: Kadir Cetinkaya Date: 2022-06-17T11:29:44+02:00 New Revision: 32805e60c9de1f82887cd2af30d247dcabd2e1d3 URL: https://github.com/llvm/llvm-project/commit/32805e60c9de1f82887cd2af30d247dcabd2e1d3 DIFF: https://github.com/llvm/llvm-project/commit/32805e60c9de1f82887cd2af30d247dcabd2e1d3.dif

[PATCH] D127863: [clang] Dont print implicit forrange initializer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG32805e60c9de: [clang] Dont print implicit forrange initializer (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:4261 + **AfterPlacementOperator** (``AfterPlacementOperatorStyle``) :versionbadge:`clang-format 14` +Defines in which cases to put a space between new/delete operators and opening parenth

[PATCH] D127961: [OpenCL] Reduce emitting candidate notes for builtins

Anastasia added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:11224 + // so do not generate such notes. + if (S.getLangOpts().OpenCL && Fn->isImplicit() && + Cand->FailureKind != ovl_fail_bad_conversion) It would have been nice to print each

[PATCH] D127961: [OpenCL] Reduce emitting candidate notes for builtins

svenvh added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:11224 + // so do not generate such notes. + if (S.getLangOpts().OpenCL && Fn->isImplicit() && + Cand->FailureKind != ovl_fail_bad_conversion) Anastasia wrote: > It would have been ni

[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

Anastasia added a comment. I wonder if accepting type alias with identifier `vector` while parsing would be simpler to implement? Then you could just add those type aliases into the internal header. I assume user code is not allowed to redefine those i.e. it would result in undefined behavior o

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

awarzynski created this revision. awarzynski added reviewers: rovka, kiranchandramohan, schweitz, peixin. Herald added subscribers: bzcheeseman, rriddle, mgorny. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. awarzynski requested review of this revision. Herald added subscri

[PATCH] D128044: add new option "-ftime-trace-path"

dongjunduo created this revision. Herald added a project: All. dongjunduo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D128044 Files: clang/include/clang/Driver/O

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

mboehme added a comment. In D126061#3590896 , @dyung wrote: > @mboehme, one of our internal tests started to fail to compile after this > change due to the compiler no longer accepting what I think should be a valid > attribute declaration. I have filed

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

sdesmalen added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:342 + if (HasSME) +Builder.defineMacro("__ARM_FEATURE_SME", "1"); + sagarkulkarni19 wrote: > sdesmalen wrote: > > When this macro is non-zero, it suggests that the compiler impl

[PATCH] D128013: [clang][dataflow] Add support for comma binary operator

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128013/new/ https://reviews.llvm.org/D128013 __

[clang] c80c576 - [Clang] Allow 'Complex float __attribute__((mode(HC)))'

Author: Jolanta Jensen Date: 2022-06-17T12:39:52+01:00 New Revision: c80c57674e4d9887dfa9159de9981941d9e6d18e URL: https://github.com/llvm/llvm-project/commit/c80c57674e4d9887dfa9159de9981941d9e6d18e DIFF: https://github.com/llvm/llvm-project/commit/c80c57674e4d9887dfa9159de9981941d9e6d18e.diff

[PATCH] D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc80c57674e4d: [Clang] Allow 'Complex float __attribute__((mode(HC)))' (authored by jolanta.jensen, committed by malharJ). Changed prior to commit:

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

aaron.ballman added inline comments. Comment at: clang/lib/Parse/Parser.cpp:1164 DS.getParsedSpecifiers() == DeclSpec::PQ_StorageClassSpecifier) { -Decl *TheDecl = ParseLinkage(DS, DeclaratorContext::File); +Decl *TheDecl = ParseLinkage(DS, DeclaratorContext::File,

[PATCH] D127863: [clang] Dont print implicit forrange initializer

CarlosAlbertoEnciso added a comment. @kadircet It seems that your change broke couple of clang tests: https://lab.llvm.org/buildbot/#/builders/109/builds/40797 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127863/new/ https://reviews.llvm.org/D127

[PATCH] D128046: Add a new clang option "-ftime-trace-path"

dongjunduo created this revision. Herald added a project: All. dongjunduo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a new clang option "-ftime-trace-path". The time profiler traces the stages during the clang compile process. Ea

[clang] 7aac15d - Revert "[clang] Dont print implicit forrange initializer"

Author: Nico Weber Date: 2022-06-17T08:59:17-04:00 New Revision: 7aac15d5df6cfa03b802e055b63227a95fa1734e URL: https://github.com/llvm/llvm-project/commit/7aac15d5df6cfa03b802e055b63227a95fa1734e DIFF: https://github.com/llvm/llvm-project/commit/7aac15d5df6cfa03b802e055b63227a95fa1734e.diff LO

[PATCH] D127863: [clang] Dont print implicit forrange initializer

thakis added a comment. Before landing changes, please: - Run tests - Look at the result from the presubmit checks After landing changes, please watch your favorite bot cycle green with it, and pay attention for buildbot email for a while. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D128048: Add a new clang option "-ftime-trace-path"

dongjunduo created this revision. Herald added a project: All. dongjunduo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The time profiler traces the stages during the clang compile process. Each compiling stage of a single source

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. In D126907#3591195 , @ChuanqiXu wrote: > In D126907#3588708 , @erichkeane > wrote: > >> In D126907#3588417 , @ChuanqiXu >> wrote: >> >>> From

Re: [PATCH] D127863: [clang] Dont print implicit forrange initializer

thanks for the revert, you beat me to it. On Fri, Jun 17, 2022 at 3:07 PM Nico Weber via Phabricator < revi...@reviews.llvm.org> wrote: > thakis added a comment. > > Before landing changes, please: > > - Run tests > - Look at the result from the presubmit checks > > After landing changes, please

[PATCH] D127873: [clang-format] Fix misplacemnt of `*` in declaration of pointer to struct

jackhong12 updated this revision to Diff 437868. jackhong12 edited the summary of this revision. jackhong12 added a comment. - Add annotator test - Add formatting test - Handle reference cases by `PrevToken->MatchingParen` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127873/new/ https:

[PATCH] D126194: [Concepts] Implement overload resolution for destructors (P0848)

erichkeane accepted this revision. erichkeane added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/AST/DeclCXX.h:1430 + /// out of which one will be selected at the end. + /// This is called separately from addedMember because

[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

beanz added a comment. For just the type alias, adding it during parsing would probably work. Where things get more complicated is we have a whole mess of other data types that we’ll need to add too eventually. One of the advantages of using an external sema source is that we can create incompl

[PATCH] D128048: Add a new clang option "-ftime-trace-path"

Whitney added a comment. Can you please add some test cases? Comment at: clang/tools/driver/cc1_main.cpp:257 if (llvm::timeTraceProfilerEnabled()) { -SmallString<128> Path(Clang->getFrontendOpts().OutputFile); -llvm::sys::path::replace_extension(Path, "json"); +S

[PATCH] D126194: [Concepts] Implement overload resolution for destructors (P0848)

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:1430 + /// out of which one will be selected at the end. + /// This is called separately from addedMember because it has to be deferred + /// to the completion of the class. eri

[PATCH] D127655: [AArch64] Define __FP_FAST_FMA[F]

paulwalker-arm added inline comments. Comment at: clang/test/Preprocessor/aarch64-target-features.c:59-60 // CHECK-NOT: __ARM_FEATURE_SVE_BITS 2048 +// CHECK: __FP_FAST_FMA 1 +// CHECK: __FP_FAST_FMAF 1 I don't think we need this change given `init-aarch64.c`

[PATCH] D127873: [clang-format] Fix misplacemnt of `*` in declaration of pointer to struct

jackhong12 updated this revision to Diff 437881. jackhong12 added a comment. Add Left/Middle/Right alignment test cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127873/new/ https://reviews.llvm.org/D127873 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/Form

[PATCH] D128049: [mlir] move SCF headers to SCF/{IR,Transforms} respectively

jpienaar accepted this revision. jpienaar added a comment. This revision is now accepted and ready to land. More consistency is good and update for downstream users mechanical, so LGTM Comment at: mlir/include/mlir/Dialect/SCF/Transforms/Transforms.h:13 -#ifndef MLIR_DIALECT_

[PATCH] D128049: [mlir] move SCF headers to SCF/{IR,Transforms} respectively

ftynse marked an inline comment as done. ftynse added inline comments. Comment at: mlir/include/mlir/Dialect/SCF/Transforms/Transforms.h:13 -#ifndef MLIR_DIALECT_SCF_TRANSFORMS_H_ -#define MLIR_DIALECT_SCF_TRANSFORMS_H_ +#ifndef MLIR_DIALECT_SCF_TRANSFORMS_TRANSFORMS_H_ +#defin

[PATCH] D128056: [clang][dataflow] Singleton pointer values for null pointers.

wyt created this revision. Herald added subscribers: martong, tschuett, xazax.hun. Herald added a project: All. wyt requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When a `nullptr` is assigned to a pointer variable, it is wrapped in a `Imp

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! The debian failures look like precommit CI is in a broken state again, but have nothing to do with your patch. Comment at: clang/lib/Sema/SemaDeclAttr.cp

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

cor3ntin created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. cor3ntin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Introduce an off-by default `-Winvalid-utf8` warning that detects

[PATCH] D128060: [clang][dataflow] Extend flow condition in the body of a for loop

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: martong, tschuett, rnkovacs. Herald added a project: All. sgatev requested review of this revision. Herald added a project: clang. Extend flow condition in the body of a for loop. Repo

[PATCH] D128060: [clang][dataflow] Extend flow condition in the body of a for loop

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:3577-3580 +ASSERT_THAT(Results, ElementsAre(Pair("if_branch_1", _), +

[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

Anastasia added a comment. In D128012#3591828 , @beanz wrote: > For just the type alias, adding it during parsing would probably work. Where > things get more complicated is we have a whole mess of other data types that > we’ll need to add too eventuall

[clang] 1a02c96 - Revert "Revert "[clang] Dont print implicit forrange initializer""

Author: Kadir Cetinkaya Date: 2022-06-17T16:51:16+02:00 New Revision: 1a02c963e338100a3000734b91f5956da9b8c95e URL: https://github.com/llvm/llvm-project/commit/1a02c963e338100a3000734b91f5956da9b8c95e DIFF: https://github.com/llvm/llvm-project/commit/1a02c963e338100a3000734b91f5956da9b8c95e.dif

[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

beanz added a comment. In D128012#3592098 , @Anastasia wrote: > aha, are you having a lot of these types then? Ok that sounds similar problem > to OpenCL builtin functions as we had to go away from a simple header include > due to long parsing time. Ve

[PATCH] D127579: [clang][WIP] add option to keep types of ptr args for non-kernel functions in metadata

Anastasia added a comment. Btw do we have any issue tracking this failure, I am having a feeling that the translation of special types might be related to https://github.com/llvm/llvm-project/issues/55121? I am not aware at which point libclc is expected to be linked for SPIR-V but if linking h

[PATCH] D127351: clang: fix early substitution of alias templates

mizvekov updated this revision to Diff 437905. mizvekov added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127351/new/ https://reviews.llvm.org/D127351 Files: clang/include/clang/Sema/Template.h clang/lib/Sema/SemaTemplateIn

[PATCH] D127690: [NFC] clang/Parser: remove dead code

mizvekov updated this revision to Diff 437906. mizvekov added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127690/new/ https://reviews.llvm.org/D127690 Files: clang/lib/Parse/Parser.cpp Index: clang/lib/Parse/Parser.cpp

[clang] 4a3a9a5 - [clang][deps] Sort submodules when calculating dependencies

Author: Ben Langmuir Date: 2022-06-17T07:55:27-07:00 New Revision: 4a3a9a5fa0b2fd0e70672c35010fe2f00740f098 URL: https://github.com/llvm/llvm-project/commit/4a3a9a5fa0b2fd0e70672c35010fe2f00740f098 DIFF: https://github.com/llvm/llvm-project/commit/4a3a9a5fa0b2fd0e70672c35010fe2f00740f098.diff

[PATCH] D128008: [clang][deps] Sort submodules when calculating dependencies

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4a3a9a5fa0b2: [clang][deps] Sort submodules when calculating dependencies (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D127142: [HIP] Link with clang_rt.builtins

yaxunl added a comment. In D127142#3590874 , @yaxunl wrote: > In D127142#3571260 , @MaskRay wrote: > >> In D127142#3570290 , @yaxunl wrote: >> >>> If I use --rtlib=compile

[PATCH] D128060: [clang][dataflow] Extend flow condition in the body of a for loop

ymandel accepted this revision. ymandel added a comment. Mild preference for splitting into three tests, since it technically different code that's covered in each. But, up to you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128060/new/ https://

[PATCH] D128060: [clang][dataflow] Extend flow condition in the body of a for loop

sgatev updated this revision to Diff 437918. sgatev added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128060/new/ https://reviews.llvm.org/D128060 Files: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.

[PATCH] D122150: [clang][analyzer] Add checker for bad use of 'errno'.

balazske updated this revision to Diff 437922. balazske marked 16 inline comments as done. balazske added a comment. Removed Errno_ prefix from ErrnoCheckState, documentation fixes, other small fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D125400: [clang][Analyzer] Add errno state to standard functions modeling.

balazske updated this revision to Diff 437924. balazske marked 2 inline comments as done. balazske added a comment. Small fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125400/new/ https://reviews.llvm.org/D125400 Files: clang/lib/StaticAn

[PATCH] D127277: [clang][analyzer] Fix StdLibraryFunctionsChecker 'mkdir' return value.

balazske updated this revision to Diff 437925. balazske added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127277/new/ https://reviews.llvm.org/D127277 Files: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp

[PATCH] D128068: [analyzer] Do not emit redundant SymbolCasts

martong created this revision. martong added reviewers: steakhal, NoQ, ASDenysPetrov. Herald added subscribers: manas, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project:

[PATCH] D127873: [clang-format] Fix misplacemnt of `*` in declaration of pointer to struct

HazardyKnusperkeks added a comment. In D127873#3589465 , @jackhong12 wrote: > I think it's a good idea. When does `MatchingParen` bind? The value of > `PrevToken->MatchingParen` is still NULL in `determineStarAmpUsage` function. What has changed, now y

[PATCH] D126779: [analyzer] Fix assertion in simplifySymbolCast

martong updated this revision to Diff 437938. martong added a comment. - Rebase on dependent patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126779/new/ https://reviews.llvm.org/D126779 Files: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp

[PATCH] D126194: [Concepts] Implement overload resolution for destructors (P0848)

royjacobson updated this revision to Diff 437940. royjacobson added a comment. Fix the AST test on windows and rebase on HEAD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126194/new/ https://reviews.llvm.org/D126194 Files: clang/docs/ReleaseNo

[PATCH] D126779: [analyzer] Fix assertion in simplifySymbolCast

martong marked 2 inline comments as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:1082 + // FIXME support cast from non-integers. + // E.g (char)(double)(double x) -> (char)(double x) + if (!RT->isIntegralOrEnumerationType()) --

[clang] fc6b228 - [Static Analyzer][CFG] Introducing the source array in the CFG of DecompositionDecl

Author: isuckatcs Date: 2022-06-17T18:34:34+02:00 New Revision: fc6b2281bfd747b3e24d23e2ee8de189f741770f URL: https://github.com/llvm/llvm-project/commit/fc6b2281bfd747b3e24d23e2ee8de189f741770f DIFF: https://github.com/llvm/llvm-project/commit/fc6b2281bfd747b3e24d23e2ee8de189f741770f.diff LOG

[PATCH] D127993: [Static Analyzer][CFG] Introducing the source array in the CFG of DecompositionDecl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfc6b2281bfd7: [Static Analyzer][CFG] Introducing the source array in the CFG of… (authored by isuckatcs). Herald added a subscriber: cfe-commits. Ch

[PATCH] D128060: [clang][dataflow] Extend flow condition in the body of a for loop

xazax.hun accepted this revision. xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:92 + void VisitForStmt(const ForStmt *S) { +auto *Cond = S->getCond(); Do we support `DoStmt` or is that missing?

[PATCH] D128056: [clang][dataflow] Singleton pointer values for null pointers.

xazax.hun added a comment. I am wondering about the future plans regarding how pointers are represented. What will be the expected behavior when the analysis discovers that the pointer has a null value? E.g.: if (p == nullptr) { } Would we expect `p` in this case to have the same

[clang] 92bf652 - [Static Analyzer] Small array binding policy

Author: isuckatcs Date: 2022-06-17T18:56:13+02:00 New Revision: 92bf652d40740b947de6c41fe09f282ec0530dc5 URL: https://github.com/llvm/llvm-project/commit/92bf652d40740b947de6c41fe09f282ec0530dc5 DIFF: https://github.com/llvm/llvm-project/commit/92bf652d40740b947de6c41fe09f282ec0530dc5.diff LOG

[PATCH] D128064: [Static Analyzer] Small array binding policy

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG92bf652d4074: [Static Analyzer] Small array binding policy (authored by isuckatcs). Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D127313: [libc++] Implement P0618R0 (Deprecating )

philnik updated this revision to Diff 437951. philnik added a comment. - Try to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127313/new/ https://reviews.llvm.org/D127313 Files: libcxx/docs/ReleaseNotes.rst libcxx/docs/Status/Cxx17Paper

[PATCH] D127509: Prefer `getCurrentFileOrBufferName` in `FrontendAction::EndSourceFile`

JohnTitor added a comment. I've re-triggered it several times but it shows the same failure, maybe they're valid? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127509/new/ https://reviews.llvm.org/D127509 _

[PATCH] D127898: [clang][dataflow] Find unsafe locs after fixpoint

xazax.hun added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:66 + SourceLocations Locs; + for (const CFGBlock *Block : Context->getCFG()) { +// Skip blocks that were not evaluated. While doing yet anot

[PATCH] D127873: [clang-format] Fix misplacemnt of `*` in declaration of pointer to struct

jackhong12 added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2314-2315 +if (PrevToken->is(tok::r_brace) && Tok.isOneOf(tok::amp, tok::ampamp) && +PrevToken->MatchingParen && PrevToken->MatchingParen->is(TT_Unknown)) + return TT_BinaryOperator

[PATCH] D126973: [clang][dataflow] Relax assumption that `AggregateStorageLocations` correspond to struct type.

xazax.hun added a comment. Herald added a subscriber: martong. With properties moved up in the hierarchy this could be abandoned now, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126973/new/ https://reviews.llvm.org/D126973 ___

[PATCH] D126973: [clang][dataflow] Relax assumption that `AggregateStorageLocations` correspond to struct type.

ymandel abandoned this revision. ymandel added a comment. In D126973#3592537 , @xazax.hun wrote: > With properties moved up in the hierarchy this could be abandoned now, right? Yes, I think that would be best. Thanks for the reminder! Repository: rG

[PATCH] D127873: [clang-format] Fix misplacemnt of `*` in declaration of pointer to struct

jackhong12 added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2314-2315 +if (PrevToken->is(tok::r_brace) && Tok.isOneOf(tok::amp, tok::ampamp) && +PrevToken->MatchingParen && PrevToken->MatchingParen->is(TT_Unknown)) + return TT_BinaryOperator

[PATCH] D128072: [clang-tidy] Organize test files into subdirectories by module (NFC)

LegalizeAdulthood created this revision. LegalizeAdulthood added reviewers: njames93, aaron.ballman. LegalizeAdulthood added a project: clang-tools-extra. Herald added subscribers: bzcheeseman, carlosgalvezp, abrachet, lebedev.ri, jdoerfert, arphaman, zzheng, kbarton, xazax.hun, nemanjai. Herald a

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam marked 2 inline comments as done. zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGExprComplex.cpp:896 + +ComplexPairTy ComplexExprEmitter::EmitPromoted(const Expr *E) { + if (auto *BinOp = dyn_cast(E->IgnoreParens())) { rjmccall wrote: >

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed updated this revision to Diff 437966. omarahmed marked an inline comment as not done. omarahmed added a comment. Refactor the tests and add new parsing logic for nested enums in dump_format_style.py Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed added a comment. As I understand, the default behavior for when the user didn't use `SBPO_Custom` is to add a space in placement operators based on this issue . And, at the same time, the default behavior should be `APO_Never` when we

[PATCH] D127277: [clang][analyzer] Fix StdLibraryFunctionsChecker 'mkdir' return value.

steakhal accepted this revision. steakhal added a comment. It feels like the parent revision is not correct. Land it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127277/new/ https://reviews.llvm.org/D127277 __

[clang] ba53906 - [clang][dataflow] Add support for comma binary operator

Author: Stanislav Gatev Date: 2022-06-17T17:48:21Z New Revision: ba53906ceff1e7979cac37ff6fdc27e976fc169a URL: https://github.com/llvm/llvm-project/commit/ba53906ceff1e7979cac37ff6fdc27e976fc169a DIFF: https://github.com/llvm/llvm-project/commit/ba53906ceff1e7979cac37ff6fdc27e976fc169a.diff LO

[PATCH] D128013: [clang][dataflow] Add support for comma binary operator

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGba53906ceff1: [clang][dataflow] Add support for comma binary operator (authored by sgatev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D128048: Add a new clang option "-ftime-trace-path"

jamieschmeiser requested changes to this revision. jamieschmeiser added a comment. This revision now requires changes to proceed. This is a good start. You should mention in the summary that when -c is not specified, the compiler is invoked with -o pointing at /tmp so the .json file will curren

[clang] e77ac66 - [Static Analyzer] Structured binding to data members

Author: isuckatcs Date: 2022-06-17T19:50:10+02:00 New Revision: e77ac66b8c1cf4f09f931d37749ed258f122d708 URL: https://github.com/llvm/llvm-project/commit/e77ac66b8c1cf4f09f931d37749ed258f122d708 DIFF: https://github.com/llvm/llvm-project/commit/e77ac66b8c1cf4f09f931d37749ed258f122d708.diff LOG

[PATCH] D127643: [Static Analyzer] Structured bindings to data members

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe77ac66b8c1c: [Static Analyzer] Structured binding to data members (authored by isuckatcs). Herald added a subscriber: cfe-commits. Repository: rG

[PATCH] D127923: [Diagnostics] Accept newline and format diag opts on first line

scott.linder added a comment. Thank you for the patch! I will leave it to others with more knowledge of the history of diagnostics to comment on whether the premise is acceptable, but I have a few technical comments Comment at: clang/lib/Frontend/TextDiagnosticPrinter.cpp:119

[PATCH] D127923: [Diagnostics] Accept newline and format diag opts on first line

scott.linder added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/TextDiagnostics.cpp:99-103 + size_t NewlinePos = PD->getShortDescription().find_first_of('\n'); + if (NewlinePos != std::string::npos) +OutStr = PD->getShortDescription().str().insert(

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed updated this revision to Diff 437980. omarahmed added a comment. Add Parse check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127270/new/ https://reviews.llvm.org/D127270 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/tool

[clang] 0dd243f - wip

Author: Chris Bieneman Date: 2022-06-17T13:34:21-05:00 New Revision: 0dd243fa8a4ec98d6cabbad16e6b485a093c6dea URL: https://github.com/llvm/llvm-project/commit/0dd243fa8a4ec98d6cabbad16e6b485a093c6dea DIFF: https://github.com/llvm/llvm-project/commit/0dd243fa8a4ec98d6cabbad16e6b485a093c6dea.diff

  1   2   >