[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

Javier-varez added a comment. I had the same failures with and without this change. It looks like these tests are already broken upstream. Without this patch: Unsupported: 15 Passed : 50 Failed : 232 With this patch: Unsupported: 15 Passed : 50 Failed : 232 R

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

Javier-varez added a comment. For referente, I run the tests without this change on commit: commit 94d1692aa155adf3b69609d142762b8c696e0710 (upstream/main, upstream/HEAD) Author: Fangrui Song Date: Tue Jun 14 21:25:56 2022 -0700 [MC] Remove unused MCStreamer::SwitchSection

[PATCH] D126291: [flang][Driver] Update link job on windows

mstorsjo added a comment. Looks good to me in general, one general question though. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:773 + // TODO: Make this work unconditionally once Flang is mature enough. + if (!Args.hasArg(options::OPT_flang_experimental_exec)) +

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

nemanjai added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7571-7573 + "Current bitcast for incompatible vector types (%0 and %1) are deprecated. " + "The default behaviour will change to what is implied by the " + "-fno-lax-vector-conversions

[PATCH] D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Comment at: clang/test/CodeGen/PowerPC/builtins-ppc-xlcompat.c:8 // RUN: -D__XL_COMPAT_ALTIVEC__ -target-cpu pwr8 | FileCheck %s -// RUN: %clang_cc1 -no-

[PATCH] D128008: [clang][deps] Sort submodules when calculating dependencies

benlangmuir created this revision. benlangmuir added reviewers: jansvoboda11, Bigcheese. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Dependency scanning does not care about the order of submodule

[PATCH] D127901: [LinkerWrapper] Add PTX output to CUDA fatbinary in LTO-mode

tra added a comment. Playing devil's advocate, I've got to ask -- do we even want to support JIT? JIT brings more trouble than benefits. - substantial start-up time on nontrivial apps. Last time I tried launching a tensorflow app and needed to JIT its kernels, it took about half an hour until

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae added inline comments. Comment at: clang/lib/Basic/LangOptions.cpp:197 - // OpenCL has half keyword - Opts.Half = Opts.OpenCL; + // OpenCL and HLSL have half keyword + Opts.Half = Opts.OpenCL || Opts.HLSL; aaron.ballman wrote: > beanz wrote: > >

[PATCH] D126224: Add DWARF string debug to clang release notes.

hctim marked an inline comment as done. hctim added a comment. In D126224#3534643 , @probinson wrote: > I see some unrelated whitespace changes, we generally don't like mixing those > with "real" changes. But the description seems fine to me. Looks lik

[PATCH] D126224: Add DWARF string debug to clang release notes.

hctim updated this revision to Diff 437717. hctim marked an inline comment as done. hctim added a comment. Change a small amount of wording, rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126224/new/ https://reviews.llvm.org/D126224 Files:

[clang] 011e060 - Add DWARF string debug to clang release notes.

Author: Mitch Phillips Date: 2022-06-16T14:54:12-07:00 New Revision: 011e0604ebc9d85db3585ebb2f63df465f726417 URL: https://github.com/llvm/llvm-project/commit/011e0604ebc9d85db3585ebb2f63df465f726417 DIFF: https://github.com/llvm/llvm-project/commit/011e0604ebc9d85db3585ebb2f63df465f726417.diff

[PATCH] D127901: [LinkerWrapper] Add PTX output to CUDA fatbinary in LTO-mode

jhuber6 added a comment. In D127901#3590402 , @tra wrote: > Playing devil's advocate, I've got to ask -- do we even want to support JIT? > > JIT brings more trouble than benefits. > > - substantial start-up time on nontrivial apps. Last time I tried launc

[PATCH] D126224: Add DWARF string debug to clang release notes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG011e0604ebc9: Add DWARF string debug to clang release notes. (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

beanz created this revision. beanz added reviewers: aaron.ballman, kuhar, bogner, rnk, python3kgae. Herald added subscribers: Anastasia, jeroen.dobbelaere, mgorny. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. HLSL vector types are ext_vector

[PATCH] D128013: [clang][dataflow] Add support for comma binary operator

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: martong, tschuett, rnkovacs. Herald added a project: All. sgatev requested review of this revision. Herald added a project: clang. Add support for comma binary operator. Repository:

[PATCH] D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions

amyk accepted this revision. amyk added a comment. This patch also LGTM. Thank you Lei. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124093/new/ https://reviews.llvm.org/D124093 ___ cfe-commits mailing

[PATCH] D124493: Move Sanitizer metadata to be on-GlobalValue.

hctim abandoned this revision. hctim added a comment. Herald added a subscriber: Enna1. Integrated slowly and surely as part of the stack leading up to D127911 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124493

[clang] ee28837 - [NFCI] Whitespace in SemaDeclAttr.cpp

Author: Mitch Phillips Date: 2022-06-16T15:10:32-07:00 New Revision: ee28837a1fbd574dbec14b9f09cb4effab6a492a URL: https://github.com/llvm/llvm-project/commit/ee28837a1fbd574dbec14b9f09cb4effab6a492a DIFF: https://github.com/llvm/llvm-project/commit/ee28837a1fbd574dbec14b9f09cb4effab6a492a.diff

[PATCH] D127259: [CodeGen] guarantee templated static variables are initialized in the reverse instantiation order

ychen added a comment. In D127259#3590127 , @rnk wrote: > I think Richard had some concerns in the other review that this may not be > enough to really guarantee initialization order within the TU. I couldn't say > either way, I shouldn't review this co

[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

python3kgae added inline comments. Comment at: clang/lib/Frontend/FrontendAction.cpp:1022 +new HLSLExternalSemaSource()); +CI.getASTContext().setExternalSource(HLSLSema); + } Does this mean features like PCH which use ExternalSource will not work an

[clang] dba2ff5 - fix x86 sanitizer failure due to use of or

Author: Lei Huang Date: 2022-06-16T17:20:31-05:00 New Revision: dba2ff500d5b29f2d18b93aed5caa5b4ef7c94dd URL: https://github.com/llvm/llvm-project/commit/dba2ff500d5b29f2d18b93aed5caa5b4ef7c94dd DIFF: https://github.com/llvm/llvm-project/commit/dba2ff500d5b29f2d18b93aed5caa5b4ef7c94dd.diff LOG

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim marked 2 inline comments as done. hctim added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:8849 break; - // HLSL attributes: aaron.ballman wrote: > hctim wrote: > > aaron.ballman wrote: > > > Spurious whitespace change? > > unfortu

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim updated this revision to Diff 437734. hctim marked 2 inline comments as done. hctim added a comment. Create test input files rather than synthesizing on the fly, fix tests on windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127544/new/

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

royjacobson added a comment. The OpenMP tests passed on D127998 (I think just randomly?). I'm going to commit this tomorrow morning so I can revert if needed. Javier, thanks again for the patch and for the patience! Repository: rG LLVM Github Monorepo CHA

[PATCH] D127579: [clang][WIP] add option to keep types of ptr args for non-kernel functions in metadata

aeubanks added a comment. If I'm understanding correctly, previously the LLVM pointee type was used to represent a frontend OpenCL type. An alternative to marking everything with `elementtype` or adding metadata, can something be done in the frontend to mangle the function name with OpenCL poin

[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

beanz added inline comments. Comment at: clang/lib/Frontend/FrontendAction.cpp:1022 +new HLSLExternalSemaSource()); +CI.getASTContext().setExternalSource(HLSLSema); + } python3kgae wrote: > Does this mean features like PCH which use ExternalSource wi

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

maryammo updated this revision to Diff 437740. maryammo added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126540/new/ https://reviews.llvm.org/D126540 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added a comment. In D113107#3585672 , @zahiraam wrote: > @rjmccall > The comma && ternary cases for EmitPromoted, I am not sure what needs to > happen there? Basically just the same thing that the normal paths do, except you recurse with `Emi

[PATCH] D127798: [AArch64] Define __ARM_FEATURE_RCPC

mingmingl updated this revision to Diff 437749. mingmingl marked an inline comment as done. mingmingl added a comment. change from `-target=aarch64-none-linux-gnu` to `--target=aarch64-none-linux-gnu` to resolve a compile error. Verified no other compilation error by `ninja check-all` Reposito

[clang] 0e18246 - [sanitizer] Delete empty sanitizer_openbsd.cpp after D89759

Author: Fangrui Song Date: 2022-06-16T16:38:01-07:00 New Revision: 0e182469ee765613ea860e3b1024094411be9628 URL: https://github.com/llvm/llvm-project/commit/0e182469ee765613ea860e3b1024094411be9628 DIFF: https://github.com/llvm/llvm-project/commit/0e182469ee765613ea860e3b1024094411be9628.diff

[PATCH] D127798: [AArch64] Define __ARM_FEATURE_RCPC

mingmingl updated this revision to Diff 437750. mingmingl added a comment. Use `--target=aarch64` rather than `--target=aarch64-unknown-linux-gnu`, given the former means all ELF based operating systems can expect the feature. (thanks maskray@ for pointing it out!) Repository: rG LLVM Github

[clang] bb83f8e - [OpenMP] Initial parsing and sema for 'parallel masked' construct

Author: Jennifer Yu Date: 2022-06-16T18:01:15-07:00 New Revision: bb83f8e70bd1d56152f02307adacd718cd67e312 URL: https://github.com/llvm/llvm-project/commit/bb83f8e70bd1d56152f02307adacd718cd67e312 DIFF: https://github.com/llvm/llvm-project/commit/bb83f8e70bd1d56152f02307adacd718cd67e312.diff L

[PATCH] D127454: [OpenMP] Initial parsing and sema for 'parallel masked' construct

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb83f8e70bd1: [OpenMP] Initial parsing and sema for 'parallel masked' construct (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES S

[clang] febe4f6 - [PowerPC][NFC] Undefine __XL_COMPAT_ALTIVEC__ in builtin lit test

Author: Lei Huang Date: 2022-06-16T20:16:52-05:00 New Revision: febe4f650b8754188c8cde01701bc16bd4a7a696 URL: https://github.com/llvm/llvm-project/commit/febe4f650b8754188c8cde01701bc16bd4a7a696 DIFF: https://github.com/llvm/llvm-project/commit/febe4f650b8754188c8cde01701bc16bd4a7a696.diff LOG

[clang] 711a71d - PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

Author: Maryam Moghadas Date: 2022-06-16T20:28:34-05:00 New Revision: 711a71d1ab1056b9ae1364eeec5eff2443629bf7 URL: https://github.com/llvm/llvm-project/commit/711a71d1ab1056b9ae1364eeec5eff2443629bf7 DIFF: https://github.com/llvm/llvm-project/commit/711a71d1ab1056b9ae1364eeec5eff2443629bf7.dif

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG711a71d1ab10: PowerPC] Emit warning for incompatible vector types that are currently… (authored by maryammo, committed by lei). Repository: rG LLV

[PATCH] D127142: [HIP] Link with clang_rt.builtins

yaxunl added a comment. In D127142#3571260 , @MaskRay wrote: > In D127142#3570290 , @yaxunl wrote: > >> If I use --rtlib=compiler-rt, does that also requires --unwindlib=unwindlib ? > > No. --unwindlib=libunwind r

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

Mogball added a comment. In principle, I think the algorithm is fine. I'm pretty sure you can rewrite bits of it to get rid of the map/sets. I'm only concerned about handling attributes. (e.g. `cmpi slt` vs `cmpi sgt`) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

dyung added a comment. @mboehme, one of our internal tests started to fail to compile after this change due to the compiler no longer accepting what I think should be a valid attribute declaration. I have filed issue #56077 for the problem, can you take a look? Repository: rG LLVM Github Mo

[PATCH] D128022: [HIP] add -fhip-kernel-arg-name

yaxunl created this revision. yaxunl added reviewers: tra, b-sumner. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: MaskRay. Add option -fhip-kernel-arg-name to emit kernel argument name metadata, which is needed for certain HIP applications. ht

[PATCH] D127826: [Driver] Pass -X to ld for riscv*-{elf,freebsd,linux}

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. ld's help message just confused me, that say `-X` is default, but actually default action is `Discard local temporary symbols in SEC_MERGE sections.` which is no option can enable that

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

ahatanak updated this revision to Diff 437796. ahatanak added a comment. Fix misleading comment and add a test case for C compound literal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125936/new/ https://reviews.llvm.org/D125936 Files: clang/l

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

ahatanak added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2291 + // statement. + CodeGenFunction::RunCleanupsScope Cleanups(*this); + rjmccall wrote: > Do we need to do anything special when entering the full expressions to make > sure that encl

[PATCH] D128031: Don't emit `-Wnullability-completeness` warnings on `weak` Objective-C properties.

mwyman created this revision. mwyman added reviewers: dmaclach, stephanemoore. mwyman added a project: clang. Herald added a project: All. mwyman requested review of this revision. Herald added a subscriber: cfe-commits. Zeroing weak references are by definition `nullable`, and adding `nonnull` or

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

ChuanqiXu added a comment. In D126907#3588708 , @erichkeane wrote: > In D126907#3588417 , @ChuanqiXu > wrote: > >> From what I can see, the crash reason would be the mismatch depth and the >> setting of MultiLe

[PATCH] D127826: [Driver] Pass -X to ld for riscv*-{elf,freebsd,linux}

MaskRay added a comment. Thanks for the archaeology! > ld will treat ld -r -s as ld -r -S -x, This seems really weird... I agree that using driver-passed -X instead of the implied -x is safe. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127826/n

[PATCH] D127826: [Driver] Pass -X to ld for riscv*-{elf,freebsd,linux}

MaskRay added a subscriber: dim. MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/FreeBSD.cpp:226 CmdArgs.push_back("elf32lriscv"); +CmdArgs.push_back("-X"); break; @dim FYI Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D127509: Prefer `getCurrentFileOrBufferName` in `FrontendAction::EndSourceFile`

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127509/new/ https://reviews.llvm.org/D127509 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D127826: [Driver] Pass -X to ld for riscv*-{elf,freebsd,linux}

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc324c938becd: [Driver] Pass -X to ld for riscv*-{elf,freebsd,linux} (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] c324c93 - [Driver] Pass -X to ld for riscv*-{elf, freebsd, linux}

Author: Fangrui Song Date: 2022-06-16T23:33:48-07:00 New Revision: c324c938becdbb963b34895cc12ffccb261bf167 URL: https://github.com/llvm/llvm-project/commit/c324c938becdbb963b34895cc12ffccb261bf167 DIFF: https://github.com/llvm/llvm-project/commit/c324c938becdbb963b34895cc12ffccb261bf167.diff

<    1   2