beanz added inline comments.
================ Comment at: clang/lib/Frontend/FrontendAction.cpp:1022 + new HLSLExternalSemaSource()); + CI.getASTContext().setExternalSource(HLSLSema); + } ---------------- python3kgae wrote: > Does this mean features like PCH which use ExternalSource will not work > anymore? Will we add these features into HLSLSema? We can always use an external source multiplexer or add support through the HLSL source. Both are viable options as appropriate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128012/new/ https://reviews.llvm.org/D128012 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
