[PATCH] D127484: [clang-format] Use tabs on GNU style

curdeius added a comment. It seems like a breaking change that may be painful for users of GNU style. @mydeveloperday, wdyt? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127484/new/ https://reviews.llvm.org/D127484 __

[PATCH] D127163: [clang] Add -fsanitize=memtag-globals (no-op).

hctim marked 2 inline comments as done. hctim added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:767 + if (IsAArch64) { +Res |= SanitizerKind::MemtagGlobals; + } eugenis wrote: > Hmm why are all the other memtag* not here? Yeah, just r

[PATCH] D127163: [clang] Add -fsanitize=memtag-globals (no-op).

hctim updated this revision to Diff 436059. hctim marked 2 inline comments as done. hctim added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127163/new/ https://reviews.llvm.org/D127163 Files: clang/include/clang/Basic/Feature

[PATCH] D127545: Remove Itanium EH ABI workaround to allow modifying a pointer caught by-reference.

jyknight created this revision. jyknight added reviewers: rjmccall, nikic. Herald added a project: All. jyknight requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Pointers will now always be caught by-value. The workaround was originally add

[PATCH] D127545: Remove Itanium EH ABI workaround to allow modifying a pointer caught by-reference.

jyknight added a comment. (Note: if folks agree with this direction, I'll file a new bug for the newly broken behavior -- even though we probably cannot actually fix it -- and link it from the commit.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D127484: [clang-format] Use tabs on GNU style

MyDeveloperDay added a comment. Oh gosh! It hard to make such changes and someone else not call them a regression, I’m not sure how I feel. We do kind of have to be able to fix bugs and if this gets closer to gnu style then I guess it’s better Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D119367: [HWASan] Allow no_sanitize(..) and change metadata passing.

hctim abandoned this revision. hctim added a comment. Herald added a subscriber: Enna1. Herald added a project: All. Deprecated by D127544 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119367/new/ https://reviews

[PATCH] D127484: [clang-format] Use tabs on GNU style

owenpan added a comment. In D127484#3574992 , @MyDeveloperDay wrote: > Oh gosh! It hard to make such changes and someone else not call them a > regression, I’m not sure how I feel. We do kind of have to be able to fix > bugs and if this gets closer to

[PATCH] D127351: clang: fix early substitution of alias templates

rsmith added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:1872 QualType Result = getSema().Context.getTemplateTypeParmType( - T->getDepth() - TemplateArgs.getNumSubstitutedLevels(), T->getIndex(), - T->isParameterPack(), NewTTPDecl); +

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:847-849 +} else if (const auto Iface = + dyn_cast(Decl)) { + if (Iface->isThisDeclarationADefinition()) Do we need sim

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:34 + +static void expandKernelSanitizerMasks(SanitizerMask *Mask) { + if (*Mask & (SanitizerKind::Address | SanitizerKind::KernelAddress)) Prefer return value to output paramet

[PATCH] D127484: [clang-format] Use tabs on GNU style

a4lg updated this revision to Diff 436087. a4lg added a comment. Thanks, suggestion by @owenpan is applied. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127484/new/ https://reviews.llvm.org/D127484 Files: clang/lib/Format/Format.cpp clang/uni

[PATCH] D127351: clang: fix early substitution of alias templates

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:1872 QualType Result = getSema().Context.getTemplateTypeParmType( - T->getDepth() - TemplateArgs.getNumSubstitutedLevels(), T->getIndex(), - T->isParameterPack(), NewTTPDecl); +

[PATCH] D126599: [docs][clang] Fix a broken link on the APINotes doc

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. It seems that other docs are following the GitHub URLs as well. I wish we could do the relative document link instead of embedding the URL, but if that is not possible, then this makes se

[PATCH] D127351: clang: fix early substitution of alias templates

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:1872 QualType Result = getSema().Context.getTemplateTypeParmType( - T->getDepth() - TemplateArgs.getNumSubstitutedLevels(), T->getIndex(), - T->isParameterPack(), NewTTPDecl); +

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

dyung added a comment. Just another data point, but we noticed the same issue of clang++ missing after install on our internal Windows builds, and I bisected it to this commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117977/new/ https://revi

[PATCH] D127310: [clang][driver] fix to correctly set devtoolset on RHEL

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127310/new/ https://reviews.llvm.org/D127310 _

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

LuoYuanke accepted this revision. LuoYuanke added a comment. This revision is now accepted and ready to land. LGTM, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107082/new/ https://reviews.llvm.org/D107082

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 436110. vaibhav.y marked 2 inline comments as done. vaibhav.y added a comment. Fix bug detected from ASAN run Passes `-fsanitize=address` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/ https://rev

[clang] f5ef2c5 - [clang] Convert for_each to range-based for loops (NFC)

Author: Kazu Hirata Date: 2022-06-10T22:39:45-07:00 New Revision: f5ef2c58381fb8056bf919c7a0862bb8d65e1e28 URL: https://github.com/llvm/llvm-project/commit/f5ef2c58381fb8056bf919c7a0862bb8d65e1e28 DIFF: https://github.com/llvm/llvm-project/commit/f5ef2c58381fb8056bf919c7a0862bb8d65e1e28.diff L

[clang] 2e603c6 - [clang] Construct SmallVector with iterator ranges (NFC)

Author: Kazu Hirata Date: 2022-06-10T22:45:26-07:00 New Revision: 2e603c67c204b6bc9d96bf090ef4fd3a5b04aa51 URL: https://github.com/llvm/llvm-project/commit/2e603c67c204b6bc9d96bf090ef4fd3a5b04aa51 DIFF: https://github.com/llvm/llvm-project/commit/2e603c67c204b6bc9d96bf090ef4fd3a5b04aa51.diff L

[PATCH] D127484: [clang-format] Use tabs on GNU style

owenpan added a comment. In D127484#3574803 , @curdeius wrote: > It seems like a breaking change that may be painful for users of GNU style. Yeah. There are tens of thousands of lines starting with 8 spaces but none starting with a tab in all .c files u

[PATCH] D125349: [Sema] Fix crash for C11 atomic in gnu++ mode

jansvoboda11 added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:8982 // Extension: Add the binary operators =, +=, -=, *=, /= for vector types. for (QualType Vec1Ty : CandidateTypes[0].vector_types()) jansvoboda11 wrote: > aaron.ballma

[PATCH] D125400: [clang][Analyzer] Add errno state to standard functions modeling.

balazske added a comment. The documentation of `ErrnoChecker` is added in the previous change D122150 . Really this documentation should be updated when any checker is changed related to errno modeling (errno modeling can be added later to any checker that eval

[PATCH] D127471: [Coroutines] Convert coroutine.presplit to enum attr

nikic added a comment. You probably want to add this to `llvm::UpgradeAttributes` as well, to maintain support for old bitcode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127471/new/ https://reviews.llvm.org/D127471 ___

[PATCH] D126291: [flang][Driver] Update link job on windows

rovka added inline comments. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:133 + if (C.getDriver().IsFlangMode()) { +tools::addFortranRuntimeLibraryPath(TC, Args, CmdArgs); mmuetzel wrote: > The GNU toolchain has this conditional on > `Args.hasArg(opti

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire updated this revision to Diff 435826. junaire added a comment. - split the tests - add % to all meta commands Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/include/clang/Interpret

[clang] f93dee1 - [clang][ASTImporter] Fix import of function with auto return type.

Author: Balázs Kéri Date: 2022-06-10T10:18:53+02:00 New Revision: f93dee10336a2361da528db0ff0f7188acba9627 URL: https://github.com/llvm/llvm-project/commit/f93dee10336a2361da528db0ff0f7188acba9627 DIFF: https://github.com/llvm/llvm-project/commit/f93dee10336a2361da528db0ff0f7188acba9627.diff L

[PATCH] D127396: [clang][ASTImporter] Fix import of function with auto return type.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf93dee10336a: [clang][ASTImporter] Fix import of function with auto return type. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127396

[clang] 1d3d5ec - [Documentation] Fixed typos in LibASTMatchers tutorial

Author: isuckatcs Date: 2022-06-10T10:22:36+02:00 New Revision: 1d3d5ecea5f07546a9755a1d4546dbe4930af624 URL: https://github.com/llvm/llvm-project/commit/1d3d5ecea5f07546a9755a1d4546dbe4930af624 DIFF: https://github.com/llvm/llvm-project/commit/1d3d5ecea5f07546a9755a1d4546dbe4930af624.diff LOG

[PATCH] D124738: [Documentation][Clang] Clang LibASTMatchers tutorial typo fix

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d3d5ecea5f0: [Documentation] Fixed typos in LibASTMatchers tutorial (authored by isuckatcs). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D127434: [clang][dataflow] In `optional` model, match call return via hasType

sgatev added a comment. I see that the declaration of `operator*` in `std::unique_ptr` is `typename add_lvalue_reference::type operator*() const;`. I managed to reproduce the crash with the following snippet: #include namespace detail { template struct type_identity { using typ

[PATCH] D127446: [clang-tidy] Add `-verify-config` command line argument

njames93 added a comment. In D127446#3572491 , @carlosgalvezp wrote: > This sounds like great functionality, surely saving a lot of headaches! Any > reason why we wouldn't want this active by default? I'd personally even go > one step further and make

[PATCH] D127471: [Coroutines] Convert coroutine.presplit to enum attr

ChuanqiXu added a comment. In D127471#3572616 , @nikic wrote: > You probably want to add this to `llvm::UpgradeAttributes` as well, to > maintain support for old bitcode. Oh, I feel like it is not so meaningful to keep backward compatibility. We've don

[PATCH] D127184: [clangd] Add to header map

nridge added a comment. This change looks fine to me. I wonder though if we should be a bit more systematic about it, and try to cover other newly added libstdc++ implementation headers? I checked out gcc's git repository, and ran: $ git diff --name-only --diff-filter=A releases/gcc-9.1.0 re

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire added inline comments. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:180 DiagnosticsEngine &Diags = getCI()->getDiagnostics(); if (Diags.hasErrorOccurred()) { TranslationUnitDecl *MostRecentTU = C.getTranslationUnitDecl(); v.g.vassile

[PATCH] D126291: [flang][Driver] Update link job on windows

rovka updated this revision to Diff 435842. rovka added a comment. Moved the check for `-flang-experimental-exec` into addFortranRuntimeLibraryPath, so it affects all the toolchains. @awarzynski does this look like a good idea? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126291/new/

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 435831. koops added a comment. Changes suggested by aaron.ballman to avoid failures on windows. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/inc

[PATCH] D126291: [flang][Driver] Update link job on windows

mmuetzel added a comment. In D126291#3572777 , @rovka wrote: > Moved the check for `-flang-experimental-exec` into > addFortranRuntimeLibraryPath, so it affects all the toolchains. @awarzynski > does this look like a good idea? If moving that check to

[PATCH] D126291: [flang][Driver] Update link job on windows

mstorsjo added inline comments. Comment at: clang/lib/Driver/ToolChains/MinGW.cpp:224 +tools::addFortranRuntimeLibs(TC, CmdArgs); + } + mmuetzel wrote: > MinGW behaves similarly to GNU in many respects. The GNU toolchain file adds > `CmdArgs.push_back("-lm"

[PATCH] D126291: [flang][Driver] Update link job on windows

mmuetzel added inline comments. Comment at: flang/test/Driver/linker-flags-windows.f90:7 +! clang/lib/Driver/Toolchains/MSVC.cpp. +! REQUIRES: windows-msvc + It looks like this test is skipped on windows (MSVC): https://buildkite.com/llvm-project/premerge-checks/

[PATCH] D126974: [scan-build-py] Fix exception on shutdown with sarif-html output format

wanders added a comment. Gentle 1-week ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126974/new/ https://reviews.llvm.org/D126974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D125860: [clang] Only use major version in resource dir

tbaeder updated this revision to Diff 435850. Herald added a subscriber: Enna1. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125860/new/ https://reviews.llvm.org/D125860 Files: clang/include/clang/Basic/Version.inc.in clang/lib/Driver/Driver.cpp clang/lib/Headers/CMakeLists.txt

[PATCH] D126291: [flang][Driver] Update link job on windows

awarzynski added a comment. In D126291#3572777 , @rovka wrote: > Moved the check for `-flang-experimental-exec` into > addFortranRuntimeLibraryPath, so it affects all the toolchains. @awarzynski > does this look like a good idea? OK with me! 👍🏻 CHANG

[PATCH] D127207: [flang][driver] Fix support for `-x`

awarzynski added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:268 + // pre-processed inputs. +.Case("f95", Language::Fortran) +.Case("f95-cpp-input", Language::Fortran) ekieri wrote: > awar

[clang] 07a7fd3 - [analyzer] Print the offending function at EndAnalysis crash

Author: Balazs Benics Date: 2022-06-10T12:21:17+02:00 New Revision: 07a7fd314a118393e6ca5e4dbcc9c3d91ff96172 URL: https://github.com/llvm/llvm-project/commit/07a7fd314a118393e6ca5e4dbcc9c3d91ff96172 DIFF: https://github.com/llvm/llvm-project/commit/07a7fd314a118393e6ca5e4dbcc9c3d91ff96172.diff

[PATCH] D127389: [analyzer] Print the offending function at EndAnalysis crash

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG07a7fd314a11: [analyzer] Print the offending function at EndAnalysis crash (authored by steakhal). Changed prior to commit: https://reviews.llvm.o

[PATCH] D127197: [ARM] Fix how size-0 bitfields affect homogeneous aggregates.

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. LGTM. I tested this patch in an end-to-end fashion to look at the assembly in affected cases, and it is doing the right thing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang] ceb21fa - [ARM] Fix how size-0 bitfields affect homogeneous aggregates.

Author: Simon Tatham Date: 2022-06-10T11:27:24+01:00 New Revision: ceb21fa4e49ddc8478371b41250f206082c5c67e URL: https://github.com/llvm/llvm-project/commit/ceb21fa4e49ddc8478371b41250f206082c5c67e DIFF: https://github.com/llvm/llvm-project/commit/ceb21fa4e49ddc8478371b41250f206082c5c67e.diff

[PATCH] D127197: [ARM] Fix how size-0 bitfields affect homogeneous aggregates.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGceb21fa4e49d: [ARM] Fix how size-0 bitfields affect homogeneous aggregates. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D127207: [flang][driver] Fix support for `-x`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e782ba21be4: [flang][driver] Fix support for `-x` (authored by awarzynski). Changed prior to commit: https://reviews.llvm.org/D127207?vs=435115&i

[clang] 3e782ba - [flang][driver] Fix support for `-x`

Author: Andrzej Warzynski Date: 2022-06-10T10:36:25Z New Revision: 3e782ba21be4b88c761d3b0854df130d7ca08a56 URL: https://github.com/llvm/llvm-project/commit/3e782ba21be4b88c761d3b0854df130d7ca08a56 DIFF: https://github.com/llvm/llvm-project/commit/3e782ba21be4b88c761d3b0854df130d7ca08a56.diff

[PATCH] D127484: [clang-format] Use tabs on GNU style

a4lg created this revision. Herald added a project: All. a4lg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. On default configuration of GNU Indent, it uses 8-width tabs. Because GNU Indent's indentation works like UT_ForContinuationAndIn

[clang] d50d994 - [analyzer] Deprecate `-analyzer-store region` flag

Author: Balazs Benics Date: 2022-06-10T12:57:15+02:00 New Revision: d50d9946d1d7e5f20881f0bc71fbd025040b1c96 URL: https://github.com/llvm/llvm-project/commit/d50d9946d1d7e5f20881f0bc71fbd025040b1c96 DIFF: https://github.com/llvm/llvm-project/commit/d50d9946d1d7e5f20881f0bc71fbd025040b1c96.diff

[PATCH] D126215: [analyzer] Deprecate `-analyzer-store region` flag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd50d9946d1d7: [analyzer] Deprecate `-analyzer-store region` flag (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] b73c228 - [analyzer][NFC] Remove unused RegionStoreFeatures

Author: Balazs Benics Date: 2022-06-10T13:02:26+02:00 New Revision: b73c2280f5f3596c65d6c145abc2c4a97a532fc6 URL: https://github.com/llvm/llvm-project/commit/b73c2280f5f3596c65d6c145abc2c4a97a532fc6 DIFF: https://github.com/llvm/llvm-project/commit/b73c2280f5f3596c65d6c145abc2c4a97a532fc6.diff

[PATCH] D126216: [analyzer][NFC] Remove unused RegionStoreFeatures

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb73c2280f5f3: [analyzer][NFC] Remove unused RegionStoreFeatures (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[clang-tools-extra] 07b4a6d - [analyzer] Deprecate the unused 'analyzer-opt-analyze-nested-blocks' cc1 flag

Author: Balazs Benics Date: 2022-06-10T13:09:37+02:00 New Revision: 07b4a6d0461fe64e10d30029ed3d598e49ca3810 URL: https://github.com/llvm/llvm-project/commit/07b4a6d0461fe64e10d30029ed3d598e49ca3810 DIFF: https://github.com/llvm/llvm-project/commit/07b4a6d0461fe64e10d30029ed3d598e49ca3810.diff

[PATCH] D126067: [analyzer] Deprecate the unused 'analyzer-opt-analyze-nested-blocks' cc1 flag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG07b4a6d0461f: [analyzer] Deprecate the unused 'analyzer-opt-analyze-nested-blocks' cc1 flag (authored by steakhal). Repository: rG LLVM Github Mon

[PATCH] D127434: [clang][dataflow] In `optional` model, match call return via hasType

samestep added a comment. @sgatev Oh nice, thank you for figuring that out! @ymandel and I saw that on Wednesday and tried for a while to figure out how to encode it into a test using the sample implementation from cppreference, but I think we kept forgetting the `::type` part. I'll add this as

[PATCH] D126215: [analyzer] Deprecate `-analyzer-store region` flag

thakis added a comment. Looks like this breaks building clang-tidy: http://45.33.8.238/linux/78232/step_4.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126215/new/ https://rev

[clang-tools-extra] 4c38953 - [clang-tidy] Remove reference to CSA AnalysisStoreOpt field

Author: Balazs Benics Date: 2022-06-10T13:21:28+02:00 New Revision: 4c38953f32f29a0cd3b8b9d9ae894bb49d3cd44b URL: https://github.com/llvm/llvm-project/commit/4c38953f32f29a0cd3b8b9d9ae894bb49d3cd44b DIFF: https://github.com/llvm/llvm-project/commit/4c38953f32f29a0cd3b8b9d9ae894bb49d3cd44b.diff

[PATCH] D126215: [analyzer] Deprecate `-analyzer-store region` flag

steakhal added a comment. In D126215#3572984 , @thakis wrote: > Looks like this breaks building clang-tidy: > http://45.33.8.238/linux/78232/step_4.txt > > Please take a look, and revert for now if it takes a while to fix. Thanks. It should be fixed by

[PATCH] D127485: [analyzer][NFC] Remove unused Analyses enum

steakhal created this revision. steakhal added a reviewer: martong. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: All. steakhal

[PATCH] D127486: [analyzer][NFC] Inline AnalyzerOptions::getUserMode()

steakhal created this revision. steakhal added a reviewer: martong. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: All. steakhal

[PATCH] D127487: [Sema] Fix assertion failure when instantiating requires expression

ilya-biryukov created this revision. ilya-biryukov added reviewers: erichkeane, saar.raz. Herald added a project: All. ilya-biryukov requested review of this revision. Herald added a project: clang. Fixes #54629. The crash is is caused by the double template instantiation. See the added test. Here

[clang-tools-extra] 8311604 - [NFC] update clang-tools-extra README.txt

Author: Shivam Gupta Date: 2022-06-10T16:59:57+05:30 New Revision: 8311604669c708f65be7335baba9fd774eef944c URL: https://github.com/llvm/llvm-project/commit/8311604669c708f65be7335baba9fd774eef944c DIFF: https://github.com/llvm/llvm-project/commit/8311604669c708f65be7335baba9fd774eef944c.diff

[PATCH] D127487: [Sema] Fix assertion failure when instantiating requires expression

ilya-biryukov added a subscriber: jyknight. ilya-biryukov added a comment. @saar.raz @erichkeane please let me know if you are the right people to review this. The change might need a little more refactoring, e.g. placement new should probably move to a helper in Sema to align with what clang us

[PATCH] D127487: [Sema] Fix assertion failure when instantiating requires expression

ilya-biryukov added a comment. Fixed issue is: 54629 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127487/new/ https://reviews.llvm.org/D127487 ___ cfe

[PATCH] D127434: [clang][dataflow] In `optional` model, match call return via hasType

samestep updated this revision to Diff 435873. samestep added a comment. Add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127434/new/ https://reviews.llvm.org/D127434 Files: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccess

[PATCH] D126067: [analyzer] Deprecate the unused 'analyzer-opt-analyze-nested-blocks' cc1 flag

thakis added a comment. One of your changes broke check-clang: http://45.33.8.238/linux/78236/step_7.txt Please take a look and revert for now if it takes a while to fix. (Please run tests locally before committing.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D125860: [clang] Only use major version in resource dir

tbaeder updated this revision to Diff 435876. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125860/new/ https://reviews.llvm.org/D125860 Files: clang/include/clang/Basic/Version.inc.in clang/lib/Driver/Driver.cpp clang/lib/Headers/CMakeLists.txt clang/lib/Tooling/CMakeLists.txt

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet updated this revision to Diff 435877. gchatelet marked an inline comment as done. gchatelet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126903/new/ https://reviews.llvm.org/D126903 Files: clang/doc

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:7334 if (TSI) { SDValue Result = TSI->EmitTargetCodeForMemset( *this, dl, Chain, Dst, Src, Size, Alignment, isVol, DstPtrInfo); courbet wrote: > There is

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

courbet added inline comments. Comment at: llvm/include/llvm/CodeGen/SelectionDAGTargetInfo.h:79 /// SDValue if the target declines to use custom code and a different /// lowering strategy should be used. virtual SDValue EmitTargetCodeForMemset(SelectionDAG &DAG, const S

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

upsj added a comment. @nridge @sammccall can you give this another look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124690/new/ https://reviews.llvm.org/D124690 ___ cfe-commits mailing list cfe-commit

[PATCH] D127408: [clang][driver] Introduce new -fdriver-only flag

egorzhdan accepted this revision. egorzhdan added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127408/new/ https://reviews.llvm.org/D127408

[clang] 90374df - [analyzer] Fix buildbots after introducing a new frontend warning

Author: Balazs Benics Date: 2022-06-10T14:47:23+02:00 New Revision: 90374df15ddc58d823ca42326a76f58e748f20eb URL: https://github.com/llvm/llvm-project/commit/90374df15ddc58d823ca42326a76f58e748f20eb DIFF: https://github.com/llvm/llvm-project/commit/90374df15ddc58d823ca42326a76f58e748f20eb.diff

[PATCH] D126291: [flang][Driver] Update link job on windows

mmuetzel added a comment. Not sure if this is the right place to add this. But maybe something like this could be used to add 'windows-msvc' and 'windows-gnu' features that could be used to run tests conditionally on Windows with MSVC or MinGW toolchains: diff --git a/llvm/utils/lit/lit/llvm/

[PATCH] D126067: [analyzer] Deprecate the unused 'analyzer-opt-analyze-nested-blocks' cc1 flag

steakhal added a comment. In D126067#3573056 , @thakis wrote: > One of your changes broke check-clang: > http://45.33.8.238/linux/78236/step_7.txt > > Please take a look and revert for now if it takes a while to fix. > > (Please run tests locally before

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet updated this revision to Diff 435883. gchatelet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126903/new/ https://reviews.llvm.org/D126903 Files: clang/docs/LanguageExtensions.rst clang/include/cla

[clang-tools-extra] 8406839 - Revert "[analyzer] Deprecate `-analyzer-store region` flag"

Author: Nico Weber Date: 2022-06-10T08:50:13-04:00 New Revision: 8406839d1926486de900c7cabeea9f841bd3edf2 URL: https://github.com/llvm/llvm-project/commit/8406839d1926486de900c7cabeea9f841bd3edf2 DIFF: https://github.com/llvm/llvm-project/commit/8406839d1926486de900c7cabeea9f841bd3edf2.diff LO

[PATCH] D126067: [analyzer] Deprecate the unused 'analyzer-opt-analyze-nested-blocks' cc1 flag

thakis added a comment. Reverted in 8406839d1926486de900c7cabeea9f841bd3edf2 for now. See comment on https://reviews.llvm.org/rG90374df15ddc58d823ca42326a76f58e748f20eb. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

courbet accepted this revision. courbet added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:7355 + isVol, true, DstPtrInfo, AAInfo); +assert(Result && "getMemset

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

aaron.ballman added a comment. Precommit CI on Linux seems to be failing, but I can't quite tell whether the failures are related or not. I suspect they're unrelated, but they're with libomp and other OpenMP tests so it's not fully clear. Can you investigate those? I tried your patch locally o

[PATCH] D127452: [clang-cl][MSVC] Map /external:Wn n=1-4 to -Wsystem-headers

hans added a comment. Right, this is not the same, but I suppose it's better than ignoring the flag. Comment at: clang/include/clang/Driver/Options.td:6462 Alias, AliasArgs<["no-invalid-source-encoding"]>; +def _SLASH_external_W0 : CLIgnoredFlag<"external:W0">; +def _SLASH_e

[PATCH] D127487: [Sema] Fix assertion failure when instantiating requires expression

erichkeane added a comment. I'm not quite understanding this yet, so I'll have to take another look early next week. However, I AM intending to get https://reviews.llvm.org/D126907 committed in the next week or so. Could you perhaps see how it interacts with that? Its a sizable, multi-month

[PATCH] D127448: [wip][pseudo] Implement guard extension.

hokein updated this revision to Diff 435889. hokein added a comment. - add comments; - add unittest and lit test; - misc improvements; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127448/new/ https://reviews.llvm.org/D127448 Files: clang-tools-

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet updated this revision to Diff 435890. gchatelet added a comment. - Update assert message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126903/new/ https://reviews.llvm.org/D126903 Files: clang/docs/LanguageExtensions.rst clang/includ

[PATCH] D127494: [clang][please ignore] Comment-only change to test CI baseline status.

mboehme created this revision. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I'm trying to work out whether failures I'm seeing in the CI for https://reviews.llvm.org/D111548 also occur on a comment-on

[PATCH] D127496: [NFC] Suggest Release mode in clang GettingStarted.html

xgupta created this revision. xgupta added reviewers: thieta, aaron.ballman. Herald added a project: All. xgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fix https://github.com/llvm/llvm-project/issues/23841. Lots of beginners a

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet updated this revision to Diff 435893. gchatelet added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126903/new/ https://reviews.llvm.org/D126903 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/Bui

[clang] 38637ee - [clang] Add support for __builtin_memset_inline

Author: Guillaume Chatelet Date: 2022-06-10T13:13:59Z New Revision: 38637ee477541370a90b37f149069d8e5c0c2efd URL: https://github.com/llvm/llvm-project/commit/38637ee477541370a90b37f149069d8e5c0c2efd DIFF: https://github.com/llvm/llvm-project/commit/38637ee477541370a90b37f149069d8e5c0c2efd.diff

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG38637ee47754: [clang] Add support for __builtin_memset_inline (authored by gchatelet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D126960: [clang][sema] Unary not boolean to int conversion

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:12328 return IntRange::forValueOfType(C, GetExprType(E)); +case UO_Not: Richard mentions UO_PreInc, UO_PreDec, UO_Minus, and UO_Not. What about the other 3? ===

[PATCH] D125349: [Sema] Fix crash for C11 atomic in gnu++ mode

rjmccall added inline comments. Comment at: clang/include/clang/AST/Type.h:277 +return qs; + } Could you go ahead and add this for `const` and `restrict` as well? I think that will give us the full set. Comment at: clang/lib/Sema/SemaO

[PATCH] D127452: [clang-cl][MSVC] Map /external:Wn n=1-4 to -Wsystem-headers

steplong added inline comments. Comment at: clang/test/Driver/cl-zc.cpp:106 // DllExportInlines-NOT: "-fno-dllexport-inlines" +// RUN: %clang_cl /external:W1 /c -### -- %s 2>&1 | FileCheck -check-prefix=EXTERNAL_Wn %s hans wrote: > This is not the right test

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. Looks reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117977/new/ https://reviews.llvm.org/D117977 __

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays for stricter handling of flexible arrays

serge-sans-paille updated this revision to Diff 435899. serge-sans-paille added a comment. Update changelog entry CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126864/new/ https://reviews.llvm.org/D126864 Files: clang/docs/ClangCommandLineReference.rst clang/docs/ReleaseNotes.rst

[PATCH] D127452: [clang-cl][MSVC] Map /external:Wn n=1-4 to -Wsystem-headers

steplong updated this revision to Diff 435901. steplong added a comment. - Move tests to cl-options.c - Map /external:W0 to -Wno-system-headers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127452/new/ https://reviews.llvm.org/D127452 Files: cla

<    1   2   3   >