nridge added a comment.

This change looks fine to me.

I wonder though if we should be a bit more systematic about it, and try to 
cover other newly added libstdc++ implementation headers?

I checked out gcc's git repository, and ran:

  $ git diff --name-only --diff-filter=A releases/gcc-9.1.0 releases/gcc-10.1.0 
| grep include/bits

which turned up several additional implementation headers newly added in gcc 10:

  libstdc++-v3/include/bits/charconv.h
  libstdc++-v3/include/bits/int_limits.h
  libstdc++-v3/include/bits/iterator_concepts.h
  libstdc++-v3/include/bits/range_cmp.h
  libstdc++-v3/include/bits/ranges_algo.h
  libstdc++-v3/include/bits/ranges_algobase.h
  libstdc++-v3/include/bits/ranges_uninitialized.h

(There are other new ones in gcc 11, and some in older versions that we've 
missed, but I think handling a single gcc version would be a good scope for 
this patch.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127184/new/

https://reviews.llvm.org/D127184

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D12718... Florian Albrechtskirchinger via Phabricator via cfe-commits
    • [PATCH] D... Nathan Ridge via Phabricator via cfe-commits
    • [PATCH] D... Florian Albrechtskirchinger via Phabricator via cfe-commits
    • [PATCH] D... Florian Albrechtskirchinger via Phabricator via cfe-commits
    • [PATCH] D... Florian Albrechtskirchinger via Phabricator via cfe-commits
    • [PATCH] D... Florian Albrechtskirchinger via Phabricator via cfe-commits
    • [PATCH] D... Nathan Ridge via Phabricator via cfe-commits
    • [PATCH] D... Sam McCall via Phabricator via cfe-commits
    • [PATCH] D... Florian Albrechtskirchinger via Phabricator via cfe-commits

Reply via email to