[PATCH] D126340: [clang][AIX] add option -mdefault-visibility-export-mapping

2022-06-02 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1228 GV->setDLLStorageClass(llvm::GlobalVariable::DLLImportStorageClass); -else if (D->hasAttr() && !GV->isDeclarationForLinker()) +else if ((D->hasAttr() || + shouldMapVisi

[PATCH] D126812: [Binary] Promote OffloadBinary to inherit from Binary

2022-06-02 Thread Artem Belevich via Phabricator via cfe-commits
tra added inline comments. Comment at: llvm/lib/Object/OffloadBinary.cpp:18 - -namespace llvm { MaskRay wrote: > tra wrote: > > tra wrote: > > > Nit: `using namespace` seems a bit too heavy-handed when you only need > > > one enum > > > `using object_error = l

[PATCH] D126412: Fix a buglet in remove_dots().

2022-06-02 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, sorry for the delay, do you need someone to push this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126412/new/ https://reviews.llvm.org/D12641

[PATCH] D126412: Fix a buglet in remove_dots().

2022-06-02 Thread Paul Pluzhnikov via Phabricator via cfe-commits
ppluzhnikov added a comment. In D126412#3553796 , @rnk wrote: > do you need someone to push this? Yes, please. I do not have commit rights. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126412/new/ https:

[PATCH] D125402: [clang][diag] warn if function returns class type by-const-value

2022-06-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D125402#3517865 , @nlee wrote: > How about adding CXXRecordDecl::hasMoveConstructor() to ensure the type is > movable? I ran a test with OpenCV(c++11), and it returned some useful > warnings: I don't think that will be

[PATCH] D126862: [clang] [MSVC] Enable unwind tables for ARM

2022-06-02 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Herald added a subscriber: StephenFan. This needs a test. There is existing testing gap as this change does not break any clang/test/Driver test. @@ -449,13 +449,15 @@ bool MSVCToolChain::

[PATCH] D126803: [llvm][analyzer][NFC] Introduce SFINAE for specializing FoldingSetTraits

2022-06-02 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added inline comments. Comment at: llvm/include/llvm/ADT/FoldingSet.h:260 /// to FoldingSets that were not originally designed to have that behavior. -template struct FoldingSetTrait - : public DefaultFoldingSetTrait {}; +template +struct FoldingSetTrait : public Defa

[PATCH] D126803: [llvm][analyzer][NFC] Introduce SFINAE for specializing FoldingSetTraits

2022-06-02 Thread Balázs Benics via Phabricator via cfe-commits
steakhal updated this revision to Diff 433791. steakhal marked 2 inline comments as done. steakhal added a comment. - Named SFINAE type parameter. - Using default return value of `enable_if_t` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126803/new

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

2022-06-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D126796#3553708 , @MaskRay wrote: > If you still decide to add an option to clang, I think "diagnostics" is > better than "warnings". There are many diagnostics which are errors by > default. Good point about warnings

[PATCH] D125402: [clang][diag] warn if function returns class type by-const-value

2022-06-02 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In D125402#3553802 , @aaron.ballman wrote: > In D125402#3517865 , @nlee wrote: > >> How about adding CXXRecordDecl::hasMoveConstructor() to ensure the type is >> movable? I ran a test

[PATCH] D125402: [clang][diag] warn if function returns class type by-const-value

2022-06-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D125402#3553825 , @erichkeane wrote: > In D125402#3553802 , @aaron.ballman > wrote: > >> In D125402#3517865 , @nlee wrote: >> >>> How a

[PATCH] D125402: [clang][diag] warn if function returns class type by-const-value

2022-06-02 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In D125402#3553841 , @aaron.ballman wrote: > In D125402#3553825 , @erichkeane > wrote: > >> In D125402#3553802 , >> @aaron.ballman wrote: >>

[PATCH] D119296: KCFI sanitizer

2022-06-02 Thread Sami Tolvanen via Phabricator via cfe-commits
samitolvanen updated this revision to Diff 433795. samitolvanen added a comment. Herald added subscribers: jsji, laytonio, arichardson, emaste. Herald added a reviewer: MaskRay. - Changed Clang to emit operand bundles for indirect calls as pcc suggested, and dropped the `llvm.kcfi.check` intrinsi

[clang] 33ca5a4 - [analyzer][NFC] Add partial specializations for ProgramStateTraits

2022-06-02 Thread Balazs Benics via cfe-commits
Author: Balazs Benics Date: 2022-06-02T19:46:38+02:00 New Revision: 33ca5a447e7f0f9778f5adc96e24a1ef4a899213 URL: https://github.com/llvm/llvm-project/commit/33ca5a447e7f0f9778f5adc96e24a1ef4a899213 DIFF: https://github.com/llvm/llvm-project/commit/33ca5a447e7f0f9778f5adc96e24a1ef4a899213.diff

[PATCH] D126801: [analyzer][NFC] Add partial specializations for ProgramStateTraits

2022-06-02 Thread Balázs Benics via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. steakhal marked an inline comment as done. Closed by commit rG33ca5a447e7f: [analyzer][NFC] Add partial specializations for ProgramStateTraits (authored by steakhal). Changed prior to commit: https://reviews.llvm.org/D126

[PATCH] D126602: [Clang][OpenMP] Replace IgnoreImpCasts with IgnoreImplicitAsWritten in atomic compare

2022-06-02 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 433800. tianshilei1992 added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126602/new/ https://reviews.llvm.org/D126602 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/lib/Sema/Sem

[PATCH] D119296: KCFI sanitizer

2022-06-02 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. This lld/ELF change looks like a hack. I'll need to study what this patch does, but in the meanwhile I changed myself to a blocking reviewer as I think the lld/ELF change needs more investigation. Comment at: lld/ELF/Symbols.cpp:553 + // incompatible

[clang] cf1f1b7 - [analyzer][NFC] Uplift checkers after D126801

2022-06-02 Thread Balazs Benics via cfe-commits
Author: Balazs Benics Date: 2022-06-02T19:46:38+02:00 New Revision: cf1f1b7240a35c5e1d4bc2cd3626ba8432949c98 URL: https://github.com/llvm/llvm-project/commit/cf1f1b7240a35c5e1d4bc2cd3626ba8432949c98 DIFF: https://github.com/llvm/llvm-project/commit/cf1f1b7240a35c5e1d4bc2cd3626ba8432949c98.diff

[PATCH] D126802: [analyzer][NFC] Uplift checkers after D126801

2022-06-02 Thread Balázs Benics via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGcf1f1b7240a3: [analyzer][NFC] Uplift checkers after D126801 (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126802/new/ https://review

[clang] 7d24641 - [llvm][analyzer][NFC] Introduce SFINAE for specializing FoldingSetTraits

2022-06-02 Thread Balazs Benics via cfe-commits
Author: Balazs Benics Date: 2022-06-02T19:46:38+02:00 New Revision: 7d24641f8916c2af16870a7b8628c1458cf15462 URL: https://github.com/llvm/llvm-project/commit/7d24641f8916c2af16870a7b8628c1458cf15462 DIFF: https://github.com/llvm/llvm-project/commit/7d24641f8916c2af16870a7b8628c1458cf15462.diff

[PATCH] D126803: [llvm][analyzer][NFC] Introduce SFINAE for specializing FoldingSetTraits

2022-06-02 Thread Balázs Benics via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d24641f8916: [llvm][analyzer][NFC] Introduce SFINAE for specializing FoldingSetTraits (authored by steakhal). Repository: rG LLVM Github Monorepo

[PATCH] D119296: KCFI sanitizer

2022-06-02 Thread Sami Tolvanen via Phabricator via cfe-commits
samitolvanen added inline comments. Comment at: lld/ELF/Symbols.cpp:553 + // incompatible declarations for the same function. + if (isWeak() && getName().startswith("__kcfi_typeid_") && + cast(this)->value != other.value) MaskRay wrote: > This change looks

[PATCH] D126602: [Clang][OpenMP] Avoid using `IgnoreImpCasts` if possible

2022-06-02 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126602/new/ https://reviews.llvm.org/D126602 ___

[PATCH] D125402: [clang][diag] warn if function returns class type by-const-value

2022-06-02 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In D125402#3553855 , @erichkeane wrote: > In D125402#3553841 , @aaron.ballman > wrote: > >> In D125402#3553825 , @erichkeane >> wrote: >> >>

[clang] cc756f9 - [PS5] Classify __m64 as integer, matching PS4 ABI

2022-06-02 Thread Paul Robinson via cfe-commits
Author: Paul Robinson Date: 2022-06-02T11:00:53-07:00 New Revision: cc756f91c3803a7f91868ecf64929a90399cb4bb URL: https://github.com/llvm/llvm-project/commit/cc756f91c3803a7f91868ecf64929a90399cb4bb DIFF: https://github.com/llvm/llvm-project/commit/cc756f91c3803a7f91868ecf64929a90399cb4bb.diff

[clang] dc5175a - [PS5] Make passing unions in registers match PS4 ABI

2022-06-02 Thread Paul Robinson via cfe-commits
Author: Paul Robinson Date: 2022-06-02T11:00:54-07:00 New Revision: dc5175adef0804eb396690ea3fe35c6d450e6e64 URL: https://github.com/llvm/llvm-project/commit/dc5175adef0804eb396690ea3fe35c6d450e6e64 DIFF: https://github.com/llvm/llvm-project/commit/dc5175adef0804eb396690ea3fe35c6d450e6e64.diff

[PATCH] D124244: [analyzer] add StoreToImmutable and ModelConstQualifiedReturn checkers

2022-06-02 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. Any update on this. I'm really excited about this one. Let me know if something blocks you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124244/new/ https://reviews.llvm.org/D124244 ___ cfe-commits mailing list cfe

[PATCH] D119296: KCFI sanitizer

2022-06-02 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: lld/ELF/Symbols.cpp:553 + // incompatible declarations for the same function. + if (isWeak() && getName().startswith("__kcfi_typeid_") && + cast(this)->value != other.value) samitolvanen wrote: > MaskRay wrote: >

[clang] 35ab2a1 - Fix a buglet in remove_dots().

2022-06-02 Thread Reid Kleckner via cfe-commits
Author: Paul Pluzhnikov Date: 2022-06-02T11:07:44-07:00 New Revision: 35ab2a11bb55c39ef9fe389aeacc14bb55c5a12d URL: https://github.com/llvm/llvm-project/commit/35ab2a11bb55c39ef9fe389aeacc14bb55c5a12d DIFF: https://github.com/llvm/llvm-project/commit/35ab2a11bb55c39ef9fe389aeacc14bb55c5a12d.dif

[PATCH] D126412: Fix a buglet in remove_dots().

2022-06-02 Thread Reid Kleckner via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35ab2a11bb55: Fix a buglet in remove_dots(). (authored by ppluzhnikov, committed by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 4c1e487 - scan-build-py: Change scripts to explicitly require python3

2022-06-02 Thread Anders Waldenborg via cfe-commits
Author: Anders Waldenborg Date: 2022-06-02T20:08:21+02:00 New Revision: 4c1e487c413810655757ea19d0cf3d4f5c40898e URL: https://github.com/llvm/llvm-project/commit/4c1e487c413810655757ea19d0cf3d4f5c40898e DIFF: https://github.com/llvm/llvm-project/commit/4c1e487c413810655757ea19d0cf3d4f5c40898e.d

[PATCH] D126804: [scan-build-py] Change scripts to explicitly require python3

2022-06-02 Thread Anders Waldenborg via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4c1e487c4138: scan-build-py: Change scripts to explicitly require python3 (authored by wanders). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126804/new/ h

[PATCH] D126902: [Attributes] Remove AttrSyntax and migrate uses to AttributeCommonInfo::Syntax (NFC)

2022-06-02 Thread Leonard Grey via Phabricator via cfe-commits
lgrey created this revision. lgrey added a reviewer: aaron.ballman. lgrey added a project: clang. Herald added a subscriber: jdoerfert. Herald added a project: All. lgrey requested review of this revision. Herald added a subscriber: cfe-commits. This is setup for allowing `hasAttribute` to work fo

[PATCH] D126902: [Attributes] Remove AttrSyntax and migrate uses to AttributeCommonInfo::Syntax (NFC)

2022-06-02 Thread Leonard Grey via Phabricator via cfe-commits
lgrey added inline comments. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:3368 + fn("C2x", C2x); + OS << "case AttributeCommonInfo::Syntax::AS_Keyword:\n"; + OS << "case AttributeCommonInfo::Syntax::AS_ContextSensitiveKeyword:\n"; Not sure if this sho

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

2022-06-02 Thread Guillaume Chatelet via Phabricator via cfe-commits
gchatelet created this revision. gchatelet added reviewers: courbet, efriedma, t.p.northover, jdoerfert. Herald added subscribers: jsji, pengfei, hiraditya. Herald added a project: All. gchatelet requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-c

[PATCH] D119296: KCFI sanitizer

2022-06-02 Thread Sami Tolvanen via Phabricator via cfe-commits
samitolvanen added inline comments. Comment at: lld/ELF/Symbols.cpp:553 + // incompatible declarations for the same function. + if (isWeak() && getName().startswith("__kcfi_typeid_") && + cast(this)->value != other.value) MaskRay wrote: > samitolvanen wrot

[PATCH] D126891: [clang-tidy] The check should ignore final classes

2022-06-02 Thread Carlos Galvez via Phabricator via cfe-commits
carlosgalvezp added a comment. Hmm, `MostDerived` **does** have a public virtual destructor in your example already - if the base class destructor is virtual, the child class destructor is virtual. In that sense the check should not warn. Seems like there's some deeper problem in the check? R

[PATCH] D124748: [clang-format] Fix whitespace counting stuff

2022-06-02 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Can there be a test case, not related to Verilog? Or do we need to wait until you pump up the support for that? Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D125373: [pp-trace] Print HashLoc in InclusionDirective callback

2022-06-02 Thread Tommy Chiang via Phabricator via cfe-commits
oToToT added a comment. Thanks for reviewing! I will commit it myself later. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125373/new/ https://reviews.llvm.org/D125373 ___ cfe-commits mailing list cfe

[PATCH] D124753: [HLSL] Set main as default entry.

2022-06-02 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. In D124753#3550670 , @python3kgae wrote: > In D124753#3550337 , @Anastasia > wrote: > >> In D124753#3546608 , @python3kgae >> wrote: >> >>> I

[PATCH] D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL

2022-06-02 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. ok, so the reason you are adding this to clang is that it needs to be mapped into a target intrinsic? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126857/new/ https://reviews.llvm.org/D126857 __

[PATCH] D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL

2022-06-02 Thread Xiang Li via Phabricator via cfe-commits
python3kgae added a comment. In D126857#3554070 , @Anastasia wrote: > ok, so the reason you are adding this to clang is that it needs to be mapped > into a target intrinsic? Yes. The plan is to create a target intrinsic for WaveActiveCountBits which map

[PATCH] D125919: Drop qualifiers from return types in C (DR423)

2022-06-02 Thread Dan Liew via Phabricator via cfe-commits
delcypher added a comment. @aaron.ballman Hey I just saw this change and had questions about it. For others looking I think the resolution to DR423 is in https://www.open-std.org/jtc1/sc22/wg14/www/docs/n1863.pdf, I found https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2148.htm#dr_423 hard to

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

2022-06-02 Thread Christopher Di Bella via Phabricator via cfe-commits
cjdb updated this revision to Diff 433823. cjdb added a comment. Herald added subscribers: sstefan1, mgrang, aheejin. Herald added a reviewer: jdoerfert. - renames flag to `-print-diagnostic-options` - adds test - adds logic to get as many options to be visible as possible I'm very unhappy with t

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

2022-06-02 Thread Christopher Di Bella via Phabricator via cfe-commits
cjdb added a comment. Okay, I understand why `-W` isn't being printed now, but the missing ones are still a bit baffling. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126796/new/ https://reviews.llvm.org/D126796 ___ cfe-commits mailing list

[PATCH] D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL

2022-06-02 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:1697 +// HLSL +LANGBUILTIN(WaveActiveCountBits, "Uib", "nc", HLSL_LANG) + FYI we most of time try to add a builtin name using a reserved identifier which is not part of the langu

[PATCH] D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC)

2022-06-02 Thread Richard via Phabricator via cfe-commits
LegalizeAdulthood added a comment. In D126495#3553183 , @LegalizeAdulthood wrote: > In D126495#3552887 , @njames93 > wrote: > >> Can I ask what the motivation is for this change? > > https://discourse.llvm.org/t

[PATCH] D126839: [clang][BPF] Update comment to include TYPE_MATCH

2022-06-02 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song added a comment. LGTM. But add the reference (https://reviews.llvm.org/D126838) to the commit message to indicate which 'earlier change'. Also let us merge it unti kernel side change is in reasonable shape. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

2022-06-02 Thread Erich Keane via Phabricator via cfe-commits
erichkeane created this revision. erichkeane added reviewers: ChuanqiXu, clang-language-wg. Herald added a subscriber: martong. Herald added a reviewer: shafik. Herald added a reviewer: dang. Herald added a project: All. erichkeane requested review of this revision. This is a continuation of D1195

[PATCH] D112916: Confusable identifiers detection

2022-06-02 Thread Mark de Wever via Phabricator via cfe-commits
Mordante added a comment. Herald added a project: All. In D112916#3113140 , @tstellar wrote: > The LLVM Board of Directors will do a legal review of this change. We will > give an update in 4-6 weeks. @tstellar, is there an update from the LLVM Board o

[PATCH] D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL

2022-06-02 Thread Xiang Li via Phabricator via cfe-commits
python3kgae updated this revision to Diff 433835. python3kgae marked 2 inline comments as done. python3kgae added a comment. Change to verify test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126857/new/ https://reviews.llvm.org/D126857 Files:

[PATCH] D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL

2022-06-02 Thread Xiang Li via Phabricator via cfe-commits
python3kgae added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:1697 +// HLSL +LANGBUILTIN(WaveActiveCountBits, "Uib", "nc", HLSL_LANG) + Anastasia wrote: > FYI we most of time try to add a builtin name using a reserved identifier > which i

[PATCH] D112916: Confusable identifiers detection

2022-06-02 Thread Tom Stellard via Phabricator via cfe-commits
tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. In D112916#3554158 , @Mordante wrote: > In D112916#3113140 , @tstellar > wrote: > >> The LLVM Board of D

[PATCH] D126172: [clang] Fix comparison of TemplateArgument when they are of template kind

2022-06-02 Thread Robert Esclapez via Phabricator via cfe-commits
roberteg16 added a comment. Thanks @mizvekov for such an insightful review. I'll try to address ASAP everything you said and let you know the results. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126172/new/ https://reviews.llvm.org/D126172

[PATCH] D112916: Confusable identifiers detection

2022-06-02 Thread Mark de Wever via Phabricator via cfe-commits
Mordante added a comment. Thanks for the update! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112916/new/ https://reviews.llvm.org/D112916 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D126862: [clang] [MSVC] Enable unwind tables for ARM

2022-06-02 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo updated this revision to Diff 433836. mstorsjo added a comment. Added testing, including testing for the existing architectures. There was a good match for testing for this in windows-exceptions.cpp - unfortunately it ends up with 2 more RUN lines, but it fits in so well there so I'd r

[PATCH] D125919: Drop qualifiers from return types in C (DR423)

2022-06-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D125919#3554078 , @delcypher wrote: > @aaron.ballman Hey I just saw this change and had questions about it. For > others looking I think the resolution to DR423 is in > https://www.open-std.org/jtc1/sc22/wg14/www/docs/n

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

2022-06-02 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:2651 +Expr *DefaultArgumentY = NTTPY->getDefaultArgument()->IgnoreImpCasts(); +ODRHash X, Y; +X.AddStmt(DefaultArgumentX); ODR hashing is intended to produce a hash that's stabl

[PATCH] D125919: Drop qualifiers from return types in C (DR423)

2022-06-02 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D125919#3554078 , @delcypher wrote: > @aaron.ballman Hey I just saw this change and had questions about it. For > others looking I think the resolution to DR423 is in > https://www.open-std.org/jtc1/sc22/wg14/www/docs/n1863.

[clang] bb7835e - [PS5] Apply 'packed' attribute to base classes, matching PS4 ABI

2022-06-02 Thread Paul Robinson via cfe-commits
Author: Paul Robinson Date: 2022-06-02T12:26:26-07:00 New Revision: bb7835e2a7fbb12d711736862e75497c83a45be2 URL: https://github.com/llvm/llvm-project/commit/bb7835e2a7fbb12d711736862e75497c83a45be2 DIFF: https://github.com/llvm/llvm-project/commit/bb7835e2a7fbb12d711736862e75497c83a45be2.diff

[clang] 30b7ffe - [PS5] Pack non-POD members in packed structs, matching PS4 ABI

2022-06-02 Thread Paul Robinson via cfe-commits
Author: Paul Robinson Date: 2022-06-02T12:26:26-07:00 New Revision: 30b7ffe74e66aa0c33c689429c593f261c2c9d13 URL: https://github.com/llvm/llvm-project/commit/30b7ffe74e66aa0c33c689429c593f261c2c9d13 DIFF: https://github.com/llvm/llvm-project/commit/30b7ffe74e66aa0c33c689429c593f261c2c9d13.diff

[PATCH] D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL

2022-06-02 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:1697 +// HLSL +LANGBUILTIN(WaveActiveCountBits, "Uib", "nc", HLSL_LANG) + python3kgae wrote: > Anastasia wrote: > > FYI we most of time try to add a builtin name using a reserved

[PATCH] D125919: Drop qualifiers from return types in C (DR423)

2022-06-02 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D125919#3554195 , @aaron.ballman wrote: > However, I reverted the changes in this patch in > c745f2ce6c03bc6d1e59cac69cc15923d4400191 > as I > don't thi

[PATCH] D126862: [clang] [MSVC] Enable unwind tables for ARM

2022-06-02 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126862/new/ https://reviews.llvm.org/D126862 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D126862: [clang] [MSVC] Enable unwind tables for ARM

2022-06-02 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. (I still think it helps to drop some RUN lines from pic.c but that change can be separate.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126862/new/ https://reviews.llvm.org/D126862 __

[PATCH] D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL

2022-06-02 Thread Xiang Li via Phabricator via cfe-commits
python3kgae updated this revision to Diff 433841. python3kgae added a comment. Simplify test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126857/new/ https://reviews.llvm.org/D126857 Files: clang/include/clang/Basic/Builtins.def clang/includ

[PATCH] D126908: [VerifyDiagnosticConsumer] Fix last line being discarded when parsing newline

2022-06-02 Thread Vang Thao via Phabricator via cfe-commits
vangthao created this revision. Herald added a project: All. vangthao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In expected diagnostic checks containing newlines, anything after the last newline would be discarded since we stop parsin

[PATCH] D126781: [CodeGen] Correctly handle weak symbols in the codegen

2022-06-02 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. You haven't really described the issue you're having. The code looks like it's maintaining a map from symbol names to the `GlobalDecl` from which it'll be emitted; can you explain what Cling wants this for? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL

2022-06-02 Thread Xiang Li via Phabricator via cfe-commits
python3kgae marked 2 inline comments as done. python3kgae added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:1697 +// HLSL +LANGBUILTIN(WaveActiveCountBits, "Uib", "nc", HLSL_LANG) + Anastasia wrote: > python3kgae wrote: > > Anastasia wrote

[PATCH] D125919: Drop qualifiers from return types in C (DR423)

2022-06-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D125919#3554233 , @rjmccall wrote: > In D125919#3554195 , @aaron.ballman > wrote: > >> However, I reverted the changes in this patch in >> c745f2ce6c03bc6d1e59cac69cc15923d44001

[PATCH] D126341: Order implicitly instantiated global variable's initializer by the reverse instantiation order

2022-06-02 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. Well, I guess we're out of luck, but that seems like a very poorly considered requirement from the standard. If we can't use comdats for inline variables, every time you include a header with a dynamically initialized variable, it will generate extra initialization code in

[PATCH] D125919: Drop qualifiers from return types in C (DR423)

2022-06-02 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Ah, yeah, that seems unrelated (and surprising). You think we're *not* supposed to drop `_Atomic` in a return type per C2x? That seems surprising; I thought it was generally treated as a qualifier and would expect that we'd be supposed to drop it. Repository: rG L

[PATCH] D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL

2022-06-02 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126857/new/ https://reviews.llvm.org/D126857 _

[PATCH] D125919: Drop qualifiers from return types in C (DR423)

2022-06-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D125919#3554310 , @rjmccall wrote: > Ah, yeah, that seems unrelated (and surprising). > > You think we're *not* supposed to drop `_Atomic` in a return type per C2x? > That seems surprising; I thought it was generally tr

[clang] 6bea9ff - [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL

2022-06-02 Thread Xiang Li via cfe-commits
Author: Xiang Li Date: 2022-06-02T13:06:01-07:00 New Revision: 6bea9ff91378571b3bedcdc12fac7bb916371871 URL: https://github.com/llvm/llvm-project/commit/6bea9ff91378571b3bedcdc12fac7bb916371871 DIFF: https://github.com/llvm/llvm-project/commit/6bea9ff91378571b3bedcdc12fac7bb916371871.diff LOG:

[PATCH] D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL

2022-06-02 Thread Xiang Li via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. python3kgae marked an inline comment as done. Closed by commit rG6bea9ff91378: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL (authored by python

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

2022-06-02 Thread Guillaume Chatelet via Phabricator via cfe-commits
gchatelet updated this revision to Diff 433858. gchatelet added a comment. - remove unused variable and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126903/new/ https://reviews.llvm.org/D126903 Files: clang/docs/LanguageExtensions.rst

[PATCH] D126839: [clang][BPF] Update comment to include TYPE_MATCH

2022-06-02 Thread Daniel Müller via Phabricator via cfe-commits
d-e-s-o added a comment. In D126839#3554125 , @yonghong-song wrote: > LGTM. But add the reference (https://reviews.llvm.org/D126838) to the commit > message to indicate which 'earlier change'. Also let us merge it unti kernel > side change is in reason

[PATCH] D126839: [clang][BPF] Update comment to include TYPE_MATCH

2022-06-02 Thread Daniel Müller via Phabricator via cfe-commits
d-e-s-o added a comment. In D126839#3554125 , @yonghong-song wrote: > Also let us merge it unti kernel side change is in reasonable shape. From what I understand it may take several days or some other not-precisely specified time until "nightly" builds

[PATCH] D113107: Support of expression granularity for _Float16.

2022-06-02 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Hmm. I'm sorry, seeing the impact of this, I think it's not great to have this `PromotionTy` field; it's too hard to get the invariants right. Let's do this instead: 1. Add an `EmitPromoted` method to `ScalarExprEmitter`. The general rule for this method is that it

[PATCH] D125847: LTO: Add option to initialize with opaque/non-opaque pointer types

2022-06-02 Thread Jake Egan via Phabricator via cfe-commits
Jake-Egan added a comment. Hi, this caused `arm-float-abi-lto.c` to fail on AIX. The failure went away for a few builds, then came back. Could you take a look? https://lab.llvm.org/buildbot/#/builders/214/builds/1625/steps/6/logs/FAIL__Clang__arm-float-abi-lto_c Repository: rG LLVM Github Mo

[PATCH] D126839: [clang][BPF] Update comment to include TYPE_MATCH

2022-06-02 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song added a comment. In D126839#3554474 , @d-e-s-o wrote: > In D126839#3554125 , @yonghong-song > wrote: > >> Also let us merge it unti kernel side change is in reasonable shape. > > From what I underst

[clang] cb08f4a - Support warn_unused_result on typedefs

2022-06-02 Thread David Blaikie via cfe-commits
Author: David Blaikie Date: 2022-06-02T20:57:31Z New Revision: cb08f4aa4467cf562b62e542725f5351c5482495 URL: https://github.com/llvm/llvm-project/commit/cb08f4aa4467cf562b62e542725f5351c5482495 DIFF: https://github.com/llvm/llvm-project/commit/cb08f4aa4467cf562b62e542725f5351c5482495.diff LOG:

[PATCH] D102122: Support warn_unused_result on typedefs

2022-06-02 Thread David Blaikie via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. dblaikie marked an inline comment as done. Closed by commit rGcb08f4aa4467: Support warn_unused_result on typedefs (authored by dblaikie). Changed prior to commit: h

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

2022-06-02 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: clang/lib/CodeGen/CGBuilder.h:53 + : CGBuilderBaseTy(C), TypeCache(TypeCache) {} + CGBuilderTy(const CodeGenTypeCache &TypeCache, llvm::LLVMContext &C, + const llvm::ConstantFolder &F, There are a lot o

[PATCH] D119296: KCFI sanitizer

2022-06-02 Thread Joao Moreira via Phabricator via cfe-commits
joaomoreira added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.h:83 +KCFI_NT_CALL, +KCFI_TC_RETURN, + I did not revise the entire patch yet. With this said, IMHO, this looks like an overcomplication of a simple problem. Is there a rea

[PATCH] D125919: Drop qualifiers from return types in C (DR423)

2022-06-02 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Ah, true, the standard doesn't describe it as a normal qualifier. From the DR, it sounds like the committee certainly expected that this reasoning would also apply to `_Atomic`, even if that's not quite what they've written, but that the DR submitter seems to not want

[PATCH] D126818: Itanium ABI: Implement mangling for constrained friends

2022-06-02 Thread Tom Honermann via Phabricator via cfe-commits
tahonermann added a comment. I wonder if I'm reading (temp.friend)p9` sentence 2 correctly. Which of these should it be parsed as? 1. A (friend function template with a constraint) that depends on a template parameter from an enclosing template

[PATCH] D126396: Clean "./" from __FILE__ expansion.

2022-06-02 Thread Paul Pluzhnikov via Phabricator via cfe-commits
ppluzhnikov created this revision. Herald added a project: All. ppluzhnikov updated this revision to Diff 432064. ppluzhnikov added a comment. Herald added a subscriber: hiraditya. ppluzhnikov updated this revision to Diff 433837. ppluzhnikov published this revision for review. Herald added a proje

[PATCH] D119296: KCFI sanitizer

2022-06-02 Thread Sami Tolvanen via Phabricator via cfe-commits
samitolvanen added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.h:83 +KCFI_NT_CALL, +KCFI_TC_RETURN, + joaomoreira wrote: > I did not revise the entire patch yet. With this said, IMHO, this looks like > an overcomplication of a simple

[PATCH] D126839: [clang][BPF] Update comment to include TYPE_MATCH

2022-06-02 Thread Daniel Müller via Phabricator via cfe-commits
d-e-s-o added a comment. In D126839#3554474 , @d-e-s-o wrote: > In D126839#3554125 , @yonghong-song > wrote: > >> Also let us merge it unti kernel side change is in reasonable shape. > > From what I understand it

[PATCH] D126839: [clang][BPF] Update comment to include TYPE_MATCH

2022-06-02 Thread Daniel Müller via Phabricator via cfe-commits
d-e-s-o added a comment. In D126839#3554570 , @yonghong-song wrote: > In D126839#3554474 , @d-e-s-o wrote: > >> In D126839#3554125 , >> @yonghong-song wrote: >> >>> Also

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

2022-06-02 Thread Mitch Phillips via Phabricator via cfe-commits
hctim updated this revision to Diff 433889. hctim marked an inline comment as done. hctim added a comment. Add round-trip tests, fork out the clang and langref changes for further commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126100/new/

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

2022-06-02 Thread Mitch Phillips via Phabricator via cfe-commits
hctim added a comment. Also, the bitset now doesn't have positive-inclusions for ASan/HWASan, and no mention of MTE yet (which will come later). Sanitizers are applied to all GVs implicitly, so we only need to carry around the exclude masks. Added a comment to the struct that clarifies this.

[PATCH] D126689: [IR] Enable opaque pointers by default

2022-06-02 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl added a comment. I was able to update LLDB https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/44252/. We can leave this in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126689/new/ https://reviews.llvm.org/D126689 ___

[PATCH] D126396: Clean "./" from __FILE__ expansion.

2022-06-02 Thread Paul Pluzhnikov via Phabricator via cfe-commits
ppluzhnikov added a comment. Alan, Thanks for the approval. Could you push this patch -- I don't have commit rights. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126396/new/ https://reviews.llvm.org/D126396 __

[PATCH] D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace

2022-06-02 Thread Ivan Murashko via Phabricator via cfe-commits
ivanmurashko accepted this revision. ivanmurashko added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101471/new/ https://reviews.llvm.org/D101471 ___ cfe-commits mailing list cfe-commits

[PATCH] D125847: LTO: Add option to initialize with opaque/non-opaque pointer types

2022-06-02 Thread Matthias Braun via Phabricator via cfe-commits
MatzeB added a comment. In D125847#3554569 , @Jake-Egan wrote: > Hi, this caused `arm-float-abi-lto.c` to fail on AIX. The failure went away > for a few builds, then came back. Could you take a look? > > https://lab.llvm.org/buildbot/#/builders/214/bui

[clang] aa1cdf8 - [PS5] Ignore 'packed' on one-byte bitfields, matching PS4

2022-06-02 Thread Paul Robinson via cfe-commits
Author: Paul Robinson Date: 2022-06-02T14:41:18-07:00 New Revision: aa1cdf87b5a97c2476a80f3aa6ac5af3e5ec0494 URL: https://github.com/llvm/llvm-project/commit/aa1cdf87b5a97c2476a80f3aa6ac5af3e5ec0494 DIFF: https://github.com/llvm/llvm-project/commit/aa1cdf87b5a97c2476a80f3aa6ac5af3e5ec0494.diff

[PATCH] D119296: KCFI sanitizer

2022-06-02 Thread Joao Moreira via Phabricator via cfe-commits
joaomoreira added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.h:83 +KCFI_NT_CALL, +KCFI_TC_RETURN, + samitolvanen wrote: > joaomoreira wrote: > > I did not revise the entire patch yet. With this said, IMHO, this looks > > like an ove

<    1   2   3   >