python3kgae added inline comments.
================
Comment at: clang/include/clang/Basic/Builtins.def:1697
+// HLSL
+LANGBUILTIN(WaveActiveCountBits, "Uib", "nc", HLSL_LANG)
+
----------------
Anastasia wrote:
> FYI we most of time try to add a builtin name using a reserved identifier
> which is not part of the language standard (mostly prefixed by `__`). Then we
> add regular function that just calls the clang builtins. This way provides
> more flexibility to the implementers. However you might not need this... in
> which case using original name avoids an extra call.
Yes. For this one, it is without prefix to avoid extra call.
I'm following things like enqueue_kernel in opencl.
For other things support overload which has to make extra call, I'll add the
prefix.
================
Comment at: clang/test/SemaHLSL/Wave.hlsl:7
+uint foo(bool b) {
+ return WaveActiveCountBits(b);
+}
----------------
Anastasia wrote:
> if you are planning to add a proper CodeGen test later then here it might be
> sufficient to have a `-verify` test and check that the builtin is accepted
> with the right arguments... you might want to add a test checking that a
> diagnostic is provided when the arguments are wrong... although this is not
> strictly necessary as we already test clang builtins quite extensively.
Changed to verify test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126857/new/
https://reviews.llvm.org/D126857
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
