[PATCH] D126781: [CodeGen] Correctly handle weak symbols in the codegen

junaire updated this revision to Diff 433624. junaire added a comment. Forget to use helpers again... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/l

[PATCH] D124748: [clang-format] Fix whitespace counting stuff

sstwcw updated this revision to Diff 433626. sstwcw added a comment. - add comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124748/new/ https://reviews.llvm.org/D124748 Files: clang/lib/Format/FormatTokenLexer.cpp clang/lib/Format/FormatT

[PATCH] D125624: [gold] Remove an external dependency to GNU binutils' header file

ruiu added a comment. The motivation of doing this is to be able to build LLVMgold.so without binutils' source files and make it clear that LLVMgold.so does not include any GPL code. The header file defines the public interface between linker plugins and compilers (and other tools such as `ar`

[PATCH] D125624: [gold] Remove an external dependency to GNU binutils' header file

tstellar added a comment. In D125624#3552238 , @ruiu wrote: > The motivation of doing this is to be able to build LLVMgold.so without > binutils' source files and make it clear that LLVMgold.so does not include > any GPL code. OK, as I mentioned. I th

[clang] 4463bd0 - unbreak Modules/cxx20-export-import.cpp with LLVM_APPEND_VC_REV after 8c8a2679a20f

Author: Nico Weber Date: 2022-06-01T22:33:36-04:00 New Revision: 4463bd0f89181234e0cef982e21de2e96038f873 URL: https://github.com/llvm/llvm-project/commit/4463bd0f89181234e0cef982e21de2e96038f873 DIFF: https://github.com/llvm/llvm-project/commit/4463bd0f89181234e0cef982e21de2e96038f873.diff LO

[PATCH] D125624: [gold] Remove an external dependency to GNU binutils' header file

ruiu added a comment. > So what happens if LLVMgold.so uses one of the new structs or constants and > then is built and run on system where binutils is old enough to not have > these new structs and constants? The same thing can happen with GCC and binutils. Imagine that you install a newer

[PATCH] D125323: [RISCV] Add the passthru operand for RVV unmasked segment load IR intrinsics.

pcwang-thead added a comment. In D125323#3550307 , @khchen wrote: > In D125323#3549794 , @pcwang-thead > wrote: > >> Is there an easy way to update tests? Or we need to add passthru operands >> manually? I will

[libunwind] 13b8bfc - [libunwind] Add more information to eh_frame_hdr version error

Author: Florian Mayer Date: 2022-06-01T19:48:19-07:00 New Revision: 13b8bfc51451fcfc00f3e3480abaf64b337a43d4 URL: https://github.com/llvm/llvm-project/commit/13b8bfc51451fcfc00f3e3480abaf64b337a43d4 DIFF: https://github.com/llvm/llvm-project/commit/13b8bfc51451fcfc00f3e3480abaf64b337a43d4.diff

[PATCH] D125624: [gold] Remove an external dependency to GNU binutils' header file

khchen added a comment. IMO, maybe we could keep the DLLVM_BINUTILS_INCDIR option support but default is using the Plugin.h? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125624/new/ https://reviews.llvm.org/D125624 __

[PATCH] D125624: [gold] Remove an external dependency to GNU binutils' header file

ruiu added a comment. In D125624#3552284 , @khchen wrote: > IMO, maybe we could keep the DLLVM_BINUTILS_INCDIR option support but default > is using the Plugin.h? We can, but I wonder what is the motivation of doing it. Repository: rG LLVM Github Mo

[PATCH] D125847: LTO: Add option to initialize with opaque/non-opaque pointer types

MaskRay added a comment. Your commit message seems to use the original summary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125847/new/ https://reviews.llvm.org/D125847 ___ cfe-commits mailing list cfe

[PATCH] D125622: [clang-tidy] Reject invalid enum initializers in C files

LegalizeAdulthood marked 2 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-macro-to-enum.c:3-7 +// C requires enum values to fit into an int. +#define TOO_BIG1 1L +#define TOO_BIG2 1UL +#define TO

[PATCH] D125622: [clang-tidy] Reject invalid enum initializers in C files

LegalizeAdulthood updated this revision to Diff 433648. LegalizeAdulthood added a comment. Update from review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125622/new/ https://reviews.llvm.org/D125622 Files: clang-tools-extra/clang-tidy/modernize/IntegralLiteralExpressionMat

[PATCH] D126853: [clang-tidy] `bugprone-use-after-move`: Don't warn on self-moves.

mboehme created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.

[clang-tools-extra] b418ef5 - [clang-tidy] Reject invalid enum initializers in C files

Author: Richard Date: 2022-06-01T22:25:39-06:00 New Revision: b418ef5cb90b32657dee46b068ac367787a8d2d6 URL: https://github.com/llvm/llvm-project/commit/b418ef5cb90b32657dee46b068ac367787a8d2d6 DIFF: https://github.com/llvm/llvm-project/commit/b418ef5cb90b32657dee46b068ac367787a8d2d6.diff LOG:

[PATCH] D125622: [clang-tidy] Reject invalid enum initializers in C files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb418ef5cb90b: [clang-tidy] Reject invalid enum initializers in C files (authored by LegalizeAdulthood). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

shchenz added a comment. Thanks for doing this. I am not familiar with the frontend, so I may be wrong/stupid in the follow comments : ) Hope other experts like @hubert.reinterpretcast can give more meaningful comments. I tested on AIX, seems for static variable `static int x = foo();` in globa

[PATCH] D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC)

LegalizeAdulthood added a comment. I know this is a rather huge diff, but the part that needs to be reviewed is the python script changes. I've rebuilt the HTML docs with sphinx and tested all the manually modified links to verify that they still go to the correct page. The existing Release No

[PATCH] D125624: [gold] Remove an external dependency to GNU binutils' header file

ruiu added a comment. > OK, as I mentioned. I think we need an attorney to review this change and > confirm that it actually accomplishes this goal. Can you add an attorney as a reviewer of this change so that we can proceed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

tbaeder added a comment. Ping. @MaskRay Can you take a quick look and check if this is what you had in mind? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125862/new/ https://reviews.llvm.org/D125862 ___ cfe-commits mailing list cfe-commits@

[PATCH] D126198: [analyzer][NFCi] Annotate major nonnull returning functions

uabelho added a comment. @steakhal : Thanks for the quick fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126198/new/ https://reviews.llvm.org/D126198 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D126855: [clang-tidy] check_clang_tidy.py: Print output nicely in Python 3.

mboehme created this revision. Herald added a subscriber: xazax.hun. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. In Python 3, `encode()` produces a `bytes`. The way this is printed makes

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

MaskRay added a comment. In D125862#3552465 , @tbaeder wrote: > Ping. @MaskRay Can you take a quick look and check if this is what you had in > mind? LG Comment at: clang/unittests/Driver/ToolChainTest.cpp:615 +TEST(ToolChainTest, To

[PATCH] D125875: [RISCV] Add vread_csr and vwrite_csr to riscv_vector.h

pcwang-thead added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125875/new/ https://reviews.llvm.org/D125875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D126781: [CodeGen] Correctly handle weak symbols in the codegen

junaire updated this revision to Diff 433659. junaire added a comment. Fix the unittest failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/lib/Cod

[PATCH] D125052: [HLSL] Enable vector types for hlsl.

rastogishubham added a comment. Hi, this patch causes an issue with the CMake Xcode build configuration, if I try to use xcode as the generator with CMake, using the build command: xcrun cmake -G Xcode -DCMAKE_BUILD_TYPE:STRING=Debug -DLLVM_ENABLE_ASSERTIONS:BOOL=TRUE -DCMAKE_C_COMPILER=/usr/bi

<    1   2   3