[PATCH] D125318: [analyzer] Add UnarySymExpr

martong updated this revision to Diff 429152. martong marked an inline comment as done. martong added a comment. - Add type parameter to evalMinus and evalComplement - Correct dumpToStream in case of binary sub expressions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D125162: [clang-format] fix alignment w/o binpacked args

cha5on added a comment. In D125162#3510737 , @curdeius wrote: > LGTM. Tell us if you need help landing this. I don't have commit access, so some help would be great :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D123685: [clang][ASTImporter] Add isNewDecl

martong marked 4 inline comments as done. martong added inline comments. Comment at: clang/include/clang/AST/ASTImporterSharedState.h:83 + + void setNewDecl(Decl *ToD) { NewDecls.insert(ToD); } }; `markAsNewDecl` sounds better, I'll update before commit. Repo

[clang] 094fb13 - [analyzer] Add taint to the BoolAssignmentChecker

Author: Endre Fülöp Date: 2022-05-13T09:27:28+02:00 New Revision: 094fb13b88b36ecfa475cb877d2c6e9d90b4d1a5 URL: https://github.com/llvm/llvm-project/commit/094fb13b88b36ecfa475cb877d2c6e9d90b4d1a5 DIFF: https://github.com/llvm/llvm-project/commit/094fb13b88b36ecfa475cb877d2c6e9d90b4d1a5.diff L

[PATCH] D125360: [analyzer] Add taint to the BoolAssignmentChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rG094fb13b88b3: [analyzer] Add taint to the BoolAssignmentChecker (authored by gamesh411). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125360/new/ https://r

[PATCH] D124038: [clang] Prevent folding of non-const compound expr

serge-sans-paille updated this revision to Diff 429156. serge-sans-paille added a comment. Update messed up format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124038/new/ https://reviews.llvm.org/D124038 Files: clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX/constant-expression

[PATCH] D122734: [CUDA][HIP] Fix mangling number for local struct

uabelho added a comment. In D122734#3509187 , @yaxunl wrote: > In D122734#3509096 , @yaxunl wrote: > >> In D122734#3508294 , @uabelho >> wrote: >> >>> Hi, >>> >>> I notic

[PATCH] D125524: [BoundV2] ArrayBoundV2 checks if the extent is tainted

gamesh411 created this revision. gamesh411 added a reviewer: steakhal. Herald added subscribers: martong, Szelethus, dkrupp. Herald added a reviewer: Szelethus. Herald added a project: All. gamesh411 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-co

[libunwind] f6366ef - [libunwind][AArch64] Add support for DWARF expression for RA_SIGN_STATE.

Author: Daniel Kiss Date: 2022-05-13T10:05:59+02:00 New Revision: f6366ef7f4f3cf1182fd70e0c50a9fa54374b612 URL: https://github.com/llvm/llvm-project/commit/f6366ef7f4f3cf1182fd70e0c50a9fa54374b612 DIFF: https://github.com/llvm/llvm-project/commit/f6366ef7f4f3cf1182fd70e0c50a9fa54374b612.diff L

[PATCH] D125524: [BoundV2] ArrayBoundV2 checks if the extent is tainted

gamesh411 updated this revision to Diff 429159. gamesh411 added a comment. add analyzer tag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125524/new/ https://reviews.llvm.org/D125524 Files: clang/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.c

[PATCH] D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Thanks. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119720/new/ https://reviews.llvm.org/D119720 _

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

ken-matsui added a comment. @aaron.ballman I prepared a new public email address: `g...@kmatsui.me` instead of the auto-generated one. So, could you please use the new one for future commit? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124726/new

[PATCH] D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum

simon_tatham accepted this revision. simon_tatham added a comment. Thanks, that explanation looks fine. (And I agree that re-paragraphing it made more sense than my version) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119720/new/ https://reviews

[PATCH] D125383: [ASTMatchers][clang-tidy][NFC] Hoist 'forEachTemplateArgument' matcher into the core library

whisperity updated this revision to Diff 429161. whisperity added a comment. - Added to `ASTMatchers/Registry.cpp` - Updated with release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125383/new/ https://reviews.llvm.org/D125383 Files: clang-tools-extra/clang-tidy/misc/UnusedUs

[PATCH] D125383: [ASTMatchers][clang-tidy][NFC] Hoist 'forEachTemplateArgument' matcher into the core library

whisperity added a comment. In D125383#3509084 , @aaron.ballman wrote: > Then I think the only thing missing here are updates to > https://github.com/llvm/llvm-project/blob/main/clang/lib/ASTMatchers/Dynamic/Registry.cpp. Could you please check if I di

[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

porglezomp added a comment. That looks good to me. I'm testing it out locally to make sure it still works right and also catches the issue, and will plan put up an updated patch in the morning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124974/

[PATCH] D124715: Add ThreadPriority::Low, and use QoS class Utility on Mac

stefanhaller added a comment. In D124715#3498846 , @sammccall wrote: > Looks great! I'm happy to land it, will do so on Tuesday unless anyone has > further comments. @sammccall Just a friendly ping, in case you forgot. 😄 Repository: rG LLVM Github M

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

ken-matsui added a comment. @aaron.ballman I prepared a new public email address: `v...@kmatsui.me` instead of the auto-generated one. So, could you please use the new one for future commit? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124726/new

[PATCH] D125526: Fix ADL leakage due to MSVC compatibility flag

frederic-tingaud-sonarsource created this revision. frederic-tingaud-sonarsource added a reviewer: rnk. Herald added a project: All. frederic-tingaud-sonarsource requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Patch https://reviews.llvm.org

[PATCH] D124613: In MSVC compatibility mode, friend function declarations behave as function declarations

frederic-tingaud-sonarsource added a comment. Sorry for the delay, the fix is here: https://reviews.llvm.org/D125526 If there is any risk or problem identified with this new fix that could delay it, I'll propose a revert of this one to avoid breaking more legitimate code. Repository: rG LLVM

[PATCH] D125323: [RISCV] Add the passthru operand for RVV unmasked segment load IR intrinsics.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7dfc56c10746: [RISCV] Add the passthru operand for RVV unmasked segment load IR intrinsics. (authored by khchen). Changed prior to commit: https:/

[PATCH] D123773: [clang][analyzer][ctu] Make CTU a two phase analysis

martong marked 15 inline comments as done. martong added inline comments. Comment at: clang/include/clang/AST/ASTImporterSharedState.h:83 + + void setNewDecl(Decl *ToD) { NewDecls.insert(ToD); } }; whisperity wrote: > (The naming of this function feels a bit od

[PATCH] D123773: [clang][analyzer][ctu] Make CTU a two phase analysis

martong updated this revision to Diff 429172. martong marked 7 inline comments as done. martong added a comment. - Change -mul to -pct - Change default values to ctu-max-nodes-pct = 50 and ctu-max-nodes-min = 1 - Rename isCTUInFirtstPhase to isSecondPhaseCTU and invert the condition - Check th

[PATCH] D122747: [NFC][ARM] Tests for Cortex-A57 and Cortex-A72 Fused AES Erratum

lenary added a comment. I spent some time last night trying to work out if a combination of `--enable-misched=false --pre-RA-sched=linearize -disable-post-ra -enable-post-misched=false` would help avoid having two sets of match lines, and none seemed to. @MaskRay as I can't find a quick way of

[PATCH] D125526: Fix ADL leakage due to MSVC compatibility flag

frederic-tingaud-sonarsource abandoned this revision. frederic-tingaud-sonarsource added a comment. After checking, I realize that the previous fix was really mimicking MSVC behavior up to its mishandling of standard compliant code. https://godbolt.org/z/cEPGfMz3f I'll revert it for now and try t

[PATCH] D125517: [Frontend] [Coroutines] Emit error when we found incompatible allocation function in promise_type

ChuanqiXu updated this revision to Diff 429176. ChuanqiXu added a comment. Remove invalid character CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125517/new/ https://reviews.llvm.org/D125517 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticSemaKinds.td clang

[PATCH] D125528: [clang-format] Fix PointerAlignment: Right not working with tab indentation.

curdeius created this revision. curdeius added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added a project: All. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/5

[PATCH] D125529: Revert MSVC compatibility feature that breaks conformant code

frederic-tingaud-sonarsource created this revision. frederic-tingaud-sonarsource added reviewers: rnk, thakis. Herald added a reviewer: shafik. Herald added a project: All. frederic-tingaud-sonarsource requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-

[clang] 3a24df9 - [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum

Author: Archibald Elliott Date: 2022-05-13T10:47:33+01:00 New Revision: 3a24df992cf87029ed89c5a4a6be4049b73ff3ab URL: https://github.com/llvm/llvm-project/commit/3a24df992cf87029ed89c5a4a6be4049b73ff3ab DIFF: https://github.com/llvm/llvm-project/commit/3a24df992cf87029ed89c5a4a6be4049b73ff3ab.d

[PATCH] D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3a24df992cf8: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum (authored by lenary). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D124613: In MSVC compatibility mode, friend function declarations behave as function declarations

frederic-tingaud-sonarsource added a comment. I realized that this current patch did in fact mimic MSVC behavior up to its mishandling on ADL. I understand that it is not in the spirit of clang's philosophy for MSVC compatibility to have that, but the fixed version I was about to propose would

[PATCH] D124730: [RISCV][NFC] Refactor RISC-V vector intrinsic utils.

kito-cheng updated this revision to Diff 429184. kito-cheng marked 3 inline comments as done. kito-cheng added a comment. Changes: - Address @khchen's comment. - Use new hash scheme for cache the result of computeType. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D124730: [RISCV][NFC] Refactor RISC-V vector intrinsic utils.

kito-cheng added inline comments. Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:55 +// basic vector type, used to compute type info of arguments. +enum class PrimitiveType : uint8_t { + Invalid, khchen wrote: > I think vector is not a primitive

[PATCH] D125532: [analyzer] Introduce clang_analyzer_dumpSvalType introspection function

steakhal created this revision. steakhal added a reviewer: martong. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: All. steakhal

[PATCH] D125318: [analyzer] Add UnarySymExpr

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:107 +return makeNonLoc(X.castAs().getSymbol(), UO_Not, + X.getType(Context)); default: martong wrote: > steakhal wrote: > > I'm not sure if

[PATCH] D125383: [ASTMatchers][clang-tidy][NFC] Hoist 'forEachTemplateArgument' matcher into the core library

aaron.ballman added a comment. In D125383#3510906 , @whisperity wrote: > In D125383#3509084 , @aaron.ballman > wrote: > >> Then I think the only thing missing here are updates to >> https://github.com/llvm/llvm

[clang-tools-extra] 9add949 - [ASTMatchers][clang-tidy][NFC] Hoist `forEachTemplateArgument` matcher into the core library

Author: Whisperity Date: 2022-05-13T12:55:48+02:00 New Revision: 9add949557d2cf603b8f541f0dbb83a8fa035d17 URL: https://github.com/llvm/llvm-project/commit/9add949557d2cf603b8f541f0dbb83a8fa035d17 DIFF: https://github.com/llvm/llvm-project/commit/9add949557d2cf603b8f541f0dbb83a8fa035d17.diff LO

[PATCH] D125383: [ASTMatchers][clang-tidy][NFC] Hoist 'forEachTemplateArgument' matcher into the core library

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9add949557d2: [ASTMatchers][clang-tidy][NFC] Hoist `forEachTemplateArgument` matcher into the… (authored by whisperity). Changed prior to commit:

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

aaron.ballman added a comment. In D122895#3510165 , @dexonsmith wrote: > For additional context to my questions above, even though open source clang > hasn't been using `-Wstrict-prototypes`, Xcode has had it on-by-default in > new projects since somet

[PATCH] D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Headers.cpp:134 + return false; +return inMainFile() ? handleCommentInMainFile(PP, Range) +: handleCommentInHeaderFile(PP, Range); the split seems to be increasi

[clang] 99d3582 - Comment parsing: Specify argument numbers for some block commands

Author: Aaron Puchert Date: 2022-05-13T13:48:46+02:00 New Revision: 99d35826a043916b259a0e440a2aa5cabbad2773 URL: https://github.com/llvm/llvm-project/commit/99d35826a043916b259a0e440a2aa5cabbad2773 DIFF: https://github.com/llvm/llvm-project/commit/99d35826a043916b259a0e440a2aa5cabbad2773.diff

[clang] d3a4033 - Comment parsing: Allow inline commands to have 0 or more than 1 argument

Author: Aaron Puchert Date: 2022-05-13T13:48:46+02:00 New Revision: d3a4033d6ee1d017e216ff7caeeeb5ca2e18a783 URL: https://github.com/llvm/llvm-project/commit/d3a4033d6ee1d017e216ff7caeeeb5ca2e18a783 DIFF: https://github.com/llvm/llvm-project/commit/d3a4033d6ee1d017e216ff7caeeeb5ca2e18a783.diff

[clang] d2396d8 - Comment parsing: Treat properties as zero-argument inline commands

Author: Aaron Puchert Date: 2022-05-13T13:48:46+02:00 New Revision: d2396d896ee12ad20bc740174edfce2120d742b2 URL: https://github.com/llvm/llvm-project/commit/d2396d896ee12ad20bc740174edfce2120d742b2 DIFF: https://github.com/llvm/llvm-project/commit/d2396d896ee12ad20bc740174edfce2120d742b2.diff

[PATCH] D125422: Comment parsing: Specify argument numbers for some block commands

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG99d35826a043: Comment parsing: Specify argument numbers for some block commands (authored by aaronpuchert). Repository: rG LLVM Github Monorepo C

[PATCH] D125429: Comment parsing: Allow inline commands to have 0 or more than 1 argument

This revision was automatically updated to reflect the committed changes. Closed by commit rGd3a4033d6ee1: Comment parsing: Allow inline commands to have 0 or more than 1 argument (authored by aaronpuchert). Changed prior to commit: https://reviews.llvm.org/D125429?vs=428968&id=429203#toc Repo

[PATCH] D125473: Comment parsing: Treat properties as zero-argument inline commands

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd2396d896ee1: Comment parsing: Treat properties as zero-argument inline commands (authored by aaronpuchert). Repository: rG LLVM Github Monorepo

[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

balazske updated this revision to Diff 429205. balazske marked 8 inline comments as done. balazske added a comment. Using one isa statement for all class names. Changed the documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118996/new/ ht

[PATCH] D125318: [analyzer] Add UnarySymExpr

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:107 +return makeNonLoc(X.castAs().getSymbol(), UO_Not, + X.getType(Context)); default: steakhal wrote: > martong wrote: > > steakhal wrote:

[PATCH] D125318: [analyzer] Add UnarySymExpr

martong updated this revision to Diff 429207. martong added a comment. - Revert "Add type parameter to evalMinus and evalComplement" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125318/new/ https://reviews.llvm.org/D125318 Files: clang/include/

[PATCH] D125395: [analyzer][solver] Handle UnarySymExpr in RangeConstraintSolver

martong updated this revision to Diff 429208. martong added a comment. - Add a test case for casts related crash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125395/new/ https://reviews.llvm.org/D125395 Files: clang/lib/StaticAnalyzer/Core/Rang

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

ldionne accepted this revision as: libc++. ldionne marked an inline comment as done. ldionne added inline comments. This revision is now accepted and ready to land. Comment at: libcxx/CMakeLists.txt:250 + +set(LIBCXX_SUPPORTED_ABI_LIBRARIES none libcxxabi system-libcxxabi libcxxr

[PATCH] D125318: [analyzer] Add UnarySymExpr

martong marked 2 inline comments as done. martong added inline comments. Comment at: clang/test/Analysis/unary-sym-expr.c:35 +return; + clang_analyzer_eval(-(x + y) == -3); // expected-warning{{TRUE}} +} steakhal wrote: > Does it work if you swap x and y? No

[clang] 4be105c - Silence some false positive -Wstrict-prototype warnings

Author: Aaron Ballman Date: 2022-05-13T08:31:52-04:00 New Revision: 4be105c98a9c7e083cd878ee1751e11160b97b4a URL: https://github.com/llvm/llvm-project/commit/4be105c98a9c7e083cd878ee1751e11160b97b4a DIFF: https://github.com/llvm/llvm-project/commit/4be105c98a9c7e083cd878ee1751e11160b97b4a.diff

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

This revision was automatically updated to reflect the committed changes. Closed by commit rGa80e65e00ada: [libc++] Overhaul how we select the ABI library (authored by ldionne). Changed prior to commit: https://reviews.llvm.org/D120727?vs=429069&id=429209#toc Repository: rG LLVM Github Monor

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

aaron.ballman added a comment. In D122895#3511312 , @aaron.ballman wrote: > However, I think the blocks behavior is a bug based on this: > https://github.com/llvm/llvm-project/blob/main/clang/lib/Sema/SemaType.cpp#L728 > and I'd be more than happy to f

[PATCH] D125532: [analyzer] Introduce clang_analyzer_dumpSvalType introspection function

martong accepted this revision. martong added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp:268 + QualType Ty = C.getSVal(Arg).getType(C.getASTContext()); + reportBug(Ty.getAsString(), C

[PATCH] D124932: [clang][dataflow] Track `optional` contents in `optional` model.

ymandel updated this revision to Diff 429210. ymandel marked 6 inline comments as done. ymandel added a comment. address reviewer comments and fix bug in how the nested value as _re_created -- now uses the loc's type rather than the expression's type (which doesn't always match exactly). CHANG

[PATCH] D125524: [BoundV2] ArrayBoundV2 checks if the extent is tainted

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp:208 if (state_exceedsUpperBound && state_withinUpperBound) { - SVal ByteOffset = rawOffset.getByteOffset(); - if (isTainted(state, ByteOffset)) { + if (isTaint

[PATCH] D124932: [clang][dataflow] Track `optional` contents in `optional` model.

ymandel updated this revision to Diff 429211. ymandel added a comment. remove stray FIXME from previous diff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124932/new/ https://reviews.llvm.org/D124932 Files: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp cl

[PATCH] D123685: [clang][ASTImporter] Add isNewDecl

martong updated this revision to Diff 429212. martong added a comment. - setNewDecl -> markAsNewDecl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123685/new/ https://reviews.llvm.org/D123685 Files: clang/include/clang/AST/ASTImporterSharedState

[PATCH] D125524: [BoundV2] ArrayBoundV2 checks if the extent is tainted

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp:208 if (state_exceedsUpperBound && state_withinUpperBound) { - SVal ByteOffset = rawOffset.getByteOffset(); - if (isTainted(state, ByteOffset)) { + if (isTain

[clang] a247ba9 - Suggest typo corrections for preprocessor directives

Author: Ken Matsui Date: 2022-05-13T09:16:46-04:00 New Revision: a247ba9d15635d96225ef39c8c150c08f492e70a URL: https://github.com/llvm/llvm-project/commit/a247ba9d15635d96225ef39c8c150c08f492e70a DIFF: https://github.com/llvm/llvm-project/commit/a247ba9d15635d96225ef39c8c150c08f492e70a.diff LO

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa247ba9d1563: Suggest typo corrections for preprocessor directives

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

aaron.ballman added a comment. LGTM, thank you for this! I adjusted the release note and commit message somewhat when landing to make sure they were detailed enough. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124726/new/ https://reviews.llvm.or

[clang] 3946de0 - [MSVC] Add support for pragma function

Author: Stephen Long Date: 2022-05-13T06:39:47-07:00 New Revision: 3946de0456fcbcd3a6c9f0d09d16d46c7987e0d7 URL: https://github.com/llvm/llvm-project/commit/3946de0456fcbcd3a6c9f0d09d16d46c7987e0d7 DIFF: https://github.com/llvm/llvm-project/commit/3946de0456fcbcd3a6c9f0d09d16d46c7987e0d7.diff

[PATCH] D124702: [MSVC] Add support for pragma function

This revision was automatically updated to reflect the committed changes. Closed by commit rG3946de0456fc: [MSVC] Add support for pragma function (authored by steplong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124702/new/ https://reviews.llvm.

[PATCH] D125422: Comment parsing: Specify argument numbers for some block commands

thakis added a comment. Hello, one of your three commits in https://github.com/llvm/llvm-project/compare/562ce1592456...d2396d896ee1 broke building on mac: - http://45.33.8.238/macm1/35247/step_4.txtp - https://green.lab.llvm.org/green/job/clang-stage1-RA/ Please take a look, and revert for n

[PATCH] D125422: Comment parsing: Specify argument numbers for some block commands

thakis added a comment. Looking at that error some more, it must've been D125429 . Moving the comment over there, sorry for the noise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125422/new/ https://reviews.llv

[PATCH] D125429: Comment parsing: Allow inline commands to have 0 or more than 1 argument

thakis added a comment. Hello, this broke building on mac: - http://45.33.8.238/macm1/35247/step_4.txtp - https://green.lab.llvm.org/green/job/clang-stage1-RA/ Please take a look, and revert for now if it takes a while to fix. (Here's the error: In file included from ../../clang/lib/AST/Comm

[clang] e0fcdf5 - Revert "In MSVC compatibility mode, friend function declarations behave as function declarations"

Author: Nico Weber Date: 2022-05-13T09:48:01-04:00 New Revision: e0fcdf5496ca686c8cebb63b63af86e666b42ab3 URL: https://github.com/llvm/llvm-project/commit/e0fcdf5496ca686c8cebb63b63af86e666b42ab3 DIFF: https://github.com/llvm/llvm-project/commit/e0fcdf5496ca686c8cebb63b63af86e666b42ab3.diff LO

[PATCH] D124613: In MSVC compatibility mode, friend function declarations behave as function declarations

thakis added a comment. Thanks, reverted in e0fcdf5496ca686c8cebb63b63af86e666b42ab3 for now. In D124613#3511098 , @frederic-tingaud-sonarsource wrote: > I realized that this current

[PATCH] D125517: [Frontend] [Coroutines] Emit error when we found incompatible allocation function in promise_type

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaCoroutine.cpp:1312 + + bool PromiseContainNew = [this, &PromiseType]() -> bool { +DeclarationName NewName = Slight preference to just have this as a part of LookupAllocationFunction.

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

ken-matsui added a comment. Thank you for your support! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124726/new/ https://reviews.llvm.org/D124726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D125547: [analyzer][solver] Handle UnarySymExpr in SMTConv

martong created this revision. martong added reviewers: steakhal, NoQ, mikhail.ramalho. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project:

[PATCH] D125524: [BoundV2] ArrayBoundV2 checks if the extent is tainted

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp:208 if (state_exceedsUpperBound && state_withinUpperBound) { - SVal ByteOffset = rawOffset.getByteOffset(); - if (isTainted(state, ByteOffset)) { + if (isTaint

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

abidmalikwaterloo updated this revision to Diff 429235. abidmalikwaterloo edited the summary of this revision. abidmalikwaterloo added a comment. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Rebase the patch and clean some formatting as needed Repository: rG LL

[PATCH] D125429: Comment parsing: Allow inline commands to have 0 or more than 1 argument

aaronpuchert added a comment. Hmm, didn't see this on Linux. I'll try to disambiguate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125429/new/ https://reviews.llvm.org/D125429 ___ cfe-commits mailing l

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

dexonsmith added a subscriber: arphaman. dexonsmith added a comment. In D122895#3511376 , @aaron.ballman wrote: > In D122895#3511312 , @aaron.ballman > wrote: > >> However, I think the blocks behavior is a bug b

[PATCH] D125547: [analyzer][solver] Handle UnarySymExpr in SMTConv

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. minor nits; Thanks Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SMTConv.h:258 + static inline llvm::SMTExprRef fromUnary(llvm::SMTSolverRef &Solve

[clang] d364307 - Remove a stale FIXME comment; NFC

Author: Aaron Ballman Date: 2022-05-13T10:23:47-04:00 New Revision: d364307542d19ec5b0f4f5ee9adc5a3b7c8639a5 URL: https://github.com/llvm/llvm-project/commit/d364307542d19ec5b0f4f5ee9adc5a3b7c8639a5 DIFF: https://github.com/llvm/llvm-project/commit/d364307542d19ec5b0f4f5ee9adc5a3b7c8639a5.diff

[clang] 25862f5 - Try to disambiguate between overloads on Mac

Author: Aaron Puchert Date: 2022-05-13T16:29:02+02:00 New Revision: 25862f53cce966cef2957825095861dec631d4f1 URL: https://github.com/llvm/llvm-project/commit/25862f53cce966cef2957825095861dec631d4f1 DIFF: https://github.com/llvm/llvm-project/commit/25862f53cce966cef2957825095861dec631d4f1.diff

[PATCH] D125532: [analyzer] Introduce clang_analyzer_dumpSvalType introspection function

steakhal marked an inline comment as done. steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp:268 + QualType Ty = C.getSVal(Arg).getType(C.getASTContext()); + reportBug(Ty.getAsString(), C); +} martong wrote:

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

jyknight added a comment. The warnings for this case aren't great: int foo(); int foo(int arg) { return 5; } results in: /tmp/test.c:1:5: warning: a function declaration without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-proto

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas updated this revision to Diff 429237. pratlucas added a comment. Adding frame access test coverage, adding check for FrameSetup flag and adjusting calculation of FP value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125094/new/ https:/

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

dexonsmith added a comment. In D122895#3511611 , @dexonsmith wrote: > Previously, `-Wstrict-prototypes` was useful for preventing actual bugs in > code. For example, it's important to have a warning that catches code like this: void f1(void (^block)

[PATCH] D125429: Comment parsing: Allow inline commands to have 0 or more than 1 argument

aaronpuchert added a comment. So we have overloads inline const StreamingDiagnostic &operator<<(const StreamingDiagnostic &DB, int I); inline const StreamingDiagnostic &operator<<(const StreamingDiagnostic &DB, int64_t I); inline const StreamingDiagnostic &operator<<(const StreamingDiagno

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

aaron.ballman added a comment. In D122895#3511611 , @dexonsmith wrote: > Sure, I'm all for adding a new warning for users that want a pedantic > warning. Can it be put behind a separate flag, such as > `-Wstrict-prototypes-pedantic`, which isn't trigge

[PATCH] D125333: [OpenMP] Use the new OpenMP device static library when doing LTO

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125333/new/ https://reviews.llvm.org/D125333

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas marked an inline comment as done. pratlucas added inline comments. Comment at: llvm/lib/Target/ARM/Thumb1FrameLowering.cpp:242 + // Find last push instruction for GPRCS2 - spilling of high registers + // (r8-r11) could consist of multiple tPUSH and tMOVr instructions.

[PATCH] D125395: [analyzer][solver] Handle UnarySymExpr in RangeConstraintSolver

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125395/new/ https://reviews.llvm.org/D125395 ___

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

aaron.ballman added a comment. In D122895#3511632 , @jyknight wrote: > The warnings for this case aren't great: > > int foo(); > > int > foo(int arg) { > return 5; > } Yeah, that's not ideal, I'm looking into it to see if I can improve tha

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

dexonsmith added a comment. In D122895#3511649 , @aaron.ballman wrote: > In D122895#3511611 , @dexonsmith > wrote: > >> Sure, I'm all for adding a new warning for users that want a pedantic >> warning. Can it b

[clang-tools-extra] 7e3ea55 - [clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks

Author: Balazs Benics Date: 2022-05-13T16:54:13+02:00 New Revision: 7e3ea55da88a9d7feaa22f29d51f89fd0152a189 URL: https://github.com/llvm/llvm-project/commit/7e3ea55da88a9d7feaa22f29d51f89fd0152a189 DIFF: https://github.com/llvm/llvm-project/commit/7e3ea55da88a9d7feaa22f29d51f89fd0152a189.diff

[PATCH] D125209: [clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rG7e3ea55da88a: [clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D125209: [clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks

thakis added a comment. Looks like this breaks tests: http://45.33.8.238/linux/76033/step_8.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125209/new/ https://reviews.llvm.org/D1

[clang] d5ffc1e - [analyzer][NFC] Tighten some of the SValBuilder return types

Author: Balazs Benics Date: 2022-05-13T17:04:34+02:00 New Revision: d5ffc1ed8b629cd04bbd46ee6981529d9dafa48f URL: https://github.com/llvm/llvm-project/commit/d5ffc1ed8b629cd04bbd46ee6981529d9dafa48f DIFF: https://github.com/llvm/llvm-project/commit/d5ffc1ed8b629cd04bbd46ee6981529d9dafa48f.diff

[PATCH] D125463: [analyzer][NFC] Tighten some of the SValBuilder return types

This revision was automatically updated to reflect the committed changes. Closed by commit rGd5ffc1ed8b62: [analyzer][NFC] Tighten some of the SValBuilder return types (authored by steakhal). Changed prior to commit: https://reviews.llvm.org/D125463?vs=428918&id=429244#toc Repository: rG LLV

[clang] a1025e6 - [analyzer] Introduce clang_analyzer_dumpSvalType introspection function

Author: Balazs Benics Date: 2022-05-13T17:07:58+02:00 New Revision: a1025e6ffe9b43afb9c6569423c4ea1d0ba8ecf2 URL: https://github.com/llvm/llvm-project/commit/a1025e6ffe9b43afb9c6569423c4ea1d0ba8ecf2 DIFF: https://github.com/llvm/llvm-project/commit/a1025e6ffe9b43afb9c6569423c4ea1d0ba8ecf2.diff

[clang-tools-extra] e8cae48 - Revert "[clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks"

Author: Balazs Benics Date: 2022-05-13T17:07:58+02:00 New Revision: e8cae487022c2216182ae1ec24f248f287a614b7 URL: https://github.com/llvm/llvm-project/commit/e8cae487022c2216182ae1ec24f248f287a614b7 DIFF: https://github.com/llvm/llvm-project/commit/e8cae487022c2216182ae1ec24f248f287a614b7.diff

[PATCH] D125532: [analyzer] Introduce clang_analyzer_dumpSvalType introspection function

This revision was automatically updated to reflect the committed changes. steakhal marked an inline comment as done. Closed by commit rGa1025e6ffe9b: [analyzer] Introduce clang_analyzer_dumpSvalType introspection function (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINC

  1   2   >