steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land.
minor nits; Thanks ================ Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SMTConv.h:258 + static inline llvm::SMTExprRef fromUnary(llvm::SMTSolverRef &Solver, + ASTContext &Ctx, ---------------- I would prefer the `fromUnOp` similarly to how `fromBinOp` is called. ================ Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SMTConv.h:467-469 + QualType FromTy; + llvm::SMTExprRef Exp = + getSymExpr(Solver, Ctx, USE->getOperand(), &FromTy, hasComparison); ---------------- If you discard the `FromTy`, you could have passed a nullptr there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125547/new/ https://reviews.llvm.org/D125547 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
