[PATCH] D124534: [clang] Add a diagnostic for line directive of a gnu extension

ken-matsui marked an inline comment as not done. ken-matsui added inline comments. Comment at: clang/test/Preprocessor/line-directive.c:33 # 42 "foo" 2 // expected-error {{invalid line marker flag '2': cannot pop empty include stack}} # 42 "foo" 1 3 // enter # 42 "foo" 2 3

[PATCH] D125157: [clang][Driver] Add more tests for riscv

benshi001 added a comment. Herald added a subscriber: shiva0217. It is my mistake. I should add `--author=Ping Deng ` when doing `git commit`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125157/new/ https://reviews.llvm.org/D125157

[PATCH] D124736: [CodeGen] Use ABI alignment for placement new

BertalanD added a comment. Could you please commit this for me, @rjmccall? I'm wondering if there's a chance this could be backported to the LLVM 14 branch. We've been running into the linked issue in production, it would be great if it were fixed in the next point release. Repository: rG

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

MaskRay added a comment. This cannot be committed as is. In particular, @rsmith's "We do not want to create or encourage the creation of language dialects and non-portable code," concern on https://discourse.llvm.org/t/making-ftrivial-auto-var-init-zero-a-first-class-option/55143/2 (shared by

[PATCH] D125162: [clang-format] fix alignment w/o binpacked args

curdeius added a comment. Thanks for creating the bug report. A few more comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:374-375 return false; + if (Changes[i].Tok->is(tok::l_brace) && + Changes[i].Tok->is(BK_BracedInit)) +

[PATCH] D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals

tbaeder updated this revision to Diff 428303. tbaeder marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124996/new/ https://reviews.llvm.org/D124996 Files: clang/docs/ReleaseNotes.rst clang/lib/Lex/PPExpressions.cpp clang/test/Lexer/utf8-char-literal.c

[clang] c4fa05f - [analyzer] Indicate if a parent state is infeasible

Author: Gabor Marton Date: 2022-05-10T10:16:55+02:00 New Revision: c4fa05f5f7783efa380c200d96cc1f756fa88c6c URL: https://github.com/llvm/llvm-project/commit/c4fa05f5f7783efa380c200d96cc1f756fa88c6c DIFF: https://github.com/llvm/llvm-project/commit/c4fa05f5f7783efa380c200d96cc1f756fa88c6c.diff

[clang] 1c1c1e2 - [analyzer] Implement assume in terms of assumeDual

Author: Gabor Marton Date: 2022-05-10T10:16:55+02:00 New Revision: 1c1c1e25f94fd1bb10fdbfe96dc14ffc655db5df URL: https://github.com/llvm/llvm-project/commit/1c1c1e25f94fd1bb10fdbfe96dc14ffc655db5df DIFF: https://github.com/llvm/llvm-project/commit/1c1c1e25f94fd1bb10fdbfe96dc14ffc655db5df.diff

[clang] 34ac048 - [analyzer] Replace adjacent assumeInBound calls to assumeInBoundDual

Author: Gabor Marton Date: 2022-05-10T10:16:55+02:00 New Revision: 34ac048aef298270d82e5430727ffd00f15c63d5 URL: https://github.com/llvm/llvm-project/commit/34ac048aef298270d82e5430727ffd00f15c63d5 DIFF: https://github.com/llvm/llvm-project/commit/34ac048aef298270d82e5430727ffd00f15c63d5.diff

[PATCH] D124674: [analyzer] Indicate if a parent state is infeasible

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4fa05f5f778: [analyzer] Indicate if a parent state is infeasible (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124674/new/ https://r

[PATCH] D124758: [analyzer] Implement assume in terms of assumeDual

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1c1c1e25f94f: [analyzer] Implement assume in terms of assumeDual (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D124761: [analyzer] Replace adjacent assumeInBound calls to assumeInBoundDual

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG34ac048aef29: [analyzer] Replace adjacent assumeInBound calls to assumeInBoundDual (authored by martong). Changed prior to commit: https://reviews

[PATCH] D124850: [Sema][SVE2] Move/simplify Sema testing for SVE2 ACLE builtins

RosieSumpter updated this revision to Diff 428308. RosieSumpter marked an inline comment as done. RosieSumpter added a comment. - Added `REQUIRES: aarch64-registered-target` to files where it was missed - Added overloaded forms to bfloat tests CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D124850: [Sema][SVE2] Move/simplify Sema testing for SVE2 ACLE builtins

RosieSumpter added inline comments. Comment at: clang/test/Sema/aarch64-sve2-intrinsics/acle_sve2_bfloat.cpp:8 + // expected-error@+1 {{use of undeclared identifier 'svwhilerw_bf16'}} + svwhilerw_bf16(const_bf16_ptr, const_bf16_ptr); + // expected-error@+1 {{use of undeclared

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

mehdi_amini added a comment. In D124750#3502401 , @srishti-pm wrote: > In D124750#3502295 , @mehdi_amini > wrote: > >> You're telling me "what" while I'm actually more interested in the "why" >> here? > > I'm n

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

srishti-pm added a comment. > My "why?" question is about canonicalization: could this be a > canonicalization and if so why / why not? This is an important thing to > answer before looking into the discussion below actually: I think, yes, it can be a canonicalization. I don't see why not. Re

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

srishti-pm added a comment. > So far you explained "what is canonicalization and why are we > canonicalizing", the same rationale applies to "push constant to the right" > that we do already in canonicalization, and this is exactly why I asked > before whether we could do what you're doing as a

[PATCH] D124932: [clang][dataflow] Track `optional` contents in `optional` model.

sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:170 /// Returns the symbolic value that represents the "has_value" property of the -/// optional value `Val`. Returns null if `Val` is null. -BoolValue *getHasValu

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

srishti-pm added a comment. > So: I understand that the producers should be sorted for a pattern to apply, > but our disconnect earlier is that my usual approach to see canonicalization > is to process an entire block/region, and as such we don't work on slices but > on operation in order until

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

mehdi_amini added a comment. That was the sense of my question about canonicalization indeed :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124750/new/ https://reviews.llvm.org/D124750 ___ cfe-commits

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

srishti-pm added a comment. > Every time the algorithm would consider a commutative op, that is all the op, > it would recurse and try to re-sort the current slice, processing the same > ops over and over. Yes, exactly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

srishti-pm added a comment. > Why? Again your description of the sort is as follow: I think I need to update my commit summary and revision summary. I had thought that this was an intuitive way of explaining the utility. But, I understand that it is quite misleading. Repository: rG LLVM Git

[PATCH] D124674: [analyzer] Indicate if a parent state is infeasible

thakis added a comment. One of your 3 commits in https://github.com/llvm/llvm-project/compare/3d888b0491f8...34ac048aef29 broke check-clang on Windows: http://45.33.8.238/win/57870/step_7.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monor

[PATCH] D124758: [analyzer] Implement assume in terms of assumeDual

martong added a comment. `infeasible-crash.c` fails both on arm and windows. The reasion is the incompatible `memmove` declaration. I am to fix this ASAP. Armv7 error: 'warning' diagnostics seen but not expected: File /home/tcwg-buildbot/worker/clang-armv7-quick/llvm/clang/test/Analysis

[PATCH] D125078: Implement a feature to show line numbers in diagnostics

ken-matsui added a comment. This feature is already implemented in GCC, so in my opinion, it would be great if we could turn this on by default. I also added a feature to separate location info and a message in https://reviews.llvm.org/D125175. Should its feature be avoided from turning on by d

[PATCH] D124038: [clang] Prevent folding of non-const compound expr

serge-sans-paille updated this revision to Diff 428317. serge-sans-paille edited the summary of this revision. serge-sans-paille added a comment. Added reg to GCC info page to explain current behavior, and make the test more explicit with respect to that quote. CHANGES SINCE LAST ACTION https

[PATCH] D124038: [clang] Prevent folding of non-const compound expr

serge-sans-paille added inline comments. Comment at: clang/test/SemaCXX/constant-expression-cxx11.cpp:1609 struct X { int a[2]; }; constexpr int *n = (X){1, 2}.a; // expected-warning {{C99}} expected-warning {{temporary}} // expected-error@-1 {{constant expression}} ---

[clang] 21feafa - [analyzer] Attempt to fix test infeasible-crash.c

Author: Gabor Marton Date: 2022-05-10T11:18:35+02:00 New Revision: 21feafaeb85aad2847db44aa2208999b166ba4a9 URL: https://github.com/llvm/llvm-project/commit/21feafaeb85aad2847db44aa2208999b166ba4a9 DIFF: https://github.com/llvm/llvm-project/commit/21feafaeb85aad2847db44aa2208999b166ba4a9.diff

[PATCH] D124758: [analyzer] Implement assume in terms of assumeDual

martong added a comment. Hopefully this commit fixes the failure: https://github.com/llvm/llvm-project/commit/21feafaeb85aad2847db44aa2208999b166ba4a9 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124758/new/ https://reviews.llvm.org/D124758 _

[PATCH] D124919: [clang] [WIP] Reject non-declaration C++11 attributes on declarations.

mboehme updated this revision to Diff 428318. mboehme added a comment. Simply code by replacing `ExtractDefiniteDeclAttrs()` function with `SlideAttrsToDeclSpec()`. This essentially inverts the logic: Instead of moving those attributes to a second list that should definitely remain on the decla

[PATCH] D124674: [analyzer] Indicate if a parent state is infeasible

thakis added a comment. https://github.com/llvm/llvm-project/commit/21feafaeb85aad2847db44aa2208999b166ba4a9 fixed it, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124674/new/ https://reviews.llvm.org/D124674

[PATCH] D124758: [analyzer] Implement assume in terms of assumeDual

martong added a comment. In D124758#3502913 , @martong wrote: > Hopefully this commit fixes the failure: > https://github.com/llvm/llvm-project/commit/21feafaeb85aad2847db44aa2208999b166ba4a9 Yes, it fixed the test case both at clang-armv7-quick and at

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers

martong added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103096/new/ https://reviews.llvm.org/D103096 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D124982: [clang][OpenMP][DebugInfo] Debug support for variables in containing scope of OMP constructs

alok updated this revision to Diff 428322. alok added a comment. Re-based. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124982/new/ https://reviews.llvm.org/D124982 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/lib/CodeGen/CGDebugInfo.h clang/lib/CodeGen/CGOpenMPRuntime.cpp c

[PATCH] D125226: [pseudo] Add benchmarks for pseudoparser.

hokein updated this revision to Diff 428323. hokein marked 6 inline comments as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125226/new/ https://reviews.llvm.org/D125226 Files: clang-tools-extra/ps

[PATCH] D125226: [pseudo] Add benchmarks for pseudoparser.

hokein added inline comments. Comment at: clang-tools-extra/pseudo/benchmarks/Benchmark.cpp:49 +static void runParseGrammar(benchmark::State &State) { + std::string GrammarText = readFile(GrammarFile); + for (auto _ : State) sammccall wrote: > rather than have

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

aaron.ballman added a comment. In D125142#3502732 , @MaskRay wrote: > This cannot be committed as is. In particular, @rsmith's "We do not want to > create or encourage the creation of language dialects and non-portable code," > concern on > https://dis

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

ken-matsui updated this revision to Diff 428335. ken-matsui added a comment. Herald added a subscriber: hiraditya. Updated the code as reviewed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124726/new/ https://reviews.llvm.org/D124726 Files: cla

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

ken-matsui added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:444 + + if (auto Sugg = Directive.find_similar_str(Candidates)) { +CharSourceRange DirectiveRange = erichkeane wrote: > I don't believe this meets our requirements for 'auto'. Than

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

mboehme added inline comments. Comment at: clang/test/SemaCXX/annotate-type.cpp:2 +// RUN: %clang_cc1 %s -std=c++17 -fsyntax-only -verify + +struct S1 { rsmith wrote: > mboehme wrote: > > aaron.ballman wrote: > > > mboehme wrote: > > > > aaron.ballman wrote: > >

[PATCH] D122766: [clang] Add the flag -ffile-reproducible

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122766/new/ https://reviews.llvm.org/D122766 ___ cfe-commits mailing list cfe-comm

[PATCH] D124866: [CUDA][HIP] support __noinline__ as keyword

aaron.ballman added a comment. In D124866#3501641 , @yaxunl wrote: > If we are to add `__forceinline__` as a keyword, I feel it better be a > separate patch to be cleaner. I'm fine with that. A few nits and a question about the test recently added.

[PATCH] D124534: [clang] Add a diagnostic for line directive of a gnu extension

aaron.ballman added a comment. Thanks, I think we're getting pretty close! Comment at: clang/test/Preprocessor/line-directive-system-headers.c:2-6 -// RUN: not %clang_cc1 -E %s 2>&1 | grep 'blonk.c:92:2: error: ABC' -// RUN: not %clang_cc1 -E %s 2>&1 | grep 'blonk.c:93:2: error

[PATCH] D124534: [clang] Add a diagnostic for line directive of a gnu extension

ken-matsui added a comment. Thank you for your review! Comment at: clang/test/Preprocessor/line-directive-system-headers.c:2-6 -// RUN: not %clang_cc1 -E %s 2>&1 | grep 'blonk.c:92:2: error: ABC' -// RUN: not %clang_cc1 -E %s 2>&1 | grep 'blonk.c:93:2: error: DEF' -// RUN: not

[PATCH] D124534: [clang] Add a diagnostic for line directive of a gnu extension

aaron.ballman added inline comments. Comment at: clang/test/Preprocessor/line-directive-system-headers.c:2-6 -// RUN: not %clang_cc1 -E %s 2>&1 | grep 'blonk.c:92:2: error: ABC' -// RUN: not %clang_cc1 -E %s 2>&1 | grep 'blonk.c:93:2: error: DEF' -// RUN: not %clang_cc1 -E %s 2>&

[PATCH] D125226: [pseudo] Add benchmarks for pseudoparser.

hokein added a comment. In D125226#3500691 , @sammccall wrote: > > I think we should have some fixed checked-in examples, but we can add them > later. Yeah, it is a good idea to have some fixed datasets checked in (but we will not run them in build

[PATCH] D125226: [pseudo] Add benchmarks for pseudoparser.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe895d5768d5: [pseudo] Add benchmarks for pseudoparser. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125226/new/ https://reviews.llvm

[clang-tools-extra] be895d5 - [pseudo] Add benchmarks for pseudoparser.

Author: Haojian Wu Date: 2022-05-10T14:13:46+02:00 New Revision: be895d5768d5e12581f158b9522b167c833796d8 URL: https://github.com/llvm/llvm-project/commit/be895d5768d5e12581f158b9522b167c833796d8 DIFF: https://github.com/llvm/llvm-project/commit/be895d5768d5e12581f158b9522b167c833796d8.diff LO

[PATCH] D124534: [clang] Add a diagnostic for line directive of a gnu extension

ken-matsui added inline comments. Comment at: clang/test/Preprocessor/line-directive-system-headers.c:2-6 -// RUN: not %clang_cc1 -E %s 2>&1 | grep 'blonk.c:92:2: error: ABC' -// RUN: not %clang_cc1 -E %s 2>&1 | grep 'blonk.c:93:2: error: DEF' -// RUN: not %clang_cc1 -E %s 2>&1 |

[PATCH] D124850: [Sema][SVE2] Move/simplify Sema testing for SVE2 ACLE builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG131e6636f23c: [Sema][SVE2] Move/simplify Sema testing for SVE2 ACLE builtins (authored by RosieSumpter). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum

lenary added a comment. Ack to all the comment clarifications, will update patch with those soon (probably tomorrow). Comment at: llvm/lib/Target/ARM/ARMFixCortexA57AES1742098Pass.cpp:146 + case ARM::VMVNd: + case ARM::VMVNq: + // VMOV of 64-bit value between D registers (w

[PATCH] D124982: [clang][OpenMP][DebugInfo] Debug support for variables in containing scope of OMP constructs

bwyma added a comment. If the parent function is inlined into multiple callers, is the outlined subprogram scope treated like any other nested lexical scope and duplicated? If the outlined subprogram scope is duplicated when inlined, how will retained nodes on the outlined subprogram be handled

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

paulwalker-arm added a comment. @aaron.ballman It looks like the conversation reached a conclusion? Given this is separate to what we're trying to add here can this patch be unblocked? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124998/new/ htt

[PATCH] D125311: [pseudo] Share the underly payload when stripping comments for a token stream

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. `stripComments(cook(...))` is a common pattern being written. Without this pa

[PATCH] D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum

dmgreen added inline comments. Comment at: llvm/lib/Target/ARM/ARMFixCortexA57AES1742098Pass.cpp:146 + case ARM::VMVNd: + case ARM::VMVNq: + // VMOV of 64-bit value between D registers (when condition = al) lenary wrote: > dmgreen wrote: > > Perhaps add these,

[PATCH] D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals

aaron.ballman added inline comments. Comment at: clang/test/Lexer/utf8-char-literal.cpp:3-4 // RUN: %clang_cc1 -triple x86_64-apple-darwin -std=c2x -x c -fsyntax-only -verify %s -// RUN: %clang_cc1 -triple x86_64-apple-darwin -std=c++1z -fsyntax-only -verify %s +// RUN: %clang

[PATCH] D125311: [pseudo] Share the underly payload when stripping comments for a token stream

hokein added a comment. Example: https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/pseudo/tool/ClangPseudo.cpp#L88 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125311/new/ https://reviews.llvm.org/D125311 _

[PATCH] D124874: [clang] add -fmodule-file-home-is-cwd

urnathan added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:1231-1236 +SmallString<128> BaseDir(CWD->getName()); +cleanPathForOutput(Context.getSourceManager().getFileManager(), BaseDir); +BaseDirectory.assign(BaseDir.begin(), BaseDir.end()); +

[PATCH] D125165: [Clang] Introduce clang-offload-binary tool to bundle device files

jdoerfert added a comment. Conceptually fine with me, @tra? Comment at: clang/docs/ClangOffloadBinary.rst:8 + +.. _clang-offload-binary: + jhuber6 wrote: > tra wrote: > > Naming nit: `binary` may not be the best term for what we're trying to do > > here. Perha

[PATCH] D125312: [pseudo] benchmark cleanups. NFC

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. - add missing benchmark for lex/preprocess steps - name ben

[PATCH] D124702: [MSVC] Add support for pragma function

steplong added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:3578 + + if (Tok.isNot(tok::l_paren)) { +PP.Diag(Tok.getLocation(), diag::warn_pragma_expected_lparen) aaron.ballman wrote: > Can we use `ExpectAndConsume()` here instead? I don't th

[PATCH] D125272: [clang] Add -fcheck-new support

urnathan added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:15440 + // + // However, -fcheck-new violates this possible assumption, so don't add + // NonNull when that is enabled. 'invalidates' or 'negates' are better words here. Repository: rG

[PATCH] D125178: Warn if using `elifdef` & `elifndef` in not C2x mode

ken-matsui updated this revision to Diff 428358. ken-matsui added a comment. Update the code as reviewed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125178/new/ https://reviews.llvm.org/D125178 Files: clang/include/clang/Basic/DiagnosticLexKin

[PATCH] D125178: Warn if using `elifdef` & `elifndef` in not C2x mode

ken-matsui added a comment. Thank you so much for your review! Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:696-698 +def ext_c2x_pp_directive : Extension< + "%select{#elifdef|#elifndef}0 is a C2x extension">, + InGroup; aaron.ballman wrote: > I

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

ldionne updated this revision to Diff 428361. ldionne added a comment. Rebase to poke CI. Any interest in reviewing this @phosek @mstorsjo? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120727/new/ https://reviews.llvm.org/D120727 Files: clang/c

[PATCH] D125314: [OpenMP] Don't set device runtime debugging flags if using '-nogpulib'

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, ABataev, JonChesterfield. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a p

[PATCH] D125311: [pseudo] Share the underly payload when stripping comments for a token stream

sammccall added a comment. This looks good, but if that's the idiom we should add it to cook() also. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125311/new/ https://reviews.llvm.org/D125311 ___ cfe-com

[PATCH] D125314: [OpenMP] Don't set device runtime debugging flags if using '-nogpulib'

jdoerfert added a comment. Not actually tested, is it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125314/new/ https://reviews.llvm.org/D125314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D125314: [OpenMP] Don't set device runtime debugging flags if using '-nogpulib'

jhuber6 added a comment. In D125314#3503453 , @jdoerfert wrote: > Not actually tested, is it? Should be, we already have a test for not emitting these when the host-or file path is empty, I just reused the same tests but set the flags to use `nogpulib`

[PATCH] D124938: [clang] serialize SUBMODULE_TOPHEADER relative to BaseDirectory

urnathan accepted this revision. urnathan added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124938/new/ https://reviews.llvm.org/D124938 ___

[PATCH] D125228: [clangd] Support for standard inlayHint protocol

kadircet updated this revision to Diff 428368. kadircet marked 9 inline comments as done. kadircet added a comment. - Get rid of warning and not advertising when client has capability. - Introduce paddingLeft/paddingRight, get rid of leading/trailing spaces in label, but re-introduce them when se

[PATCH] D125228: [clangd] Support for standard inlayHint protocol

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:586 + // Only advertise inlayHints extension if client doesn't support the standard + // implementation. sammccall wrote: > I still feel a little uncomfortable with this

[PATCH] D125228: [clangd] Support for standard inlayHint protocol

kadircet updated this revision to Diff 428370. kadircet added a comment. - Advertise inlayHintProvider Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125228/new/ https://reviews.llvm.org/D125228 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D124702: [MSVC] Add support for pragma function

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:3578 + + if (Tok.isNot(tok::l_paren)) { +PP.Diag(Tok.getLocation(), diag::warn_pragma_expected_lparen) steplong wrote: > aaron.ballman wrote: > > Can we use `ExpectAndConsume()`

[PATCH] D124702: [MSVC] Add support for pragma function

steplong updated this revision to Diff 428375. steplong edited the summary of this revision. steplong added a comment. - Clang-formatted patch - Split out the pragma intrinsic stuff - Replaced SmallSetVector in pragma handler with SmallVector. MSNoBuiltins is still a SmallSetVector in Sema. - Com

[PATCH] D125203: [PowerPC] Fix PPCISD::STBRX selection issue on A2

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. In D125203#3502651 , @tingwang wrote: > In D125203#3502433 , @nemanjai > wrote: > >> Why not also fix th

[PATCH] D125228: [clangd] Support for standard inlayHint protocol

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Great! If you didn't already, can you check with VSCode before landing? This might catch protocol bits we missed, but also will make sure that the disablement of the legacy protocol in vs

[PATCH] D125165: [Clang] Introduce clang-offload-binary tool to bundle device files

jhuber6 updated this revision to Diff 428379. jhuber6 added a comment. Changing name from clang-offload-binary to clang-offload-packager and updating some help mesages. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125165/new/ https://reviews.llvm

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

Mogball added a comment. I need to look at the algorithm in more detail, but I'm not a fan of using a string key. Concatenating strings to make compound keys is not very efficient and potentially brittle. Can you assign unique IDs and use an array of IDs instead? Comment at:

[clang] 00a3c9f - [Frontend] Flip default of CreateInvocationOptions::ProbePrecompiled to false

Author: Sam McCall Date: 2022-05-10T16:58:13+02:00 New Revision: 00a3c9f2a46a566b3ff10f2d24b01426df2193ab URL: https://github.com/llvm/llvm-project/commit/00a3c9f2a46a566b3ff10f2d24b01426df2193ab DIFF: https://github.com/llvm/llvm-project/commit/00a3c9f2a46a566b3ff10f2d24b01426df2193ab.diff LO

[PATCH] D125149: [Frontend] Flip default of CreateInvocationOptions::ProbePrecompiled to false

This revision was automatically updated to reflect the committed changes. Closed by commit rG00a3c9f2a46a: [Frontend] Flip default of CreateInvocationOptions::ProbePrecompiled to false (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

Mogball added a comment. On the matter of whether this should be a canonicalization, my concern with this is that if an operation has its own preferred ordering of operands that conflicts with the sort, then this will cause canonicalization to loop infinitely. It's not actually the canonicaliz

[PATCH] D124534: [clang] Add a diagnostic for line directive of a gnu extension

ken-matsui updated this revision to Diff 428382. ken-matsui added a comment. Update test codes as reviewed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124534/new/ https://reviews.llvm.org/D124534 Files: clang/include/clang/Basic/DiagnosticGrou

[clang] 93a8225 - [CodeGen] Use ABI alignment for C++ new expressions

Author: Daniel Bertalan Date: 2022-05-10T16:02:23+01:00 New Revision: 93a8225da1f983cccb3e4b5e762369121aaa7dd5 URL: https://github.com/llvm/llvm-project/commit/93a8225da1f983cccb3e4b5e762369121aaa7dd5 DIFF: https://github.com/llvm/llvm-project/commit/93a8225da1f983cccb3e4b5e762369121aaa7dd5.dif

[PATCH] D124736: [CodeGen] Use ABI alignment for C++ new expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rG93a8225da1f9: [CodeGen] Use ABI alignment for C++ new expressions (authored by BertalanD, committed by thakis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D125178: Warn if using `elifdef` & `elifndef` in not C2x mode

aaron.ballman added a comment. It looks like precommit CI caught some related failures: Failed Tests (7): Clang :: Lexer/deprecate-macro.c Clang :: Lexer/unsafe-macro.c Clang :: Preprocessor/elifdef.c Clang :: Preprocessor/if_warning.c Clang :: Preprocessor/ifdef-recover.c

[PATCH] D115187: [clangd] Expose CoawaitExpr's operand in the AST

sammccall added a comment. In D115187#3500098 , @nridge wrote: > I think the issue is related to this loop > > in `AnalyzeImplicitConversions

[PATCH] D124702: [MSVC] Add support for pragma function

steplong added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:1070 +SourceLocation Loc, const llvm::SmallSetVector &Intrinsics) { + if (!CurContext->getRedeclContext()->isFileContext()) { +Diag(Loc, diag::err_pragma_intrinsic_function_scope); a

[clang] ca75ac5 - Diagnose unreachable generic selection associations

Author: Aaron Ballman Date: 2022-05-10T11:15:56-04:00 New Revision: ca75ac5f04f269def97e6844c2f5c9596b29c84c URL: https://github.com/llvm/llvm-project/commit/ca75ac5f04f269def97e6844c2f5c9596b29c84c DIFF: https://github.com/llvm/llvm-project/commit/ca75ac5f04f269def97e6844c2f5c9596b29c84c.diff

[PATCH] D125259: [C11] Diagnose unreachable generic selection associations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGca75ac5f04f2: Diagnose unreachable generic selection associations (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D125259: [C11] Diagnose unreachable generic selection associations

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:1702 + + if (Reason) +Diag(Types[i]->getTypeLoc().getBeginLoc(), erichkeane wrote: > Splitting this up into the separate line for only 2 items seems like a waste, >

[PATCH] D124613: In MSVC compatibility mode, friend function declarations behave as function declarations

thakis added a comment. I don't think you need to build chromium. https://bugs.chromium.org/p/chromium/issues/detail?id=1323014#c5 has a stand-alone reproducer attached that you can download. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124613/ne

[PATCH] D125165: [Clang] Introduce clang-offload-packager tool to bundle device files

yaxunl added inline comments. Comment at: clang/docs/ClangOffloadBinary.rst:15 +metadata. We use a custom binary format for bundling all the device images +together. The image format is a small header wrapping around a string map. This +tool creates bundled binaries so that they

[PATCH] D125178: Warn if using `elifdef` & `elifndef` in not C2x mode

ken-matsui added a comment. In D125178#3503617 , @aaron.ballman wrote: > It looks like precommit CI caught some related failures: > > Failed Tests (7): > Clang :: Lexer/deprecate-macro.c > Clang :: Lexer/unsafe-macro.c > Clang :: Preprocess

[PATCH] D125318: [analyzer] Add UnarySymExpr

martong created this revision. martong added reviewers: NoQ, steakhal. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project:

[PATCH] D124699: [DeadArgElim] Set unused arguments for internal functions

thakis added a comment. Updating the tests makes sense to me, fwiw. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124699/new/ https://reviews.llvm.org/D124699 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D125259: [C11] Diagnose unreachable generic selection associations

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:1702 + + if (Reason) +Diag(Types[i]->getTypeLoc().getBeginLoc(), aaron.ballman wrote: > erichkeane wrote: > > Splitting this up into the separate line for only 2 items

[PATCH] D125318: [analyzer] Add UnarySymExpr

martong added a comment. Related false positive: https://github.com/llvm/llvm-project/issues/55241 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125318/new/ https://reviews.llvm.org/D125318 ___ cfe-commi

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

jpienaar added a comment. > (1) the operands defined by non-constant-like ops come first, followed by (2) > block arguments, and these are followed by (3) the operands defined by > constant-like ops. I would have thought block-arguments would come first as we don't know their values, while non

[PATCH] D125165: [Clang] Introduce clang-offload-packager tool to bundle device files

jhuber6 added inline comments. Comment at: clang/docs/ClangOffloadBinary.rst:15 +metadata. We use a custom binary format for bundling all the device images +together. The image format is a small header wrapping around a string map. This +tool creates bundled binaries so that they

  1   2   3   >