[PATCH] D124504: Remove --no-opaque-pointers in test/cxx2a-thread-local-constinit.cpp

ChuanqiXu created this revision. ChuanqiXu added a reviewer: nikic. ChuanqiXu added a project: clang. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. The option `--no-opaque-pointers` in test/cxx2a-thread-local-constinit.cpp blocks

[PATCH] D124435: [X86] Always extend the integer parameters in callee

LiuChen3 updated this revision to Diff 425427. LiuChen3 added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124435/new/ https://reviews.llvm.org/D124435 Files: clang/docs/ClangCommandLineReference.rst clang/include/

[PATCH] D124435: [X86] Always extend the integer parameters in callee

LiuChen3 marked 9 inline comments as done. LiuChen3 added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2310 case ABIArgInfo::Extend: + case ABIArgInfo::ConservativeExtend: if (RetAI.isSignExt()) At present, `ConservativeExtend` has no specif

[PATCH] D124341: [clang-tidy][NFC] Replace many instances of std::string where a StringRef would suffice.

njames93 added a comment. In D124341#3475083 , @aaron.ballman wrote: > I went through the changes and they look correct to me... yet I'm still > mildly terrified. :-D Have you tried running clang-tidy through its paces > with ASan/MSan enabled to see i

[PATCH] D124435: [X86] Always extend the integer parameters in callee

LiuChen3 updated this revision to Diff 425428. LiuChen3 added a comment. add one missing comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124435/new/ https://reviews.llvm.org/D124435 Files: clang/docs/ClangCommandLineReference.rst clang/i

[PATCH] D124435: [X86] Always extend the integer parameters in callee

LiuChen3 added a comment. In D124435#3474130 , @skan wrote: > Should we update the `clang/docs/ReleaseNotes.rst` for this? The ReleaseNotes says "written by LLVM Team". So I am not sure if I can update this. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D124504: Remove --no-opaque-pointers in test/cxx2a-thread-local-constinit.cpp

nikic added a reviewer: opaque-pointers. nikic added a comment. How does it block your work? Tests currently still use `-no-opaque-pointers` to avoid breaking this mode. I think it's generally okay to drop the option, but I'm a bit unclear about the motivation in this case -- do you want to make

[PATCH] D124435: [X86] Always extend the integer parameters in callee

LiuChen3 added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2988-2992 +.. option:: -mconservative-extend +Always extend the integer parameter both in the callee and caller. + +.. option:: -mno-conservative-extend +Keep the original integer parameter passi

[PATCH] D124504: Remove --no-opaque-pointers in test/cxx2a-thread-local-constinit.cpp

ChuanqiXu added a comment. In D124504#3476537 , @nikic wrote: > How does it block your work? Tests currently still use `-no-opaque-pointers` > to avoid breaking this mode. I think it's generally okay to drop the option, > but I'm a bit unclear about the

[PATCH] D124462: [Analyzer] Fix clang::ento::taint::dumpTaint definition

mantognini created this revision. Herald added subscribers: manas, steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. mantognini published this revision for review. mantognini added revie

[PATCH] D124359: [clangd] Add inlay hints for mutable reference parameters

upsj updated this revision to Diff 425432. upsj added a comment. add tests for reference inlay hints Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124359/new/ https://reviews.llvm.org/D124359 Files: clang-tools-extra/clangd/InlayHints.cpp clan

[PATCH] D124462: [Analyzer] Fix clang::ento::taint::dumpTaint definition

steakhal added a reviewer: steakhal. steakhal added a comment. Could you please elaborate whats the motivation for this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124462/new/ https://reviews.llvm.org/D124462

[clang] c1e9459 - Revert "[asan] Enable detect_stack_use_after_return=1 by default"

Author: Vitaly Buka Date: 2022-04-27T00:43:39-07:00 New Revision: c1e94591bcc95f36da0372080c455b09af8c46fd URL: https://github.com/llvm/llvm-project/commit/c1e94591bcc95f36da0372080c455b09af8c46fd DIFF: https://github.com/llvm/llvm-project/commit/c1e94591bcc95f36da0372080c455b09af8c46fd.diff L

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

pcwang-thead added a comment. In D112921#3474964 , @rjmccall wrote: > Hmm. Allowing a version on `-stdlib` is intuitively appealing, but I'm not > sure it actually gives us the information we need. As I recall, `-stdlib` > selects the high-level stdli

[PATCH] D124504: Remove --no-opaque-pointers in test/cxx2a-thread-local-constinit.cpp

nikic added a comment. In D124504#3476562 , @ChuanqiXu wrote: > In D124504#3476537 , @nikic wrote: > >> How does it block your work? Tests currently still use `-no-opaque-pointers` >> to avoid breaking this mode.

[PATCH] D124461: [Analyzer] Remove undefined function

mantognini created this revision. Herald added subscribers: manas, steakhal, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. mantognini added reviewers: NoQ, baloghadamsoftware. mantognini published this

[PATCH] D124057: [asan] Enable detect_stack_use_after_return=1 by default

vitalybuka updated this revision to Diff 425433. vitalybuka added a comment. redo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124057/new/ https://reviews.llvm.org/D124057 Files: clang/docs/AddressSanitizer.rst clang/docs/ReleaseNotes.rst c

[PATCH] D124504: Remove --no-opaque-pointers in test/cxx2a-thread-local-constinit.cpp

ChuanqiXu abandoned this revision. ChuanqiXu added a comment. In D124504#3476585 , @nikic wrote: > In D124504#3476562 , @ChuanqiXu > wrote: > >> In D124504#3476537 , @nik

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

krasimir added a comment. > @krasimir I'm on sick leave and will have a look as soon as I'm back. Can it > wait that long? I'm planning to revert this temporarily and add a regression test, you can proceed with this work without time pressure. We aim to release a new clang-format version weekl

[PATCH] D123300: [Clang] Enable opaque pointers by default

yurai007 added a comment. In D123300#3474834 , @nikic wrote: > @yurai007 I've put up https://reviews.llvm.org/D124459 to fix this > optimization failure. @nikic: I can confirm that patch fix regression and makes coroutines snippet great again. Thanks!

[PATCH] D124158: [Clang][Attr] Skip adding noundef attribute to arguments when function has convergent attribute

skc7 updated this revision to Diff 425442. skc7 added a comment. fix failing tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124158/new/ https://reviews.llvm.org/D124158 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/PowerPC/ppc64l

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

pcwang-thead updated this revision to Diff 425443. pcwang-thead added a comment. Herald added subscribers: dexonsmith, arichardson. - Add handling of Apple targets. - Update libc++ tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112921/new/ ht

[PATCH] D124435: [X86] Always extend the integer parameters in callee

rjmccall added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2988-2992 +.. option:: -mconservative-extend +Always extend the integer parameter both in the callee and caller. + +.. option:: -mno-conservative-extend +Keep the original integer parameter passi

[PATCH] D124509: [RISCV] Fix int16 -> __fp16 conversion code gen

kito-cheng created this revision. Herald added subscribers: sunshaoce, VincentWu, luke957, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, si

[PATCH] D124510: [RISCV] Precommit test for D124509

kito-cheng created this revision. Herald added subscribers: sunshaoce, VincentWu, luke957, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, si

[PATCH] D124060: [PowerPC] Enable CR bits support for Power8 and above.

nemanjai added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:519 .Default(false); + Features["crbits"] = llvm::StringSwitch(CPU) +.Case("ppc64le", true) shchenz wrote: > amyk wrote:

[PATCH] D124512: Revert "[clang-format] SortIncludes should support "@import" lines in Objective-C"

krasimir created this revision. Herald added a project: All. krasimir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts commit d46fa023caa2db5a9f1e21dd038bcb626261d958

[PATCH] D124513: [clang-format] add a regression test for include sorting

krasimir created this revision. Herald added a project: All. krasimir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds a regression test from the comments on https://reviews.llvm.org/D121370. Repository: rG LLVM Github Monorepo

[PATCH] D124513: [clang-format] add a regression test for include sorting

krasimir updated this revision to Diff 425456. krasimir added a comment. - update with just the last commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124513/new/ https://reviews.llvm.org/D124513 Files: clang/unittests/Format/SortIncludesTest

[PATCH] D124158: [Clang][Attr] Skip adding noundef attribute to arguments when function has convergent attribute

skc7 updated this revision to Diff 425458. skc7 added a comment. skip adding noundef to return type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124158/new/ https://reviews.llvm.org/D124158 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeG

[PATCH] D124158: [Clang][Attr] Skip adding noundef attribute to arguments when function has convergent attribute

skc7 updated this revision to Diff 425463. skc7 added a comment. update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124158/new/ https://reviews.llvm.org/D124158 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/PowerPC/ppc64le-vara

[PATCH] D124158: [Clang][Attr] Skip adding noundef attribute to arguments when function has convergent attribute

skc7 added inline comments. Comment at: llvm/test/Transforms/SimplifyCFG/tautological-conditional-branch-convergent-noundef.ll:26 + %i3 = phi double [%i2, %bb2], [undef, %bb1] + %i4 = call noundef double @two(double %i3, i1 %i1) + ret void skc7 wrote: > ars

[PATCH] D124435: [X86] Always extend the integer parameters in callee

LiuChen3 added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:1938 +return IsConservativeExtend ? ABIArgInfo::getConservativeExtend(Ty) +: ABIArgInfo::getExtend(Ty); } rjmccall wrote: > LiuChen3 wrote: > > rjm

[PATCH] D124349: [analyzer] Get direct binding for specific punned case

vabridgers added a comment. polite ping to @NoQ and/or @martong. @steakhal is ok with this change, are you ok if I land this? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124349/new/ https://reviews.llvm.org/D124349 _

[PATCH] D124462: [Analyzer] Fix clang::ento::taint::dumpTaint definition

mantognini added a comment. In D124462#3476581 , @steakhal wrote: > Could you please elaborate whats the motivation for this change? Right, I could have been more explicit. Sorry about that. `dumpTaint` is declared inside the `taint` namespace in the he

[clang] 31ff400 - Revert "[Driver] Support for compressed debug info on Fuchsia"

Author: Tom Weaver Date: 2022-04-27T12:29:04+01:00 New Revision: 31ff40042d0504a37b443a8e8d5edfd90d54e228 URL: https://github.com/llvm/llvm-project/commit/31ff40042d0504a37b443a8e8d5edfd90d54e228 DIFF: https://github.com/llvm/llvm-project/commit/31ff40042d0504a37b443a8e8d5edfd90d54e228.diff LO

[PATCH] D114115: [Driver] Support for compressed debug info on Fuchsia

TWeaver added a comment. Hello all, really sorry but I've had to revert this patch due to failures on windows build bots: http://lab.llvm.org:8011/#/builders/216 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114115/new/ https://reviews.llvm.org/

[PATCH] D124437: [AST] Consider QualifiedTemplateName in TemplateName::getAsUsingDecl().

hokein updated this revision to Diff 425481. hokein added a comment. Fix the broken test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124437/new/ https://reviews.llvm.org/D124437 Files: clang-tools-extra/clangd/unittests/IncludeCleanerTests.cp

[clang] 8052f4d - [AST] Consider QualifiedTemplateName in TemplateName::getAsUsingDecl().

Author: Haojian Wu Date: 2022-04-27T14:16:19+02:00 New Revision: 8052f4d22a12f1baa949c7a04f029e231faae90a URL: https://github.com/llvm/llvm-project/commit/8052f4d22a12f1baa949c7a04f029e231faae90a DIFF: https://github.com/llvm/llvm-project/commit/8052f4d22a12f1baa949c7a04f029e231faae90a.diff LO

[PATCH] D124437: [AST] Consider QualifiedTemplateName in TemplateName::getAsUsingDecl().

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8052f4d22a12: [AST] Consider QualifiedTemplateName in TemplateName::getAsUsingDecl(). (authored by hokein). Repository: rG LLVM Github Monorepo C

[PATCH] D124373: [clang] add parameter pack/pack expansion matchers

upsj updated this revision to Diff 425487. upsj added a comment. formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124373/new/ https://reviews.llvm.org/D124373 Files: clang/include/clang/ASTMatchers/ASTMatchers.h clang/lib/ASTMatchers/A

[PATCH] D124164: [include-cleaner] Include-cleaner library structure, and simplistic AST walking.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, as discussed offline. this mostly LG. there are concerns about more code re-use, especially around handling pragmas but we should probably address them as we go rather than now.

[PATCH] D124462: [Analyzer] Fix clang::ento::taint::dumpTaint definition

steakhal added a comment. Although gcc (and probably clang too) allows specifying `__attribute__((noinline))` at any declaration (by merging //compatible// attributes), I would prefer not to repeat ourselves. The attribute must be present at the header to force all usages not to inline it, henc

[PATCH] D123605: [WIP][Sema][SVE] Move/simplify Sema testing for SVE ACLE builtins

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. Thanks for this @RosieSumpter. If you remove the 'WIP' and s/SVE/SVE2/ from the title and description, I'm happy to accept. The negative tests for the SVE(1) intrinsics can be added as a

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

RKSimon added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117829/new/ https://reviews.llvm.org/D117829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D124525: [OpenMP][ClangLinkerWrapper] Extending linker wrapper to embed metadata for multi-arch fat binaries

saiislam created this revision. saiislam added reviewers: jdoerfert, JonChesterfield, jhuber6, yaxunl. Herald added a subscriber: guansong. Herald added a project: All. saiislam requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, sstefan1. Herald added projects

[clang] 0a4a43c - [OpenMP] Properly handle the `-f/-fno` veraints for the new driver

Author: Joseph Huber Date: 2022-04-27T09:58:55-04:00 New Revision: 0a4a43cf138b929b5280dbe4fcf5f219ca18ae43 URL: https://github.com/llvm/llvm-project/commit/0a4a43cf138b929b5280dbe4fcf5f219ca18ae43 DIFF: https://github.com/llvm/llvm-project/commit/0a4a43cf138b929b5280dbe4fcf5f219ca18ae43.diff

[PATCH] D124158: [Clang][Attr] Skip adding noundef attribute to arguments when function has convergent attribute

jdoerfert added a comment. > For Ex: SimplifyCFG pass removes the branch leading to a BB which has an > incoming value that will always trigger undefined behavior. This basically > modifies the CFG and combines the basic blocks. This works for CPU execution. > But on a GPU, there are intrinsics

[PATCH] D124060: [PowerPC] Enable CR bits support for Power8 and above.

nemanjai added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:3566 +Control the CR-bit tracking feature on PowerPC. ``-mcrbits`` (the enablement of CR-bit tracking support) is the default for POWER8 and above. + ``` ... is the default fo

[PATCH] D124525: [OpenMP][ClangLinkerWrapper] Extending linker wrapper to embed metadata for multi-arch fat binaries

jdoerfert added inline comments. Comment at: openmp/libomptarget/include/omptarget.h:163 + int32_t image_number; // Image number in image library starting from 0 + int32_t number_images; // Number of images, used for initial allocation + char *offload_arch;//

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane updated this revision to Diff 425516. erichkeane added a comment. Correct the caching behavior to make the FriendFunc example work. I THINK this is ready to review! I'd like to do the lambda examples in a followup patch as I believe that is a pre-existing issue, and this patch has g

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:165 +std::string +ExtractionContext::computeExprType(const clang::Expr *E) const { + if (Ctx.getLangOpts().CPlusPlus) (does this need to be a method?) ===

[PATCH] D124525: [OpenMP][ClangLinkerWrapper] Extending linker wrapper to embed metadata for multi-arch fat binaries

jhuber6 added inline comments. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:1161 -LinkedImages.push_back(*ImageOrErr); +LinkedImages.emplace_back(TheArch, *ImageOrErr); } I'm doing something similar in D123810, I just used the

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/unittests/clang-tidy/ModernizeModuleTest.cpp:1 +#include "ClangTidyTest.h" +#include "modernize/IntegralLiteralExpressionMatcher.h" Needs a file header CHANGES SINCE LAST ACTION https://re

[PATCH] D124493: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

filcab added a comment. Hi @hctim, thanks for the patch. I have one question, though. Do you really need to remove the information you removed? Some people might be testing ASan binaries without access to debug info (because it's been stripped or it's not been loaded and is not available for th

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

dblaikie added a comment. In D123534#3475790 , @hctim wrote: >> summary of DWARF: >> & how many of these descriptions get added to the debug info? > > afaict, there is now: > 1x .debug_addr entry for each string > 1x. debug_info DW_TAG_variable for each

[PATCH] D123436: [Clang] Use std::move in GlobalModuleIndex::readIndex. NFC

dblaikie added a comment. In D123436#3475858 , @junaire wrote: > In D123436#3475002 , @dblaikie > wrote: > >> In D123436#3462567 , @dblaikie >> wrote: >> >>> Perhaps Glo

[PATCH] D124532: [AST] Improve traversal of concept requirements

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. ilya-biryukov requested review of this revision. Herald added projects: clang, clang-tools-extra. - Do not visit implicit AST node t

[PATCH] D124534: Add a warning diagnostic for line directive of a gnu extension

ken-matsui created this revision. Herald added a project: All. ken-matsui requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D124534 Files: clang-tools-extra/

[PATCH] D124534: Add a warning diagnostic for line directive of a gnu extension

ken-matsui added a comment. This change is related to: https://github.com/llvm/llvm-project/issues/55067 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124534/new/ https://reviews.llvm.org/D124534 ___ cfe

[PATCH] D124158: [Clang][Attr] Skip adding noundef attribute to arguments when function has convergent attribute

skc7 added a comment. In D124158#3477281 , @jdoerfert wrote: >> For Ex: SimplifyCFG pass removes the branch leading to a BB which has an >> incoming value that will always trigger undefined behavior. This basically >> modifies the CFG and combines the b

[PATCH] D124091: [clang][AArch64][SVE] Implement conditional operator for SVE vectors

DavidTruby updated this revision to Diff 425541. DavidTruby added a comment. Fix crash where condition and splatted result don't have the same width Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124091/new/ https://reviews.llvm.org/D124091 Files:

[PATCH] D123958: [randstruct] Randomize all elements of a record

aaron.ballman added a comment. Can you also add a test specifically for an enumeration declaration, as that was something we found bugs with? Comment at: clang/lib/AST/Randstruct.cpp:201 +dyn_cast(RandomizedFields.back()->getType())) + if (CA->getSize().sle(2)

[PATCH] D124158: [Clang][Attr] Skip adding noundef attribute to arguments when function has convergent attribute

efriedma added a comment. The issue you're describing sounds like it's specific to @__shfl_sync. In general, in C++, you aren't allowed to read from an uninitialized variable; see [basic.indet] in the standard. But if your testcase doesn't have undefined behavior, CUDA language rules must som

[PATCH] D124536: [AMDGPU] Add gfx11 subtarget ELF definition

Joe_Nash created this revision. Herald added subscribers: hsmhsm, foad, dexonsmith, kerbowa, rupprecht, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl, emaste, arsenm. Herald added a reviewer: jhenderson. Herald added a project: All. Joe_Nash requested review of this revisi

[PATCH] D124537: [AMDGPU][clang] Definition of gfx11 subtarget

Joe_Nash created this revision. Herald added subscribers: mattd, gchakrabarti, asavonic, dexonsmith, kerbowa, t-tye, tpr, dstuttard, yaxunl, jvesely, kzhuravl, jholewinski. Herald added a project: All. Joe_Nash requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald

[PATCH] D124341: [clang-tidy][NFC] Replace many instances of std::string where a StringRef would suffice.

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp:51 ClangTidyContext *Context) -: NamePrefix(CheckName.str() + "."), CheckOptions(CheckOptions), +: NamePrefix((CheckName + ".").str()), CheckOptions(CheckOptions),

[PATCH] D124537: [AMDGPU][clang] Definition of gfx11 subtarget

b-sumner added a comment. t-tye should review this too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124537/new/ https://reviews.llvm.org/D124537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D124540: [clang][dataflow] Perform structural comparison of indirection values in `join`.

ymandel created this revision. ymandel added reviewers: xazax.hun, sgatev. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. This patch changes `Environment::join`, in the case that two val

[PATCH] D124532: [AST] Improve traversal of concept requirements

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124532/new/ https://reviews.llvm.org/D124532

[PATCH] D124435: [X86] Always extend the integer parameters in callee

rjmccall added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:1938 +return IsConservativeExtend ? ABIArgInfo::getConservativeExtend(Ty) +: ABIArgInfo::getExtend(Ty); } LiuChen3 wrote: > rjmccall wrote: > > Liu

[PATCH] D124487: [HLSL] Adjust access specifier behavior

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1603 +def ext_hlsl_access_specifiers : ExtWarn< + "access specifiers are a clang HLSL extension">; This also needs to go into a warning group.

[PATCH] D124373: [clang] add parameter pack/pack expansion matchers

aaron.ballman added a comment. Due to how expensive it is to instantiate all the templates from ASTMatchers.h, we typically don't add new matchers unless there's a need for them in-tree or they're expected to be generally useful to a number of out-of-tree matchers. Are you planning to make use

[PATCH] D124461: [Analyzer] Remove undefined function

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124461/new/ https://reviews.llvm.org/D124461 ___ cf

[PATCH] D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

aaron.ballman added a comment. In D122920#3476388 , @yihanaa wrote: > In D122920#3472379 , @asoffer wrote: > >> In D122920#3471865 , @yihanaa >> wrote: >> >>> In D122920#

[clang] 2d0c897 - [Driver] Support for compressed debug info on Fuchsia

Author: Petr Hosek Date: 2022-04-27T11:24:41-07:00 New Revision: 2d0c897212d0551966b26eae986209ea31c4f032 URL: https://github.com/llvm/llvm-project/commit/2d0c897212d0551966b26eae986209ea31c4f032 DIFF: https://github.com/llvm/llvm-project/commit/2d0c897212d0551966b26eae986209ea31c4f032.diff LO

[PATCH] D124545: [HIP] Add HIP runtime library arguments for linker

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: MaskRay. Add -L -l options for linker. https://reviews.llvm.org/D124545 Files: clang/include/clang/Driver/Options.td clang/include/cl

[clang] 82aa5e2 - Revert "[Driver] Support for compressed debug info on Fuchsia"

Author: Petr Hosek Date: 2022-04-27T11:41:41-07:00 New Revision: 82aa5e2c6fe9ffbd637d421a799deffa0d90d7bf URL: https://github.com/llvm/llvm-project/commit/82aa5e2c6fe9ffbd637d421a799deffa0d90d7bf DIFF: https://github.com/llvm/llvm-project/commit/82aa5e2c6fe9ffbd637d421a799deffa0d90d7bf.diff LO

[PATCH] D114115: [Driver] Support for compressed debug info on Fuchsia

dyung added a comment. I think the problem here is that if zlib is not available, you won't get the clang command line you expect: https://lab.llvm.org/buildbot/#/builders/216/builds/3519 Input was: << 1: clang version 15.0.0 (https://github.com/llvm/llvm-project.git 2d

[PATCH] D124534: Add a warning diagnostic for line directive of a gnu extension

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. Thank you for working on this new diagnostic! Comment at: clang-tools-extra/test/clang-apply-replacements/Inputs/crlf/crlf.cpp:1 - -// This file intentionally uses a CRLF newlines! - -void foo() { -

[PATCH] D124545: [HIP] Add HIP runtime library arguments for linker

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:681 + ArgStringList &CmdArgs) const { + CmdArgs.push_back( + Args.MakeArgString(StringRe

[PATCH] D124545: [HIP] Add HIP runtime library arguments for linker

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:681 + ArgStringList &CmdArgs) const { + CmdArgs.push_back( + Args.MakeArgString(StringRef("-L") + RocmInstallation.getLib

[PATCH] D114115: [Driver] Support for compressed debug info on Fuchsia

probinson added a comment. Lit is aware of zlib's presence or absence, you could use `REQUIRES: zlib` (or you might factor that bit out into its own test with the REQUIRES). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114115/new/ https://reviews

[PATCH] D124220: [OpenMP] Add options to only compile the host or device when offloading

tra added inline comments. Comment at: clang/include/clang/Driver/Options.td:2527 HelpText<"Use the static host OpenMP runtime while linking.">; +def offload_device_only : Flag<["-"], "offload-device-only">, + HelpText<"Only compile for the offloading device.">; -

[PATCH] D124221: Add new builtin __builtin_reflect_struct.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:420 +auto *FD = IFD ? IFD->getAnonField() : dyn_cast(D); +if (!FD || (FD->isUnnamedBitfield() || FD->isAnonymousStructOrUnion())) + continue; rsmith wrote: > yihanaa wro

[PATCH] D124373: [clang] add parameter pack/pack expansion matchers

upsj added a comment. This is part of my long-term goal to add support for forwarding parameters and documentation for make_unique-like functions to clangd. To be fair, the details are not entirely fleshed out - for inlay hints (displaying parameter names inline), the entire function template i

[PATCH] D124220: [OpenMP] Add options to only compile the host or device when offloading

jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4215 Action *HostAction) const { - if (!isa(HostAction)) + if (Args.hasArg(options::OPT_offload_host_only)) return HostAction; tra wrote: > jhube

[clang] 5e096ce - Update PGO and 3-stage cache files

Author: Chris Bieneman Date: 2022-04-27T14:41:56-05:00 New Revision: 5e096ce6c84fe80a15158dd10d3a23fb7135aa6d URL: https://github.com/llvm/llvm-project/commit/5e096ce6c84fe80a15158dd10d3a23fb7135aa6d DIFF: https://github.com/llvm/llvm-project/commit/5e096ce6c84fe80a15158dd10d3a23fb7135aa6d.diff

[PATCH] D124373: [clang] add parameter pack/pack expansion matchers

aaron.ballman added a comment. In D124373#3477996 , @upsj wrote: > This is part of my long-term goal to add support for forwarding parameters > and documentation for make_unique-like functions to clangd. To be fair, the > details are not entirely fleshe

[PATCH] D124373: [clang] add parameter pack/pack expansion matchers

upsj planned changes to this revision. upsj added a comment. I wasn't aware of that, sounds perfect, thanks! Then I'll put this on hold until I figure out if it's really necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124373/new/ https://

[PATCH] D123958: [randstruct] Randomize all elements of a record

void updated this revision to Diff 425593. void marked 2 inline comments as done. void added a comment. Add a few more tests and remove a dead check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123958/new/ https://reviews.llvm.org/D123958 Files:

[PATCH] D123958: [randstruct] Randomize all elements of a record

void added inline comments. Comment at: clang/lib/AST/Randstruct.cpp:201 +dyn_cast(RandomizedFields.back()->getType())) + if (CA->getSize().sle(2) || CA->isIncompleteArrayType()) +FlexibleArray = RandomizedFields.pop_back_val(); aaron.bal

[PATCH] D124551: [Driver] Add f16 support to -mrecip parsing.

craig.topper created this revision. craig.topper added reviewers: spatel, efriedma, RKSimon. Herald added a subscriber: StephenFan. Herald added a project: All. craig.topper requested review of this revision. Herald added a subscriber: MaskRay. Herald added a project: clang. This is a followup to

[PATCH] D123958: [randstruct] Randomize all elements of a record

void updated this revision to Diff 425595. void added a comment. Fix test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123958/new/ https://reviews.llvm.org/D123958 Files: clang/include/clang/AST/Decl.h clang/include/clang/AST/Randstruct.h

[PATCH] D95063: AMDGPU: Use optimization remarks for register usage

arsenm abandoned this revision. arsenm added a comment. Herald added subscribers: hsmhsm, foad. Herald added a project: All. Obsoleted by D123878 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95063/new/ https://reviews.llvm.org/D95063

[clang] fd0e60d - [PS5] Test sanitizer options/lib names

Author: Paul Robinson Date: 2022-04-27T13:45:41-07:00 New Revision: fd0e60d7874363a641e35a862b05d8dfabab77ef URL: https://github.com/llvm/llvm-project/commit/fd0e60d7874363a641e35a862b05d8dfabab77ef DIFF: https://github.com/llvm/llvm-project/commit/fd0e60d7874363a641e35a862b05d8dfabab77ef.diff

[PATCH] D124534: Add a warning diagnostic for line directive of a gnu extension

ken-matsui updated this revision to Diff 425601. ken-matsui added a comment. Add a diagnostic for line directive of a gnu extension Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124534/new/ https://reviews.llvm.org/D124534 Files: clang/include/c

[PATCH] D124534: Add a warning diagnostic for line directive of a gnu extension

ken-matsui added a comment. Hi @aaron.ballman, Thank you for your review! I updated the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124534/new/ https://reviews.llvm.org/D124534 ___ cfe-commits m

[PATCH] D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON

beanz added a comment. I posted a PR to swift that migrates build-script to use `LLVM_ENABLE_RUNTIMES`: https://github.com/apple/swift/pull/58465 Obviously I can't test this against your internal infrastructure, but the change here is pretty trivial. Repository: rG LLVM Github Monorepo CHA

[PATCH] D124556: Prevent shadowing a variable declared in `if`

ken-matsui created this revision. Herald added a project: All. ken-matsui requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D124556 Files: clang/lib/Basic/Diagnostic.cpp Ind

  1   2   >