steakhal added a comment.
Although gcc (and probably clang too) allows specifying
`__attribute__((noinline))` at any declaration (by merging //compatible//
attributes), I would prefer not to repeat ourselves.
The attribute must be present at the header to force all usages not to inline
it, hence I would rather drop such attributes from the definition files.
Aside from that, looks good. Please update the summary of this patch
accordingly.
================
Comment at: clang/lib/StaticAnalyzer/Checkers/Taint.cpp:40
-void dumpTaint(ProgramStateRef State) { printTaint(State, llvm::errs()); }
+LLVM_DUMP_METHOD void taint::dumpTaint(ProgramStateRef State) {
+ printTaint(State, llvm::errs());
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124462/new/
https://reviews.llvm.org/D124462
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
