[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 423645. jhuber6 added a comment. Herald added a subscriber: mattd. Adding new test for CUDA phases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120272/new/ https://reviews.llvm.org/D120272 Files: clang/inc

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 added a comment. In D123325#3459108 , @yaxunl wrote: > should we have a test to show the effect of -foffload-new-driver on > -ccc-print-phases for CUDA/HIP? I decided to add the test in D120272 because this fi

[PATCH] D123961: [clang][dataflow] Do not crash on missing `Value` for struct-typed variable init.

xazax.hun accepted this revision. xazax.hun added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:184-186 - // FIXME: The initializer expression must always be assigned a value. - // Replace thi

[PATCH] D121838: Generalize "check-all" umbrella targets, use for check-clang-tools

sammccall updated this revision to Diff 423648. sammccall marked 5 inline comments as done. sammccall added a comment. Herald added projects: Sanitizers, libc++, libc++abi. Herald added subscribers: libcxx-commits, Sanitizers. Herald added a reviewer: libc++. Herald added a reviewer: libc++abi. Thi

[PATCH] D123889: [clang-tidy] Improve macro handling in modernize-macro-to-enum

LegalizeAdulthood marked 2 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:235 SmallVector Files; + std::vector ExpressionNames; FileState *CurrentFile = nullptr; aar

[PATCH] D124012: [Clang] Fix references to captured variables in dependant context.

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D119136 changed how captures are handled in a lambda call operator declaration, but di

[PATCH] D123961: [clang][dataflow] Do not crash on missing `Value` for struct-typed variable init.

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:184-186 - // FIXME: The initializer expression must always be assigned a value. - // Replace this with an assert when we have sufficient coverage of -

[PATCH] D124013: [clangd] Dont include version string in update tasks

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman, javed.absar. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-too

[PATCH] D124012: [Clang] Fix references to captured variables in dependant context.

cor3ntin updated this revision to Diff 423653. cor3ntin added a comment. Remove some whitespace only changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124012/new/ https://reviews.llvm.org/D124012 Files: clang/include/clang/Sema/Sema.h cla

[PATCH] D123889: [clang-tidy] Improve macro handling in modernize-macro-to-enum

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Thank you for the fix! Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:235 SmallVector Files; + std::vector ExpressionNames;

[PATCH] D124012: [Clang] Fix references to captured variables in dependant context.

cor3ntin updated this revision to Diff 423656. cor3ntin added a comment. Fix whitespace changes (again) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124012/new/ https://reviews.llvm.org/D124012 Files: clang/include/clang/Sema/Sema.h clang/lib

[PATCH] D123907: [HLSL] Add shader attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123907/new/ https://reviews.llvm.org/D123907

[PATCH] D124012: [Clang] Fix references to captured variables in dependant context.

cor3ntin updated this revision to Diff 423657. cor3ntin added a comment. More cleanups and formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124012/new/ https://reviews.llvm.org/D124012 Files: clang/include/clang/Sema/Sema.h clang/lib/

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae added a comment. Thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123907/new/ https://reviews.llvm.org/D123907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D123831: [POC][WIP] Use relative include in extract-api

ributzka added a comment. In D123831#3458774 , @dang wrote: > In D123831#3455048 , @cishida wrote: > >>> we might not always want to transform an absolute path because the >>> resulting relative include name migh

[PATCH] D124004: Define __FLT_EVAL_METHOD__ when input source is stdin.

aaron.ballman added inline comments. Comment at: clang/lib/Frontend/FrontendAction.cpp:845-855 + if (Input.isFile() && Input.getFile() == "-") { +Preprocessor &PP = CI.getPreprocessor(); +std::string PredefineBuffer; +PredefineBuffer.reserve(4080); +llvm::raw_str

[PATCH] D123313: [OpenMP] Make clang argument handling for the new driver more generic

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6949-6952 +CmdArgs.push_back(Args.MakeArgString( +"-fembed-offload-object=" + File + "," + +Action::GetOffloadKindName(OffloadAction->getOffloadingDeviceKind()) + +"," + TC

[PATCH] D123313: [OpenMP] Make clang argument handling for the new driver more generic

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6949-6952 +CmdArgs.push_back(Args.MakeArgString( +"-fembed-offload-object=" + File + "," + +Action::GetOffloadKindName(OffloadAction->getOffloadingDeviceKind()) + +"," + T

[PATCH] D124004: Define __FLT_EVAL_METHOD__ when input source is stdin.

zahiraam added a subscriber: glandium. zahiraam added inline comments. Comment at: clang/lib/Frontend/FrontendAction.cpp:845-855 + if (Input.isFile() && Input.getFile() == "-") { +Preprocessor &PP = CI.getPreprocessor(); +std::string PredefineBuffer; +PredefineBuffer

[PATCH] D124012: [Clang] Fix references to captured variables in dependant context.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:539-546 void Sema::buildLambdaScope(LambdaScopeInfo *LSI, CXXMethodDecl *CallOperator, SourceRange IntroducerRange, LambdaCaptureDefault Captu

[PATCH] D123313: [OpenMP] Make clang argument handling for the new driver more generic

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6949-6952 +CmdArgs.push_back(Args.MakeArgString( +"-fembed-offload-object=" + File + "," + +Action::GetOffloadKindName(OffloadAction->getOffloadingDeviceKind()) + +"," + TC

[PATCH] D122734: [CUDA][HIP] Fix mangling number for local struct

rnk added inline comments. Herald added a subscriber: mattd. Comment at: clang/include/clang/AST/ASTContext.h:682 +/// Current name mangling is for device name in host compilation. +bool MangleDeviceNameInHostCompilation = false; + } CUDANameMangleCtx; I

[PATCH] D124004: Define __FLT_EVAL_METHOD__ when input source is stdin.

aaron.ballman added inline comments. Comment at: clang/lib/Frontend/FrontendAction.cpp:845-855 + if (Input.isFile() && Input.getFile() == "-") { +Preprocessor &PP = CI.getPreprocessor(); +std::string PredefineBuffer; +PredefineBuffer.reserve(4080); +llvm::raw_str

[clang-tools-extra] 1aa3a54 - [clangd] Dont include version string in update tasks

Author: Kadir Cetinkaya Date: 2022-04-19T19:27:04+02:00 New Revision: 1aa3a54921a1e6bb43ff14c072b9129aa78d6988 URL: https://github.com/llvm/llvm-project/commit/1aa3a54921a1e6bb43ff14c072b9129aa78d6988 DIFF: https://github.com/llvm/llvm-project/commit/1aa3a54921a1e6bb43ff14c072b9129aa78d6988.dif

[PATCH] D124013: [clangd] Dont include version string in update tasks

This revision was automatically updated to reflect the committed changes. Closed by commit rG1aa3a54921a1: [clangd] Dont include version string in update tasks (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124013/new/ https:/

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

tra added a comment. Thank you for adding the compilation pipeline tests. LGTM overall. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6223-6226 if (Args.hasFlag(options::OPT_fgpu_rdc, options::OPT_fno_gpu_rdc, false)) CmdArgs.push_back("-fgpu-rdc"); +if (Ar

[PATCH] D124012: [Clang] Fix references to captured variables in dependant context.

cor3ntin updated this revision to Diff 423671. cor3ntin added a comment. - Get rid of buildLambdaScopeCaptures - Set the call operator inner loc in CompleteLambdaCallOperator (+ tests) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124012/new/ htt

[PATCH] D124012: [Clang] Fix references to captured variables in dependant context.

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:1378-1383 + CompleteLambdaCallOperator( + Method, Intro.Range.getBegin(), ParamInfo.getTrailingRequiresClause(), + MethodTyInfo, ParamInfo.getDeclSpec().getConstexprSpecifier(), Params, + Ex

[PATCH] D123009: [Sema] Enum conversion warning when one signed and other unsigned.

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Thank you for working on this, and for your patience -- this review fell off my radar for a bit, sorry about that! I think there's an issue here to be solved, but I'm n

[PATCH] D124012: [Clang] Fix references to captured variables in dependant context.

cor3ntin marked an inline comment as done. cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:539-546 void Sema::buildLambdaScope(LambdaScopeInfo *LSI, CXXMethodDecl *CallOperator, SourceRange IntroducerRange,

[PATCH] D124004: Define __FLT_EVAL_METHOD__ when input source is stdin.

zahiraam added inline comments. Comment at: clang/lib/Frontend/FrontendAction.cpp:845-855 + if (Input.isFile() && Input.getFile() == "-") { +Preprocessor &PP = CI.getPreprocessor(); +std::string PredefineBuffer; +PredefineBuffer.reserve(4080); +llvm::raw_string_o

[PATCH] D123957: Update the developer policy to mention release notes

lattner added a comment. This is awesome, I agree completely we should curate release notes better. That said, I think this should make it more clear that there is a "difference in kind" between user-facing tools like clang/lldb etc and other libraries in LLVM. We don't want release note burd

[PATCH] D123957: Update the developer policy to mention release notes

lattner added a comment. Also, when this lands, we should post on the forum about it. Every change to the developer policy warrants broader visibility than just a phab discussion IMO. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123957/new/ https://reviews.llvm.org/D123957

[PATCH] D123926: [clang] Add a raw_ostream operator<< overload for QualType

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thanks for this! LGTM with some small nits. Comment at: clang/include/clang/AST/Type.h:1319 +llvm::raw_ostream &operator<<(llvm::raw_ostream &OS, const clang:

[PATCH] D124012: [Clang] Fix references to captured variables in dependant context.

cor3ntin updated this revision to Diff 423675. cor3ntin marked an inline comment as done. cor3ntin added a comment. Remove `startLambdaDefinition` which is no longer used Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124012/new/ https://reviews.llv

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts

stevewan added a comment. I don't think the redirect files portion of this patch is well-described in the description, could you please add it? Comment at: clang/lib/Driver/ToolChains/AIX.cpp:80 +static bool hasExportListLinkerOpts(const ArgStringList &CmdArgs) { + for (size_

[PATCH] D123957: Update the developer policy to mention release notes

aaron.ballman added a comment. In D123957#3459557 , @lattner wrote: > This is awesome, I agree completely we should curate release notes better. > That said, I think this should make it more clear that there is a "difference > in kind" between user-fac

[PATCH] D123958: [randstruct] Randomize all elements of a record

kees added a comment. In D123958#3459205 , @aaron.ballman wrote: > I had assumed that any structure not marked for randomization would not be > randomized. Based on that, I don't think inner structure objects (anonymous > or otherwise) should automatic

[PATCH] D123858: [clang][dataflow] Ensure well-formed flow conditions.

ymandel updated this revision to Diff 423682. ymandel added a comment. address comments; move tests to proper locations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123858/new/ https://reviews.llvm.org/D123858 Files: clang/lib/Analysis/FlowSens

[PATCH] D124026: [Headers][MSVC] Define wchar_t in stddef.h like MSVC if not using the builtin type

steplong created this revision. steplong added reviewers: rnk, efriedma. Herald added a project: All. steplong requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. MSVC expects wchar_t to be defined in stddef.h if /Zc:wchar_t- is specified Rep

[PATCH] D123957: Update the developer policy to mention release notes

aaron.ballman updated this revision to Diff 423683. aaron.ballman marked 3 inline comments as done. aaron.ballman added a comment. Updated based on review feedback. - Made it more clear that adding a release note is discretionary rather than mandatory - Clarified that bug fix release notes shoul

[PATCH] D124004: Define __FLT_EVAL_METHOD__ when input source is stdin.

aaron.ballman added inline comments. Comment at: clang/lib/Frontend/FrontendAction.cpp:845-855 + if (Input.isFile() && Input.getFile() == "-") { +Preprocessor &PP = CI.getPreprocessor(); +std::string PredefineBuffer; +PredefineBuffer.reserve(4080); +llvm::raw_str

[PATCH] D123858: [clang][dataflow] Ensure well-formed flow conditions.

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:123-136 + } else if (auto *CondVal = cast_or_null( + Env.getValue(Cond, SkipPast::None))) { +Env.

[PATCH] D123858: [clang][dataflow] Ensure well-formed flow conditions.

xazax.hun accepted this revision. xazax.hun added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:110 +// FIXME: The flow condition must be an r-value, so `SkipPast::None` should +

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 423685. jhuber6 added a comment. Making suggested changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120272/new/ https://reviews.llvm.org/D120272 Files: clang/include/clang/Basic/Cuda.h clang/lib/Drive

[PATCH] D123775: [AST] Support template declaration found through using-decl for QualifiedTemplateName.

hokein updated this revision to Diff 423686. hokein marked 6 inline comments as done. hokein added a comment. expose underlying template name, removed the getUsingShadowDecl; address comments; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123775/new

[PATCH] D121838: Generalize "check-all" umbrella targets, use for check-clang-tools

sammccall added inline comments. Comment at: llvm/cmake/modules/AddLLVM.cmake:1876 +get_property(gather_names GLOBAL PROPERTY LLVM_LIT_UMBRELLAS) +set_property(GLOBAL APPEND PROPERTY LLVM_LIT_UMBRELLAS ${name}) +foreach(name ${gather_names}) hokein wr

[PATCH] D122734: [CUDA][HIP] Fix mangling number for local struct

tra added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:11760-11763 + auto Cutoff = [](unsigned V) { return V > 1 ? V : 1; }; + if (CUDANameMangleCtx.MangleDeviceNameInHostCompilation) +return Cutoff(Res >> 16); + return Cutoff(Res & 0x); r

[PATCH] D124006: [DebugInfo] Use the 'getTypeAlignIfRequired' function to get DW_AT_alignment correct when attribute((__aligned__)) is present.

dblaikie added a comment. Could you include some static_asserts(+alignof) in the test case to demonstrate these are the alignments that the language is computing too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124006/new/ https://reviews.llvm.o

[PATCH] D124012: [Clang] Fix references to captured variables in dependant context.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but please wait a bit before landing so other reviewers have time to weigh in (should be fine to land tomorrow sometime if you don't hear back). Comment

[PATCH] D123775: [AST] Support template declaration found through using-decl for QualifiedTemplateName.

hokein updated this revision to Diff 423687. hokein added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123775/new/ https://reviews.llvm.org/D123775 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Properti

[PATCH] D123775: [AST] Support template declaration found through using-decl for QualifiedTemplateName.

hokein added inline comments. Comment at: clang/include/clang/AST/PropertiesBase.td:666 } - def : Property<"declaration", TemplateDeclRef> { + def : Property<"templateDecl", TemplateDeclRef> { let Read = [{ qtn->getTemplateDecl() }]; sammccall wrote: >

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

alanphipps added a comment. We've also been seeing failures in our downstream Arm compiler when running the Perennial C++14 compliance tests related to this change. Specifically, the tests expect a diagnostic to be issued when the lambda capture variable is outside of the lambda's {} scope. An

[PATCH] D123858: [clang][dataflow] Ensure well-formed flow conditions.

ymandel updated this revision to Diff 423690. ymandel added a comment. add comments to tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123858/new/ https://reviews.llvm.org/D123858 Files: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAn

[PATCH] D123775: [AST] Support template declaration found through using-decl for QualifiedTemplateName.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/ASTImporter.cpp:9189 +TemplateName UnderlyingTN = QTN->getUnderlyingTemplate(); +if (UsingShadowDecl *USD = UnderlyingTN.getAsUsin

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin added a comment. In D119136#3457027 , @rtrieu wrote: > This seems to be acting weird in template instantations. Here's an example > where the lambda only errors inside a template. Thanks for notifying me of that. I will land a fix shortly ht

[PATCH] D123858: [clang][dataflow] Ensure well-formed flow conditions.

ymandel updated this revision to Diff 423693. ymandel marked 2 inline comments as done. ymandel added a comment. added fixme Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123858/new/ https://reviews.llvm.org/D123858 Files: clang/lib/Analysis/Flo

[PATCH] D123858: [clang][dataflow] Ensure well-formed flow conditions.

ymandel added a comment. Thanks for the review! Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:110 +// FIXME: The flow condition must be an r-value, so `SkipPast::None` should +// suffice. xazax.hun wrote: > I am still not

[PATCH] D124004: Define __FLT_EVAL_METHOD__ when input source is stdin.

zahiraam added inline comments. Comment at: clang/lib/Frontend/FrontendAction.cpp:845-855 + if (Input.isFile() && Input.getFile() == "-") { +Preprocessor &PP = CI.getPreprocessor(); +std::string PredefineBuffer; +PredefineBuffer.reserve(4080); +llvm::raw_string_o

[clang] 800f263 - [CUDA][HIP] Fix delete operator for -fopenmp

Author: Yaxun (Sam) Liu Date: 2022-04-19T14:28:03-04:00 New Revision: 800f26386cd9054ceed68e481612908f635b9718 URL: https://github.com/llvm/llvm-project/commit/800f26386cd9054ceed68e481612908f635b9718 DIFF: https://github.com/llvm/llvm-project/commit/800f26386cd9054ceed68e481612908f635b9718.dif

[PATCH] D123976: [CUDA][HIP] Fix delete operator for -fopenmp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG800f26386cd9: [CUDA][HIP] Fix delete operator for -fopenmp (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorep

[PATCH] D121838: Generalize "check-all" umbrella targets, use for check-clang-tools

sammccall added 1 blocking reviewer(s): ldionne. sammccall added a comment. The changes to runtimes/ are mostly mechanical, but Herald says I'm supposed to get a review :-) @ldionne, @phosek, looks like this touches the same bits from D121276 , WDYT? Repositor

[PATCH] D124032: [COFF, ARM64] Add __break intrinsic

pzheng created this revision. pzheng added reviewers: rnk, mstorsjo, efriedma. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. pzheng requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. https:/

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

Mordante added a comment. In D123182#3458712 , @royjacobson wrote: > So, it seems like this broke one of `basic_arg_format`'s private > constructors.. Sorry for that. > > This is now ambiguous when calling `basic_format_arg(char)` because the > argumen

[PATCH] D123957: Update the developer policy to mention release notes

nikic accepted this revision. nikic added inline comments. This revision is now accepted and ready to land. Comment at: llvm/docs/DeveloperPolicy.rst:195 +* Adding, removing, or regrouping a diagnostic. +* Fixing a bug (please link to the issue fixed in the bug database). +* Addi

[PATCH] D124033: [NFC] Adding a note about the macro __FLT_EVAL_METHOD__

zahiraam created this revision. zahiraam added a reviewer: aaron.ballman. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. This is to clarify that the macro __FLT_EVAL_METHOD__ it is not pre-defined like other preprocessor macros. It will

[PATCH] D123957: Update the developer policy to mention release notes

xbolva00 added a comment. Can you please add link to RFC to commit message? Otherwise looks good CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123957/new/ https://reviews.llvm.org/D123957 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane added a comment. FWIW, I am about 95% sure I have a hold on this, plus a bunch of other cases I came up with. I likely won't get a patch up for review today (in the next hour!) unless something miraculous happens, but hopefully I'll have something tomorrow for folks to take another

[clang] e37726b - [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions.

Author: Denys Petrov Date: 2022-04-19T22:34:03+03:00 New Revision: e37726beb22a8e3865e1f6fcdbb5cd4262786903 URL: https://github.com/llvm/llvm-project/commit/e37726beb22a8e3865e1f6fcdbb5cd4262786903 DIFF: https://github.com/llvm/llvm-project/commit/e37726beb22a8e3865e1f6fcdbb5cd4262786903.diff

[PATCH] D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe37726beb22a: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions… (authored by ASDenysPetrov). Changed prior to commit

[PATCH] D123957: Update the developer policy to mention release notes

tschuett added a comment. LGTM and thanks. Feel free to ignore my comment. Maybe sort entries by importance. I have problems reading longish texts and documents. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123957/new/ https://reviews.llvm.org/D123957 ___

[PATCH] D123955: [C2x] Disallow functions without prototypes/functions with identifier lists

rsmith accepted this revision. rsmith added a comment. LGTM. Some comments for potential improvements, but I'd be OK with this landing as-is if you don't find any of them sufficiently motivating :) Comment at: clang/lib/Parse/ParseDecl.cpp:6664- +// OpenCL disallows va

[PATCH] D124032: [COFF, ARM64] Add __break intrinsic

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124032/new/ https://reviews.llvm.org/D124032 ___ cfe-c

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present for all archs

int3 added a comment. This is ready for review, please take a look 🙏 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122258/new/ https://reviews.llvm.org/D122258 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM; two non-blocking comments and a question. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:420-422 +def ext_implicit_function_decl_c99 : ExtWarn< + "implic

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane updated this revision to Diff 423713. erichkeane added a comment. Herald added a subscriber: martong. Herald added a reviewer: shafik. Fixed the issue that Corentin's test came up with, added a number of others. The problem is that we didn't properly 'collect' the parameters in cases w

[PATCH] D124036: [clang-format] Don't skip PP lines if original line was a PP line when trying to merge lines

aeubanks created this revision. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes a crash introduced in D123737 where LastNonComment would be null. Repository:

[PATCH] D124036: [clang-format] Don't skip PP lines if original line was a PP line when trying to merge lines

aeubanks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:13397 + + verifyFormat("//\n" + "#define a \\\n" not sure if you'd like a better test, this was the reduced test case I got that still caused a crash Repository:

[clang] c57f034 - [clang][Sema] Add flag to LookupName to force C/ObjC codepath

Author: Alex Langford Date: 2022-04-19T12:57:14-07:00 New Revision: c57f03415f9668f942802ff7108410d57c2b10da URL: https://github.com/llvm/llvm-project/commit/c57f03415f9668f942802ff7108410d57c2b10da DIFF: https://github.com/llvm/llvm-project/commit/c57f03415f9668f942802ff7108410d57c2b10da.diff

[PATCH] D122691: [clang][Sema] Add flag to LookupName to force C/ObjC codepath

bulbazord closed this revision. bulbazord added a comment. Gah, forgot to add the phabricator link to the commit message. I added the commit object to this diff, hopefully people can track it down the review if needed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122691/new/ https://

[PATCH] D124032: [COFF, ARM64] Add __break intrinsic

mstorsjo added a comment. Should there be tests for the LLVM side of this too, not only on the clang side? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124032/new/ https://reviews.llvm.org/D124032 ___ c

[PATCH] D124038: [clang] Prevent folding of non-const compound expr

serge-sans-paille created this revision. serge-sans-paille added a reviewer: aaron.ballman. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When a non-const compound statement is used to initia

[PATCH] D123957: Update the developer policy to mention release notes

lattner accepted this revision. lattner added a comment. Nice, LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123957/new/ https://reviews.llvm.org/D123957 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

jhuber6 created this revision. jhuber6 added reviewers: yaxunl, JonChesterfield, jdoerfert, tianshilei1992. Herald added a subscriber: guansong. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. T

[PATCH] D123961: [clang][dataflow] Do not crash on missing `Value` for struct-typed variable init.

ymandel updated this revision to Diff 423724. ymandel added a comment. extended comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123961/new/ https://reviews.llvm.org/D123961 Files: clang/lib/Analysis/FlowSensitive/Transfer.cpp clang/uni

[PATCH] D124040: Basic Support for otherwise clause

abidmalikwaterloo created this revision. Herald added a project: All. abidmalikwaterloo requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. The patch provides otherwise support in

[clang] eb2131b - [clang][dataflow] Do not crash on missing `Value` for struct-typed variable init.

Author: Yitzhak Mandelbaum Date: 2022-04-19T20:52:29Z New Revision: eb2131bdbad3f74be2fcf236b4d6921612af47a9 URL: https://github.com/llvm/llvm-project/commit/eb2131bdbad3f74be2fcf236b4d6921612af47a9 DIFF: https://github.com/llvm/llvm-project/commit/eb2131bdbad3f74be2fcf236b4d6921612af47a9.diff

[PATCH] D123961: [clang][dataflow] Do not crash on missing `Value` for struct-typed variable init.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb2131bdbad3: [clang][dataflow] Do not crash on missing `Value` for struct-typed variable… (authored by ymandel). Repository: rG LLVM Github Monor

[PATCH] D123544: [randstruct] Automatically randomize a structure of function pointers

kees added a comment. I tested this (with D123958 ), and it appears to be working as intended. These two fptrs are the first and second listed, and are happily randomized: [0.00] LSM: offsetof(struct security_hook_heads, ptrace_access_check): 816 [

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

tejohnson added a comment. lgtm if you are waiting for a re-review. As noted in my previous comment, you have added a little bit of unnecessary checking at the lower end with your new clamp function, since it is an unsigned value and can never go below 0. But it isn't a big deal if you prefer t

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

paulkirth added a comment. Ah, thanks. I've had to try to re-land this so many times, I wanted to be sure the pre-submit was looking OK after rebasing. or at least be sure it didn't look like it was failing from any of my changes. w.r.t. `clamp`, keeping it compatible was my intent. Repositor

[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Nice! I like the strategy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124039/new/ https://reviews.llvm.org/D124039 ___

[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

jhuber6 updated this revision to Diff 423743. jhuber6 added a comment. Fix test on Windows failing because of ".exe" at the end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124039/new/ https://reviews.llvm.org/D124039 Files: clang/test/Driver/

[clang] 63814be - [modules] Merge variable template specializations.

Author: Richard Smith Date: 2022-04-19T14:48:42-07:00 New Revision: 63814be4fa23ef9b36cf2d14388c7f6ba591d3b6 URL: https://github.com/llvm/llvm-project/commit/63814be4fa23ef9b36cf2d14388c7f6ba591d3b6 DIFF: https://github.com/llvm/llvm-project/commit/63814be4fa23ef9b36cf2d14388c7f6ba591d3b6.diff

[clang] e3cf153 - [Driver][test] Remove unneeded clang from -cc1 CHECK lines

Author: Fangrui Song Date: 2022-04-19T14:58:48-07:00 New Revision: e3cf1535220128ed9e7c3ba77cc074318461302d URL: https://github.com/llvm/llvm-project/commit/e3cf1535220128ed9e7c3ba77cc074318461302d DIFF: https://github.com/llvm/llvm-project/commit/e3cf1535220128ed9e7c3ba77cc074318461302d.diff

[PATCH] D119296: KCFI sanitizer

samitolvanen updated this revision to Diff 423748. samitolvanen marked 12 inline comments as done. samitolvanen added a comment. Addressed Nick's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119296/new/ https://reviews.llvm.org/D119296

[PATCH] D119296: KCFI sanitizer

samitolvanen added a comment. In D119296#3457740 , @nickdesaulniers wrote: > Please add a test where calls to `@llvm.kcfi.check` produce `KCFI_CHECK` > during instruction selection. (You can use `-stop-before=finalize-isel` to > dump the IR prior to is

[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

This revision was automatically updated to reflect the committed changes. Closed by commit rG260c5df2d52b: [OpenMP] Add better testing for the linker wrapper (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124039/new/ https://re

[clang] 260c5df - [OpenMP] Add better testing for the linker wrapper

Author: Joseph Huber Date: 2022-04-19T18:37:09-04:00 New Revision: 260c5df2d52b67751f9ed33fde1b453c53f44f88 URL: https://github.com/llvm/llvm-project/commit/260c5df2d52b67751f9ed33fde1b453c53f44f88 DIFF: https://github.com/llvm/llvm-project/commit/260c5df2d52b67751f9ed33fde1b453c53f44f88.diff

[clang] dbb10f7 - [OpenMP] Fix deleted move constructor failing on some compiles

Author: Joseph Huber Date: 2022-04-19T18:40:15-04:00 New Revision: dbb10f7097dd357557b7b1976ff0b47c5627141b URL: https://github.com/llvm/llvm-project/commit/dbb10f7097dd357557b7b1976ff0b47c5627141b DIFF: https://github.com/llvm/llvm-project/commit/dbb10f7097dd357557b7b1976ff0b47c5627141b.diff

<    1   2   3   >