Author: Kadir Cetinkaya Date: 2022-04-19T19:27:04+02:00 New Revision: 1aa3a54921a1e6bb43ff14c072b9129aa78d6988
URL: https://github.com/llvm/llvm-project/commit/1aa3a54921a1e6bb43ff14c072b9129aa78d6988 DIFF: https://github.com/llvm/llvm-project/commit/1aa3a54921a1e6bb43ff14c072b9129aa78d6988.diff LOG: [clangd] Dont include version string in update tasks This increases cardinality of span latency metrics. Currently this was being shown to the user via file status updates as `Running Update (x)` after this change we'll only display `Running Update`. This also affects logs in case of a crash, but contents and version number for inputs are printed separately in that case already. Differential Revision: https://reviews.llvm.org/D124013 Added: Modified: clang-tools-extra/clangd/TUScheduler.cpp Removed: ################################################################################ diff --git a/clang-tools-extra/clangd/TUScheduler.cpp b/clang-tools-extra/clangd/TUScheduler.cpp index 7c5a52f6ea443..19d4ca5a48a50 100644 --- a/clang-tools-extra/clangd/TUScheduler.cpp +++ b/clang-tools-extra/clangd/TUScheduler.cpp @@ -798,7 +798,7 @@ ASTWorker::~ASTWorker() { void ASTWorker::update(ParseInputs Inputs, WantDiagnostics WantDiags, bool ContentChanged) { - std::string TaskName = llvm::formatv("Update ({0})", Inputs.Version); + llvm::StringLiteral TaskName = "Update"; auto Task = [=]() mutable { // Get the actual command as `Inputs` does not have a command. // FIXME: some build systems like Bazel will take time to preparing _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
