[PATCH] D123763: [randstruct] Enforce using a designated init for a randomized struct

void created this revision. void added reviewers: aaron.ballman, MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A randomized structure needs to use a designa

[PATCH] D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available

pengfei added a comment. GCC supports "-mcrc32", but seems only for built-in functions: https://godbolt.org/z/veeGMoY11 https://gcc.gnu.org/onlinedocs/gcc/x86-Options.html#x86-Options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122789/new/ http

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

bowang added a comment. Any updates on this patch? Would like to see it moving forward. I was trying to use Google Breakpad with Clang. Breakpad is a crash handling library that generates a minidump at crash. The exception handler on Windows relies on SEH. Breakpad works fine with MSVC. But wh

[PATCH] D121984: [RISCV] Moving RVV intrinsic type related util to clang/Support

kito-cheng added a comment. Hi @aaron.ballman: > Why shouldn't this live in clang/utils/TableGen along with the others? We plan to use those stuffs on clang side in https://reviews.llvm.org/D111617, my original change was put those stuffs on `llvm/Support`, but actually those stuffs are only u

[PATCH] D123574: [clang] NFCI: Use FileEntryRef in PPCallbacks::InclusionDirective

jansvoboda11 updated this revision to Diff 422763. jansvoboda11 added a comment. Rebase, apply review suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123574/new/ https://reviews.llvm.org/D123574 Files: clang-tools-extra/clang-move/Move

[PATCH] D123574: [clang] NFCI: Use FileEntryRef in PPCallbacks::InclusionDirective

jansvoboda11 marked 3 inline comments as done. jansvoboda11 added inline comments. Comment at: clang-tools-extra/clangd/unittests/ParsedASTTests.cpp:564-565 IncludeStructure Includes = ExpectedAST.getIncludeStructure(); - auto MainFE = FM.getFile(testPath("foo.cpp")); + auto

[PATCH] D120639: [RISCV] Pass -mno-relax to assembler when -fno-integrated-as specified

asb added a comment. @maskray: Are you happy all your comments are addressed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120639/new/ https://reviews.llvm.org/D120639 ___ cfe-commits mailing list cfe-c

[clang] d79ad2f - [clang][lex] NFCI: Use FileEntryRef in PPCallbacks::InclusionDirective()

Author: Jan Svoboda Date: 2022-04-14T10:46:12+02:00 New Revision: d79ad2f1dbc2db63121620f55d6cfa915f2733ac URL: https://github.com/llvm/llvm-project/commit/d79ad2f1dbc2db63121620f55d6cfa915f2733ac DIFF: https://github.com/llvm/llvm-project/commit/d79ad2f1dbc2db63121620f55d6cfa915f2733ac.diff L

[PATCH] D123574: [clang][lex] NFCI: Use FileEntryRef in PPCallbacks::InclusionDirective()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jansvoboda11 marked an inline comment as done. Closed by commit rGd79ad2f1dbc2: [clang][lex] NFCI: Use FileEntryRef in PPCallbacks::InclusionDirective() (authored by ja

[PATCH] D123767: [clang][parse] NFCI: Use FileEntryRef in Parser::ParseModuleImport()

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, bnbarham. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch removes use of the deprecated `DirectoryEntry::getN

[PATCH] D123300: [Clang] Enable opaque pointers by default

uabelho added a comment. Hi, I noticed this produces broken code: clang -cc1 -triple amdgcn-- -emit-llvm -o - -x c op.c with op.c being void bar(); void foo() { bar(); } The result is define dso_local void @foo() #0 { entry: call void @bar(i32 noundef 42) ret void }

[PATCH] D123768: [clang][CodeGen] NFCI: Use FileEntryRef

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, bnbarham. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch removes use of the deprecated `DirectoryEntry::getN

[PATCH] D123769: [clang] NFCI: Use DirectoryEntryRef in collectIncludePCH

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, bnbarham. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch removes use of the deprecated `DirectoryEntry::getN

[PATCH] D123770: [clang] NFCI: Use FileEntryRef in FileManagerTest

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, bnbarham. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch removes use of the deprecated `{File,Directory}Entr

[PATCH] D123300: [Clang] Enable opaque pointers by default

nikic added a comment. @uabelho The IR is correct, but requires using `opt -opaque-pointers` explicitly. Normally, opaque pointer mode is automatically enabled, but there is no explicit mention of `ptr` in the IR. Not sure if we can do anything to improve that before the default on the opt side

[clang] 6ba1b90 - Reland "[AST] Add a new TemplateKind for template decls found via a using decl.""

Author: Haojian Wu Date: 2022-04-14T11:04:55+02:00 New Revision: 6ba1b9075dc1fef6c32eafa71495bfec803321e4 URL: https://github.com/llvm/llvm-project/commit/6ba1b9075dc1fef6c32eafa71495bfec803321e4 DIFF: https://github.com/llvm/llvm-project/commit/6ba1b9075dc1fef6c32eafa71495bfec803321e4.diff LO

[PATCH] D123127: [AST] Add a new TemplateName for templates found via a using declaration.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6ba1b9075dc1: Reland "[AST] Add a new TemplateKind for template decls found via a using decl. (authored by hokein). Repository: rG LLVM Github Mon

[PATCH] D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline.

owenpan added inline comments. Comment at: clang/lib/Format/FormatTokenLexer.cpp:1031-1035 + if (it->second.Finalized) { +FormatTok->setFinalizedType(it->second.Type); + } else { +FormatTok->setType(it->second.Type); + } It seems we

[PATCH] D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline.

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1791 +tokenCanStartNewLine(*FormatTok) && Text == Text.upper() && +!PreviousToken->isTypeFinalized()) { PreviousToken->setFinalizedType(TT_FunctionLikeOrFreestan

[PATCH] D123771: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*()

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, bnbarham. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch removes uses of the deprecated `DirectoryEntry::get

[PATCH] D123300: [Clang] Enable opaque pointers by default

uabelho added a comment. In D123300#3451087 , @nikic wrote: > @uabelho The IR is correct, but requires using `opt -opaque-pointers` > explicitly. Normally, opaque pointer mode is automatically enabled, but there > is no explicit mention of `ptr` in the

[PATCH] D123772: [clang][lex] NFC: Use FileEntryRef in PreprocessorLexer::getFileEntry()

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, bnbarham. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch changes the return type of `PreprocessorLexer::getF

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

DavidSpickett added a comment. > Sure, we can have an AArch64 specific section. I have no AArch64/arm > background to comment on what the lists should look like. Could you provide a > pointer on how to decide what should be AArch64 specific? Thank you! I looked through the list and here's what

[PATCH] D121984: [RISCV] Moving RVV intrinsic type related util to clang/Support

kito-cheng updated this revision to Diff 422783. kito-cheng added a comment. Fix comment in RISCVVIntrinsicUtils.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121984/new/ https://reviews.llvm.org/D121984 Files: clang/include/clang/Support/RISC

[PATCH] D123773: [clang][analyzer][ctu] Make CTU a two phase analysis

martong created this revision. martong added reviewers: steakhal, NoQ. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project:

[PATCH] D121984: [RISCV] Moving RVV intrinsic type related util to clang/Support

kito-cheng updated this revision to Diff 422786. kito-cheng marked an inline comment as done. kito-cheng added a comment. Fix comment in RISCVVIntrinsicUtils.h...again :P Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121984/new/ https://reviews.llv

[clang] 6c93e1d - [flang][driver] Add support for `-mmlir`

Author: Andrzej Warzynski Date: 2022-04-14T09:40:31Z New Revision: 6c93e1d329e6c6ef828ec63c66f4cb39ee9cb9ce URL: https://github.com/llvm/llvm-project/commit/6c93e1d329e6c6ef828ec63c66f4cb39ee9cb9ce DIFF: https://github.com/llvm/llvm-project/commit/6c93e1d329e6c6ef828ec63c66f4cb39ee9cb9ce.diff

[PATCH] D123297: [flang][driver] Add support for -mmlir

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c93e1d329e6: [flang][driver] Add support for `-mmlir` (authored by awarzynski). Changed prior to commit: https://reviews.llvm.org/D123297?vs=422163&id=422787#toc Repository: rG LLVM Github Monorepo

[PATCH] D123297: [flang][driver] Add support for -mmlir

awarzynski added inline comments. Comment at: clang/include/clang/Driver/Options.td:3272 MarshallingInfoStringVector>; +def mmlir : Separate<["-"], "mmlir">,Flags<[CoreOption,FC1Option,FlangOption]>, + HelpText<"Additional arguments to forward to MLIR's option processing">; -

[PATCH] D123775: [AST] Support template declaration found through using-decl for QualifiedTemplateName.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a subscriber: martong. Herald added a reviewer: shafik. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. This is a followup of https://reviews.llvm.org/D123127, addin

[PATCH] D123773: [clang][analyzer][ctu] Make CTU a two phase analysis

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CoreEngine.cpp:167 + // Let CTU run as many steps we had in the single TU run. + // However, we need at least some minimal value to pass those lit tests that + // report a bug only in the CTU mode. --

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo added a comment. The last update removed all previous updates. Can you point me to the correct way to do it? I did the following : arc patch D122255 "did something/cleaning" git commit -a --amend arc diff Repository: rG LLVM Github Monorepo

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin added a comment. > Presumably we should be parsing the attribute in the enclosing context rather > than in the half-way-inside-the-lambda context in which we parse parameters? That's a good question. void f() { int y; (void)[=, x = 1]() __attribute__((diagnose_if(!is_same,

[PATCH] D123627: Correctly diagnose prototype redeclaration errors in C

uweigand added a comment. It looks like this caused the LNT build bot to fail (at least on s390x), because one of the test cases now triggers this error: https://lab.llvm.org/buildbot/#/builders/45/builds/6787 /usr/bin/make -f SingleSource/Regression/C/gcc-c-torture/execute/ieee/CMakeFiles/GC

[PATCH] D123655: [clang-tidy] Add portability-std-allocator-const check

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/56334/step_8.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123655/new/ https://reviews.ll

[PATCH] D123609: [Clang] Remove support for legacy pass manager

HaohaiWen added a comment. Hi @nikic, We recently noticed legacy PM was removed from many places. Does community plan to remove legacy PM completely? Do you know when will CG switch to new PM? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[PATCH] D123609: [Clang] Remove support for legacy pass manager

nikic added a comment. In D123609#3451320 , @HaohaiWen wrote: > Hi @nikic, > We recently noticed legacy PM was removed from many places. > Does community plan to remove legacy PM completely? > Do you know when will CG switch to new PM? > Thanks. At this

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin updated this revision to Diff 422806. cor3ntin added a comment. Properly support GNU Attributes Perform delayed parsing of GNU attributes (using code that already existed to delay the parsing of class methods), so that gnu attributes can refer to captured variables, with the

[PATCH] D123627: Correctly diagnose prototype redeclaration errors in C

aaron.ballman marked an inline comment as done. aaron.ballman added a comment. In D123627#3451269 , @uweigand wrote: > It looks like this caused the LNT build bot to fail (at least on s390x), > because one of the test cases now triggers this error: > htt

[PATCH] D123783: [clang] Eliminate TypeProcessingState::trivial.

mboehme created this revision. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This flag is redundant -- it's true iff `savedAttrs` is empty. Querying `savedAttrs.empty()` should not take any more time

[PATCH] D123784: [clang][analyzer][ctu] Traverse the ctu CallEnter nodes in reverse order

martong created this revision. martong added reviewers: NoQ, steakhal, xazax.hun. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a reviewer: Szelethus. Herald added a project:

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman added a comment. In D122983#3450177 , @rsmith wrote: > It seems surprising to me for the diagnostic to change from warn-by-default > to error-by-default when changing from C99 to C11, given that the language > rule did not change between C

[PATCH] D123212: [clangd] Handle the new UsingTemplateName.

hokein updated this revision to Diff 422823. hokein added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123212/new/ https://reviews.llvm.org/D123212 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-extra/clangd/Incl

[clang] 53fd8db - [Clang][AArch64][SVE] Allow subscript operator for SVE types

Author: David Truby Date: 2022-04-14T13:20:50+01:00 New Revision: 53fd8db79192f38feaec11c761e0d0fbdf1516b0 URL: https://github.com/llvm/llvm-project/commit/53fd8db79192f38feaec11c761e0d0fbdf1516b0 DIFF: https://github.com/llvm/llvm-project/commit/53fd8db79192f38feaec11c761e0d0fbdf1516b0.diff L

[PATCH] D122732: [Clang][AArch64][SVE] Allow subscript operator for SVE types

This revision was automatically updated to reflect the committed changes. Closed by commit rG53fd8db79192: [Clang][AArch64][SVE] Allow subscript operator for SVE types (authored by DavidTruby). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122732/new

[PATCH] D123303: [Clang][AArch64][SVE] Add shift operators for SVE vector types

This revision was automatically updated to reflect the committed changes. Closed by commit rG66c44b20b4a5: [Clang][AArch64][SVE] Add shift operators for SVE vector types (authored by DavidTruby). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123303/n

[clang] 66c44b2 - [Clang][AArch64][SVE] Add shift operators for SVE vector types

Author: David Truby Date: 2022-04-14T13:20:50+01:00 New Revision: 66c44b20b4a538fbb1bae8bc9533c25f5a006bd5 URL: https://github.com/llvm/llvm-project/commit/66c44b20b4a538fbb1bae8bc9533c25f5a006bd5 DIFF: https://github.com/llvm/llvm-project/commit/66c44b20b4a538fbb1bae8bc9533c25f5a006bd5.diff L

[PATCH] D123212: [clangd] Handle the new UsingTemplateName.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:446 Outer.add(RD, Flags); // add(Decl) will despecialize if needed. +else if (const auto *UTN = + TST->getTemplateName

[PATCH] D121984: [RISCV] Moving RVV intrinsic type related util to clang/Support

aaron.ballman added a comment. In D121984#3450956 , @kito-cheng wrote: > Hi @aaron.ballman: > >> Why shouldn't this live in clang/utils/TableGen along with the others? > > We plan to use those stuffs on clang side in > https://reviews.llvm.org/D111617,

[clang] 52d346e - [PS4] NFC refactor of PS4 toolchain class, prep for PS5

Author: Paul Robinson Date: 2022-04-14T05:37:39-07:00 New Revision: 52d346e715cfaa08a71cdc8982627a3a598e47dd URL: https://github.com/llvm/llvm-project/commit/52d346e715cfaa08a71cdc8982627a3a598e47dd DIFF: https://github.com/llvm/llvm-project/commit/52d346e715cfaa08a71cdc8982627a3a598e47dd.diff

[PATCH] D123787: [clang][OpenMP][DebugInfo] Debug support for TLS variables when present in OpenMP consructs

alok created this revision. alok added reviewers: jmorse, aprantl, djtodoro, jini.susan. alok added a project: debug-info. Herald added subscribers: guansong, yaxunl. Herald added a project: All. alok requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: c

[PATCH] D123403: [OpenMP] Refactor OMPScheduleType enum.

peixin added a comment. A few comments. Mostly nits. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:3767 + /*HasMonotonicModifier=*/false, /*HasNonmonotonicModifier=*/false, + /*HasOrdedClause=*/false); return; Comme

[PATCH] D123763: [randstruct] Enforce using a designated init for a randomized struct

aaron.ballman added a comment. Thank you for this! Because we're not checking anything about the randomized output or the AST nodes directly, this should be tested through the usual `lit` tests instead of using a unit test. Comment at: clang/include/clang/Basic/DiagnosticSem

[PATCH] D123636: [randstruct] Add test for "-frandomize-layout-seed-file" flag

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM but please wait a bit in case @MaskRay has comments. Comment at: clang/unittests/AST/RandstructTest.cpp:72 + + return std::tuple(AST.release(), ASTFileSe

Re: [clang] 26dbb93 - [Driver] Fix -fpascal-strings on Darwin

Should there be some test coverage for this change (or was this fixing an already failing test)? ~Aaron On Thu, Apr 14, 2022 at 2:01 AM Fangrui Song via cfe-commits wrote: > > > Author: Fangrui Song > Date: 2022-04-13T23:00:57-07:00 > New Revision: 26dbb93704bf39a198909d04ad8c49b4bde46cce > > UR

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski added a comment. @h-vetinari & @rouson, thanks for the encouragement! In D122008#3450214 , @h-vetinari wrote: > I'd be more than a little surprised that there's no way to do this. Have you > tried CMAKE_Fortran_FLAGS >

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski updated this revision to Diff 422836. awarzynski added a comment. Add a flang, `-flang-experimental-exec`, to guard the new functionality. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122008/new/ https://reviews.llvm.org/D122008 Files:

[PATCH] D123655: [clang-tidy] Add portability-std-allocator-const check

thakis added a comment. Reverted in a29d9ba1f584745c1a169da5d08f10b27623cfb0 for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123655/new/ https://reviews.llvm.org/D123655

[PATCH] D123167: [HLSL] Pointers are unsupported in HLSL

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11579-11584 +def err_hlsl_pointers_unsupported : Error<"%select{pointers|references}0 are " + "unsupported in HLSL">; + +def err_hlsl_operato

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski updated this revision to Diff 422841. awarzynski added a comment. Update the tests after the previous update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122008/new/ https://reviews.llvm.org/D122008 Files: clang/include/clang/Driver/

[PATCH] D123775: [AST] Support template declaration found through using-decl for QualifiedTemplateName.

sammccall added inline comments. Comment at: clang/include/clang/AST/PropertiesBase.td:666 } - def : Property<"declaration", TemplateDeclRef> { + def : Property<"templateDecl", TemplateDeclRef> { let Read = [{ qtn->getTemplateDecl() }]; this seems to be

[PATCH] D123682: [clang-tblgen] Automatically document options values

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D123682#3450215 , @MaskRay wrote: > Thank you for improving the tool :) > > cd clang > path/to/clang-tblgen --gen-opt-docs -I ../l

[clang-tools-extra] dd47ab7 - Revert "[clang-tidy] Add portability-std-allocator-const check"

Author: Nico Weber Date: 2022-04-14T09:20:51-04:00 New Revision: dd47ab750b584a320bf61d58a3965a03f3871c1b URL: https://github.com/llvm/llvm-project/commit/dd47ab750b584a320bf61d58a3965a03f3871c1b DIFF: https://github.com/llvm/llvm-project/commit/dd47ab750b584a320bf61d58a3965a03f3871c1b.diff LO

[PATCH] D123655: [clang-tidy] Add portability-std-allocator-const check

thakis added a comment. Err, actually in dd47ab750b584a320bf61d58a3965a03f3871c1b Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123655/new/ https://reviews.llvm.org/D123655 ___ cfe-commits mailing list c

[PATCH] D115620: [AArch64] Lowering and legalization of strict FP16

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. OK Thanks. This LGTM then. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115620/new/ https://reviews.llvm.org/D115620 ___ cfe-commits ma

[PATCH] D123655: [clang-tidy] Add portability-std-allocator-const check

sammccall added a comment. Thanks Nico! @MaskRay my guess is this is related to implicit -fdelayed-template-parsing on windows, which causes non-instantiated templates not really to be parsed. If that's the case, best just to add -fno-delayed-template-parsing to the test and accept that these c

[PATCH] D123212: [clangd] Handle the new UsingTemplateName.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:76 bool VisitTemplateSpecializationType(TemplateSpecializationType *TST) { +if (const auto *UTN = TST

[PATCH] D122766: [clang] Use forward slash as the path separator for Windows in __FILE__, __builtin_FILE(), and std::source_location

hans added a comment. In D122766#3450298 , @ayzhao wrote: > So, the general consensus seems to be that we should use backslashes when > targeting Windows. > > I implemented using only backslashes for Windows; however, > clang/test/SemaCXX/destructor.cpp

[PATCH] D123167: [HLSL] Pointers are unsupported in HLSL

beanz added a comment. One comment inline. Update coming in a few minutes. Comment at: clang/lib/Sema/SemaExpr.cpp:15252-15257 + if (getLangOpts().HLSL) { +if (Opc == UO_AddrOf) + return ExprError(Diag(OpLoc, diag::err_hlsl_operator_unsupported) << 0); +if (Opc ==

[PATCH] D123403: [OpenMP] Refactor OMPScheduleType enum.

Meinersbur marked 7 inline comments as done. Meinersbur added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:135 + UnorderedGuidedSimd = BaseGuidedSimd | ModifierUnordered, // (46) + UnorderedRuntimeSimd = BaseRuntimeSimd | ModifierUnordered, //

[PATCH] D123167: [HLSL] Pointers are unsupported in HLSL

beanz updated this revision to Diff 422860. beanz added a comment. Updates to test cases to increase coverage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123167/new/ https://reviews.llvm.org/D123167 Files: clang/include/clang/Basic/Diagnostic

[PATCH] D123403: [OpenMP] Refactor OMPScheduleType enum.

Meinersbur updated this revision to Diff 422862. Meinersbur added a comment. - address review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123403/new/ https://reviews.llvm.org/D123403 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/test/OpenM

[PATCH] D123456: [C89/C2x] Diagnose calls to a function without a prototype but passes arguments

aaron.ballman added a comment. FYI -- I plan to land this tomorrow unless I hear more feedback from reviewers (but as always, I'll happily take post-commit feedback as well). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123456/new/ https://reviews.llvm.org/D123456 ___

[PATCH] D122069: [Object] Add binary format for bundling offloading metadata

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe471ba3d0122: [Object] Add binary format for bundling offloading metadata (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

erichkeane added a comment. FWIW, Aaron and I discussed this at length while he was preparing this patch. I think the current behavior (warn in C99, warn-as-error in C11/C17, hard error in C20) is about as aggressive as I'd want us to be with erroring without causing extensive heartache on our

[clang] 1fdf952 - [HLSL] Add Semantic syntax, and SV_GroupIndex

Author: Chris Bieneman Date: 2022-04-14T10:21:58-05:00 New Revision: 1fdf952deeb9a02aa34794af3c1a7d13a30e068e URL: https://github.com/llvm/llvm-project/commit/1fdf952deeb9a02aa34794af3c1a7d13a30e068e DIFF: https://github.com/llvm/llvm-project/commit/1fdf952deeb9a02aa34794af3c1a7d13a30e068e.diff

[PATCH] D122699: [HLSL] Add Semantic syntax, and SV_GroupIndex

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1fdf952deeb9: [HLSL] Add Semantic syntax, and SV_GroupIndex (authored by beanz). Changed prior to commit: https://reviews.llvm.org/D122699?vs=4206

[PATCH] D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available

hjl.tools added a comment. In D122789#3447413 , @pengfei wrote: > In D122789#3446865 , @MaskRay wrote: > >> To kurly (original Gentoo reporter): >> >> printf '#include \n#include \nuint32_t >> computeHardwareCR

[PATCH] D121299: [NVPTX] Disable DWARF .file directory for PTX

asavonic added a comment. Herald added a subscriber: gchakrabarti. @MaskRay, should we merge this patch or rework it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121299/new/ https://reviews.llvm.org/D121299 __

[clang] 1b1466c - [AArch64] Adjust aarch64 constrained intrinsics tests and un-XFAIL

Author: John Brawn Date: 2022-04-14T16:51:22+01:00 New Revision: 1b1466c346694c02ff0e30c96a50701b58bc4830 URL: https://github.com/llvm/llvm-project/commit/1b1466c346694c02ff0e30c96a50701b58bc4830 DIFF: https://github.com/llvm/llvm-project/commit/1b1466c346694c02ff0e30c96a50701b58bc4830.diff LO

[PATCH] D115620: [AArch64] Lowering and legalization of strict FP16

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG12c1022679d4: [AArch64] Lowering and legalization of strict FP16 (authored by john.brawn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D118259: [AArch64] Adjust aarch64 constrained intrinsics tests and un-XFAIL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1b1466c34669: [AArch64] Adjust aarch64 constrained intrinsics tests and un-XFAIL (authored by john.brawn). Repository: rG LLVM Github Monorepo CH

[PATCH] D123773: [clang][analyzer][ctu] Make CTU a two phase analysis

xazax.hun added a comment. > Make CTU a two phase analysis At this point maybe it will be a three phase, as we might dump the ASTs/create index in phase 1 :) > During this phase, if we find a foreign function (that could be inlined from > another TU) then we don’t inline that immediately, we r

[PATCH] D123767: [clang][parse] NFCI: Use FileEntryRef in Parser::ParseModuleImport()

bnbarham accepted this revision. bnbarham added a comment. This revision is now accepted and ready to land. Thanks for doing all these Jan! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123767/new/ https://reviews.llvm.org/D123767

[PATCH] D123737: [clang-format] Skip preprocessor lines when finding the record lbrace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf14ebe91c5dd: [clang-format] Skip preprocessor lines when finding the record lbrace (authored by aeubanks). Repository: rG LLVM Github Monorepo C

[clang] f14ebe9 - [clang-format] Skip preprocessor lines when finding the record lbrace

Author: Arthur Eubanks Date: 2022-04-14T09:31:15-07:00 New Revision: f14ebe91c5dd6be5b64a45e479291cd08676be0c URL: https://github.com/llvm/llvm-project/commit/f14ebe91c5dd6be5b64a45e479291cd08676be0c DIFF: https://github.com/llvm/llvm-project/commit/f14ebe91c5dd6be5b64a45e479291cd08676be0c.diff

[PATCH] D123771: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*()

bnbarham added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:339 // Search for a module map file in this directory. -if (loadModuleMapFile(Dir.getDir(), IsSystem, +if (loadModuleMapFile(*Dir.getDirRef(), IsSystem, /*IsFramewor

[PATCH] D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`

MosheBerman updated this revision to Diff 422902. MosheBerman added a comment. The tests now pass and actually verify the behavior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123352/new/ https://reviews.llvm.org/D123352 Files: clang/include/c

[clang] 7ef9dd3 - [PS4] Fix a couple of typos

Author: Paul Robinson Date: 2022-04-14T10:14:17-07:00 New Revision: 7ef9dd3c61fd85b430bcd74f7ce2c075d93fe4fa URL: https://github.com/llvm/llvm-project/commit/7ef9dd3c61fd85b430bcd74f7ce2c075d93fe4fa DIFF: https://github.com/llvm/llvm-project/commit/7ef9dd3c61fd85b430bcd74f7ce2c075d93fe4fa.diff

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1234 +void Parser::ParseLambdaLexedAttribute(LateParsedAttribute &LA, + ParsedAttributes &Attrs, Declarator &D) { I think this should likely

[PATCH] D123667: [clang][AST] Fix crash getting name of a template decl

tblah updated this revision to Diff 422906. tblah added a comment. Added a unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123667/new/ https://reviews.llvm.org/D123667 Files: clang/lib/AST/TypePrinter.cpp clang/unittests/AST/TypePrinte

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin marked an inline comment as done. cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1253-1256 + // Due to a parsing error, we either went over the cached tokens or + // there are still cached tokens left, so we skip the leftover tokens. + wh

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1397 +for (LateParsedAttribute *Attr : LateParsedAttrs) { + ParseLambdaLexedAttribute(*Attr, Attributes, D); + delete Attr; cor3ntin wrote: > aaron.ballman

Re: [clang] 26dbb93 - [Driver] Fix -fpascal-strings on Darwin

This fixed failure of clang_f_opts.c after bfafa105aab05e2c243e74114739b7d37f8ab0be when the LLVM_DEFAULT_TARGET_TRIPLE looks like arm64-apple-darwin. Sorry that I did not provide enough information in the message. I think the few lines in Darwin.cpp should just be removed since -mpascal-strings i

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin marked an inline comment as done. cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1486 + if (Tok.isOneOf(tok::kw_mutable, tok::arrow, tok::kw___attribute, + tok::kw___declspec, tok::kw_constexpr, tok::kw_consteval, +

[PATCH] D123167: [HLSL] Pointers are unsupported in HLSL

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from the formatting nit. Comment at: clang/lib/Sema/SemaExpr.cpp:15252-15257 + if (getLangOpts().HLSL) { +if (Opc == UO_AddrOf) + return Ex

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1486 + if (Tok.isOneOf(tok::kw_mutable, tok::arrow, tok::kw___attribute, + tok::kw___declspec, tok::kw_constexpr, tok::kw_consteval, + tok::kw___private, tok::kw__

[PATCH] D122766: [clang] Use forward slash as the path separator for Windows in __FILE__, __builtin_FILE(), and std::source_location

ayzhao added a subscriber: rsmith. ayzhao added a comment. In D122766#3451775 , @hans wrote: > In D122766#3450298 , @ayzhao wrote: > >> So, the general consensus seems to be that we should use backslashes when >>

[PATCH] D123783: [clang] Eliminate TypeProcessingState::trivial.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:170 /// Whether we saved the attributes in the decl spec. bool hasSavedAttrs; Isn't the same true for this variable? It seems like: `trivial` == `savedAttrs.empty()` `hasSav

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin updated this revision to Diff 422920. cor3ntin marked 2 inline comments as done. cor3ntin added a comment. Address aarons comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119136/new/ https://reviews.llvm.org/D119136 Files: clang/d

  1   2   >