[PATCH] D123478: [clangd] Fix incorrect operator< impl for HighlightingToken

nridge updated this revision to Diff 422410. nridge added a comment. Add semantic highlighting testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123478/new/ https://reviews.llvm.org/D123478 Files: clang-tools-extra/clangd/SemanticHighlighti

[clang-tools-extra] e500062 - [clangd] Fix incorrect operator< impl for HighlightingToken

Author: Nathan Ridge Date: 2022-04-13T03:19:48-04:00 New Revision: e5000624933e11e56a1530f1561efa136c9c8bd7 URL: https://github.com/llvm/llvm-project/commit/e5000624933e11e56a1530f1561efa136c9c8bd7 DIFF: https://github.com/llvm/llvm-project/commit/e5000624933e11e56a1530f1561efa136c9c8bd7.diff

[PATCH] D123478: [clangd] Fix incorrect operator< impl for HighlightingToken

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe5000624933e: [clangd] Fix incorrect operator< impl for HighlightingToken (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D121375: [clang] NFC, move the utility function CompilerInvocation::setLangDefaults to LangOptions.h

hokein updated this revision to Diff 422412. hokein marked an inline comment as done. hokein added a comment. getDefaultLanguageStandard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121375/new/ https://reviews.llvm.org/D121375 Files: clang/inc

[clang] b0343a3 - Support the min of module flags when linking, use for AArch64 BTI/PAC-RET

Author: Daniel Kiss Date: 2022-04-13T09:31:51+02:00 New Revision: b0343a38a5910e980bb031e4014655d77cd0c162 URL: https://github.com/llvm/llvm-project/commit/b0343a38a5910e980bb031e4014655d77cd0c162 DIFF: https://github.com/llvm/llvm-project/commit/b0343a38a5910e980bb031e4014655d77cd0c162.diff L

[PATCH] D123493: Support the min of module flags when linking, use for AArch64 BTI/PAC-RET

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb0343a38a591: Support the min of module flags when linking, use for AArch64 BTI/PAC-RET (authored by danielkiss). Herald added a project: clang. Hera

[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

balazske updated this revision to Diff 422419. balazske added a comment. Rebase to newer 'main' branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118996/new/ https://reviews.llvm.org/D118996 Files: clang-tools-extra/clang-tidy/bugprone/Signa

[PATCH] D105263: [X86] AVX512FP16 instructions enabling 1/6

pengfei added a comment. Thanks @vtjnash for the information! Comments on https://github.com/JuliaLang/julia/issues/44829 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105263/new/ https://reviews.llvm.org/D105263 _

[clang] 93471e6 - [clang] NFC, move CompilerInvocation::setLangDefaults to LangOptions.h

Author: Haojian Wu Date: 2022-04-13T09:44:39+02:00 New Revision: 93471e65df48372ee59bd0c2f8ba58a254ba1ca5 URL: https://github.com/llvm/llvm-project/commit/93471e65df48372ee59bd0c2f8ba58a254ba1ca5 DIFF: https://github.com/llvm/llvm-project/commit/93471e65df48372ee59bd0c2f8ba58a254ba1ca5.diff LO

[PATCH] D121375: [clang] NFC, move the utility function CompilerInvocation::setLangDefaults to LangOptions.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG93471e65df48: [clang] NFC, move CompilerInvocation::setLangDefaults to LangOptions.h (authored by hokein). Changed prior to commit: https://review

[clang] 5967528 - [clang][ASTImporter] Fix an import error handling related bug.

Author: Balázs Kéri Date: 2022-04-13T10:11:33+02:00 New Revision: 596752863e27e6b4b89e34ecfcf5317a5bf46b52 URL: https://github.com/llvm/llvm-project/commit/596752863e27e6b4b89e34ecfcf5317a5bf46b52 DIFF: https://github.com/llvm/llvm-project/commit/596752863e27e6b4b89e34ecfcf5317a5bf46b52.diff L

[PATCH] D122525: [clang][ASTImporter] Fix an import error handling related bug.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG596752863e27: [clang][ASTImporter] Fix an import error handling related bug. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES

[clang] 2978d02 - [Clang] Remove support for legacy pass manager

Author: Nikita Popov Date: 2022-04-13T10:21:42+02:00 New Revision: 2978d026819b82f77eef42d92b3b53919f375bd8 URL: https://github.com/llvm/llvm-project/commit/2978d026819b82f77eef42d92b3b53919f375bd8 DIFF: https://github.com/llvm/llvm-project/commit/2978d026819b82f77eef42d92b3b53919f375bd8.diff

[PATCH] D123609: [Clang] Remove support for legacy pass manager

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2978d026819b: [Clang] Remove support for legacy pass manager (authored by nikic). Herald added a project: clang. Herald added a subscriber: cfe-commi

[PATCH] D123297: [flang][driver] Add support for -mmlir

rovka accepted this revision. rovka added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123297/new/ https://reviews.llvm.org/D123297

[PATCH] D123598: Clean the code, formated and add basic tests for the patch.

abidmalikwaterloo added a comment. It. should update D122255 . It should not create the new one. ---> I used the following arc patch D122255 "did something" git commit -a arc diff > Repository: rG LLVM Github Monorepo

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo added a comment. There should be an update to D122255 . It should not create the new one.D123598 ---> I did the following : arc patch D122255 "did something/cleaning" git comm

[PATCH] D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions

martong added a comment. Thanks for you patience Denys! Finally I had some time for the review. Nice work! Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h:242 +/// +/// This function optimized for each of the six cast cases:

[PATCH] D123667: [clang][AST] Fix crash getting name of a template decl

tblah created this revision. tblah added a reviewer: rsmith. Herald added a project: All. tblah requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. NamedDecl::getIdentifier can return a nullptr when DeclarationName::isIdentifier is false, whic

[PATCH] D123211: [flang][driver] Add support for generating LLVM bytecode files

awarzynski added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:491 + // Create and configure `TargetMachine` + std::unique_ptr TM; + ekieri wrote: > awarzynski wrote: > > ekieri wrote: > > > Is there a reason why use TM.reset instead of in

[clang] dd56939 - [flang][driver] Add support for generating LLVM bytecode files

Author: Andrzej Warzynski Date: 2022-04-13T10:19:56Z New Revision: dd56939a4b04072a449a05701373e95d00cc494f URL: https://github.com/llvm/llvm-project/commit/dd56939a4b04072a449a05701373e95d00cc494f DIFF: https://github.com/llvm/llvm-project/commit/dd56939a4b04072a449a05701373e95d00cc494f.diff

[PATCH] D123211: [flang][driver] Add support for generating LLVM bytecode files

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd56939a4b04: [flang][driver] Add support for generating LLVM bytecode files (authored by awarzynski). Changed prior to commit: https://reviews.llvm.org/D123211?vs=420862&id=422453#toc Repository: rG

[PATCH] D123297: [flang][driver] Add support for -mmlir

awarzynski added inline comments. Comment at: flang/lib/FrontendTool/ExecuteCompilerInvocation.cpp:15 +#include "mlir/IR/MLIRContext.h" +#include "mlir/Pass/PassManager.h" #include "flang/Frontend/CompilerInstance.h" rovka wrote: > Nit: Should these come after t

[PATCH] D121915: [RISCV] CLZ Instruction

joker881 added a comment. wait ,It seems the format problem have not solved,sorry Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121915/new/ https://reviews.llvm.org/D121915 ___ cfe-commits mailing list c

[clang] 46f83ca - [InlineAsm] Add support for address operands ("p").

Author: Jonas Paulsson Date: 2022-04-13T12:50:21+02:00 New Revision: 46f83caebc8f2329bcf16b3edf6785dff480c5e3 URL: https://github.com/llvm/llvm-project/commit/46f83caebc8f2329bcf16b3edf6785dff480c5e3 DIFF: https://github.com/llvm/llvm-project/commit/46f83caebc8f2329bcf16b3edf6785dff480c5e3.diff

[PATCH] D122220: [InlineAsm] Add support for address operands ("p").

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG46f83caebc8f: [InlineAsm] Add support for address operands ("p"). (authored by jonpa). Herald added a project: clang. Herald added a subscriber: cfe-

[PATCH] D122220: [InlineAsm] Add support for address operands ("p").

jonpa added a comment. -no-opaque-pointers added to SystemZ clang test, per 532dc62 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10/new/ https://reviews.llvm.org/D10

[PATCH] D123667: [clang][AST] Fix crash getting name of a template decl

aaron.ballman edited reviewers, added: aaron.ballman; removed: lattner. aaron.ballman added a comment. This looks good in general, but can you add a test case for the scenario which previously crashed and a release note for the fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D123668: [Testing] TestAST, a helper for writing straight-line AST tests

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, mgorny. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. Tests that need

[PATCH] D119221: [clang][lexer] Allow u8 character literal prefixes in C2x

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. The changes LGTM (thanks for filing the issue). Please wait a day or so for Tom to sign off though (I've pinged him off-list). CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D123648: Restrict lvalue-to-rvalue conversions in CGExprConstant.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thanks for catching this (sorry, pretty sure this was my bug)! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123648/new/ https://reviews.llvm.org/D123648 __

[PATCH] D123544: [randstruct] Automatically randomize a structure of function pointers

aaron.ballman added a comment. In D123544#3446814 , @void wrote: > In D123544#3446416 , @aaron.ballman > wrote: > >> However, I had forgotten that the base feature *requires* the user to pass a >> randomization

[PATCH] D123127: [AST] Add a new TemplateName for templates found via a using declaration.

sammccall accepted this revision. sammccall added a comment. Nice fix! Just nits Comment at: clang/include/clang/AST/TemplateName.h:197 using StorageType = - llvm::PointerUnion; nit: I'd use Decl here instead of NamedDecl. Sure, the lowest common type

[PATCH] D123300: [Clang] Enable opaque pointers by default

paulwalker-arm added a comment. We've spotted some breakages caused by this patch within the llvm test suite when built for AArch64-SVE. I've got https://reviews.llvm.org/D123670 as a WIP fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123300/

[PATCH] D122468: [clang-format] Fix SeparateDefinitionBlocks breaking up function-try-block.

curdeius updated this revision to Diff 422479. curdeius marked 5 inline comments as done. curdeius added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122468/new/ https://reviews.llvm.org/D122468 Files: clang/

[PATCH] D123672: [clangd] Export preamble AST and serialized size as metrics

sammccall created this revision. sammccall added a reviewer: adamcz. Herald added subscribers: usaxena95, kadircet, arphaman, javed.absar. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project:

[PATCH] D123672: [clangd] Export preamble AST and serialized size as metrics

adamcz added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:500 + if (Stats != nullptr) { +Stats->TotalBuildTime = PreambleTimer.getTime(); This is a significant change. You are now exporting this information for failed preamble builds

[clang] 385e7df - Correctly diagnose prototype redeclaration errors in C

Author: Aaron Ballman Date: 2022-04-13T08:21:31-04:00 New Revision: 385e7df33046d7292612ee1e3ac00a59d8bc0441 URL: https://github.com/llvm/llvm-project/commit/385e7df33046d7292612ee1e3ac00a59d8bc0441 DIFF: https://github.com/llvm/llvm-project/commit/385e7df33046d7292612ee1e3ac00a59d8bc0441.diff

[PATCH] D123627: Correctly diagnose prototype redeclaration errors in C

aaron.ballman closed this revision. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Thank you for the reviews, I've landed in 385e7df33046d7292612ee1e3ac00a59d8bc0441 . Comment

[PATCH] D121915: [RISCV] CLZ Instruction

joker881 updated this revision to Diff 422487. joker881 added a comment. upadated test files, fixed the format problem Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121915/new/ https://reviews.llvm.org/D121915 Files: clang/include/clang/Basic/Bu

[PATCH] D123672: [clangd] Export preamble AST and serialized size as metrics

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:500 + if (Stats != nullptr) { +Stats->TotalBuildTime = PreambleTimer.getTime(); adamcz wrote: > This is a significant change. You are now exporting this information for > f

[clang-tools-extra] f407c9e - [clangd] Export preamble AST and serialized size as metrics

Author: Sam McCall Date: 2022-04-13T14:43:06+02:00 New Revision: f407c9ed1057c4093cd09c0f8cee16f68c63157e URL: https://github.com/llvm/llvm-project/commit/f407c9ed1057c4093cd09c0f8cee16f68c63157e DIFF: https://github.com/llvm/llvm-project/commit/f407c9ed1057c4093cd09c0f8cee16f68c63157e.diff LO

[PATCH] D123672: [clangd] Export preamble AST and serialized size as metrics

This revision was automatically updated to reflect the committed changes. Closed by commit rGf407c9ed1057: [clangd] Export preamble AST and serialized size as metrics (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123672/new/

[PATCH] D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan, ksyx. Herald added a project: All. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/is

[PATCH] D107636: [analyzer][solver] Compute adjustment for unsupported symbols as well

martong requested changes to this revision. martong added a comment. This revision now requires changes to proceed. I am not sure if this patch makes sense at all because the adjustment handling logic is restricted to handle SymInt expressions only. Comment at: clang/lib/Stati

[PATCH] D123300: [Clang] Enable opaque pointers by default

mstorsjo added a comment. In D123300#3446823 , @aeubanks wrote: > In D123300#3446023 , @nikic wrote: > >> @mstorsjo Thanks! I've reduced this to a crash in `-argpromotion`: >> >> efine void @caller() { >> ca

[PATCH] D123649: Allow flexible array initialization in C++.

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:346 +else if (!D.getFlexibleArrayInitChars(getContext()).isZero()) + CGM.ErrorUnsupported(D.getInit(), "flexible array init"); else if (HaveInsertPoint()) { Can you write a t

[PATCH] D123450: [clang-format] Parse Verilog if statements

sstwcw updated this revision to Diff 422496. sstwcw edited the summary of this revision. sstwcw added a comment. abandon alias Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123450/new/ https://reviews.llvm.org/D123450 Files: clang/docs/ClangForm

[PATCH] D123450: [clang-format] Parse Verilog if statements

sstwcw marked an inline comment as done. sstwcw added inline comments. Comment at: clang/lib/Format/FormatToken.h:374 + /// Verilog we want to treat the backtick like a hash. + tok::TokenKind AliasToken = tok::unknown; + HazardyKnusperkeks wrote: > sstwcw wrote

[PATCH] D123636: [randstruct] Add test for "-frandomize-layout-seed-file" flag

aaron.ballman added inline comments. Comment at: clang/unittests/AST/RandstructTest.cpp:56 + llvm::SmallString<256> SeedFilename; + EXPECT_FALSE(llvm::sys::fs::createTemporaryFile("seed", "rng", SeedFileFD, + SeedFilename));

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

aaron.ballman added a comment. I think these changes should go through a community RFC on Discourse given that they alter the behavior of existing flags. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123630/new/ https://reviews.llvm.org/D123630 _

[PATCH] D122748: [Sema] Don't check bounds for function pointer

ArcsinX added a comment. Friendly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122748/new/ https://reviews.llvm.org/D122748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D122748: [Sema] Don't check bounds for function pointer

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. >> Friendly ping Unfriendly LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122748/new/ https://reviews.llvm.org/D122748 _

[PATCH] D121984: [RISCV] Moving RVV intrinsic type related util to clang/Support

aaron.ballman added a comment. Errr, I'm not strongly opposed, but at the same time, this doesn't feel like a Support kind of thing. My understanding of llvm/Support is that it's primarily for generally useful utilities that are going to be used across the entire llvm project (or beyond). This

[PATCH] D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline.

ksyx added inline comments. Comment at: clang/lib/Format/FormatTokenLexer.h:117-120 + struct MacroTokenInfo { +TokenType Type; +bool Finalized; + }; Would making constructor of `struct MacroTokenInfo` having default parameter or overloading it help avo

[PATCH] D123655: [clang-tidy] Add portability-std-allocator-const-t check

sammccall added a comment. This looks nice, my main substantive question is about matching VarDecl vs TypeLoc. Maybe there's a good reason to keep it this way but I'd like to understand why. The rest is nits, feel free to ignore any bits you disagree with. Comment at: clang-

[PATCH] D123598: Clean the code, formated and add basic tests for the patch.

abidmalikwaterloo updated this revision to Diff 422504. abidmalikwaterloo added a comment. I submitted update but it created a new patch D123598 . I marked it abandon and submitting it again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D123680: Add support for ignored bitfield conditional codegen.

erichkeane created this revision. erichkeane added reviewers: eli.friedman, aaron.ballman, tahonermann. Herald added a project: All. erichkeane requested review of this revision. Currently we emit an error in just about every case of conditionals with a 'non simple' branch if treated as an LValue.

[PATCH] D123682: [clang-tblgen] Automatically document options values

serge-sans-paille created this revision. serge-sans-paille added a reviewer: MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a port of f5

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo updated this revision to Diff 422509. abidmalikwaterloo added a comment. I update it but it created a new patch D123598 . I marked it Abandon. Not sure how to delete it. I am submitting it again after cleaning the codes and adding some basic tes

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

qiongsiwu1 added a subscriber: momchil.velikov. qiongsiwu1 added a comment. May I get some comments from the rest of the reviewers for the respective platforms? @momchil.velikov @chill: arm @pengfei : x86 @jdoerfert: cuda @yaxunl : opencl @kaz7 : ve @bcain : hexagon @sdardis : mips Thanks so mu

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo updated this revision to Diff 422512. abidmalikwaterloo added a comment. Added tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122255/new/ https://reviews.llvm.org/D122255 Files: clang/test/OpenMP/metadirective_ast_print2.c

[PATCH] D122069: [Object] Add binary format for bundling offloading metadata

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Couple of nits above but basically I'm convinced. The gnarly part of binary formats is string tables and I'm delighted that part of MC was readily reusable. Wrapping the stri

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

yaxunl added a subscriber: Anastasia. yaxunl added a comment. Pls add @Anastasia for OpenCL. LGTM for HIP. HIP headers depend on some of CUDA headers, but LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123498/new/ https://reviews.llvm.org/D12

[PATCH] D97121: [clang-tidy] Add a Standalone diagnostics mode to clang-tidy

aaron.ballman added a comment. I'd like to hear from @sammccall as well, but I think the changes here LGTM. Can you please add a release note for the fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97121/new/ https://reviews.llvm.org/D97121 __

[PATCH] D123655: [clang-tidy] Add portability-std-allocator-const-t check

Eugene.Zelenko added a comment. Shouldn't this check be enabled only when libstdc++ is used? Comment at: clang-tools-extra/docs/clang-tidy/checks/portability-std-allocator-const-t.rst:6 + +Per C++ ``[allocator.requirements.general]``: "T is any cv-unqualified object +type", ``

[PATCH] D122831: [OpenMP] Make the new offloading driver the default

JonChesterfield added a comment. Editing the tests in place to check for new driver properties would mean we lose coverage for the old driver and get a lot of churn if we need to back out the change. How about taking some of the more interesting driver tests, duplicating them to only run the n

[PATCH] D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline.

curdeius added inline comments. Comment at: clang/lib/Format/FormatTokenLexer.h:117-120 + struct MacroTokenInfo { +TokenType Type; +bool Finalized; + }; ksyx wrote: > Would making constructor of `struct MacroTokenInfo` having default parameter > or ove

[PATCH] D123601: [clang][AArch64] Split neon tests into 2 files

fhahn added a comment. In D123601#3445601 , @tstellar wrote: > Can't we add a timeout exception for this test in buildkite? Splitting the > file in two actually increases the runtime, due to the overhead of setting up > each test. I don't know, this i

[clang] b58616c - [clang-format] Fix SeparateDefinitionBlocks breaking up function-try-block.

Author: Marek Kurdej Date: 2022-04-13T16:44:04+02:00 New Revision: b58616c2cdf70e075b887a66edf6bbc568e2ff99 URL: https://github.com/llvm/llvm-project/commit/b58616c2cdf70e075b887a66edf6bbc568e2ff99 DIFF: https://github.com/llvm/llvm-project/commit/b58616c2cdf70e075b887a66edf6bbc568e2ff99.diff

[PATCH] D122468: [clang-format] Fix SeparateDefinitionBlocks breaking up function-try-block.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb58616c2cdf7: [clang-format] Fix SeparateDefinitionBlocks breaking up function-try-block. (authored by curdeius). Repository: rG LLVM Github Monor

[PATCH] D123601: [clang][AArch64] Split neon tests into 2 files

fhahn added a comment. (splitting up huge monolithic tests likely also speeds up overall testing time on multi-core systems) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123601/new/ https://reviews.llvm.org/D123601 __

[clang] 0424b51 - [CUDA][HIP] Fix host used external kernel in archive

Author: Yaxun (Sam) Liu Date: 2022-04-13T10:47:16-04:00 New Revision: 0424b5115cffad73a0f6e68affed603a7ed9a692 URL: https://github.com/llvm/llvm-project/commit/0424b5115cffad73a0f6e68affed603a7ed9a692 DIFF: https://github.com/llvm/llvm-project/commit/0424b5115cffad73a0f6e68affed603a7ed9a692.dif

[PATCH] D123441: [CUDA][HIP] Fix host used external kernel in archive

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG0424b5115cff: [CUDA][HIP] Fix host used external kernel in archive (authored by yaxunl). Herald added a proj

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

chill added a comment. Should these lists contain only source tree headers or also generated header files? I'm not seeing `arm_mve.h`, for example. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123498/new/ https://reviews.llvm.org/D123498 ___

[PATCH] D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline.

ksyx added inline comments. Comment at: clang/lib/Format/FormatTokenLexer.h:117-120 + struct MacroTokenInfo { +TokenType Type; +bool Finalized; + }; curdeius wrote: > ksyx wrote: > > Would making constructor of `struct MacroTokenInfo` having default >

[libunwind] a85da64 - [libunwind][AIX] implementation of the unwinder for AIX

Author: Xing Xue Date: 2022-04-13T11:01:59-04:00 New Revision: a85da649b9ac67afffec6bff9487e6405e1f9cba URL: https://github.com/llvm/llvm-project/commit/a85da649b9ac67afffec6bff9487e6405e1f9cba DIFF: https://github.com/llvm/llvm-project/commit/a85da649b9ac67afffec6bff9487e6405e1f9cba.diff LOG:

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski added a comment. Thank you all for your feedback! **CMake integration** I have a couple more data points. I've experimented with CMake using Tin's CMake PR . I confirm that together with this patch, I was able to build a

[PATCH] D123211: [flang][driver] Add support for generating LLVM bytecode files

ekieri added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:491 + // Create and configure `TargetMachine` + std::unique_ptr TM; + awarzynski wrote: > ekieri wrote: > > awarzynski wrote: > > > ekieri wrote: > > > > Is there a reason why use

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

DavidSpickett added a comment. Is there any reason to have an AArch64 specific section? A lot of the files do apply to both Arm and AArch64 but for example the mve file Momchil mentioned does not. Would make sense if you wanted AArch64 only there'd be an `aarch64-resource-headers`, even if it

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

DavidSpickett added a comment. Then again a lot of Arm systems can run 32 bit code as well so there is a situation where you might include both. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123498/new/ https://reviews.llvm.org/D123498 __

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski updated this revision to Diff 422525. awarzynski added a comment. Updates based on feedback from @MaskRay (thank you!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122008/new/ https://reviews.llvm.org/D122008 Files: clang/lib/Driver/

[libunwind] 9c0152c - [libunwind][AIX] implementation of the unwinder for AIX

Author: Xing Xue Date: 2022-04-13T11:29:37-04:00 New Revision: 9c0152cda35f58ad9916b698c7a645d4a4dfeaf2 URL: https://github.com/llvm/llvm-project/commit/9c0152cda35f58ad9916b698c7a645d4a4dfeaf2 DIFF: https://github.com/llvm/llvm-project/commit/9c0152cda35f58ad9916b698c7a645d4a4dfeaf2.diff LOG:

[PATCH] D119221: [clang][lexer] Allow u8 character literal prefixes in C2x

tahonermann accepted this revision. tahonermann added a comment. Looks good to me! Thank you for filing the separate issue. Comment at: clang/test/Lexer/utf8-char-literal.cpp:23 +char f = u8'ab';// expected-error {{Unicode character literals may not contain multipl

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

pengfei accepted this revision. pengfei added a comment. LGTM for X86. Comment at: clang/lib/Headers/CMakeLists.txt:88 + +set(x86_files +# Intrinsics Verified the list is correct to X86. Nit: should make them in alphabetical order? Comment a

[PATCH] D123685: [clang][ASTImporter] Add isNewDecl

martong created this revision. martong added reviewers: balazske, steakhal. Herald added subscribers: gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. martong requested review of this revision. Herald added a p

[PATCH] D123680: Add support for ignored bitfield conditional codegen.

efriedma added a comment. This is basically what I expected; the general approach seems fine. Comment at: clang/lib/CodeGen/CGExpr.cpp:200 + E->IgnoreParenNoopCasts(getContext( { +if (CondOp->getObjectKind() == OK_BitField) + return EmitIgnoredConditionalO

[PATCH] D123680: Add support for ignored bitfield conditional codegen.

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:200 + E->IgnoreParenNoopCasts(getContext( { +if (CondOp->getObjectKind() == OK_BitField) + return EmitIgnoredConditionalOperator(CondOp); efriedma wrote: > Is there s

[clang] b870620 - [NFC] Add CMake cache file for HLSL

Author: Chris Bieneman Date: 2022-04-13T11:28:18-05:00 New Revision: b870620c29814b71b0c9788f17f8054f04ae2d40 URL: https://github.com/llvm/llvm-project/commit/b870620c29814b71b0c9788f17f8054f04ae2d40 DIFF: https://github.com/llvm/llvm-project/commit/b870620c29814b71b0c9788f17f8054f04ae2d40.diff

[PATCH] D121560: [clang][Opt] Add NoArgUnusedWith to not warn for unused redundant options

abrachet added a comment. In D121560#3439570 , @MaskRay wrote: > If you need a -static-libstdc++ not subject to unused argument warning, > --start-no-unused-arguments and D53238 > (-static=c++stdlib) may be better choic

[PATCH] D123680: Add support for ignored bitfield conditional codegen.

erichkeane updated this revision to Diff 422539. erichkeane added a comment. Added support for chained-conditional operators as requested. All of the variants I could come up with that I was afraid would be breaking ended up having an rvalue conversion (which makes it 'work'). CHANGES SINCE L

[PATCH] D122069: [Object] Add binary format for bundling offloading metadata

jhuber6 updated this revision to Diff 422544. jhuber6 added a comment. Maxing suggested changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122069/new/ https://reviews.llvm.org/D122069 Files: llvm/include/llvm/Object/OffloadBinary.h llvm/li

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! When landing, please revert the changes to SemaDecl.cpp (no need to churn that file) and apply the one suggested refactoring (I commented to make it more clear which one I mean). Comment at: clang/lib/

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:173 __wmmintrin_pclmul.h x86gprintrin.h x86intrin.h qiongsiwu1 wrote: > abhina.sreeskantharajan wrote: > > nit: There are some x86 headers here that appear to be

[PATCH] D122683: [OpenMP] Use new offloading binary when embedding offloading images

jhuber6 updated this revision to Diff 422547. jhuber6 added a comment. Cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122683/new/ https://reviews.llvm.org/D122683 Files: clang/include/clang/Basic/CodeGenOptions.h clang/lib/CodeGen/Back

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:1127-1132 + auto it = LSI->DelayedCaptures.end(); + if (Var) +it = llvm::find_if(LSI->DelayedCaptures, [&Var](auto &&Pair) { + return Pair.second.Var == Var; +}); + i

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:1127-1132 + auto it = LSI->DelayedCaptures.end(); + if (Var) +it = llvm::find_if(LSI->DelayedCaptures, [&Var](auto &&Pair) { + return Pair.second.Var == Var; +}); + i

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:1127-1132 + auto it = LSI->DelayedCaptures.end(); + if (Var) +it = llvm::find_if(LSI->DelayedCaptures, [&Var](auto &&Pair) { + return Pair.second.Var == Var; +}); +

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin updated this revision to Diff 422557. cor3ntin added a comment. Cleanup SemaLambda as discussed with Aaron Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119136/new/ https://reviews.llvm.org/D119136 Files: clang/docs/ReleaseNotes.rst c

[libunwind] 7165edc - [libunwind][AIX] implementation of the unwinder for AIX

Author: Xing Xue Date: 2022-04-13T13:18:10-04:00 New Revision: 7165edcad76fec2e025414ddf44e76363806fc3d URL: https://github.com/llvm/llvm-project/commit/7165edcad76fec2e025414ddf44e76363806fc3d DIFF: https://github.com/llvm/llvm-project/commit/7165edcad76fec2e025414ddf44e76363806fc3d.diff LOG:

  1   2   >