[clang] d69e9f9 - [OpaquePtrs][Clang] Add -opaque-pointers/-no-opaque-pointers cc1 options

Author: Nikita Popov Date: 2022-04-05T10:15:41+02:00 New Revision: d69e9f9d8978399a9d1f1c1ed62aa661440afcd3 URL: https://github.com/llvm/llvm-project/commit/d69e9f9d8978399a9d1f1c1ed62aa661440afcd3 DIFF: https://github.com/llvm/llvm-project/commit/d69e9f9d8978399a9d1f1c1ed62aa661440afcd3.diff

[PATCH] D123034: [OpaquePtrs][Clang] Add -opaque-pointers/-no-opaque-pointers cc1 options

This revision was automatically updated to reflect the committed changes. Closed by commit rGd69e9f9d8978: [OpaquePtrs][Clang] Add -opaque-pointers/-no-opaque-pointers cc1 options (authored by nikic). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Git

[PATCH] D123037: [clang][dataflow] Support integral casts

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:206 + // boolean. + auto &ExprLoc = Env.createStorageLocation(*S); + Env.setStorageLocation(*S, ExprLoc); Nit: Just `Loc`? I beli

[PATCH] D122008: [flang][driver] Add support for generating executables

richard.barton.arm added a comment. Option 1 for me, let's not delay. With upstreaming of fir-dev making great progress, we can start to think about having a working flang in LLVM 15. For that we would need to have upstreaming finished, the driver finished and CMake support finished before end

[clang] 3ba8548 - [libc++][ranges] Implement ranges::transform

Author: Nikolas Klauser Date: 2022-04-05T11:06:28+02:00 New Revision: 3ba8548c8e04bb301c4243887362c54bfbd4af8b URL: https://github.com/llvm/llvm-project/commit/3ba8548c8e04bb301c4243887362c54bfbd4af8b DIFF: https://github.com/llvm/llvm-project/commit/3ba8548c8e04bb301c4243887362c54bfbd4af8b.dif

[PATCH] D122173: [libc++][ranges] Implement ranges::transform

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. philnik marked an inline comment as done. Closed by commit rG3ba8548c8e04: [libc++][ranges] Implement ranges::transform (authored by philnik). Herald added a project: c

[clang] ff18b15 - [CodeGen] Avoid unnecessary ConstantExpr cast

Author: Nikita Popov Date: 2022-04-05T11:28:40+02:00 New Revision: ff18b158edc4719c4b05cd04dceaedcf69a8d9c5 URL: https://github.com/llvm/llvm-project/commit/ff18b158edc4719c4b05cd04dceaedcf69a8d9c5 DIFF: https://github.com/llvm/llvm-project/commit/ff18b158edc4719c4b05cd04dceaedcf69a8d9c5.diff

[clang] 302fe7b - Remove libc++ test from clang lib.

Author: Benjamin Kramer Date: 2022-04-05T11:33:55+02:00 New Revision: 302fe7b3c40f7b949f3bebb74997bef9bf74d59f URL: https://github.com/llvm/llvm-project/commit/302fe7b3c40f7b949f3bebb74997bef9bf74d59f DIFF: https://github.com/llvm/llvm-project/commit/302fe7b3c40f7b949f3bebb74997bef9bf74d59f.dif

[PATCH] D123064: [Clang][C++23][WIP] P2071 Named universal character escapes

cor3ntin updated this revision to Diff 420422. cor3ntin added a comment. Add lexing tests, improve diagnostics. As a drive by, this also fix the handling of `\U{123}` which was a non diagnosed invalid escape sequence, leading to some assertion failure. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D123031: [clangd] Use consistent header paths in CanonicalIncludes mappings

kbobyrev updated this revision to Diff 420423. kbobyrev added a comment. Switch to stable file UniqueIDs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123031/new/ https://reviews.llvm.org/D123031 Files: clang-tools-extra/clangd/IncludeCleaner.c

[PATCH] D123031: [clangd] Use stable keys for CanonicalIncludes mappings

kbobyrev updated this revision to Diff 420425. kbobyrev added a comment. Rebase on top of main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123031/new/ https://reviews.llvm.org/D123031 Files: clang-tools-extra/clangd/IncludeCleaner.cpp clang

[PATCH] D123031: [clangd] Use stable keys for CanonicalIncludes mappings

kbobyrev updated this revision to Diff 420426. kbobyrev added a comment. Rebase correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123031/new/ https://reviews.llvm.org/D123031 Files: clang-tools-extra/clangd/IncludeCleaner.cpp clang-tool

[PATCH] D122774: [clang][extract-api] Add Objective-C Category support

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122774/new/ https://reviews.llvm.org/D122774 ___ cf

[PATCH] D123031: [clangd] Use stable keys for CanonicalIncludes mappings

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/CanonicalIncludes.h:38 public: - /// Adds a string-to-string mapping from \p Path to \p CanonicalPath. - void addMapping(llvm::StringRef Path, llvm::StringRef CanonicalPath); + /// Adds a string-to-st

[clang] 46cfbe5 - [LLVMContext] Replace enableOpaquePointers() with setOpaquePointers()

Author: Nikita Popov Date: 2022-04-05T12:02:48+02:00 New Revision: 46cfbe561bfd3b35984b3e1662bd2bca4eb9e96d URL: https://github.com/llvm/llvm-project/commit/46cfbe561bfd3b35984b3e1662bd2bca4eb9e96d DIFF: https://github.com/llvm/llvm-project/commit/46cfbe561bfd3b35984b3e1662bd2bca4eb9e96d.diff

[clang] 4d8a74c - [Test] Use cc1 instead of mllvm -opaque-pointers option (NFC)

Author: Nikita Popov Date: 2022-04-05T12:04:48+02:00 New Revision: 4d8a74c460eb9ec46f913375c92fa8c2359ddc22 URL: https://github.com/llvm/llvm-project/commit/4d8a74c460eb9ec46f913375c92fa8c2359ddc22 DIFF: https://github.com/llvm/llvm-project/commit/4d8a74c460eb9ec46f913375c92fa8c2359ddc22.diff

[PATCH] D123113: [Flang] Add `INTENT` for non-dummy arguments extension nvfortran compiler supports using INTENT attributes for non-dummy arguments. For example, for local variables.

unterumarmung created this revision. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. unterumarmung requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, jdoerfert, MaskRay. Herald added a reviewer: jdoerfert. Herald added a project: clang. This

[PATCH] D123113: [Flang] Add `INTENT` for non-dummy arguments extension

unterumarmung updated this revision to Diff 420436. unterumarmung retitled this revision from "[Flang] Add `INTENT` for non-dummy arguments extension nvfortran compiler supports using INTENT attributes for non-dummy arguments. For example, for local variables." to "[Flang] Add `INTENT` for non-d

[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer

dang marked 2 inline comments as done. dang added a comment. In D123045#3428030 , @QuietMisdreavus wrote: > In D123045#3427992 , @zixuw wrote: > >> In D123045#3427699 ,

[PATCH] D123113: [Flang] Add `INTENT` for non-dummy arguments extension

unterumarmung updated this revision to Diff 420437. unterumarmung added a comment. Fixed commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123113/new/ https://reviews.llvm.org/D123113 Files: clang/include/clang/Driver/Options.td cla

[PATCH] D122173: [libc++][ranges] Implement ranges::transform

bkramer added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/ranges_transform.module.verify.cpp:1-15 +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exce

[clang] 8b63622 - [clang][extract-api] Undefining macros should not result in a crash

Author: Daniel Grumberg Date: 2022-04-05T11:42:45+01:00 New Revision: 8b63622b9fd9ad2a86487da6098b7a4351d3e8eb URL: https://github.com/llvm/llvm-project/commit/8b63622b9fd9ad2a86487da6098b7a4351d3e8eb DIFF: https://github.com/llvm/llvm-project/commit/8b63622b9fd9ad2a86487da6098b7a4351d3e8eb.dif

[PATCH] D123056: [clang][extract-api] Undefining macros should not result in a crash

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b63622b9fd9: [clang][extract-api] Undefining macros should not result in a crash (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123056/ne

[PATCH] D123019: [clang][extract-api] Add support for typedefs

dang added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:598-605 + // Typedefs of anonymous types have their entries unified with the underlying + // type. + bool ShouldDrop = Record.UnderlyingType.Name.empty(); + // enums declared

[PATCH] D123019: [clang][extract-api] Add support for typedefs

dang updated this revision to Diff 420442. dang added a comment. Whitespace changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123019/new/ https://reviews.llvm.org/D123019 Files: clang/include/clang/ExtractAPI/API.h clang/include/clang/Extr

[PATCH] D122173: [libc++][ranges] Implement ranges::transform

philnik marked an inline comment as done. philnik added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/ranges_transform.module.verify.cpp:1-15 +//===--===// +// +// Part of the LLVM Project, und

[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer

dang added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:510 Symbols.emplace_back(std::move(*Obj)); + PathComponentContext.pop_back(); } dang wrote: > zixuw wrote: > > zixuw wrote: > > > QuietMisdreavus wrote: > >

[PATCH] D121375: [clang] NFC, move the utility function CompilerInvocation::setLangDefaults to LangOptions.h

sammccall added a comment. +1 to Duncan's comments, and a couple of nits while here. Otherwise LG, will be nice to use this without pulling in the grab-bag that is Frontend. In D121375#3428123 , @dexonsmith wrote: > Also, the description doesn't talk a

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman updated this revision to Diff 420446. aaron.ballman added a comment. Fixing the clangd include fixer unit tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122983/new/ https://reviews.llvm.org/D122983 Files: clang-tools-extra/clangd/IncludeFixer.cpp clang-tools-ext

[clang] b1f610f - [Test] Use cc1 interface in more tests (NFC)

Author: Nikita Popov Date: 2022-04-05T13:16:24+02:00 New Revision: b1f610fec54a0083f0086788c404484359a1a48e URL: https://github.com/llvm/llvm-project/commit/b1f610fec54a0083f0086788c404484359a1a48e DIFF: https://github.com/llvm/llvm-project/commit/b1f610fec54a0083f0086788c404484359a1a48e.diff

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman added a comment. In D122983#3427518 , @xbolva00 wrote: > Could you please check that https://github.com/llvm/llvm-test-suite is > buildable with your patch? I gave it a shot just to see, but I'm unable to build it even without my patch:

[clang] f348ca5 - [Tests] Use %clang_cc1 instead of %clang -cc1 in codegen tests (NFC)

Author: Nikita Popov Date: 2022-04-05T13:21:44+02:00 New Revision: f348ca51c741580761e7ddefa1a8a0713494c20e URL: https://github.com/llvm/llvm-project/commit/f348ca51c741580761e7ddefa1a8a0713494c20e DIFF: https://github.com/llvm/llvm-project/commit/f348ca51c741580761e7ddefa1a8a0713494c20e.diff

[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer

dang updated this revision to Diff 420451. dang added a comment. Address code review feedback: - Fix the function signature serialization - Typo fix of "m to ", Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123045/new/ https://reviews.llvm.org/D12

[PATCH] D122954: [clang] Extend target_clones tests to exercise declarations that are not definitions.

aaron.ballman added a comment. In D122954#3427676 , @tahonermann wrote: >> but I DO have the opposite problem: Figuring out what the associated tests >> are for a patch > > I also have that issue, but I don't see the relevance here. The changes in > D1

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4d165ad7d9b3: In fast-math mode, when unsafe math optimizations are enabled, the (authored by zahiraam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122155

[clang] 4d165ad - In fast-math mode, when unsafe math optimizations are enabled, the

Author: Zahira Ammarguellat Date: 2022-04-05T04:58:19-07:00 New Revision: 4d165ad7d9b3395a59c287ef60542b4de3a4d95a URL: https://github.com/llvm/llvm-project/commit/4d165ad7d9b3395a59c287ef60542b4de3a4d95a DIFF: https://github.com/llvm/llvm-project/commit/4d165ad7d9b3395a59c287ef60542b4de3a4d95a

[PATCH] D122808: [clang] Fix warnings when `-Wdeprecated-enum-enum-conversion` is enabled

antoniofrighetto updated this revision to Diff 420458. Herald added subscribers: llvm-commits, dexonsmith. Herald added a project: LLVM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122808/new/ https://reviews.llvm.org/D122808 Files: clang/include/clang/AST/DeclarationName.h llvm/in

[PATCH] D120662: [clang-offload-bundler] add -input/-output options

ronlieb added subscribers: saiislam, ronlieb. ronlieb added a comment. @saiislam for awareness Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120662/new/ https://reviews.llvm.org/D120662 ___ cfe-commits

[PATCH] D123070: [Driver][NFC] Simplify handling of flags in Options.td

awarzynski accepted this revision. awarzynski added a subscriber: jansvoboda11. awarzynski added a comment. This revision is now accepted and ready to land. Thanks for doing this, Emil! This is a much appreciated clean-up. On quite a few occasions I got confused with the nested `let` statements.

[PATCH] D123031: [clangd] Use stable keys for CanonicalIncludes mappings

kbobyrev updated this revision to Diff 420462. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123031/new/ https://reviews.llvm.org/D123031 Files: clang-

[PATCH] D123031: [clangd] Use stable keys for CanonicalIncludes mappings

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Just nits Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:359 if (Entry) { - auto PublicHeader = CanonIncludes.mapHeader(Entry->getName()); +

[PATCH] D122404: [clang][AArc64][SVE] Add support for comparison operators on SVE types

This revision was automatically updated to reflect the committed changes. Closed by commit rG4be1ec9fb5ca: [clang][AArc64][SVE] Add support for comparison operators on SVE types (authored by DavidTruby). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] 4be1ec9 - [clang][AArc64][SVE] Add support for comparison operators on SVE types

Author: David Truby Date: 2022-04-05T13:56:27+01:00 New Revision: 4be1ec9fb5ca59fce923d8a5a3fcb3c40a2884de URL: https://github.com/llvm/llvm-project/commit/4be1ec9fb5ca59fce923d8a5a3fcb3c40a2884de DIFF: https://github.com/llvm/llvm-project/commit/4be1ec9fb5ca59fce923d8a5a3fcb3c40a2884de.diff L

[PATCH] D123032: [clang][dataflow] Exclude protobuf types from modeling in the environment.

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:513 + const RecordDecl *RD = BaseTy->getDecl(); + if (RD->getIdentifier() == nullptr || RD->getName() != "Message") +return false; -

[PATCH] D122954: [clang] Extend target_clones tests to exercise declarations that are not definitions.

erichkeane added a comment. In D122954#3427676 , @tahonermann wrote: >> but I DO have the opposite problem: Figuring out what the associated tests >> are for a patch > > I also have that issue, but I don't see the relevance here. The changes in > D1229

[PATCH] D123037: [clang][dataflow] Support integral casts

ymandel updated this revision to Diff 420483. ymandel marked an inline comment as done. ymandel added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123037/new/ https://reviews.llvm.org/D123037 Files: clang/lib/Analysi

[PATCH] D123037: [clang][dataflow] Support integral casts

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:1904 -const auto *FooVal = -cast(Env.getValue(*FooDecl, SkipPast::None)); -const auto *

[PATCH] D123127: [AST] Add a new TemplateName for templates found via a using declaration.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, martong, mgorny. Herald added a reviewer: shafik. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: ilya-biryukov. Herald added

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman updated this revision to Diff 420488. aaron.ballman added a comment. Fixing more precommit CI failures. The `ScudoWrappersCTest.MallocInfo` do not appear to be caused by this patch, however. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122983/new/ https://reviews.llvm.or

[clang] 54c5033 - [clang] Document p1703 not needed

Author: Nathan Sidwell Date: 2022-04-05T06:54:31-07:00 New Revision: 54c50336e4c11e9c9255d96ae0b55a56cc193ecb URL: https://github.com/llvm/llvm-project/commit/54c50336e4c11e9c9255d96ae0b55a56cc193ecb DIFF: https://github.com/llvm/llvm-project/commit/54c50336e4c11e9c9255d96ae0b55a56cc193ecb.diff

[PATCH] D123120: [clang] Document p1703 not needed

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG54c50336e4c1: [clang] Document p1703 not needed (authored by urnathan). Herald added a project: clang. Herald added a subscriber: cfe-commits. Chang

[clang] d002495 - [clang][dataflow] Support integral casts

Author: Yitzhak Mandelbaum Date: 2022-04-05T13:55:32Z New Revision: d002495b949c1d0d2db22605f134d722a39637fa URL: https://github.com/llvm/llvm-project/commit/d002495b949c1d0d2db22605f134d722a39637fa DIFF: https://github.com/llvm/llvm-project/commit/d002495b949c1d0d2db22605f134d722a39637fa.diff

[PATCH] D123037: [clang][dataflow] Support integral casts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd002495b949c: [clang][dataflow] Support integral casts (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D123070: [Driver][NFC] Simplify handling of flags in Options.td

jansvoboda11 accepted this revision. jansvoboda11 added a comment. Thank you for working on this! I you haven't already, I suggest you test this change by dumping all TableGen records in the backend and comparing the before and after. When working on `Options.td`, I found it quite easy to intro

[PATCH] D122661: [Clang] Do not warn on unused lifetime-extending vars with side effects...

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:1893-1894 +const Expr *Init = VD->getInit(); +if (const ExprWithCleanups *Cleanups = +dyn_cast_or_null(Init)) + Init = Cleanups->getSubExpr(); ===

[PATCH] D122808: [clang] Fix warnings when `-Wdeprecated-enum-enum-conversion` is enabled

aaron.ballman added a comment. Thanks! This is heading in the right direction. You should also add some test coverage to `llvm/unittests/ADT/STLExtrasTests.cpp` for the new interface. Comment at: llvm/include/llvm/ADT/STLExtras.h:207-211 +template , +

[PATCH] D122766: [clang] Use forward slash as the path separator for Windows in __FILE__, __builtin_FILE(), and std::source_location

aaron.ballman added a comment. In D122766#3419303 , @hans wrote: > Maybe Martin or Aaron have opinions here too? Naively, this seems wrong to me. Yes, Windows sometimes allows you to use forward slashes, but that is not the path separator which Windows

[PATCH] D123031: [clangd] Use stable keys for CanonicalIncludes mappings

kbobyrev updated this revision to Diff 420500. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Fix the test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123031/new/ https://reviews.llvm.org/D123031 Files: clang-tools-

[clang-tools-extra] 3de4d5e - [clangd] Use stable keys for CanonicalIncludes mappings

Author: Kirill Bobyrev Date: 2022-04-05T16:27:54+02:00 New Revision: 3de4d5e6dd66165057439c69b6a03e7001ec03e0 URL: https://github.com/llvm/llvm-project/commit/3de4d5e6dd66165057439c69b6a03e7001ec03e0 DIFF: https://github.com/llvm/llvm-project/commit/3de4d5e6dd66165057439c69b6a03e7001ec03e0.diff

[PATCH] D123031: [clangd] Use stable keys for CanonicalIncludes mappings

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3de4d5e6dd66: [clangd] Use stable keys for CanonicalIncludes mappings (authored by kbobyrev). Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D123070: [Driver][NFC] Simplify handling of flags in Options.td

hans accepted this revision. hans added a comment. Looks reasonable to me. I worry that the closing comments on '}'s might rot since there's no tooling to maintain them though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123070/new/ https://rev

[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer

QuietMisdreavus added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:510 Symbols.emplace_back(std::move(*Obj)); + PathComponentContext.pop_back(); } dang wrote: > dang wrote: > > zixuw wrote: > > > zixuw wrote: > >

[PATCH] D122766: [clang] Use forward slash as the path separator for Windows in __FILE__, __builtin_FILE(), and std::source_location

hans added a comment. > My feeling is that the default behavior on Windows needs to be to use > backslashes and not forward slashes. Okay, how would folks feel about always canonicalizing `__FILE__` etc. to use //backslashes// when targeting Windows? Repository: rG LLVM Github Monorepo CHA

[PATCH] D119271: clang: emit allocalign to LLVM for alloc_align attributes

durin42 planned changes to this revision. durin42 added a comment. I have some reworking to do on this after my latest round of llvm-side work that I'll try and get out later this week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119271/new/ htt

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

hubert.reinterpretcast added a comment. In D122983#3429060 , @aaron.ballman wrote: > Morally, yes, that's reasonable in CodeGen because you're ensuring you get no > diagnostics. Practically, that's a convoluted, more expensive, less > maintainable way

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

jdoerfert added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. Are we considering relanding this with smaller alignment for smaller mallocs (and friends)? See: https://github.com/llvm/llvm-project/issues/54747#issuecomment-1088420860 Repository: rG LLVM Github

[clang-tools-extra] 012e90b - Reland "[clangd] IncludeCleaner: Add support for IWYU pragma private"

Author: Kirill Bobyrev Date: 2022-04-05T16:57:39+02:00 New Revision: 012e90bb2483888d113368b69933aec0ab6a5041 URL: https://github.com/llvm/llvm-project/commit/012e90bb2483888d113368b69933aec0ab6a5041 DIFF: https://github.com/llvm/llvm-project/commit/012e90bb2483888d113368b69933aec0ab6a5041.diff

[PATCH] D123127: [AST] Add a new TemplateName for templates found via a using declaration.

sammccall added a comment. This looks pretty good! The tests in clang are sadly indirect. I think adding support to clangd's FindTarget would be a small change and would allow a fairly direct test, but maybe it will affect a bunch of existing tests or possibly have a blast radius. Up to you.

[clang] 09a5eae - [clang-offload-bundler] add -input/-output options

Author: Yaxun (Sam) Liu Date: 2022-04-05T11:13:01-04:00 New Revision: 09a5eae0d1952f53dffd56b9a598215aa1a1487e URL: https://github.com/llvm/llvm-project/commit/09a5eae0d1952f53dffd56b9a598215aa1a1487e DIFF: https://github.com/llvm/llvm-project/commit/09a5eae0d1952f53dffd56b9a598215aa1a1487e.dif

[PATCH] D120662: [clang-offload-bundler] add -input/-output options

This revision was automatically updated to reflect the committed changes. Closed by commit rG09a5eae0d195: [clang-offload-bundler] add -input/-output options (authored by yaxunl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120662/new/ https://rev

[PATCH] D123026: [clang][NFC] Extract the EmitAssemblyHelper::emitLTOSummary method

psamolysov-intel added a comment. Colleagues, could you review this small non-functional change. After the `TargetTruiple` member has been extracted, it becomes clear that there is some code duplication in the `BackendUtil.cpp` source file. I think this is a good idea to eliminate this code dup

[PATCH] D123064: [Clang][C++23][WIP] P2071 Named universal character escapes

cor3ntin updated this revision to Diff 420521. cor3ntin added a comment. - Support loose matching - Modifiy the binary format to make it easier to have a root node Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123064/new/ https://reviews.llvm.org/D

[PATCH] D123026: [clang][NFC] Extract the EmitAssemblyHelper::emitLTOSummary method

tejohnson added a comment. I'd prefer to keep the setting of the module flags inline here. The main reason is that the EnableSplitLTOUnit module flag is also set inline for the ThinLTO case just above, and it is easier to see what is going on if they are near each other. Suggest making the new

[PATCH] D122661: [Clang] Do not warn on unused lifetime-extending vars with side effects...

cor3ntin updated this revision to Diff 420530. cor3ntin marked an inline comment as done. cor3ntin added a comment. - Address Aaron's comments. - Add more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122661/new/ https://reviews.llvm.org/D12

[PATCH] D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum

lenary marked 6 inline comments as done. lenary added a comment. A few comments before I post the next version of the patch. Comment at: llvm/lib/Target/ARM/ARMFixCortexA57AES1742098Pass.cpp:145 + case ARM::VMVNq: +return CondCodeIsAL(3); + // VMOV of 64-bit value between

[PATCH] D123032: [clang][dataflow] Exclude protobuf types from modeling in the environment.

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:513 + const RecordDecl *RD = BaseTy->getDecl(); + if (RD->getIdentifier() == nullptr || RD->getName() != "Message") +return false; ymandel wrote: > xazax.h

[PATCH] D123031: [clangd] Use stable keys for CanonicalIncludes mappings

thakis added a comment. Looks like this breaks tests on Windows: http://45.33.8.238/win/55690/step_9.txt please take a look, etc :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123031/new/ https://reviews.llvm.org/D123031 ___

[PATCH] D123032: [clang][dataflow] Exclude protobuf types from modeling in the environment.

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:513 + const RecordDecl *RD = BaseTy->getDecl(); + if (RD->getIdentifier() == nullptr || RD->getName() != "Message") +return false; xazax.hun wrote: > ymand

[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

qiucf accepted this revision as: qiucf. qiucf added a comment. This revision is now accepted and ready to land. Looks good to me in my side. Thanks for implementing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122478/new/ https://reviews.llvm.

[PATCH] D123100: [Support/Hash functions] Change the `final()` and `result()` of the hashing functions to return an array of bytes

akyrtzi updated this revision to Diff 420545. akyrtzi added a comment. Expand type instead of using `auto` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123100/new/ https://reviews.llvm.org/D123100 Files: bolt/lib/Core/DebugData.cpp clang/incl

[PATCH] D123100: [Support/Hash functions] Change the `final()` and `result()` of the hashing functions to return an array of bytes

akyrtzi added inline comments. Comment at: bolt/lib/Core/DebugData.cpp:823 Hasher.update(AbbrevData); -StringRef Key = Hasher.final(); +auto Hash = Hasher.final(); +StringRef Key((const char *)Hash.data(), Hash.size()); jhenderson wrote: > Amir w

[clang-tools-extra] 211df73 - Fix the test after D123031

Author: Kirill Bobyrev Date: 2022-04-05T18:21:24+02:00 New Revision: 211df7319af4d97b11f59fbc88bfb7ca27eab785 URL: https://github.com/llvm/llvm-project/commit/211df7319af4d97b11f59fbc88bfb7ca27eab785 DIFF: https://github.com/llvm/llvm-project/commit/211df7319af4d97b11f59fbc88bfb7ca27eab785.diff

[PATCH] D123031: [clangd] Use stable keys for CanonicalIncludes mappings

kbobyrev added a comment. In D123031#3429801 , @thakis wrote: > Looks like this breaks tests on Windows: > http://45.33.8.238/win/55690/step_9.txt > > please take a look, etc :) Should be fixed in https://github.com/llvm/llvm-project/commit/211df7319af

[clang] 357afd9 - [clang-format] Pass return code of git-clang-format by sys.exit()

Author: owenca Date: 2022-04-05T09:52:01-07:00 New Revision: 357afd952852db0be3f690f8b647bd4b02f38cad URL: https://github.com/llvm/llvm-project/commit/357afd952852db0be3f690f8b647bd4b02f38cad DIFF: https://github.com/llvm/llvm-project/commit/357afd952852db0be3f690f8b647bd4b02f38cad.diff LOG: [

[PATCH] D123144: FileManager: std::map => BumpPtrAllocator + DenseMap of pointers

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a subscriber: dexonsmith. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is both smaller and faster. Reposito

[clang] bb3980a - DebugInfo: Don't use enumerators in template names for debug info as they are not canonical

Author: David Blaikie Date: 2022-04-05T17:16:42Z New Revision: bb3980ae9fa7e19540080285f2bf2d960ea802fc URL: https://github.com/llvm/llvm-project/commit/bb3980ae9fa7e19540080285f2bf2d960ea802fc DIFF: https://github.com/llvm/llvm-project/commit/bb3980ae9fa7e19540080285f2bf2d960ea802fc.diff LOG:

[PATCH] D123100: [Support/Hash functions] Change the `final()` and `result()` of the hashing functions to return an array of bytes

Amir accepted this revision. Amir added a comment. BOLT changes LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123100/new/ https://reviews.llvm.org/D123100 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D117835: [OpenMPIRBuilder] Detect and fix ambiguous InsertPoints for createSections.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc082ca16f123: [OpenMPIRBuilder] Detect and fix ambiguous InsertPoints for createSections. (authored by Meinersbur). Repository: rG LLVM Github Mon

[PATCH] D122661: [Clang] Do not warn on unused lifetime-extending vars with side effects...

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thanks, the additional test coverage makes it more clear that the changes are good. Please add a release note when landing though! Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D123144: FileManager: std::map => BumpPtrAllocator + DenseMap of pointers

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! maybe put an NFC in the patch name? Comment at: clang/lib/Basic/FileManager.cpp:581 /// do directory look-up instead of file look-up. -std::error_code -FileManag

[PATCH] D123070: [Driver][NFC] Simplify handling of flags in Options.td

ekieri added a comment. Thank you all for the support! @jansvoboda11 , yes, I did that, and will do it again before pushing. @hans , thanks, that is a valid concern. I was asked to add closing comments on an earlier patch though, and I find them particularly useful (when accurate...) in this f

[clang-tools-extra] a0e4ba4 - [clangd] Add support to extract method for ExtractFunction Tweak

Author: Fabio Rossini Sluzala Date: 2022-04-05T19:49:17+02:00 New Revision: a0e4ba4b4607267d96c3ab8bc1c38f5a09830692 URL: https://github.com/llvm/llvm-project/commit/a0e4ba4b4607267d96c3ab8bc1c38f5a09830692 DIFF: https://github.com/llvm/llvm-project/commit/a0e4ba4b4607267d96c3ab8bc1c38f5a098306

[PATCH] D122698: [clangd] Add support to extract method for ExtractFunction Tweak

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0e4ba4b4607: [clangd] Add support to extract method for ExtractFunction Tweak (authored by FabioRS, committed by sammccall). Changed prior to commit: https://reviews.llvm.org/D122698?vs=420336&id=42057

[PATCH] D122698: [clangd] Add support to extract method for ExtractFunction Tweak

sammccall added a comment. You're right about the out-of-line function case. Current version looks great! I had to rework the logic around merging the edits a little, it wasn't quite correct and was hitting assertions (not sure if you were seeing these locally, but phabricator is not currently r

[clang] cf1c550 - FileManager: std::map => BumpPtrAllocator + DenseMap of pointers. NFC

Author: Sam McCall Date: 2022-04-05T19:54:44+02:00 New Revision: cf1c5507b7259de219c45d601ee3249993263ec1 URL: https://github.com/llvm/llvm-project/commit/cf1c5507b7259de219c45d601ee3249993263ec1 DIFF: https://github.com/llvm/llvm-project/commit/cf1c5507b7259de219c45d601ee3249993263ec1.diff LO

[PATCH] D123144: FileManager: std::map => BumpPtrAllocator + DenseMap of pointers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rGcf1c5507b725: FileManager: std::map => BumpPtrAllocator + DenseMap of pointers. NFC (authored by sammccal

[PATCH] D123104: [Modules] Use looked-up filename when looking for module maps

benlangmuir accepted this revision. benlangmuir added inline comments. Comment at: clang/include/clang/Lex/HeaderSearch.h:758 + bool IsSystemHeaderDir, + StringRef FileName = ""); This parameter co

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

beanz added reviewers: pow2clk, rnk, bogner, MaskRay, dexonsmith. beanz added a comment. Herald added a subscriber: StephenFan. Looping in a few extra reviewers, also added some comments below. Comment at: clang/lib/Driver/ToolChains/HLSL.cpp:43 +return false; + if (!Versi

[PATCH] D119609: [Clang][Sema] Prohibit statement expression in the default argument

aaron.ballman accepted this revision. aaron.ballman added a comment. This should also have a release note that explains the change in behavior, since we're now being more restrictive with what programs we accept. Aside from the release note and the column wrapping, this LGTM!

[PATCH] D122955: [clang] NFC: Enhance comments in CodeGen for multiversion function support.

tahonermann updated this revision to Diff 420586. tahonermann added a comment. Reworded a comment to address code review commentary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122955/new/ https://reviews.llvm.org/D122955 Files: clang/include/

  1   2   3   >