sammccall added a comment.

You're right about the out-of-line function case. Current version looks great!
I had to rework the logic around merging the edits a little, it wasn't quite 
correct and was hitting assertions (not sure if you were seeing these locally, 
but phabricator is not currently running the clangd tests properly).

Thanks again, landing now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122698/new/

https://reviews.llvm.org/D122698

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to