[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

2022-04-02 Thread Xiang Li via Phabricator via cfe-commits
python3kgae updated this revision to Diff 419954. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122865/new/ https://reviews.llvm.org/D122865 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver/Driver.h clang/in

[PATCH] D122965: Corrected A Command

2022-04-02 Thread Priyansh Singh via Phabricator via cfe-commits
ps-19 added a comment. I seriously can not understand why x64_Debian build if failing for every patch. Comment at: clang/test/CodeGen/c-unicode.c:5 int \uaccess = 0; // ALLOWED: "곎ss": // ALLOWED-NOT: "\uaccess": Comment Line No: 5 is // ALLOWED: "곎ss": i th

[PATCH] D122965: Corrected A Command

2022-04-02 Thread Priyansh Singh via Phabricator via cfe-commits
ps-19 added a comment. In D122965#3424348 , @ps-19 wrote: > I seriously can not understand why x64_Debian build if failing for every > patch. I have ran clang-format command for every patch even multiple times. Repository: rG LLVM Github Monorepo C

[PATCH] D119609: [Clang][Sema] Prohibit expression statement in lambda default argument

2022-04-02 Thread Jun Zhang via Phabricator via cfe-commits
junaire updated this revision to Diff 419965. junaire added a comment. - Rebase. - Update commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119609/new/ https://reviews.llvm.org/D119609 Files: clang/include/clang/Basic/DiagnosticSemaK

[PATCH] D119609: [Clang][Sema] Prohibit expr statement in the default argument

2022-04-02 Thread Jun Zhang via Phabricator via cfe-commits
junaire added a comment. Hi @aaron.ballman, do you think it's time to consider reviewing this? I don't why there's no response or progress in GCC, but I think I can submit a patch for them if they think this issue is low prior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] cc21395 - [AMDPU][Sanitizer] Refactor sanitizer options handling for AMDGPU Toolchain

2022-04-02 Thread Ron Lieberman via cfe-commits
Author: Ron Lieberman Date: 2022-04-02T11:01:09Z New Revision: cc2139524f77248c7e147d4cc3befb31fe3e6daa URL: https://github.com/llvm/llvm-project/commit/cc2139524f77248c7e147d4cc3befb31fe3e6daa DIFF: https://github.com/llvm/llvm-project/commit/cc2139524f77248c7e147d4cc3befb31fe3e6daa.diff LOG:

[PATCH] D122781: Refactor sanitizer options handling for AMDGPU Toolchain

2022-04-02 Thread Ron Lieberman via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGcc2139524f77: [AMDPU][Sanitizer] Refactor sanitizer options handling for AMDGPU Toolchain (authored by ronlieb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D122781: Refactor sanitizer options handling for AMDGPU Toolchain

2022-04-02 Thread Ron Lieberman via Phabricator via cfe-commits
ronlieb added a comment. i pushed it in. will watch for build bot issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122781/new/ https://reviews.llvm.org/D122781 ___ cfe-commits mailing list cfe-commit

[PATCH] D122768: [WIP][Clang] Support capturing structured bindings in lambdas

2022-04-02 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 419970. cor3ntin added a comment. - Add codegen test - Fixed a typo that caused openmp test failures - Cleanups & formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.llvm.org/D

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

2022-04-02 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9060 continue; - const VarDecl *VD = LC.getCapturedVar(); + const VarDecl *VD = cast(LC.getCapturedVar()); if (LC.getCaptureKind() != LCK_ByRef && !VD->getType()->isPointer

[clang] f1e7eca - Revert "[AMDPU][Sanitizer] Refactor sanitizer options handling for AMDGPU Toolchain"

2022-04-02 Thread Ron Lieberman via cfe-commits
Author: Ron Lieberman Date: 2022-04-02T13:25:50Z New Revision: f1e7ecaa18a7b1c77fc95e4b83d3db02c4e2d211 URL: https://github.com/llvm/llvm-project/commit/f1e7ecaa18a7b1c77fc95e4b83d3db02c4e2d211 DIFF: https://github.com/llvm/llvm-project/commit/f1e7ecaa18a7b1c77fc95e4b83d3db02c4e2d211.diff LOG:

[clang] b93893e - [AArch64] Default HBC/MOPS features in clang

2022-04-02 Thread via cfe-commits
Author: tyb0807 Date: 2022-04-02T14:51:23+01:00 New Revision: b93893e60f0c860e5814cea6cc285c8e89e035af URL: https://github.com/llvm/llvm-project/commit/b93893e60f0c860e5814cea6cc285c8e89e035af DIFF: https://github.com/llvm/llvm-project/commit/b93893e60f0c860e5814cea6cc285c8e89e035af.diff LOG:

[clang] 9a015ee - [AArch64] Avoid scanning feature list for target parsing

2022-04-02 Thread via cfe-commits
Author: tyb0807 Date: 2022-04-02T14:51:23+01:00 New Revision: 9a015ee1f948755d69dc2ff52e7655229e2eed47 URL: https://github.com/llvm/llvm-project/commit/9a015ee1f948755d69dc2ff52e7655229e2eed47 DIFF: https://github.com/llvm/llvm-project/commit/9a015ee1f948755d69dc2ff52e7655229e2eed47.diff LOG:

[PATCH] D120111: [AArch64] Default HBC/MOPS features in clang

2022-04-02 Thread Son Tuan Vu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb93893e60f0c: [AArch64] Default HBC/MOPS features in clang (authored by tyb0807). Herald added a subscriber: MaskRay. Herald added a project: All. R

[PATCH] D120864: [AArch64] Avoid scanning feature list for target parsing

2022-04-02 Thread Son Tuan Vu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9a015ee1f948: [AArch64] Avoid scanning feature list for target parsing (authored by tyb0807). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

2022-04-02 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 419980. cor3ntin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.llvm.org/D122768 Files: clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp clang

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

2022-04-02 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 419988. cor3ntin added a comment. Better codegen test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.llvm.org/D122768 Files: clang-tools-extra/clang-tidy/modernize/LoopConvertUtil

[PATCH] D72742: Don't assume promotable integers are zero/sign-extended already in x86-64 ABI.

2022-04-02 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. Herald added subscribers: StephenFan, sstefan1. Herald added a project: All. Passing-by remark: i'm not sure it was noted already, but i believe that the function linkage should be differentiated here, the ABI mismatch can only exist if the function can actually be call

[PATCH] D122981: [Clang] Diagnose incomplete return/param types only when function is not deleted

2022-04-02 Thread PoYao Chang via Phabricator via cfe-commits
rZhBoYao created this revision. rZhBoYao added reviewers: ChuanqiXu, rsmith. rZhBoYao added a project: clang. Herald added a project: All. rZhBoYao requested review of this revision. Herald added a subscriber: cfe-commits. According to dcl.fct.def.general p2

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

2022-04-02 Thread Xiang Li via Phabricator via cfe-commits
python3kgae updated this revision to Diff 419991. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122865/new/ https://reviews.llvm.org/D122865 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver/Driver.h clang/in

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

2022-04-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman created this revision. aaron.ballman added reviewers: jyknight, eli.friedman, rjmccall, erichkeane, clang-language-wg. Herald added subscribers: usaxena95, pengfei, kadircet, arphaman. Herald added a project: All. aaron.ballman requested review of this revision. Herald added projects

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

2022-04-02 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added inline comments. Comment at: clang/docs/ReleaseNotes.rst:114 +- The ``-Wimplicit-function-declaration`` warning diagnostic now defaults to + emitting an error (which can be downgraded with ``-Wno-error``) in C11 and + C17 mode. This is because the feature was rem

[PATCH] D122952: [clang] NFC: Extend comdat validation in target multiversion function tests.

2022-04-02 Thread Tom Honermann via Phabricator via cfe-commits
tahonermann created this revision. tahonermann added reviewers: erichkeane, aaron.ballman. Herald added a project: All. tahonermann added inline comments. tahonermann published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Commen

[PATCH] D122953: [clang] Emit target_clones resolver functions as COMDAT.

2022-04-02 Thread Tom Honermann via Phabricator via cfe-commits
tahonermann created this revision. tahonermann added reviewers: erichkeane, aaron.ballman. Herald added a project: All. tahonermann published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, resolver functions synthesized for target_clone

[PATCH] D122954: [clang] Extend target_clones tests to exercise declarations that are not definitions.

2022-04-02 Thread Tom Honermann via Phabricator via cfe-commits
tahonermann created this revision. tahonermann added reviewers: erichkeane, aaron.ballman. Herald added a project: All. tahonermann added inline comments. tahonermann published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Commen

[PATCH] D122955: [clang] NFC: Enhance comments in CodeGen for multiversion function support.

2022-04-02 Thread Tom Honermann via Phabricator via cfe-commits
tahonermann created this revision. tahonermann added reviewers: erichkeane, aaron.ballman. Herald added a project: All. tahonermann added inline comments. tahonermann published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Commen

[PATCH] D122956: [clang] NFC: Simplify the interface to CodeGenModule::GetOrCreateMultiVersionResolver().

2022-04-02 Thread Tom Honermann via Phabricator via cfe-commits
tahonermann created this revision. tahonermann added reviewers: erichkeane, aaron.ballman. Herald added a project: All. tahonermann added inline comments. tahonermann published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Commen

[PATCH] D122957: [clang] NFC: Preparation for merging code to emit target and target_clones resolvers.

2022-04-02 Thread Tom Honermann via Phabricator via cfe-commits
tahonermann created this revision. tahonermann added reviewers: erichkeane, aaron.ballman. Herald added a project: All. tahonermann published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change modifies CodeGenModule::emitMultiVersionFunctio

[PATCH] D122958: [clang] Corrections for target_clones multiversion functions.

2022-04-02 Thread Tom Honermann via Phabricator via cfe-commits
tahonermann created this revision. tahonermann added reviewers: erichkeane, aaron.ballman. Herald added a subscriber: kristof.beyls. Herald added a project: All. tahonermann updated this revision to Diff 419919. tahonermann added a comment. tahonermann updated this revision to Diff 420008. tahonerm