lebedev.ri added a comment.
Herald added subscribers: StephenFan, sstefan1.
Herald added a project: All.

Passing-by remark: i'm not sure it was noted already,
but i believe that the function linkage should be differentiated here,
the ABI mismatch can only exist if the function can actually be called
from the external code, which isn't always the case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72742/new/

https://reviews.llvm.org/D72742

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to