[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

qiucf added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9899 +def err_ppc_unsupported_argument_type : Error< + "unsupported argument type %0 for target %1">; def err_x86_builtin_invalid_rounding : Error< Can we re-use `err_type

[PATCH] D122556: [RISCV] Add definitions for Xiangshan processors.

MaskRay added inline comments. Comment at: clang/test/CodeGen/RISCV/riscv-metadata.c:18 +// Test if Xiangshan processors work with -target-cpu +// RUN: %clang_cc1 -triple riscv64 -emit-llvm -o - -target-cpu xiangshan-yanqihu %s | FileCheck -check-prefix=EMPTY-LP64 %s -

[PATCH] D122556: [RISCV] Add definitions for Xiangshan processors.

MaskRay added inline comments. Comment at: clang/test/Driver/riscv-cpus.c:146 +// MCPU-XS-NANHU: "-target-feature" "+m" "-target-feature" "+a" "-target-feature" "+f" "-target-feature" "+d" +// MCPU-XS-NANHU: "-target-feature" "+c" "-target-feature" "+zba" "-target-feature" "+zb

[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

tingwang updated this revision to Diff 418509. tingwang added a comment. Update test case to show that we need D122462 to fix the crash. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122478/new/ https://reviews.l

[PATCH] D122542: [flang][driver] Make --version and -version consistent with clang

awarzynski accepted this revision. awarzynski added a comment. Makes sense, many thanks for doing this! Comment at: clang/include/clang/Driver/Options.td:5756 + +} + [nit] IMHO this file lacks comments, hence the suggestion :) Repository: rG LLVM Github Mo

[PATCH] D121984: [RISCV][NFC] Moving RVV intrinsic type related util to llvm/Support

MaskRay added a comment. Seems that there is a circular dependency problem: 7c7e7770b7176f452d40f4e7ac545aaee1b19c4d (reverted). I'd suggest that we revert this patch. Having target specific stuff in LLVMSupport is always f

[clang] c0eb9b4 - Revert D121984 "[RISCV][NFC] Moving RVV intrinsic type related util to llvm/Support"

Author: Fangrui Song Date: 2022-03-28T01:17:37-07:00 New Revision: c0eb9b4cdef6049ebabb4018d3c9dcb0dc699868 URL: https://github.com/llvm/llvm-project/commit/c0eb9b4cdef6049ebabb4018d3c9dcb0dc699868 DIFF: https://github.com/llvm/llvm-project/commit/c0eb9b4cdef6049ebabb4018d3c9dcb0dc699868.diff

[PATCH] D121984: [RISCV][NFC] Moving RVV intrinsic type related util to llvm/Support

kito-cheng added a subscriber: akuegel. kito-cheng added a comment. Hi @MaskRay, @akuegel has removed the `llvm/TableGen/*`, so I guess the issue you mentioned in https://github.com/llvm/llvm-project/commit/c0eb9b4cdef6049ebabb4018d3c9dcb0dc699868 is resolved by https://github.com/llvm/llvm-pr

[PATCH] D121984: [RISCV][NFC] Moving RVV intrinsic type related util to llvm/Support

akuegel added a comment. Yes, I believe the issue with the circular dependency was already fixed by my latest commit. Sorry for first committing the wrong fix (just removing the headers without checking that they were needed to pull in raw_ostream header transitively). So if you apply my fix, y

[PATCH] D121984: [RISCV][NFC] Moving RVV intrinsic type related util to llvm/Support

MaskRay added a comment. Ah, sorry, I did not see that the end state of @akuegel's 3 commits fixed the circular dependency. However, I think my other concern still applies: the layering seems weird that the RISCV stuff is placed in LLVMSupport. Any chance it can be fixed? You may consider a mor

[PATCH] D121984: [RISCV][NFC] Moving RVV intrinsic type related util to llvm/Support

MaskRay added a comment. The original patch added 600 lines while the subject just said "Move". This may be fishy as well. Having TableGen related `void RVVIntrinsic::emitCodeGenSwitchBody(raw_ostream &OS) const {` in LLVMSupport is also weird. So I think this patch deserves more discussion an

[PATCH] D122234: [clang] Link libbitint for large division of _BitInt; increase max _BitInt size

mgehre-amd marked 2 inline comments as done. mgehre-amd added inline comments. Herald added a subscriber: MaskRay. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8422 +def err_int_to_float_bit_int_max_size : Error< + "cannot convert '_BitInt' operands of more tha

[clang] c5d83cd - [clang][ASTImporter] Fix a bug when importing CXXDefaultInitExpr.

Author: Balázs Kéri Date: 2022-03-28T10:55:26+02:00 New Revision: c5d83cdca457fd024a3f76c5e2ba649462ecde67 URL: https://github.com/llvm/llvm-project/commit/c5d83cdca457fd024a3f76c5e2ba649462ecde67 DIFF: https://github.com/llvm/llvm-project/commit/c5d83cdca457fd024a3f76c5e2ba649462ecde67.diff L

[PATCH] D120824: [clang][ASTImporter] Fix a bug when importing CXXDefaultInitExpr.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc5d83cdca457: [clang][ASTImporter] Fix a bug when importing CXXDefaultInitExpr. (authored by balazske). Changed prior to commit: https://reviews.llvm.org/D120824?vs=414642&id=418521#toc Repository: r

[PATCH] D122564: [RISCV] [NFC] add some tests for overloaded intrinsics of FP16

Chenbing.Zheng created this revision. Chenbing.Zheng added reviewers: craig.topper, HsiangKai, benshi001, frasercrmck. Chenbing.Zheng added a project: LLVM. Herald added subscribers: s, VincentWu, luke957, StephenFan, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnob

[PATCH] D119409: [C++20] [Modules] Remain dynamic initializing internal-linkage variables in module interface unit

iains added a comment. In D119409#3410474 , @ChuanqiXu wrote: > In D119409#3409806 , @iains wrote: > >> I think that this problem might well be a consequence of the bug which is >> fixed by D122413

[clang] 8a2a966 - Return -no-canonical-prefixes for riskv32/64 test

Author: Mikhail Goncharov Date: 2022-03-28T11:23:14+02:00 New Revision: 8a2a966520023cd7d424e89b730c054f1f06f496 URL: https://github.com/llvm/llvm-project/commit/8a2a966520023cd7d424e89b730c054f1f06f496 DIFF: https://github.com/llvm/llvm-project/commit/8a2a966520023cd7d424e89b730c054f1f06f496.d

[PATCH] D119409: [C++20] [Modules] Remain dynamic initializing internal-linkage variables in module interface unit

ChuanqiXu added a comment. In D119409#3410868 , @iains wrote: > In D119409#3410474 , @ChuanqiXu > wrote: > >> In D119409#3409806 , @iains wrote: >> >>> I think that this

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:270 + // needed. + BoolValue &ComparisonValue = MakeValue(Env, *HasValueVal); + auto *ComparisonExprLoc = ymandel wrote: > ymandel wrote: > > xa

[PATCH] D122567: [X86][AMX] enable amx cast intrinsics in FE.

LuoYuanke created this revision. Herald added a subscriber: pengfei. Herald added a project: All. LuoYuanke requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We have some discission in D99152 and llvm-dev an

[PATCH] D99152: [AMX] Prototype for vector and amx bitcast.

LuoYuanke added a comment. Herald added a project: All. In D99152#3235546 , @lebedev.ri wrote: > What's the status here? Here is the patch D122567 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D122554: [clangd] Handle tabs in getIncrementalChangesAfterNewline()

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Going to add tabs to case-sensitivity and symlinks to my list of things that will haunt me forever... Comment at: clang-tools-extra/clangd/Format.cpp:127 + i

[PATCH] D122469: OpenMP 5.1 - Support 'seq_cst' clause on 'flush' directive

soumitra updated this revision to Diff 418530. soumitra added a comment. The previous patch had unrelated changes inadvertently. Corrected. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122469/new/ https://reviews.llvm.org/D122469 Files: clang/include/clang/AST/OpenMPClause.h clang

[PATCH] D121451: [clang-format] Add space to comments starting with '#'.

sammccall added a comment. In D121451#3402167 , @curdeius wrote: > You comment the whole block and it becomes (with this patch): > > // #include > // > // int something; > > whereas it was: > > //#include > // > // int something; > > which s

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth added a comment. ok. then i will continue under `misc-const-correctness`. thank you for the clarifications! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943 ___

[PATCH] D122547: [clang] Make Driver tests pass when running with temp dir containing "crt"

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122547/new/ https://reviews.llvm.org/D122547 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

balazske added a comment. I found only small issues. Comment at: clang-tools-extra/clang-tidy/bugprone/UnsafeFunctionsCheck.cpp:109 + + SourceRange Range = SourceRange(DeclRef->getBeginLoc(), DeclRef->getEndLoc()); + // FIXME: I'm not sure if this can ever happen, but to be

[PATCH] D122377: [PowerPC][Linux] Support 16-byte lock free atomics on pwr8 and up

lkail updated this revision to Diff 418537. lkail added a comment. Thanks @efriedma for pointing out. Updated guard code. Also adjust backend to reflect ABI change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122377/new/ https://reviews.llvm.org

[PATCH] D122495: [clang][extract-api] Use correct language info from inputs

dang added inline comments. Comment at: clang/include/clang/ExtractAPI/API.h:312 - /// Get the language options used to parse the APIs. - const LangOptions &getLangOpts() const { return LangOpts; } + /// Get the language by the APIs. + Language getLanguage() const { return

[PATCH] D122573: [TBAA] Emit distinct TBAA tags for pointers with different depths,types.

fhahn created this revision. fhahn added reviewers: rjmccall, aaron.ballman, scanon, rsmith, hfinkel. Herald added subscribers: jeroen.dobbelaere, kosarev. Herald added a project: All. fhahn requested review of this revision. Herald added a project: clang. This patch extends Clang's TBAA generatio

[PATCH] D122234: [clang] Link libbitint for large division of _BitInt; increase max _BitInt size

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8422 +def err_int_to_float_bit_int_max_size : Error< + "cannot convert '_BitInt' operands of more than %0 bits to floating point">; mgehre-amd wrote: > aaron.ball

[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

tingwang updated this revision to Diff 418544. tingwang marked 11 inline comments as done. tingwang added a comment. Update based on Chaofan's suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122478/new/ https://reviews.llvm.org/D122478

[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

tingwang added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:192 + [llvm_float_ty, llvm_float_ty, llvm_float_ty, llvm_vararg_ty], + [IntrNoMem]>; } qiucf wrote: > Will we support `llvm_f128_ty`? I'm afr

[PATCH] D122409: [libclang] Add missing CursorKind enums defined in Index.h.

sighingnow added a comment. /cc @arphaman @sstefan1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122409/new/ https://reviews.llvm.org/D122409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

ymandel marked 2 inline comments as done. ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:270 + // needed. + BoolValue &ComparisonValue = MakeValue(Env, *HasValueVal); + auto *ComparisonExprLoc =

[PATCH] D122544: Utilize comparison operation implemented in APInt

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Can you also add a release note for the fix? I'm happy to land this on your behalf if you'd prefer, but given that you've had several quality commits already, you might wan

[PATCH] D122556: [RISCV] Add definitions for Xiangshan processors.

jrtc27 added inline comments. Comment at: llvm/include/llvm/Support/RISCVTargetParser.def:34 PROC(SIFIVE_U74, {"sifive-u74"}, FK_64BIT, {"rv64gc"}) +PROC(XIANGSHAN_YANQIHU,{"xiangshan-yanqihu"},FK_64BIT,{"rv64gc"}) +PROC(XIANGSHAN_NANHU,{"xiangshan-nanhu"},FK_64BIT,{"rv64imafdc_

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

amyk added a comment. Overall this change looks good to me, although I do have one question. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15208 - for (unsigned i = 0, e = E->getNumArgs(); i != e; i++) { -if (E->getArg(i)->getType()->isArrayType()) - Ops.push_back(EmitA

[clang] 281b7ee - Update www_status/add test for P1972:

Author: Erich Keane Date: 2022-03-28T06:31:04-07:00 New Revision: 281b7eeb149d236dd4f2c1ab976cce361de4e057 URL: https://github.com/llvm/llvm-project/commit/281b7eeb149d236dd4f2c1ab976cce361de4e057 DIFF: https://github.com/llvm/llvm-project/commit/281b7eeb149d236dd4f2c1ab976cce361de4e057.diff L

[PATCH] D122519: [AIX] XFAIL test for lack of visibility support

cebowleratibm accepted this revision. cebowleratibm added a comment. This revision is now accepted and ready to land. The AIX default of ignoring source-level visibility is problematic. I agree the test should be xfailed for AIX. You can put [NFC] and [tests] to the commit. Should be safe to c

[clang] f5a9b5c - [NFC][tests][AIX] XFAIL test for lack of visibility support

Author: Jake Egan Date: 2022-03-28T09:43:48-04:00 New Revision: f5a9b5cc12658f4d6caa3e0cfc3e771698fb3798 URL: https://github.com/llvm/llvm-project/commit/f5a9b5cc12658f4d6caa3e0cfc3e771698fb3798 DIFF: https://github.com/llvm/llvm-project/commit/f5a9b5cc12658f4d6caa3e0cfc3e771698fb3798.diff LOG

[PATCH] D122519: [NFC][tests][AIX] XFAIL test for lack of visibility support

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5a9b5cc1265: [NFC][tests][AIX] XFAIL test for lack of visibility support (authored by Jake-Egan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122519/new/

[clang] 4df69c1 - [ARM] Make testcase warning pattern match more specific

Author: Ranjeet Singh Date: 2022-03-28T14:44:15+01:00 New Revision: 4df69c1ff19f75e302cfc3e022009fe971fc5c24 URL: https://github.com/llvm/llvm-project/commit/4df69c1ff19f75e302cfc3e022009fe971fc5c24 DIFF: https://github.com/llvm/llvm-project/commit/4df69c1ff19f75e302cfc3e022009fe971fc5c24.diff

[PATCH] D122487: [ARM] Make testcase warning pattern match more specific

This revision was automatically updated to reflect the committed changes. Closed by commit rG4df69c1ff19f: [ARM] Make testcase warning pattern match more specific (authored by rs). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122487/new/ https://re

[PATCH] D122585: [OpenMP] Handle function declaration or definition omp pragmas in C mode

rpenacob created this revision. rpenacob added reviewers: ABataev, jdoerfert. Herald added subscribers: guansong, yaxunl. Herald added a project: All. rpenacob requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Clang crashes when a C+

[PATCH] D122378: [doc] Rely on tblgen to dump supported options value when generating doc

serge-sans-paille updated this revision to Diff 418579. serge-sans-paille retitled this revision from "Be more explicit about -fvisibility= documentation" to "[doc] Rely on tblgen to dump supported options value when generating doc". serge-sans-paille edited the summary of this revision. serge-sa

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski updated this revision to Diff 418580. awarzynski added a comment. Herald added a subscriber: MaskRay. Use llvm_add_library instead of add_flang_library Fortran_main should be a static library, but `add_flang_library` does not parse `STATIC` in `add_flang_library(Fortran_main STATIC For

[PATCH] D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum

lenary added a comment. In D119720#3339855 , @dmgreen wrote: > I have a high level question regarding RDF, as I've not seen it used in many > other places, so it may be under-tested on Arm systems at the moment. This > currently, for all code, builds an

[PATCH] D122553: [Driver][AVR] Fix warn_drv_avr_stdlib_not_linked condition

benshi001 accepted this revision. benshi001 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:451 + !Args.hasArg(options::OPT_nodefaultlibs)) { +if (CPU.empty()) { + // We cannot link any standard

[PATCH] D122586: Fix template instantiation of UDLs

aaron.ballman created this revision. aaron.ballman added reviewers: erichkeane, rsmith, clang-language-wg. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. Previously, we would instantiate the UDL by marking the function as referenced an

[PATCH] D122586: Fix template instantiation of UDLs

erichkeane added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:10516 TreeTransform::TransformUserDefinedLiteral(UserDefinedLiteral *E) { - if (FunctionDecl *FD = E->getDirectCallee()) -SemaRef.MarkFunctionReferenced(E->getBeginLoc(), FD); - return SemaRef.May

[PATCH] D122586: Fix template instantiation of UDLs

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/test/CodeGenCXX/cxx20-consteval-crash.cpp:28 + +namespace Issue54578 { +inline consteval unsigned char operator""_UC(const unsigned long long n) {

[PATCH] D122586: Fix template instantiation of UDLs

cor3ntin added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:10516 TreeTransform::TransformUserDefinedLiteral(UserDefinedLiteral *E) { - if (FunctionDecl *FD = E->getDirectCallee()) -SemaRef.MarkFunctionReferenced(E->getBeginLoc(), FD); - return SemaRef.Maybe

[PATCH] D122586: Fix template instantiation of UDLs

aaron.ballman added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:10516 TreeTransform::TransformUserDefinedLiteral(UserDefinedLiteral *E) { - if (FunctionDecl *FD = E->getDirectCallee()) -SemaRef.MarkFunctionReferenced(E->getBeginLoc(), FD); - return SemaRef.

[PATCH] D122586: Fix template instantiation of UDLs

erichkeane added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:10516 TreeTransform::TransformUserDefinedLiteral(UserDefinedLiteral *E) { - if (FunctionDecl *FD = E->getDirectCallee()) -SemaRef.MarkFunctionReferenced(E->getBeginLoc(), FD); - return SemaRef.May

[PATCH] D122587: [clang][NFC] Extract the EmitAssemblyHelper::TargetTriple member

psamolysov-intel created this revision. psamolysov-intel added reviewers: tejohnson, ddunbar, tobiasvk, tobiasvk_caf. psamolysov-intel added a project: clang. Herald added a subscriber: ormris. Herald added a project: All. psamolysov-intel requested review of this revision. Herald added a subscribe

[PATCH] D122587: [clang][NFC] Extract the EmitAssemblyHelper::TargetTriple member

psamolysov-intel added a comment. I see some code duplication on lines 1056-1065 and 1472-1481, I have a fix for this and going to open a new review after this patch will be landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122587/new/ https:/

[PATCH] D120989: Support debug info for alias variable

kavitha-natarajan added a comment. > Thanks for the details - can you ping this thread once the gdb thread has > progressed/seems like it's moving in this direction? @dblaikie, received comments for the gdb patch https://sourceware.org/pipermail/gdb-patches/2022-March/186960.html and the next

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

zahiraam updated this revision to Diff 418597. zahiraam marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122155/new/ https://reviews.llvm.org/D122155 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/include/clang/Basic/DiagnosticSemaKin

[PATCH] D121302: [HIP] Fix -fno-gpu-sanitize

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/HIPAMD.cpp:165 // Diagnose unsupported sanitizer options only once. + if (!Args.hasFlag(options::OPT_fgpu_sanitize, options::OPT_fno_gpu_sanitize)) +return;

[PATCH] D122588: [RISCV] Make PATH empty when testing --gcc-toolchain is multilib_riscv_elf_sdk

StephenFan created this revision. StephenFan added reviewers: MaskRay, khchen, asb, jrtc27. Herald added subscribers: s, VincentWu, luke957, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, e

[clang] e334f04 - [libTooling] Support TransformerResult in consumer callbacks

Author: Eric Li Date: 2022-03-28T15:39:46Z New Revision: e334f044cdb5c0f4f549fc0380a6757e37ccb105 URL: https://github.com/llvm/llvm-project/commit/e334f044cdb5c0f4f549fc0380a6757e37ccb105 DIFF: https://github.com/llvm/llvm-project/commit/e334f044cdb5c0f4f549fc0380a6757e37ccb105.diff LOG: [libT

[PATCH] D122499: [libTooling] Support TransformerResult in consumer callbacks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe334f044cdb5: [libTooling] Support TransformerResult in consumer callbacks (authored by li.zhe.hua, committed by ymandel). Repository: rG L

[PATCH] D122589: Additionally set f32 mode with denormal-fp-math

dcandler created this revision. dcandler added reviewers: arsenm, spatel. Herald added a project: All. dcandler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, wdng. Herald added a project: clang. When the denormal-fp-math option is used, this should set the deno

[PATCH] D122444: [Driver][Linux] Remove D.Dir+"/../lib" from default search paths for LLVM_ENABLE_RUNTIMES builds

jdoerfert reopened this revision. jdoerfert added a comment. This revision is now accepted and ready to land. So, this broke all OpenMP (offloading) as libomp and (libomptarget) are no longer found by default. (OpenMP is build as ENABLE_RUNTIME.) How do we fix this? Repository: rG LLVM Githu

[PATCH] D122444: [Driver][Linux] Remove D.Dir+"/../lib" from default search paths for LLVM_ENABLE_RUNTIMES builds

jhuber6 added a comment. This change broke finding the OpenMP runtime libraries when using the LLVM runtimes build. clang foo.c -fopenmp -fopenmp-targets=nvptx64 /usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: cannot find -lomp /usr/lib64/gcc/x86_64-suse-linux/7/.

[PATCH] D122587: [clang][NFC] Extract the EmitAssemblyHelper::TargetTriple member

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122587/new/ https://reviews.llvm.org/D122587 _

[PATCH] D122378: [doc] Rely on tblgen to dump supported options value when generating doc

serge-sans-paille updated this revision to Diff 418608. serge-sans-paille added a comment. Minor Options.td nits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122378/new/ https://reviews.llvm.org/D122378 Files: clang/include/clang/Driver/Options.td llvm/utils/TableGen/OptRSTEmitter

[PATCH] D122546: Let clang-repl link privately against Clang components

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. Thanks for the clarification! LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122546/new/ https://reviews.llvm.org/D122546

[PATCH] D122589: Additionally set f32 mode with denormal-fp-math

arsenm added a comment. Testcase? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122589/new/ https://reviews.llvm.org/D122589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

jansvoboda11 added a comment. Thanks for the revert @gulfem. I was hoping I'll be able to quickly forward-fix the issue, but turns out there's more to investigate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121812/new/ https://reviews.llvm.org/

[PATCH] D122592: [OpenMP] Fix library path missing when using OpenMP

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, ye-luo, MaskRay. Herald added subscribers: StephenFan, guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a projec

[PATCH] D122592: [OpenMP] Fix library path missing when using OpenMP

jhuber6 updated this revision to Diff 418617. jhuber6 added a comment. IncludePath -> LibraryPath Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122592/new/ https://reviews.llvm.org/D122592 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clan

[PATCH] D122592: [OpenMP] Fix library path missing when using OpenMP

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. s/include/library (commit message and code) add test. Assuming both are easy to fix, LG. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[PATCH] D122592: [OpenMP] Fix library path missing when using OpenMP

MaskRay accepted this revision. MaskRay added a comment. Another idea is to refactor `tools::addOpenMPRuntime` to use the full path of `libomp.so` or `libomp.a` instead of `-LXXX -lomp`. The two ways have identical semantics when `libomp.so` has a `DT_SONAME` tag. In the long term, perhaps libom

[clang] 16524d2 - [Driver][AVR] Fix warn_drv_avr_stdlib_not_linked condition

Author: Fangrui Song Date: 2022-03-28T09:43:36-07:00 New Revision: 16524d2f1bdc2e74ca34425edf43ac8ef5d39531 URL: https://github.com/llvm/llvm-project/commit/16524d2f1bdc2e74ca34425edf43ac8ef5d39531 DIFF: https://github.com/llvm/llvm-project/commit/16524d2f1bdc2e74ca34425edf43ac8ef5d39531.diff

[PATCH] D122553: [Driver][AVR] Fix warn_drv_avr_stdlib_not_linked condition

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG16524d2f1bdc: [Driver][AVR] Fix warn_drv_avr_stdlib_not_linked condition (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D122553: [Driver][AVR] Fix warn_drv_avr_stdlib_not_linked condition

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:451 + !Args.hasArg(options::OPT_nodefaultlibs)) { +if (CPU.empty()) { + // We cannot link any standard libraries without an MCU specified. benshi001 wrote: > I think we s

[PATCH] D122592: [OpenMP] Fix library path missing when using OpenMP

jhuber6 added a comment. In D122592#3411741 , @MaskRay wrote: > Another idea is to refactor `tools::addOpenMPRuntime` to use the full path of > `libomp.so` or `libomp.a` instead of `-LXXX -lomp`. > The two ways have identical semantics when `libomp.so` h

[PATCH] D122588: [RISCV] Make PATH empty when testing --gcc-toolchain is multilib_riscv_elf_sdk

MaskRay added a comment. Thanks for the patch. I think it's correct, though I'd add `[test]` to indicate this patch is test only and therefore not change any code. If the test no longer works on Windows, add `// UNSUPPORTED: system-windows` Does riscv32-toolchain.c need a similar change? Please

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

tejohnson added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1554 + Twine(*Opts.DiagnosticsMisExpectTolerance), SA); + for (StringRef Sanitizer : serializeSanitizerKinds(Opts.SanitizeRecover)) paulkirth wrote: > I really

[PATCH] D122592: [OpenMP] Fix library path missing when using OpenMP

ye-luo added a comment. > using the multiarch directory If we can cross compile libomp and libomptarget to the target system. We may have lib/x86_64-unknown-linux-gnu/libomp.so lib/aarch64-unknown-linux-gnu/libomp.so Compile clang once but compile runtime library for multiple architectures. Re

[PATCH] D122592: [OpenMP] Fix library path missing when using OpenMP

jhuber6 updated this revision to Diff 418628. jhuber6 added a comment. Add test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122592/new/ https://reviews.llvm.org/D122592 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/lib/Driver/Tool

[PATCH] D122564: [RISCV] [NFC] add some tests for overloaded intrinsics of FP16

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122564/new/ https://reviews.llvm.org/D122564 ___

[PATCH] D122592: [OpenMP] Fix library path missing when using OpenMP

MaskRay added a comment. In D122592#3411795 , @ye-luo wrote: >> using the multiarch directory > > If we can cross compile libomp and libomptarget to the target system. We may > have > lib/x86_64-unknown-linux-gnu/libomp.so > lib/aarch64-unknown-linux-gnu

[PATCH] D122592: [OpenMP] Fix library path missing when using OpenMP

MaskRay added inline comments. Comment at: clang/test/OpenMP/library-path.c:1 +// RUN: %clang -### -fopenmp=libomp -v %s 2>&1 | FileCheck %s + Suggest the style in `linux-cross.cpp`: use `-ccc-install-dir %S/Inputs/basic_linux_tree/usr/bin` to specify InstalledD

[PATCH] D122592: [OpenMP] Fix library path missing when using OpenMP

MaskRay added inline comments. Comment at: clang/test/OpenMP/library-path.c:1 +// RUN: %clang -### -fopenmp=libomp -v %s 2>&1 | FileCheck %s + MaskRay wrote: > Suggest the style in `linux-cross.cpp`: use `-ccc-install-dir > %S/Inputs/basic_linux_tree/usr/bin` to

[clang] 17ea5bf - Revert "[Driver][AVR] Fix warn_drv_avr_stdlib_not_linked condition"

Author: Fangrui Song Date: 2022-03-28T10:11:45-07:00 New Revision: 17ea5bf1d54d13d6505b636e56ab151a45eab12d URL: https://github.com/llvm/llvm-project/commit/17ea5bf1d54d13d6505b636e56ab151a45eab12d DIFF: https://github.com/llvm/llvm-project/commit/17ea5bf1d54d13d6505b636e56ab151a45eab12d.diff

[PATCH] D122377: [PowerPC][Linux] Support 16-byte lock free atomics on pwr8 and up

efriedma added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:1329 setOperationAction(ISD::INTRINSIC_VOID, MVT::i128, Custom); } You probably want an "else" here to call `setMaxAtomicSizeInBitsSupported(64)` or something like

[PATCH] D122524: [clang][AVR] Emit proper warnings

benshi001 updated this revision to Diff 418634. benshi001 marked an inline comment as done. benshi001 retitled this revision from "[clang][AVR] Generate link warnings properly" to "[clang][AVR] Emit proper warnings". benshi001 edited the summary of this revision. benshi001 set the repository for t

[PATCH] D121951: [AMDGPU][OpenCL] Add "amdgpu-no-hostcall-ptr" in Clang codegen pre-COV_5

scott.linder updated this revision to Diff 418635. scott.linder added a comment. Do not add the no-hostcall attribute for "COV_None" modules, to allow for the OpenCL implementation of hostcall in the device-libs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D121951: [AMDGPU][OpenCL] Add "amdgpu-no-hostcall-ptr" in Clang codegen pre-COV_5

scott.linder added a comment. @yaxunl Does excluding device-libs via COV_None make sense? @sameerds Would you still rather we just not add this attribute in the frontend at all? I'm OK with it if that is the consensus Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D122524: [clang][AVR] Emit proper warnings

benshi001 added a comment. In D122524#3410542 , @MaskRay wrote: > I think it is excessive to add so many RUN lines. I do not understand much > about AVR -mcpu. That said, I created D122553 > for what I think should be

[PATCH] D122592: [OpenMP] Fix library path missing when using OpenMP

jhuber6 updated this revision to Diff 418638. jhuber6 added a comment. Making suggested changes to test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122592/new/ https://reviews.llvm.org/D122592 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[clang] 52fa1d1 - [Driver][AVR] Fix warn_drv_avr_stdlib_not_linked condition

Author: Fangrui Song Date: 2022-03-28T10:27:16-07:00 New Revision: 52fa1d1a02940ac46aac5b8d6f87ca9d6a6a97be URL: https://github.com/llvm/llvm-project/commit/52fa1d1a02940ac46aac5b8d6f87ca9d6a6a97be DIFF: https://github.com/llvm/llvm-project/commit/52fa1d1a02940ac46aac5b8d6f87ca9d6a6a97be.diff

[PATCH] D122592: [OpenMP] Fix library path missing when using OpenMP

jdoerfert added a comment. In D122592#3411812 , @MaskRay wrote: > In D122592#3411795 , @ye-luo wrote: > >>> using the multiarch directory >> >> If we can cross compile libomp and libomptarget to the target system.

[PATCH] D122592: [OpenMP] Fix library path missing when using OpenMP

jhuber6 added a comment. In D122592#3411877 , @jdoerfert wrote: > In D122592#3411812 , @MaskRay wrote: > >> In D122592#3411795 , @ye-luo wrote: >> using the multiarch

[PATCH] D122524: [clang][AVR] Emit proper warnings

MaskRay added a comment. In D122524#3411872 , @benshi001 wrote: > In D122524#3410542 , @MaskRay wrote: > >> I think it is excessive to add so many RUN lines. I do not understand much >> about AVR -mcpu. That said

[PATCH] D122542: [flang][driver] Make --version and -version consistent with clang

ekieri updated this revision to Diff 418643. ekieri added a comment. Address review comment. Fix typo in summary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122542/new/ https://reviews.llvm.org/D122542 Files: clang/include/clang/Driver/Option

[PATCH] D122425: Pass -disable-llvm-passes to avoid running llvm passes

ahatanak added a comment. Yes, this test was susceptible to changes made to llvm passes and the pass pipeline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122425/new/ https://reviews.llvm.org/D122425

  1   2   3   >