MaskRay added a comment.

Thanks for the patch. I think it's correct, though I'd add `[test]` to indicate 
this patch is test only and therefore not change any code.

If the test no longer works on Windows, add `// UNSUPPORTED: system-windows`

Does riscv32-toolchain.c need a similar change? Please look around for related 
tests when fixing something.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122588/new/

https://reviews.llvm.org/D122588

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to