[PATCH] D122542: [flang][driver] Make --version and -version consistent with clang

ekieri created this revision. ekieri added reviewers: PeteSteinfeld, awarzynski. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. ekieri requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. This patch makes -versi

[clang] d9cea8d - [C++20][Modules][HU 4/5] Handle pre-processed header units.

Author: Iain Sandoe Date: 2022-03-27T09:38:06+01:00 New Revision: d9cea8d3a8fff86672174780312674871729578c URL: https://github.com/llvm/llvm-project/commit/d9cea8d3a8fff86672174780312674871729578c DIFF: https://github.com/llvm/llvm-project/commit/d9cea8d3a8fff86672174780312674871729578c.diff L

[PATCH] D121098: [C++20][Modules][HU 4/5] Handle pre-processed header units.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9cea8d3a8ff: [C++20][Modules][HU 4/5] Handle pre-processed header units. (authored by iains). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121098/new/ htt

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

benshi001 added a comment. I have built (with -DCMAKE_BUILD_TYPE=Debug) and tested your patch, but got the following failure FAIL: LLVM :: CodeGen/AVR/pseudo/STDWPtrQRr.mir (150 of 152) TEST 'LLVM :: CodeGen/AVR/pseudo/STDWPtrQRr.mir' FAILED Scrip

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

Patryk27 added a comment. Hmm, that's weird - I've just re-checked and everything's working correctly on my side; maybe you're testing it on an older LLVM revision? (for reference, my patch is based off of the current LLVM's main branch, which - at the time of writing this comment - is the d9ce

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

benshi001 added inline comments. Comment at: llvm/lib/Target/AVR/AVRExpandPseudoInsts.cpp:1174 - auto MIBLO = buildMI(MBB, MBBI, OpLo) - .addReg(DstReg) - .addImm(Imm) - .addReg(SrcLoReg, getKillRegState(SrcIsKill)); +b

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

benshi001 added a comment. In D122533#3410064 , @Patryk27 wrote: > Hmm, that's weird - I've just re-checked and everything's working correctly > on my side; maybe you're testing it on an older LLVM revision? (for > reference, my patch is based off of th

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

Patryk27 added inline comments. Comment at: llvm/lib/Target/AVR/AVRExpandPseudoInsts.cpp:1174 - auto MIBLO = buildMI(MBB, MBBI, OpLo) - .addReg(DstReg) - .addImm(Imm) - .addReg(SrcLoReg, getKillRegState(SrcIsKill)); +bu

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

benshi001 added inline comments. Comment at: llvm/test/CodeGen/AVR/pseudo/STDWPtrQRr.mir:1 -# RUN: llc -O0 -run-pass=avr-expand-pseudo %s -o - | FileCheck %s +# RUN: llc -O0 -run-pass=avr-expand-pseudo %s -o - | FileCheck %s You can trigger the bug, with `-ver

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

Patryk27 added a comment. I think I'm using `=Release` instead of `=Debug`, that would explain the difference, yeah; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122533/new/ https://reviews.llvm.org/D122533 __

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

benshi001 added inline comments. Comment at: llvm/lib/Target/AVR/AVRExpandPseudoInsts.cpp:1174 - auto MIBLO = buildMI(MBB, MBBI, OpLo) - .addReg(DstReg) - .addImm(Imm) - .addReg(SrcLoReg, getKillRegState(SrcIsKill)); +b

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

benshi001 added a comment. In D122533#3410072 , @Patryk27 wrote: > I think I'm using `=Release` instead of `=Debug`, that would explain the > difference, yeah; You need not Debug, just add `-verify-machineinstrs` option after the `-run-pass=avr-expand-

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

Patryk27 updated this revision to Diff 418443. Patryk27 added a comment. SBCI -> SUBI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122533/new/ https://reviews.llvm.org/D122533 Files: clang/docs/tools/clang-formatted-files.txt llvm/lib/Target/

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

benshi001 added inline comments. Comment at: llvm/lib/Target/AVR/AVRExpandPseudoInsts.cpp:1174 - auto MIBLO = buildMI(MBB, MBBI, OpLo) - .addReg(DstReg) - .addImm(Imm) - .addReg(SrcLoReg, getKillRegState(SrcIsKill)); +b

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

Patryk27 marked 2 inline comments as done. Patryk27 added inline comments. Comment at: llvm/lib/Target/AVR/AVRExpandPseudoInsts.cpp:1174 - auto MIBLO = buildMI(MBB, MBBI, OpLo) - .addReg(DstReg) - .addImm(Imm) - .addReg(Src

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

Patryk27 added a comment. Ah, sorry - I've pushed my changes at the same time you created your comment; one moment, let me change to SUBIW, then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122533/new/ https://reviews.llvm.org/D122533 _

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

Patryk27 added a comment. Ah, nevermind - looks like I've already actually used `SUBIWRdK`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122533/new/ https://reviews.llvm.org/D122533 ___ cfe-commits mail

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

benshi001 added inline comments. Comment at: llvm/test/CodeGen/AVR/pseudo/STDWPtrQRr.mir:1 -# RUN: llc -O0 -run-pass=avr-expand-pseudo %s -o - | FileCheck %s +# RUN: llc -O0 -run-pass=avr-expand-pseudo %s -o - | FileCheck %s benshi001 wrote: > You can trigger

[PATCH] D122077: [InstCombine] Fold (ctpop(X) == 1) | (X == 0) into ctpop(X) < 2

spatel added a comment. Thank you for the making the test changes. I pushed the baseline tests on your behalf here: ebaa28e0750b Please rebase and update the patch here in Phabricator - it should only show changes in the CHE

[PATCH] D122104: [X86][regcall] Support passing / returning structures

pengfei updated this revision to Diff 418448. pengfei marked 2 inline comments as done. pengfei added a comment. Address Yuanke's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122104/new/ https://reviews.llvm.org/D122104 Files: clang/i

[PATCH] D122104: [X86][regcall] Support passing / returning structures

pengfei added inline comments. Comment at: clang/include/clang/CodeGen/CGFunctionInfo.h:590 + /// Log 2 of the maximum vector width. + unsigned MaxVectorWidth : 4; + LuoYuanke wrote: > I notice some code would indicate it is log 2 size with Log2 suffix in the

[PATCH] D122544: Utilize comparison operation implemented in APInt

SimplyDanny created this revision. SimplyDanny added a reviewer: njames93. Herald added a subscriber: carlosgalvezp. Herald added a project: All. SimplyDanny requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This is a fix for #539

[PATCH] D122524: [clang][AVR] Generate link warnings properly

MaskRay added inline comments. Comment at: clang/test/Driver/avr-toolchain.c:39 + +// RUN: %clang %s -### -target avr --sysroot %S/Inputs/basic_avr_tree -mmcu=atmega328 2>&1 | FileCheck --check-prefix=CHECK5 %s +// CHECK5-NOT: warning: no target microcontroller specified on comm

[PATCH] D122524: [clang][AVR] Generate link warnings properly

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:379 !Args.hasArg(options::OPT_nodefaultlibs) && + !Args.hasArg(options::OPT_S) && !Args.hasArg(options::OPT_c /* does not apply when not linking */)) { This is insuf

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

Patryk27 updated this revision to Diff 418460. Patryk27 added a comment. Add `-verify-machineinstrs` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122533/new/ https://reviews.llvm.org/D122533 Files: clang/docs/tools/clang-formatted-files.txt l

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

Patryk27 added a comment. Ok, I have added the switch; I think a separate patch that adds that switch to all the tests would be handy - what do you think? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122533/new/ https://reviews.llvm.org/D122533

[clang] 8b245ab - [Clang, TBAA] Add test cases for nested pointers and TBAA data.

Author: Florian Hahn Date: 2022-03-27T19:59:37+01:00 New Revision: 8b245ab41dfaed153e9ce768470107ec71551e1f URL: https://github.com/llvm/llvm-project/commit/8b245ab41dfaed153e9ce768470107ec71551e1f DIFF: https://github.com/llvm/llvm-project/commit/8b245ab41dfaed153e9ce768470107ec71551e1f.diff

[PATCH] D122546: Let clang-repl link privately against Clang components

aaronpuchert created this revision. aaronpuchert added a reviewer: v.g.vassilev. Herald added a subscriber: mgorny. Herald added a project: All. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. First of all, this is the conventi

[PATCH] D121756: [clang-format] Clean up code looking for if statements

HazardyKnusperkeks added a comment. In D121756#3407320 , @owenpan wrote: > In D121756#3398165 , @sstwcw wrote: > >> It turned out this patch does change behavior. >> >> - while ( >> - FormatTok->isOneOf(

[PATCH] D119136: [wip][clang] Implement Change scope of lambda trailing-return-type

cor3ntin updated this revision to Diff 418467. cor3ntin added a comment. - Rebase (I managed to conflict with myself) - Fix formatting - which fixes the broken tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119136/new/ https://reviews.llvm.org

[PATCH] D122547: [clang] Make Driver tests pass when running with temp dir containing "crt"

thakis created this revision. thakis added a reviewer: hans. Herald added subscribers: abrachet, emaste. Herald added a project: All. thakis requested review of this revision. In a recent run, temp files got created in /tmp/lit-tmp-2wcrtcx1/foo-xxx.o. Since the tmp path contained "crt", this made

[PATCH] D122548: [clang-format] Don't format qualifiers in PPDirective

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, curdeius, HazardyKnusperkeks. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes #54513 <

[PATCH] D122548: [clang-format] Don't format qualifiers in PPDirective

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM thank you for the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122548/new/ https://reviews.llvm.org/D122548 ___ cfe-comm

[PATCH] D122549: [VFS] RedirectingFileSystem only replace path if not already mapped

bnbarham created this revision. bnbarham added reviewers: dexonsmith, keith, JDevlieghere, vsapsai, sammccall. Herald added a subscriber: hiraditya. Herald added a project: All. bnbarham requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, c

[PATCH] D122529: [ASTMatchers] Output currently matching node on crash

njames93 updated this revision to Diff 418473. njames93 added a comment. Update tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122529/new/ https://reviews.llvm.org/D122529 Files: clang/lib/ASTMatchers/ASTMatchFinder.cpp clang/unittests/A

[PATCH] D122468: [clang-format] Fix SeparateDefinitionBlocks breaking up function-try-block.

owenpan added a comment. We can refactor by extending `_verifyFormat()` instead of adding a new function. Comment at: clang/unittests/Format/DefinitionBlockSeparatorTest.cpp:46 const FormatStyle &Style = getLLVMStyle(),

[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant

bc-lee added a comment. Hi, could you have a look at it once more? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121868/new/ https://reviews.llvm.org/D121868 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D122104: [X86][regcall] Support passing / returning structures

LuoYuanke accepted this revision. LuoYuanke added a comment. This revision is now accepted and ready to land. LGTM, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122104/new/ https://reviews.llvm.org/D122104

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

benshi001 accepted this revision. benshi001 added a comment. This revision is now accepted and ready to land. @aykevl How about your opinion? I think current form is good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122533/new/ https://reviews.ll

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

benshi001 added a comment. In D122533#3410259 , @Patryk27 wrote: > Ok, I have added the switch; I think a separate patch that adds that switch > to all of the AVR tests could come handy - what do you think? No. `-verify-machineinstrs` might be default i

[PATCH] D121556: [randstruct] Add randomize structure layout support

void updated this revision to Diff 418480. void added a comment. - Make sure the command line seed is properly passed on to each front-end level. - Some general cleanups. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/ https://reviews.llv

[PATCH] D122524: [clang][AVR] Generate link warnings properly

benshi001 updated this revision to Diff 418481. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122524/new/ https://reviews.llvm.org/D122524 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/avr-toolchain.c Index: clang/test/Driver/avr-toolchain.c ==

[PATCH] D119409: [C++20] [Modules] Remain dynamic initializing internal-linkage variables in module interface unit

ChuanqiXu added a comment. In D119409#3409806 , @iains wrote: > I think that this problem might well be a consequence of the bug which is > fixed by D122413 . > > We have been generating code with module internal entitie

[PATCH] D120129: [NVPTX] Enhance vectorization of ld.param & st.param

jdoerfert requested changes to this revision. jdoerfert added a comment. This revision now requires changes to proceed. Please revert this commit. It breaks any code using the cuda.11.0.2 libdevice.bc file, the source of the `null` `nvvm.annotations` and the annotations with 5 arguments. See bel

[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

tingwang updated this revision to Diff 418485. tingwang added a comment. Option -mlong-double-128 is not supported on AIX currently, and clang fails due to type mismatch in the fe case. Add check logic to print diag message in this case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D122460: [clang] fixed bug #54406

randyli planned changes to this revision. randyli added inline comments. Comment at: clang/lib/Sema/SemaExprMember.cpp:690 +// int n = a.B::m; +if (BaseExpr && isa(DC) && isa(RDecl)) { + CXXRecordDecl *SRecord = cast(DC)->getCanonicalDecl(); rjmccall

[PATCH] D120129: [NVPTX] Enhance vectorization of ld.param & st.param

kovdan01 added a comment. In D120129#3410479 , @jdoerfert wrote: > Please revert this commit. It breaks any code using the cuda.11.0.2 > libdevice.bc file, the source of the `null` `nvvm.annotations` and the > annotations with 5 arguments. See below. >

[PATCH] D120129: [NVPTX] Enhance vectorization of ld.param & st.param

jdoerfert added a comment. In D120129#3410493 , @kovdan01 wrote: > In D120129#3410479 , @jdoerfert > wrote: > >> Please revert this commit. It breaks any code using the cuda.11.0.2 >> libdevice.bc file, the sour

[PATCH] D120129: [NVPTX] Enhance vectorization of ld.param & st.param

kovdan01 added a comment. In D120129#3410510 , @jdoerfert wrote: > The two assertions introduced here do not hold for the libdevice.bc above. So > whenever we link the above we will cause the assertions to fail. That's what > I mean with break. isKernel

[PATCH] D120129: [NVPTX] Enhance vectorization of ld.param & st.param

jdoerfert added a comment. In D120129#3410512 , @kovdan01 wrote: > In D120129#3410510 , @jdoerfert > wrote: > >> The two assertions introduced here do not hold for the libdevice.bc above. >> So whenever we link

[PATCH] D120129: [NVPTX] Enhance vectorization of ld.param & st.param

kovdan01 added a comment. In D120129#3410514 , @jdoerfert wrote: > Our internal build bots and CI for some projects are broken for 3 days. I > wish to unbreak them so we get actual meaningful results, e.g., see if > something else is breaking our build.

[PATCH] D122469: OpenMP 5.1 - Support 'seq_cst' clause on 'flush' directive

jdoerfert added a comment. I think this contains two distinct changes. Please split. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122469/new/ https://reviews.llvm.org/D122469 ___ cfe-commits mailing lis

[PATCH] D122553: [Driver][AVR] Fix warn_drv_avr_stdlib_not_linked condition

MaskRay created this revision. MaskRay added reviewers: aykevl, benshi001. Herald added subscribers: StephenFan, Jim, dylanmckay. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Many options (-fsyntax-on

[PATCH] D122524: [clang][AVR] Generate link warnings properly

MaskRay added a comment. I think it is excessive to add so many RUN lines. I do not understand much about AVR -mcpu. That said, I created D122553 for what I think should be done for the `-c/-S/-fsyntax-only` condition. More tests would just be excessive. CHA

[PATCH] D122553: [Driver][AVR] Fix warn_drv_avr_stdlib_not_linked condition

MaskRay updated this revision to Diff 418493. MaskRay added a comment. fix file header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122553/new/ https://reviews.llvm.org/D122553 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolC

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

Patryk27 added a comment. In D122533#3410428 , @benshi001 wrote: > In D122533#3410259 , @Patryk27 > wrote: > >> Ok, I have added the switch; I think a separate patch that adds that switch >> to all of the AVR te

[PATCH] D122542: [flang][driver] Make --version and -version consistent with clang

PeteSteinfeld accepted this revision. PeteSteinfeld added a comment. This revision is now accepted and ready to land. Looks good. Thanks for doing this, Emil! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122542/new/ https://reviews.llvm.org/D1225

[clang] ad57e10 - [RISCV][NFC] Moving RVV intrinsic type related util to llvm/Support

Author: Kito Cheng Date: 2022-03-28T14:35:28+08:00 New Revision: ad57e10dbca2fdeff1448afc0aa1cf23d6df8736 URL: https://github.com/llvm/llvm-project/commit/ad57e10dbca2fdeff1448afc0aa1cf23d6df8736 DIFF: https://github.com/llvm/llvm-project/commit/ad57e10dbca2fdeff1448afc0aa1cf23d6df8736.diff LO

[PATCH] D121984: [RISCV][NFC] Moving RVV intrinsic type related util to llvm/Support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGad57e10dbca2: [RISCV][NFC] Moving RVV intrinsic type related util to llvm/Support (authored by kito-cheng). Changed prior to commit: https://revie

[PATCH] D122554: [clangd] Handle tabs in getIncrementalChangesAfterNewline()

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[clang] 85b1354 - [C++20][Modules][HU 5/5] Add fdirectives-only mode for preprocessing output.

Author: Iain Sandoe Date: 2022-03-28T07:38:22+01:00 New Revision: 85b1354098ba0a665fdd47204d0e53e63d09d9ab URL: https://github.com/llvm/llvm-project/commit/85b1354098ba0a665fdd47204d0e53e63d09d9ab DIFF: https://github.com/llvm/llvm-project/commit/85b1354098ba0a665fdd47204d0e53e63d09d9ab.diff L

[PATCH] D121099: [C++20][Modules][HU 5/5] Add fdirectives-only mode for preprocessing output.

This revision was automatically updated to reflect the committed changes. Closed by commit rG85b1354098ba: [C++20][Modules][HU 5/5] Add fdirectives-only mode for preprocessing output. (authored by iains). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D122556: [RISCV] Add definitions for Xiangshan processors.

SForeKeeper created this revision. Herald added subscribers: s, VincentWu, luke957, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, kito-cheng, niosHD, sabuasa