[PATCH] D122524: [clang][AVR] Generate link warnings properly

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/AVR.cpp:379
       !Args.hasArg(options::OPT_nodefaultlibs) &&
+      !Args.hasArg(options::OPT_S) &&
       !Args.hasArg(options::OPT_c /* does not apply when not linking */)) {
----------------
This is insufficient. -fsyntax-only, -E, etc should not need the diagnostic as 
well.
I know there may be test coverage gap but it is excessive to test all of -S -c 
-E ... that there is no diagnostic.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122524/new/

https://reviews.llvm.org/D122524

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits