[PATCH] D122336: [InstrProfiling] No runtime hook for unused funcs

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:569-573 +if (!CoverageNamesVar) { + return MadeChange; +} else if (!NeedsRuntimeHook) { +

[clang] 1c13bbd - [NFCI] Fix set-but-unused warning in UnwrappedLineParser.cpp

Author: Dávid Bolvanský Date: 2022-03-24T08:13:29+01:00 New Revision: 1c13bbdde630b8716f817989a33ccc77a588642c URL: https://github.com/llvm/llvm-project/commit/1c13bbdde630b8716f817989a33ccc77a588642c DIFF: https://github.com/llvm/llvm-project/commit/1c13bbdde630b8716f817989a33ccc77a588642c.dif

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG711e3a569167: [clang][parse] Move source range into ParsedAttibutesView (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 711e3a5 - [clang][parse] Move source range into ParsedAttibutesView

Author: Timm Bäder Date: 2022-03-24T08:11:57+01:00 New Revision: 711e3a569167ee6f3fbccf983933d92cd03a469b URL: https://github.com/llvm/llvm-project/commit/711e3a569167ee6f3fbccf983933d92cd03a469b DIFF: https://github.com/llvm/llvm-project/commit/711e3a569167ee6f3fbccf983933d92cd03a469b.diff LO

[clang] 48285c2 - [NFCI] Fix set-but-unused warning in ClangAttrEmitter.cpp

Author: Dávid Bolvanský Date: 2022-03-24T08:13:28+01:00 New Revision: 48285c20eb5f5ed4f7b539fbd7f882c997a08f46 URL: https://github.com/llvm/llvm-project/commit/48285c20eb5f5ed4f7b539fbd7f882c997a08f46 DIFF: https://github.com/llvm/llvm-project/commit/48285c20eb5f5ed4f7b539fbd7f882c997a08f46.dif

[PATCH] D121584: [clang-format] Correctly recognize arrays in template parameter list.

krasimir added a comment. > It appears that this regressed some ObjC patterns: @curdeius any progress on this? If not, could we revert this for now? Internally we've got enough of these regressing ObjC patterns that we can't release clang-format with this. Repository: rG LLVM Github Monorep

[PATCH] D121584: [clang-format] Correctly recognize arrays in template parameter list.

curdeius added a comment. Yes, let's revert this. I should have a fix soon though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121584/new/ https://reviews.llvm.org/D121584 ___ cfe-commits mailing list

[clang] 67d9276 - [clang-cl] Ignore /Wv and /Wv:17 flags

Author: Tobias Hieta Date: 2022-03-24T09:42:34+01:00 New Revision: 67d9276b16024bae66dfc2fcb739d947637b8c52 URL: https://github.com/llvm/llvm-project/commit/67d9276b16024bae66dfc2fcb739d947637b8c52 DIFF: https://github.com/llvm/llvm-project/commit/67d9276b16024bae66dfc2fcb739d947637b8c52.diff

[PATCH] D122298: [clang-cl] Ignore /Wv and /Wv:17 flags

This revision was automatically updated to reflect the committed changes. Closed by commit rG67d9276b1602: [clang-cl] Ignore /Wv and /Wv:17 flags (authored by thieta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122298/new/ https://reviews.llvm.or

[PATCH] D121368: [pseudo][WIP] Build Ambiguous forest node in the GLR Parser.

sammccall added a comment. Some notes before our meeting. It does appear that it's possible to generate duplicate forest nodes in this way, and AFAIK any method other that explicitly deduplicating creating using a map<(rule, rhsnodes), sequencenode> is going to have this problem. The good news

[PATCH] D122244: [analyzer] Turn missing tablegen doc entry of a checker into fatal error

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! You did check whether a missing doc field will actually trigger this error, right? Comment at: clang/utils/TableGen/ClangSACheckersEmitter.cpp:82 +PrintFatal

[clang] d00e840 - [Clang] Add option to set alternative toolchain path

Author: Qiu Chaofan Date: 2022-03-24T17:01:35+08:00 New Revision: d00e8400e2e3a602fdf40cd7348ed113952261d3 URL: https://github.com/llvm/llvm-project/commit/d00e8400e2e3a602fdf40cd7348ed113952261d3 DIFF: https://github.com/llvm/llvm-project/commit/d00e8400e2e3a602fdf40cd7348ed113952261d3.diff L

[PATCH] D121992: [Clang] [Driver] Add option to set alternative toolchain path

This revision was automatically updated to reflect the committed changes. Closed by commit rGd00e8400e2e3: [Clang] Add option to set alternative toolchain path (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121992/new/ https://re

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

arichardson added a comment. In D122335#3404358 , @jrtc27 wrote: > As a developer who often deals with crashes locally this is more annoying; > currently I can just point tools at the shell script and C file in /tmp and > let them go to work reducing, b

[clang] be5c3ca - Revert "[clang-format] Correctly recognize arrays in template parameter list."

Author: Krasimir Georgiev Date: 2022-03-24T10:14:13+01:00 New Revision: be5c3ca7fbaec90fff004af54d3cd5f6c30a9664 URL: https://github.com/llvm/llvm-project/commit/be5c3ca7fbaec90fff004af54d3cd5f6c30a9664 DIFF: https://github.com/llvm/llvm-project/commit/be5c3ca7fbaec90fff004af54d3cd5f6c30a9664.d

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

xbolva00 added a comment. In D100581#3404624 , @xbolva00 wrote: > @mbenfield found false positive > > void test(void) { > static int counter = 0; > counter += 5; > } posted https://reviews.llvm.org/D122374 Repository: rG LLVM Github Monor

[clang] f854434 - [NVPTX] Enhance vectorization of ld.param & st.param

Author: Daniil Kovalev Date: 2022-03-24T12:25:36+03:00 New Revision: f854434f0f2a01027bdaad8e6fdac5a782fce291 URL: https://github.com/llvm/llvm-project/commit/f854434f0f2a01027bdaad8e6fdac5a782fce291 DIFF: https://github.com/llvm/llvm-project/commit/f854434f0f2a01027bdaad8e6fdac5a782fce291.diff

[PATCH] D121549: Define ABI breaking class members correctly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf854434f0f2a: [NVPTX] Enhance vectorization of ld.param & st.param (authored by kovdan01). Herald added subscribers: asavonic, StephenFan, jholewinsk

[clang] a034878 - Revert "[NVPTX] Enhance vectorization of ld.param & st.param"

Author: Daniil Kovalev Date: 2022-03-24T12:32:06+03:00 New Revision: a0348785649271e8c63a42bd4a83a2fefa96efe0 URL: https://github.com/llvm/llvm-project/commit/a0348785649271e8c63a42bd4a83a2fefa96efe0 DIFF: https://github.com/llvm/llvm-project/commit/a0348785649271e8c63a42bd4a83a2fefa96efe0.diff

[clang] 2af845a - Relands "[Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators"

Author: Dávid Bolvanský Date: 2022-03-24T10:34:44+01:00 New Revision: 2af845a6519c9cde5c8f58db5554f8b1084ce1ed URL: https://github.com/llvm/llvm-project/commit/2af845a6519c9cde5c8f58db5554f8b1084ce1ed DIFF: https://github.com/llvm/llvm-project/commit/2af845a6519c9cde5c8f58db5554f8b1084ce1ed.dif

[clang] 828b63c - [NVPTX] Enhance vectorization of ld.param & st.param

Author: Daniil Kovalev Date: 2022-03-24T12:36:52+03:00 New Revision: 828b63c309439d3b0915205f1e5a159c69cb36b8 URL: https://github.com/llvm/llvm-project/commit/828b63c309439d3b0915205f1e5a159c69cb36b8 DIFF: https://github.com/llvm/llvm-project/commit/828b63c309439d3b0915205f1e5a159c69cb36b8.diff

[PATCH] D120129: [NVPTX] Enhance vectorization of ld.param & st.param

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. kovdan01 marked 2 inline comments as done. Closed by commit rG828b63c30943: [NVPTX] Enhance vectorization of ld.param & st.param (authored by kovdan01). Herald added a

[PATCH] D122244: [analyzer] Turn missing tablegen doc entry of a checker into fatal error

steakhal added a comment. In D122244#3404727 , @Szelethus wrote: > LGTM! You did check whether a missing doc field will actually trigger this > error, right? Yup, it works as expected! ninja: Entering directory `build/release' [1/375] Building Chec

[PATCH] D121549: [CodeGen] Define ABI breaking class members correctly

kovdan01 updated this revision to Diff 417858. kovdan01 added a comment. Accidentally placed this revision ID in commit message related to other patch. Reverted that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121549/new/ https://reviews.llvm.org/D121549 Files: llvm/include/llvm/

[PATCH] D122244: [analyzer] Turn missing tablegen doc entry of a checker into fatal error

steakhal updated this revision to Diff 417862. steakhal added a comment. reword error message CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122244/new/ https://reviews.llvm.org/D122244 Files: clang/utils/TableGen/ClangSACheckersEmitter.cpp Index: clang/utils/TableGen/ClangSAChecker

[PATCH] D122377: [PowerPC][Linux] Support 16-byte lock free atomics on pwr8 and up

lkail created this revision. lkail added reviewers: hubert.reinterpretcast, jsji, xingxue, PowerPC. Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai. Herald added a project: All. lkail requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: ll

[PATCH] D122378: Be more explicit about -fvisibility= documentation

serge-sans-paille created this revision. serge-sans-paille added a reviewer: aaron.ballman. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When in need, I had to look into gcc info page, then

[PATCH] D122377: [PowerPC][Linux] Support 16-byte lock free atomics on pwr8 and up

lkail updated this revision to Diff 417868. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122377/new/ https://reviews.llvm.org/D122377 Files: clang/lib/Basic/Targets/PPC.cpp clang/lib/Basic/Targets/PPC.h clang/test/CodeGen/PowerPC/atomic-alignment.c clang/test/CodeGen/PowerPC/qua

[PATCH] D122315: [clangd] Retain main file fixes attached to diags from preamble

kadircet updated this revision to Diff 417873. kadircet marked 2 inline comments as done. kadircet added a comment. - Get rid of redundant local variable - Update comment around assumptions about main file-ness inside toLSPDiag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122315: [clangd] Retain main file fixes attached to diags from preamble

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:68 return true; // Fixes are always in the main file. if (!D.Fixes.empty()) sammccall wrote: > update comment: Fixes are only added if the fix or diagnostics is in the

[PATCH] D122331: [clang][extract-api] Stop allocating APIRecords via BumpPtrAllocator

dang added a comment. I have checked locally against San to make sure this doesn't reintroduce the memory leak issues we were seeing initially that lead to the addition of `APIRecordUniquePtr` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122331/n

[PATCH] D122315: [clangd] Retain main file fixes attached to diags from preamble

sammccall added a comment. LG, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122315/new/ https://reviews.llvm.org/D122315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D120989: Support debug info for alias variable

kavitha-natarajan updated this revision to Diff 417878. kavitha-natarajan added a comment. @aprantl, thanks for your comments. Updated the patch with the fixes. @dblaikie, haven't got any response from gdb reviewers about the gdb patch yet. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D122341: Fix a crash with variably-modified parameter types in a naked function

aaron.ballman updated this revision to Diff 417884. aaron.ballman added a comment. Updating based on review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122341/new/ https://reviews.llvm.org/D122341 Files: clang/docs/ReleaseNotes.rst clang/lib/CodeGen/CodeGenFunction.cpp

[PATCH] D122341: Fix a crash with variably-modified parameter types in a naked function

aaron.ballman added a comment. In D122341#3403587 , @erichkeane wrote: > Other than this 1 thing, LGTM. I DO find myself wondering how much of the > CXXMethodDecl bit in the branch above is valid for 'naked' as well. If it > ISN'T we might consider

[PATCH] D122331: [clang][extract-api] Stop allocating APIRecords via BumpPtrAllocator

dang updated this revision to Diff 417885. dang marked 2 inline comments as done. dang added a comment. Address review feedback: Rename APISet::Allocator to APISet::StringAllocator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122331/new/ https://r

[PATCH] D122331: [clang][extract-api] Stop allocating APIRecords via BumpPtrAllocator

dang added inline comments. Comment at: clang/include/clang/ExtractAPI/API.h:326 + /// Note: The main use for this is being able to deduplicate strings. llvm::BumpPtrAllocator Allocator; zixuw wrote: > zixuw wrote: > > Should we just rename the allocator al

[clang] 406bde9 - [PowerPC] [Clang] Add SSE4 and BMI intrinsics implementation

Author: Qiu Chaofan Date: 2022-03-24T20:03:08+08:00 New Revision: 406bde9a15136254f2b10d9ef3a42033b3cb1b16 URL: https://github.com/llvm/llvm-project/commit/406bde9a15136254f2b10d9ef3a42033b3cb1b16 DIFF: https://github.com/llvm/llvm-project/commit/406bde9a15136254f2b10d9ef3a42033b3cb1b16.diff L

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG406bde9a1513: [PowerPC] [Clang] Add SSE4 and BMI intrinsics implementation (authored by qiucf). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D122385: [clang][deps] Fix clang-cl output argument parsing

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, saudi. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. One goal of the ad-hoc command line argument parsing i

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

aaron.ballman added a comment. In D122335#3404754 , @arichardson wrote: > In D122335#3404358 , @jrtc27 wrote: > >> As a developer who often deals with crashes locally this is more annoying; >> currently I can ju

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

jansvoboda11 added a comment. Sorry for the breakage and thanks for reporting this! This is a real bug uncovered by your build using `/opt`. I have a fix here: D122385 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

aaron.ballman added a comment. In D122248#3403734 , @yihanaa wrote: > What if we don't emit '=' for zero-width bitfield, like this: > > struct Bar { > unsigned c : 1; > unsigned : 3; > unsigned : 0; > unsigned b; > }; > > struct Bar { >

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:50-53 +def warn_eval_method_setting_via_option_in_value_unsafe_context : Warning< +"setting the eval method via '-ffp-eval-method' has not effect when numeric " +"result

[PATCH] D122077: [InstCombine] Fold (ctpop(X) == 1) | (X == 0) into ctpop(X) < 2

spatel added a comment. A few changes for tests suggested inline. There might be some generalization of ctpop analysis that we can make as a follow-up patch. For example, I was looking at a "wrong predicate" combination and noticed that we miss possible optimizations like this: https://alive2.l

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

aaron.ballman added a comment. In D120185#3403676 , @njames93 wrote: > In D120185#3403270 , @aaron.ballman > wrote: > >> I'd like to understand what's happening better rather than land with a >> disabled test. N

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:47 +CRLF, +CRLFCR, + }; LegalizeAdulthood wrote: > aaron.ballman wrote: > > LegalizeAdulthood wrote: > > > aaron.ballman wrote: > > > > LegalizeA

[PATCH] D122338: [OPENMP] Eliminate extra set of simd variant function attribute.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:11988 if (isa(E)) { Pos = ParamPositions[FD]; } else { I would also recommend to replace all `operator []` calls to something that does not modify the m

[PATCH] D122378: Be more explicit about -fvisibility= documentation

aaron.ballman added a comment. Thanks for the additional docs! Comment at: clang/docs/ClangCommandLineReference.rst:2616 -.. option:: -fvisibility= +.. option:: -fvisibility=[default|hidden] From looking at Options.td, it seems there are more visibility val

[PATCH] D122378: Be more explicit about -fvisibility= documentation

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Btw, you're changing a generated .rst file. You need to fix up the documentation in Options.td which is used to generate this .rst file. I don't know that you'll be abl

[clang] 4d20781 - Typo fix in the documentation; NFC

Author: Aaron Ballman Date: 2022-03-24T08:56:14-04:00 New Revision: 4d20781b6935099879f8704fcf93d9cdb83cf3ef URL: https://github.com/llvm/llvm-project/commit/4d20781b6935099879f8704fcf93d9cdb83cf3ef DIFF: https://github.com/llvm/llvm-project/commit/4d20781b6935099879f8704fcf93d9cdb83cf3ef.diff

[clang] de867c6 - [clang] Reformat

Author: Nathan Sidwell Date: 2022-03-24T05:56:23-07:00 New Revision: de867c6d6ed86851dcd0f9de1154db3d42a0ad63 URL: https://github.com/llvm/llvm-project/commit/de867c6d6ed86851dcd0f9de1154db3d42a0ad63 DIFF: https://github.com/llvm/llvm-project/commit/de867c6d6ed86851dcd0f9de1154db3d42a0ad63.diff

[PATCH] D122314: [clang] Reformat

This revision was automatically updated to reflect the committed changes. Closed by commit rGde867c6d6ed8: [clang] Reformat (authored by urnathan). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

erichkeane added a comment. In D122248#3405062 , @aaron.ballman wrote: > In D122248#3403734 , @yihanaa wrote: > >> What if we don't emit '=' for zero-width bitfield, like this: >> >> struct Bar { >> unsigned

[PATCH] D122303: [pseudo] Sort nonterminals based on their reduction order.

hokein updated this revision to Diff 417902. hokein marked 5 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122303/new/ https://reviews.llvm.org/D122303 Files: clang-tools-extra/p

[PATCH] D122303: [pseudo] Sort nonterminals based on their reduction order.

hokein added inline comments. Comment at: clang-tools-extra/pseudo/lib/GrammarBNF.cpp:147 + VisitStates[SID] = Visiting; + auto It = llvm::partition_point( + Dependencies, [&SID](const std::pair &D) { sammccall wrote: > this is more tersely `ll

[PATCH] D122394: [C++20][Modules] Correct an assert for modules-ts.

iains created this revision. Herald added a project: All. iains added a reviewer: urnathan. iains published this revision for review. iains added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. somewhat on the trivial side. When adding the support for modules pa

[PATCH] D122385: [clang][deps] Fix clang-cl output argument parsing

saudi added a comment. Nice! It's much more straightforward now, the reverse iteration was pretty confusing. Thanks! Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:478 + if (Arg == "-Xclang") +++I; + A test for boundary

[PATCH] D122341: Fix a crash with variably-modified parameter types in a naked function

erichkeane added a comment. In D122341#3405008 , @aaron.ballman wrote: > In D122341#3403587 , @erichkeane > wrote: > >> Other than this 1 thing, LGTM. I DO find myself wondering how much of the >> CXXMethodDec

[PATCH] D122303: [pseudo] Sort nonterminals based on their reduction order.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf383b88d8214: [pseudo] Sort nonterminals based on their reduction order. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang-tools-extra] f383b88 - [pseudo] Sort nonterminals based on their reduction order.

Author: Haojian Wu Date: 2022-03-24T14:30:12+01:00 New Revision: f383b88d8214dc8f2d8bc9521c3ddd1c4454927f URL: https://github.com/llvm/llvm-project/commit/f383b88d8214dc8f2d8bc9521c3ddd1c4454927f DIFF: https://github.com/llvm/llvm-project/commit/f383b88d8214dc8f2d8bc9521c3ddd1c4454927f.diff LO

[PATCH] D104439: [analyzer][NFC] Demonstrate a move from the analyzer-configs `.def` file to a TableGen file

steakhal added reviewers: jansvoboda11, myhsu. steakhal added subscribers: jansvoboda11, myhsu. steakhal added a comment. Herald added a project: All. > We can put all the acceptable values in the help text AND generate the enum > class WITHOUT any redundancy. +1 > While not demonstrated, it'd

[clang-tools-extra] 62d5f25 - [pseudo] Introduce parse forest.

Author: Haojian Wu Date: 2022-03-24T14:47:17+01:00 New Revision: 62d5f254ccd0fc745fceb15a80494ef892db367c URL: https://github.com/llvm/llvm-project/commit/62d5f254ccd0fc745fceb15a80494ef892db367c DIFF: https://github.com/llvm/llvm-project/commit/62d5f254ccd0fc745fceb15a80494ef892db367c.diff LO

[PATCH] D122139: [pseudo] Introduce parse forest.

This revision was automatically updated to reflect the committed changes. Closed by commit rG62d5f254ccd0: [pseudo] Introduce parse forest. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D122139?vs=417225&id=417911#toc Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D122394: [C++20][Modules] Correct an assert for modules-ts.

urnathan added a comment. Is this because of history that ModulesTS option != p1103 modules? I thought we wanted to make the former become the latter (i.e. ModuleTS is the same as CPlusPlusModules) This seems to be moving in the wrong direction. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D122394: [C++20][Modules] Correct an assert for modules-ts.

iains added a comment. In D122394#3405338 , @urnathan wrote: > Is this because of history that ModulesTS option != p1103 modules? I thought > we wanted to make the former become the latter (i.e. ModuleTS is the same as > CPlusPlusModules) This seems t

[clang-tools-extra] 50f4f32 - [clangd] Retain main file fixes attached to diags from preamble

Author: Kadir Cetinkaya Date: 2022-03-24T15:19:25+01:00 New Revision: 50f4f32b56688d8cdeff5cda0982f19863093cd5 URL: https://github.com/llvm/llvm-project/commit/50f4f32b56688d8cdeff5cda0982f19863093cd5 DIFF: https://github.com/llvm/llvm-project/commit/50f4f32b56688d8cdeff5cda0982f19863093cd5.dif

[PATCH] D122315: [clangd] Retain main file fixes attached to diags from preamble

This revision was automatically updated to reflect the committed changes. Closed by commit rG50f4f32b5668: [clangd] Retain main file fixes attached to diags from preamble (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122315/ne

[PATCH] D122104: [X86][regcall] Support passing / returning structures

pengfei added a comment. Ping? We have internal request for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122104/new/ https://reviews.llvm.org/D122104 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D122401: [AVR] Add more devices

benshi001 created this revision. benshi001 added reviewers: aykevl, dylanmckay. Herald added subscribers: Jim, hiraditya. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jacquesguan. Herald added projects: clang, LLVM.

[PATCH] D122341: Fix a crash with variably-modified parameter types in a naked function

aaron.ballman updated this revision to Diff 417928. aaron.ballman added a comment. Updated the tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122341/new/ https://reviews.llvm.org/D122341 Files: clang/docs/ReleaseNotes.rst clang/lib/CodeGen/CodeGenFunction.cpp clang/test/Code

[PATCH] D122341: Fix a crash with variably-modified parameter types in a naked function

aaron.ballman added a comment. In D122341#3405269 , @erichkeane wrote: > In D122341#3405008 , @aaron.ballman > wrote: > >> In D122341#3403587 , @erichkeane >> wrote: >>

[clang] 488c772 - Fix a crash with variably-modified parameter types in a naked function

Author: Aaron Ballman Date: 2022-03-24T10:39:14-04:00 New Revision: 488c772920566354075f7933eedbe4358c128bd2 URL: https://github.com/llvm/llvm-project/commit/488c772920566354075f7933eedbe4358c128bd2 DIFF: https://github.com/llvm/llvm-project/commit/488c772920566354075f7933eedbe4358c128bd2.diff

[PATCH] D122341: Fix a crash with variably-modified parameter types in a naked function

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the reviews! I've commit in 488c772920566354075f7933eedbe4358c128bd2 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122341/new/ https://re

[PATCH] D122403: [OpenMP] Add a sematnic check for updating hidden or internal values

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield, ABataev. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: c

[PATCH] D122404: [clang][AArc64][SVE] Add support for comparison operators on SVE types

DavidTruby created this revision. Herald added subscribers: ctetreau, psnobl, tschuett. Herald added a reviewer: efriedma. Herald added a project: All. DavidTruby requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Comparison operators on SVE t

[PATCH] D121765: [CUDA][HIP] Fix hostness check with -fopenmp

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/include/clang/Sema/Sema.h:3325-3330 + /// getCurFunctionDecl - If parsing a lambda, then return the lambda + /// declaration if \p AllowLambda is true, otherwise return the function + ///

[PATCH] D120306: [clangd] IncludeCleaner: Add support for IWYU pragma private

kbobyrev updated this revision to Diff 417940. kbobyrev added a comment. Herald added a project: All. Switch to a different model of recording includes that differentiates between user includes and public headers recored through IWYU pragmas. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D103501: [clang][AIX] Enable inlined quadword atomic operations

lkail abandoned this revision. lkail added a comment. Herald added a project: All. Most are covered by https://reviews.llvm.org/D122377 already. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103501/new/ https://reviews.llvm.org/D103501 ___

[PATCH] D122407: [ASan] Reland of D116182 to always link asan_static library.

kstoimenov created this revision. Herald added a subscriber: mgorny. Herald added a project: All. kstoimenov requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[PATCH] D122377: [PowerPC][Linux] Support 16-byte lock free atomics on pwr8 and up

jsji added inline comments. Comment at: clang/test/CodeGen/PowerPC/atomic-alignment.c:7 +// RUN: -emit-llvm -o - %s | FileCheck %s --check-prefixes=PPC,PPC64-PWR8 // RUN: %clang_cc1 -verify -triple powerpc64-unknown-aix -emit-llvm -o - %s | \ // RUN: FileCheck %s --check-pr

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

gulfem added a comment. In D121812#3405060 , @jansvoboda11 wrote: > Sorry for the breakage and thanks for reporting this! This is a real bug > uncovered by your build using `/opt`. I have a fix here: D122385 > . Thank

[clang] 5b164a3 - Diagnose use of a naked attribute on a member function in ms-mode

Author: Aaron Ballman Date: 2022-03-24T11:52:43-04:00 New Revision: 5b164a3a9b8c52e45641203de9c4c73fa7402570 URL: https://github.com/llvm/llvm-project/commit/5b164a3a9b8c52e45641203de9c4c73fa7402570 DIFF: https://github.com/llvm/llvm-project/commit/5b164a3a9b8c52e45641203de9c4c73fa7402570.diff

[PATCH] D122336: [InstrProfiling] No runtime hook for unused funcs

gulfem updated this revision to Diff 417945. gulfem added a comment. Addressed phosek's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122336/new/ https://reviews.llvm.org/D122336 Files: clang/test/CoverageMapping/unused_function_no_runt

[PATCH] D122338: [OPENMP] Eliminate extra set of simd variant function attribute.

jyu2 updated this revision to Diff 417944. jyu2 added a comment. Address Alexey's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122338/new/ https://reviews.llvm.org/D122338 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenM

[PATCH] D122338: [OPENMP] Eliminate extra set of simd variant function attribute.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:11992 ->getCanonicalDecl(); + assert(ParamPositions.find(PVD) != ParamPositions.end()); Pos = ParamPositions[PVD]; Better to use

[PATCH] D121328: Disable -Wmissing-prototypes for internal linkage functions that aren't explicitly marked "static"""

deansturtevant requested changes to this revision. deansturtevant added a comment. This revision now requires changes to proceed. Aha! (I think). If the code to test "isExternalVisible" is executed *after* the code to test whether it's a C++ member function (the very next test), then the problem

[PATCH] D122338: [OPENMP] Eliminate extra set of simd variant function attribute.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:11992-11993 ->getCanonicalDecl(); + assert(ParamPositions.find(PVD) != ParamPositions.end()); Pos = ParamPositions[PVD]; } --

[PATCH] D122403: [OpenMP] Add a sematnic check for updating hidden or internal values

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122403/new/ https://reviews.llvm.org/D122403 ___

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane updated this revision to Diff 417948. erichkeane added reviewers: clang-language-wg, aaron.ballman, saar.raz. erichkeane added a subscriber: cfe-commits. erichkeane added a comment. Added release notes. I tossed every ranges-based example I could find on google at this and I saw only

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa added a comment. In D122248#3405166 , @erichkeane wrote: > In D122248#3405062 , @aaron.ballman > wrote: > >> In D122248#3403734 , @yihanaa >> wrote: >> >>> What

[PATCH] D122408: [pseudo] [WIP2] Implement GLR parser

sammccall created this revision. Herald added subscribers: mgrang, mgorny. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. Derived from https://reviews.llvm.org/D121150, which

[clang] f82ec55 - [OpenMP] Initial parsing/sema for the 'omp target parallel loop' construct

Author: Mike Rice Date: 2022-03-24T09:19:00-07:00 New Revision: f82ec5532b2f303732e547226816d7a668db3050 URL: https://github.com/llvm/llvm-project/commit/f82ec5532b2f303732e547226816d7a668db3050 DIFF: https://github.com/llvm/llvm-project/commit/f82ec5532b2f303732e547226816d7a668db3050.diff LOG

[PATCH] D122359: [OpenMP] Initial parsing/sema for the 'omp target parallel loop' construct

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf82ec5532b2f: [OpenMP] Initial parsing/sema for the 'omp target parallel loop' construct (authored by mikerice). Herald added a project: clang. Heral

[PATCH] D122409: [libclang] Add missing CursorKind enums defined in Index.h.

sighingnow created this revision. Herald added a subscriber: arphaman. Herald added a project: All. sighingnow requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Signed-off-by: Tao He Repository:

[PATCH] D122409: [libclang] Add missing CursorKind enums defined in Index.h.

sighingnow updated this revision to Diff 417955. sighingnow edited the summary of this revision. sighingnow added a comment. Add summary of this diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122409/new/ https://reviews.llvm.org/D122409 Files

[PATCH] D109977: LLVM Driver Multicall tool

phosek added a comment. Herald added a subscriber: StephenFan. @beanz Let me know if you need help, I'm happy to commandeer the change if you're too busy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109977/new/ https://reviews.llvm.org/D109977

[PATCH] D122409: [libclang] Add missing CursorKind enums defined in Index.h.

sighingnow added a comment. See also: https://github.com/llvm/llvm-project/blob/main/clang/include/clang-c/Index.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122409/new/ https://reviews.llvm.org/D122409

[PATCH] D109977: LLVM Driver Multicall tool

beanz added a comment. In D109977#3405687 , @phosek wrote: > @beanz Let me know if you need help, I'm happy to commandeer the change if > you're too busy. Please feel free to commandeer it. I'm really sorry I've held this up so long and I'm totally swa

[PATCH] D119409: [C++20] [Modules] Remain dynamic initializing internal-linkage variables in module interface unit

dblaikie added a comment. is this an issue for Clang Header Modules codegen too? (maybe the solution should be the same for both, then) & maybe we should do this regardless of the presence/absence/type of initializer, just for consistency? CHANGES SINCE LAST ACTION https://reviews.llvm.org/

  1   2   3   >