kadircet added inline comments.
================
Comment at: clang-tools-extra/clangd/Diagnostics.cpp:68
return true;
// Fixes are always in the main file.
if (!D.Fixes.empty())
----------------
sammccall wrote:
> update comment: Fixes are only added if the fix or diagnostics is in the main
> file.
as discussed offline, this is still the case and it isn't an `or` but an `and`,
i.e. we preserve a fix if it's in the main file AND the primary diagnostic
we'll attach it to is also inside the main file.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122315/new/
https://reviews.llvm.org/D122315
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
