[clang] edb7ba7 - Revert "[llvm][AArch64] Insert "bti j" after call to setjmp"

Author: David Spickett Date: 2022-03-23T10:43:20Z New Revision: edb7ba714acba1d18a20d9f4986d2e38aee1d109 URL: https://github.com/llvm/llvm-project/commit/edb7ba714acba1d18a20d9f4986d2e38aee1d109 DIFF: https://github.com/llvm/llvm-project/commit/edb7ba714acba1d18a20d9f4986d2e38aee1d109.diff LOG

[PATCH] D122301: [clang-format] Fix invalid code generation with comments in lambda

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, curdeius, HazardyKnusperkeks. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes: https:/

[PATCH] D122301: [clang-format] Fix invalid code generation with comments in lambda

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. Great! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122301/new/ https://reviews.llvm.org/D122301 ___

[clang] 47eb4f7 - [CGOpenMPRuntime] Specify correct type in EmitLoadOfPointerLValue()

Author: Nikita Popov Date: 2022-03-23T11:51:14+01:00 New Revision: 47eb4f7dcd845878b16a53dadd765195b9c24b6e URL: https://github.com/llvm/llvm-project/commit/47eb4f7dcd845878b16a53dadd765195b9c24b6e DIFF: https://github.com/llvm/llvm-project/commit/47eb4f7dcd845878b16a53dadd765195b9c24b6e.diff

[PATCH] D120397: [C++20] [Modules] Make the linkage consistent for template and its specialization

iains added a comment. for the record, I experimented with adding the linkage as an output for AST dumps (adding to TextNodeDumper / DeclPrinter), since it seems that this could be generally useful. this works fine, but, it would create a lot of testsuite churn - around 350 tests would need ame

[PATCH] D122303: [pseudo] Sort nonterminals based on their reduction order.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: mgrang, mgorny. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. Reductions need to be performed in

[clang] aaf2bcc - [CodeGen][OpenMP] Add alignment to test (NFC)

Author: Nikita Popov Date: 2022-03-23T12:01:00+01:00 New Revision: aaf2bccf1fa2f5c96de7354298bede139f8cb7e5 URL: https://github.com/llvm/llvm-project/commit/aaf2bccf1fa2f5c96de7354298bede139f8cb7e5 DIFF: https://github.com/llvm/llvm-project/commit/aaf2bccf1fa2f5c96de7354298bede139f8cb7e5.diff

[clang] 8b62dd3 - Reapply [CodeGen] Avoid deprecated Address ctor in EmitLoadOfPointer()

Author: Nikita Popov Date: 2022-03-23T12:06:11+01:00 New Revision: 8b62dd3cd6d775a9c6ae3bfe841bf965dc2c944d URL: https://github.com/llvm/llvm-project/commit/8b62dd3cd6d775a9c6ae3bfe841bf965dc2c944d DIFF: https://github.com/llvm/llvm-project/commit/8b62dd3cd6d775a9c6ae3bfe841bf965dc2c944d.diff

[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

aaron.ballman added a comment. In D118052#3401861 , @joaomoreira wrote: > I did track down the problem to clang/lib/Frontend/CompilerInvocation.cpp -- > RoundTrip method. There, we can se the following statement: > > #ifndef NDEBUG > bool DoRoundT

[PATCH] D121992: [Clang] [Driver] Add option to set alternative toolchain path

qiucf updated this revision to Diff 417566. qiucf marked 3 inline comments as done. qiucf added a comment. - Move test to another file - Add documentation on option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121992/new/ https://reviews.llvm.org/

[clang] 0254f59 - Forgot to add a release note for WG14 N2412.

Author: Aaron Ballman Date: 2022-03-23T07:39:53-04:00 New Revision: 0254f59fef86f9b4f4489490795f3e31d3d324d3 URL: https://github.com/llvm/llvm-project/commit/0254f59fef86f9b4f4489490795f3e31d3d324d3 DIFF: https://github.com/llvm/llvm-project/commit/0254f59fef86f9b4f4489490795f3e31d3d324d3.diff

[clang] c070d5c - [CGOpenMPRuntime] Remove uses of deprecated Address constructor

Author: Nikita Popov Date: 2022-03-23T12:40:44+01:00 New Revision: c070d5ceff05c3459b9a9add6d18aae9a3fa5916 URL: https://github.com/llvm/llvm-project/commit/c070d5ceff05c3459b9a9add6d18aae9a3fa5916 DIFF: https://github.com/llvm/llvm-project/commit/c070d5ceff05c3459b9a9add6d18aae9a3fa5916.diff

[PATCH] D120874: [C++20] [Modules] Use '-' as the separator of partitions when searching in filesystems

iains added a comment. I have no comment the patch itself, that seems fine, I even agree that this could be convenient :-) However, I am concerned that this now means that '-fprebuilt-module-path' has meaning for both clang modules and c++20 modules - which is something we agree is generally u

[clang] c3b9819 - Reland "[llvm][AArch64] Insert "bti j" after call to setjmp"

Author: David Spickett Date: 2022-03-23T11:43:43Z New Revision: c3b98194df5572bc9b33024b48457538a7213b4c URL: https://github.com/llvm/llvm-project/commit/c3b98194df5572bc9b33024b48457538a7213b4c DIFF: https://github.com/llvm/llvm-project/commit/c3b98194df5572bc9b33024b48457538a7213b4c.diff LOG

[PATCH] D121451: [clang-format] Add space to comments starting with '#'.

curdeius added a comment. In D121451#3401947 , @MyDeveloperDay wrote: > I'm a little uncomfortable with > > //# > > becoming > > // # > > At least without an option for it to not make changes Don't you think that `//#PPdirective` should be indented

[PATCH] D122119: [C++20][Modules] Adjust handling of exports of namespaces and using-decls.

urnathan added a comment. In D122119#3401322 , @ChuanqiXu wrote: > > I think the example is invalid since it violates [[ > http://eel.is/c++draft/module.interface#6 | [module.interface]p6 ]] > explicitly. If this is intended behavior or by design, w

[PATCH] D122303: [pseudo] Sort nonterminals based on their reduction order.

hokein updated this revision to Diff 417567. hokein added a comment. some tweaks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122303/new/ https://reviews.llvm.org/D122303 Files: clang-tools-extra/pseudo/include/clang-pseudo/Grammar.h clang-t

[clang] b0bc93d - Revert "[clang] roll-forward "[clang] Mark `trivial_abi` types as "trivially relocatable""."

Author: Zahira Ammarguellat Date: 2022-03-23T04:54:00-07:00 New Revision: b0bc93da926a943cdc2d8b04f8dcbe23a774520c URL: https://github.com/llvm/llvm-project/commit/b0bc93da926a943cdc2d8b04f8dcbe23a774520c DIFF: https://github.com/llvm/llvm-project/commit/b0bc93da926a943cdc2d8b04f8dcbe23a774520c

[clang] b26466d - Update the C and C++ status pages now that Clang 14 is out

Author: Aaron Ballman Date: 2022-03-23T07:59:52-04:00 New Revision: b26466d0019582f9b3dc65587cf8043da144b45d URL: https://github.com/llvm/llvm-project/commit/b26466d0019582f9b3dc65587cf8043da144b45d DIFF: https://github.com/llvm/llvm-project/commit/b26466d0019582f9b3dc65587cf8043da144b45d.diff

[PATCH] D120397: [C++20] [Modules] Make the linkage consistent for template and its specialization

aaron.ballman added a comment. In D120397#3401380 , @ChuanqiXu wrote: > In D120397#3399808 , @aaron.ballman > wrote: > >> Can you also add a release note that explains we've fixed the crash? > > My thought is to

[PATCH] D121099: [C++20][Modules][HU 5/5] Add fdirectives-only mode for preprocessing output.

urnathan accepted this revision. urnathan added a comment. This revision is now accepted and ready to land. Kind of surprised this wasn't already a thing :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121099/new/ https://reviews.llvm.org/D121099

[PATCH] D122141: [clang][extract-api] Suppprt for the module name property in SymbolGraph

dang updated this revision to Diff 417570. dang added a comment. Missed some stuff in the previous rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122141/new/ https://reviews.llvm.org/D122141 Files: clang/include/clang/Driver/Options.td

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, feel free to add the assert when you land. Comment at: clang/include/clang/Sema/ParsedAttr.h:813 void takeAllFrom(AttributePool &pool) { takePool(pool); pool.Attrs.clear();

[PATCH] D122141: [clang][extract-api] Suppprt for the module name property in SymbolGraph

dang updated this revision to Diff 417572. dang added a comment. Accidentally re-added some of the old files in SymbolGraph/ during the rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122141/new/ https://reviews.llvm.org/D122141 Files: clan

[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

aaron.ballman added a comment. I'm seeing precommit CI failures: Failed Tests (1): Clang :: SemaCXX/constant-expression-cxx2b.cpp Comment at: clang/lib/Sema/SemaDeclCXX.cpp:1905 +if (SemaRef.LangOpts.CPlusPlus2b) { + if (!VD->getType()->isLiteralType(SemaRe

[clang] a45ad3c - [clang-format] [doc] Add script to automatically update help output in ClangFormat.rst.

Author: Marek Kurdej Date: 2022-03-23T13:17:50+01:00 New Revision: a45ad3ca8ce78988a4d51b432455ce0bbf13 URL: https://github.com/llvm/llvm-project/commit/a45ad3ca8ce78988a4d51b432455ce0bbf13 DIFF: https://github.com/llvm/llvm-project/commit/a45ad3ca8ce78988a4d51b432455ce0bbf13.diff

[PATCH] D121916: [clang-format] [doc] Add script to automatically update help output in ClangFormat.rst.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa45ad3ca8ce7: [clang-format] [doc] Add script to automatically update help output in… (authored by curdeius). Changed prior to commit: https://rev

[PATCH] D122278: [clang] Improve diagnostic for reopened inline namespace

aaron.ballman added a comment. Thank you for the fix! This LGTM with a minor nit, but please also add a release note for the fix. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:11062-11066 + if (auto *FirstNS = PrevNS->getFirstDecl()) +// 'inline' must appear on the original

[PATCH] D121593: [clangd][WIP] Provide clang-include-cleaner

sammccall added a comment. We'd like to proceed here by extracting the include-cleaner functionality from clangd into a library. It would be used by: - clangd - a new clang-tidy check - possibly a standalone tool, if clang-tidy doesn't fit well into the cleanup workflow - some out-of-tree clean

[PATCH] D122285: [analyzer] Add path note tags to standard library function summaries.

Szelethus added a comment. LGTM on my end, this is awesome! In D122285#3401754 , @steakhal wrote: >> The notes are prunable, i.e. they won't bring-in entire stack frames worth >> of notes just because they're there, but they will be always visible >> r

[PATCH] D122083: [Concepts] Fix placeholder constraints when references are involved

erichkeane added a comment. Can you add some tests for the OTHER forms of 'auto' as well? We have `decltype(auto)` and `auto_type`, and I want to make sure whatever we do with those 'looks right'. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:4773 + QualType MaybeAut

[PATCH] D115248: [Clang] Fix PR28101

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:3430 << D.getName().TemplateId->LAngleLoc; + if (cast(CurContext)->getDeclName() == Name) +Diag(Loc, diag::err_member_name_of_class) << Name; I see we are diagnos

[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

cor3ntin updated this revision to Diff 417586. cor3ntin added a comment. - Fix test - Add a comment explaining why we do not use CheckLiteralType @aaron,ballman I completely missed that...! However, CheckLiteralType does a bunch of tests that we do not need to diagnose *why* a type is not litera

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

bjope added a comment. Hello. We've got some problem in our downstream tests after this patch and I'm trying to figure out how things are supposed to work. Maybe someone being part of this review knows. Problem is that we have some libc verification suites that include test cases using `float_

[clang] 5fdc4dd - [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC)

Author: Vince Bridgers Date: 2022-03-23T08:26:37-05:00 New Revision: 5fdc4dd7770486c0127dc5919aafea3f8ff2e61e URL: https://github.com/llvm/llvm-project/commit/5fdc4dd7770486c0127dc5919aafea3f8ff2e61e DIFF: https://github.com/llvm/llvm-project/commit/5fdc4dd7770486c0127dc5919aafea3f8ff2e61e.diff

[clang] 9ef7ac5 - [analyzer] Fix crash in RangedConstraintManager.cpp

Author: Vince Bridgers Date: 2022-03-23T08:26:40-05:00 New Revision: 9ef7ac51af67d08212dc69e5a932c4aa447ee9b7 URL: https://github.com/llvm/llvm-project/commit/9ef7ac51af67d08212dc69e5a932c4aa447ee9b7 DIFF: https://github.com/llvm/llvm-project/commit/9ef7ac51af67d08212dc69e5a932c4aa447ee9b7.diff

[PATCH] D120134: [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG5fdc4dd77704: [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC) (authored by vabridgers, committed by einvbri ). Repository: rG LLVM Github Mon

[PATCH] D122277: [analyzer] Fix crash in RangedConstraintManager.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ef7ac51af67: [analyzer] Fix crash in RangedConstraintManager.cpp (authored by vabridgers, committed by einvbri ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D121328: Disable -Wmissing-prototypes for internal linkage functions that aren't explicitly marked "static"""

deansturtevant added a comment. Note that some fix is important to make if we think that the -Wmissing-prototypes warning is valuable, because there are cases where it currently would fire where the function cannot explicitly be given internal linkage, e.g. namespace { struct Initialized {}; }

[PATCH] D122303: [pseudo] Sort nonterminals based on their reduction order.

sammccall added a comment. I think my main suggestion is to sort the symbols, not just the rules. Having the rules in blocks grouped by the symbol they produce, but not in symbol order, seems confusing to reason about. The extraction of TestGrammar seems unrelated to the rest of the patch and it

[PATCH] D122083: [Concepts] Fix placeholder constraints when references are involved

royjacobson updated this revision to Diff 417591. royjacobson added a comment. Remove the curly brackets from one line loop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122083/new/ https://reviews.llvm.org/D122083 Files: clang/lib/Sema/SemaTem

[PATCH] D122175: [clang][extract-api] Enable processing of multiple headers

dang updated this revision to Diff 417593. dang added a comment. Rebase on top of latest changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122175/new/ https://reviews.llvm.org/D122175 Files: clang/include/clang/ExtractAPI/FrontendActions.h

[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

aaron.ballman added a comment. In D122249#3402331 , @cor3ntin wrote: > - Fix test > - Add a comment explaining why we do not use CheckLiteralType > > @aaron,ballman I completely missed that...! No worries! > However, CheckLiteralType does a bunch of tes

[clang] 59dadd1 - [clang][lex] Fix failures with Microsoft header search rules

Author: Jan Svoboda Date: 2022-03-23T14:49:17+01:00 New Revision: 59dadd178b0b12cb4a975a262ed20e7c3822aedc URL: https://github.com/llvm/llvm-project/commit/59dadd178b0b12cb4a975a262ed20e7c3822aedc DIFF: https://github.com/llvm/llvm-project/commit/59dadd178b0b12cb4a975a262ed20e7c3822aedc.diff L

[PATCH] D122237: [clang][lex] Fix failures with Microsoft header search rules

This revision was automatically updated to reflect the committed changes. Closed by commit rG59dadd178b0b: [clang][lex] Fix failures with Microsoft header search rules (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122237/n

[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant

bc-lee updated this revision to Diff 417595. bc-lee added a comment. Addressing review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121868/new/ https://reviews.llvm.org/D121868 Files: clang/include/clang/Driver/Options.td clang/incl

[PATCH] D122083: [Concepts] Fix placeholder constraints when references are involved

royjacobson marked an inline comment as done. royjacobson added a comment. In D122083#3402289 , @erichkeane wrote: > Can you add some tests for the OTHER forms of 'auto' as well? We have > `decltype(auto)` and `auto_type`, and I want to make sure whate

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

aaron.ballman added a comment. In D121122#3402334 , @bjope wrote: > Hello. We've got some problem in our downstream tests after this patch and > I'm trying to figure out how things are supposed to work. Maybe someone being > part of this review knows.

[PATCH] D122083: [Concepts] Fix placeholder constraints when references are involved

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. In D122083#3402440 , @royjacobson wrote: > In D122083#3402289 , @erichkeane > wrote: > >> Can you a

[PATCH] D122175: [clang][extract-api] Enable processing of multiple headers

dang updated this revision to Diff 417596. dang added a comment. Clarify doc comment for ExtractAPIAction::PrepareToExecuteAction Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122175/new/ https://reviews.llvm.org/D122175 Files: clang/include/cla

[PATCH] D122175: [clang][extract-api] Enable processing of multiple headers

dang marked an inline comment as done. dang added inline comments. Comment at: clang/include/clang/SymbolGraph/FrontendActions.h:35 + /// This is called before executing the action on any inputs. This merges all + /// the provided headers into a single header for processing. +

[PATCH] D122265: [Clang][NFC] Cleanup dcl.constexpr/p3 tests

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks for the cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122265/new/ https://reviews.llvm.org/D122265

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

zahiraam added a comment. In D121122#3402442 , @aaron.ballman wrote: > In D121122#3402334 , @bjope wrote: > >> Hello. We've got some problem in our downstream tests after this patch and >> I'm trying to figure o

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:755 +)cpp"); + TU.Filename = "foo.m"; + auto AST = TU.build(); nit: not necessary, this pragma isn't tied to objc Comment at: clang-tools-ext

[libunwind] a749e32 - Replace links to archived mailing lists by links to Discourse forums

Author: Danny Mösch Date: 2022-03-23T10:10:20-04:00 New Revision: a749e3295df4aee18a0ad723875a6501f30ac744 URL: https://github.com/llvm/llvm-project/commit/a749e3295df4aee18a0ad723875a6501f30ac744 DIFF: https://github.com/llvm/llvm-project/commit/a749e3295df4aee18a0ad723875a6501f30ac744.diff L

[clang-tools-extra] a749e32 - Replace links to archived mailing lists by links to Discourse forums

Author: Danny Mösch Date: 2022-03-23T10:10:20-04:00 New Revision: a749e3295df4aee18a0ad723875a6501f30ac744 URL: https://github.com/llvm/llvm-project/commit/a749e3295df4aee18a0ad723875a6501f30ac744 DIFF: https://github.com/llvm/llvm-project/commit/a749e3295df4aee18a0ad723875a6501f30ac744.diff L

[clang] a749e32 - Replace links to archived mailing lists by links to Discourse forums

Author: Danny Mösch Date: 2022-03-23T10:10:20-04:00 New Revision: a749e3295df4aee18a0ad723875a6501f30ac744 URL: https://github.com/llvm/llvm-project/commit/a749e3295df4aee18a0ad723875a6501f30ac744 DIFF: https://github.com/llvm/llvm-project/commit/a749e3295df4aee18a0ad723875a6501f30ac744.diff L

[PATCH] D120573: [OpenMP] Support runtime user conditions in metadirective

ggeorgakoudis added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1793 +void CodeGenFunction::EmitOMPMetaDirective(const OMPMetaDirective &D) { + llvm::BasicBlock *AfterBlock = + createBasicBlock("omp.meta.user.condition.after"); abidmalik

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

aaron.ballman added a comment. In D121078#3400810 , @SimplyDanny wrote: > @tonic, can you please have another look? If @tonic has any additional feedback, we can handle it post-commit at this point. I've gone ahead and committed this on your behalf in

[PATCH] D122261: [Clang][NFC] Some `const` for `IdentifierInfo *`s feeding `DeclarationName`

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122261/new/ https://reviews.llvm.org/D122261 _

[clang] 683fc62 - [clang][AArc64][SVE] Implement vector-scalar operators

Author: David Truby Date: 2022-03-23T14:20:48Z New Revision: 683fc6203cfa3f604df5f59cef714568cba2daac URL: https://github.com/llvm/llvm-project/commit/683fc6203cfa3f604df5f59cef714568cba2daac DIFF: https://github.com/llvm/llvm-project/commit/683fc6203cfa3f604df5f59cef714568cba2daac.diff LOG: [

[PATCH] D121829: [clang][AArc64][SVE] Implement vector-scalar operators

This revision was automatically updated to reflect the committed changes. Closed by commit rG683fc6203cfa: [clang][AArc64][SVE] Implement vector-scalar operators (authored by DavidTruby). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121829/new/ htt

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:50-53 +def warn_eval_method_setting_via_option_in_value_unsafe_context : Warning< +"setting the eval method via '-ffp-eval-method' has not effect when numeric " +"result

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

jansvoboda11 added inline comments. Comment at: clang/test/ClangScanDeps/cl-resource-dir.c:3 + +// REQUIRES: shell + saudi wrote: > I was wondering whether it could be a concern that this test will be skipped > on Windows systems, where `clang-cl` specific devel

[PATCH] D122083: [Concepts] Fix placeholder constraints when references are involved

royjacobson updated this revision to Diff 417602. royjacobson added a comment. Add test for auto**& combination Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122083/new/ https://reviews.llvm.org/D122083 Files: clang/lib/Sema/SemaTemplateDeductio

[PATCH] D122315: [clangd] Retain main file fixes attached to diags from preamble

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Cl

[PATCH] D122083: [Concepts] Fix placeholder constraints when references are involved

royjacobson added a comment. In D122083#3402445 , @erichkeane wrote: > 1 more test I'd like to see that doesn't seem covered (ref to ptr), Added, good idea. > AND according to @aaron.ballman we need "Release Notes" for this. Otherwise > LGTM. Do you

[PATCH] D122083: [Concepts] Fix placeholder constraints when references are involved

erichkeane added a comment. In D122083#3402523 , @royjacobson wrote: > In D122083#3402445 , @erichkeane > wrote: > >> 1 more test I'd like to see that doesn't seem covered (ref to ptr), > > Added, good idea. > >

[clang] 9f63cd7 - [Clang][NFC] Cleanup dcl.constexpr/p3 tests

Author: Corentin Jabot Date: 2022-03-23T15:37:48+01:00 New Revision: 9f63cd763ec85e89212e071d5d50ae5a3d5f384d URL: https://github.com/llvm/llvm-project/commit/9f63cd763ec85e89212e071d5d50ae5a3d5f384d DIFF: https://github.com/llvm/llvm-project/commit/9f63cd763ec85e89212e071d5d50ae5a3d5f384d.diff

[PATCH] D122265: [Clang][NFC] Cleanup dcl.constexpr/p3 tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f63cd763ec8: [Clang][NFC] Cleanup dcl.constexpr/p3 tests (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122265/new/ https://reviews.

[clang] beee096 - [CGBlocks] Don't assume presence of bitcast

Author: Nikita Popov Date: 2022-03-23T15:39:39+01:00 New Revision: beee09687f4602dba82a378bad94ed9657c97339 URL: https://github.com/llvm/llvm-project/commit/beee09687f4602dba82a378bad94ed9657c97339 DIFF: https://github.com/llvm/llvm-project/commit/beee09687f4602dba82a378bad94ed9657c97339.diff

[clang] 5c6752d - [CGObjCMac] Check global value type instead of poitner type

Author: Nikita Popov Date: 2022-03-23T15:39:39+01:00 New Revision: 5c6752d4ade99ecdaca391cf14b7d7e5c9a75fc1 URL: https://github.com/llvm/llvm-project/commit/5c6752d4ade99ecdaca391cf14b7d7e5c9a75fc1 DIFF: https://github.com/llvm/llvm-project/commit/5c6752d4ade99ecdaca391cf14b7d7e5c9a75fc1.diff

[clang] ba36556 - [InstrProfiling] Account for missing bitcast/GEP

Author: Nikita Popov Date: 2022-03-23T15:39:39+01:00 New Revision: ba365561455e467664df8c656f111b26fd1f81de URL: https://github.com/llvm/llvm-project/commit/ba365561455e467664df8c656f111b26fd1f81de DIFF: https://github.com/llvm/llvm-project/commit/ba365561455e467664df8c656f111b26fd1f81de.diff

[clang] a8690ba - [CGExpr] Perform bitcast unconditionally

Author: Nikita Popov Date: 2022-03-23T15:39:39+01:00 New Revision: a8690ba9d0147bbca8d9031ef1596c4de025e6ed URL: https://github.com/llvm/llvm-project/commit/a8690ba9d0147bbca8d9031ef1596c4de025e6ed DIFF: https://github.com/llvm/llvm-project/commit/a8690ba9d0147bbca8d9031ef1596c4de025e6ed.diff

[clang] 26053ce - [clang][deps] Create lit substitution for deps-to-rsp

Author: Jan Svoboda Date: 2022-03-23T15:42:10+01:00 New Revision: 26053ce05a87fdb9a0714d6df399783fee50b317 URL: https://github.com/llvm/llvm-project/commit/26053ce05a87fdb9a0714d6df399783fee50b317 DIFF: https://github.com/llvm/llvm-project/commit/26053ce05a87fdb9a0714d6df399783fee50b317.diff L

[clang] 30cb49b - [clang][deps] NFC: De-duplicate clang-cl tests

Author: Jan Svoboda Date: 2022-03-23T15:42:11+01:00 New Revision: 30cb49b44e4e2af2e0627b2aa33df0ba57ab9e55 URL: https://github.com/llvm/llvm-project/commit/30cb49b44e4e2af2e0627b2aa33df0ba57ab9e55 DIFF: https://github.com/llvm/llvm-project/commit/30cb49b44e4e2af2e0627b2aa33df0ba57ab9e55.diff L

[PATCH] D121525: [clang][deps] Create lit substitution for deps-to-rsp

This revision was automatically updated to reflect the committed changes. Closed by commit rG26053ce05a87: [clang][deps] Create lit substitution for deps-to-rsp (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D121525?vs=414843&id=417608#toc Repository: rG LLVM G

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG30cb49b44e4e: [clang][deps] NFC: De-duplicate clang-cl tests (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D121368: [pseudo][WIP] Build Ambiguous forest node in the GLR Parser.

sammccall added a comment. A bunch of comments, but probably the most important one is that the inner loop feels uncomfortably chaotic: - there's a huge function with a lot of stuff in scope and referenced, it's unclear what the data flow is - there are very many (hopefully, unneccesarily many)

[PATCH] D122083: [Concepts] Fix placeholder constraints when references are involved

royjacobson updated this revision to Diff 417618. royjacobson added a comment. Added release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122083/new/ https://reviews.llvm.org/D122083 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/Se

[PATCH] D122083: [Concepts] Fix placeholder constraints when references are involved

erichkeane accepted this revision. erichkeane added a comment. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122083/new/ https://reviews.llvm.org/D122083 ___ cfe-commits mailing list cfe-co

[PATCH] D115248: [Clang] Fix PR28101

rZhBoYao marked 3 inline comments as done. rZhBoYao added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:3430 << D.getName().TemplateId->LAngleLoc; + if (cast(CurContext)->getDeclName() == Name) +Diag(Loc, diag::err_member_name_of_class) << Na

[PATCH] D115248: [Clang] Fix PR28101

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:3430 << D.getName().TemplateId->LAngleLoc; + if (cast(CurContext)->getDeclName() == Name) +Diag(Loc, diag::err_member_name_of_class) << Name; rZhBoYao wrote: > er

[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:1905 +if (SemaRef.LangOpts.CPlusPlus2b) { + if (!VD->getType()->isLiteralType(SemaRef.Context)) +SemaRef.Diag(VD->getLocation(), aaron.ballman wrote: > aaron.b

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

bjope added a comment. Looked around a bit. - Seems like in GNU libc they use an internal `__GLIBC_FLT_EVAL_METHOD` that is set to 2 if `__FLT_EVAL_METHOD__` is -1 (https://sourceware.org/git/?p=glibc.git;a=blob;f=bits/flt-eval-method.h;hb=f60e45ba10f0ca2794318de95720cdbdb6ff20d0). - In LLVM:

Re: [PATCH] D122255: Meta directive runtime support

I quickly went through the D120573. There are many overlapping. On Tue, Mar 22, 2022 at 4:23 PM Johannes Doerfert via Phabricator < revi...@reviews.llvm.org> wrote: > jdoerfert added subscribers: ggeorgakoudis, mikerice, cchen. > jdoerfert added a comment. > > This contains a lot of unrelated ch

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

dgoldman updated this revision to Diff 417623. dgoldman marked 2 inline comments as done. dgoldman added a comment. Minor fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122179/new/ https://reviews.llvm.org/D122179 Files: clang-tools-extra/c

[PATCH] D122083: [Concepts] Fix placeholder constraints when references are involved

royjacobson updated this revision to Diff 417624. royjacobson added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122083/new/ https://reviews.llvm.org/D122083 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaTemplateDedu

[clang] da167a5 - [Clang][NFC] Some `const` for `IdentifierInfo *`s feeding `DeclarationName`

Author: Hubert Tong Date: 2022-03-23T11:07:56-04:00 New Revision: da167a53c87f53ce582de6cc122d5e090f341b42 URL: https://github.com/llvm/llvm-project/commit/da167a53c87f53ce582de6cc122d5e090f341b42 DIFF: https://github.com/llvm/llvm-project/commit/da167a53c87f53ce582de6cc122d5e090f341b42.diff L

[PATCH] D122261: [Clang][NFC] Some `const` for `IdentifierInfo *`s feeding `DeclarationName`

This revision was automatically updated to reflect the committed changes. Closed by commit rGda167a53c87f: [Clang][NFC] Some `const` for `IdentifierInfo *`s feeding `DeclarationName` (authored by hubert.reinterpretcast). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[clang] 94fd00f - [Concepts] Fix placeholder constraints when references are involved

Author: Roy Jacobson Date: 2022-03-23T11:14:58-04:00 New Revision: 94fd00f41ebddf84148f494410130527169d9573 URL: https://github.com/llvm/llvm-project/commit/94fd00f41ebddf84148f494410130527169d9573 DIFF: https://github.com/llvm/llvm-project/commit/94fd00f41ebddf84148f494410130527169d9573.diff

[PATCH] D122083: [Concepts] Fix placeholder constraints when references are involved

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG94fd00f41ebd: [Concepts] Fix placeholder constraints when references are involved (authored by royjacobson). Repository: rG LLVM Github Monorepo

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang/lib/Lex/PPLexerChange.cpp:436 + if (PragmaAssumeNonNullLoc.isValid() && !this->PPOpts->GeneratePreamble && + !(CurLexer && CurLexer->getFileID() == PredefinesFileID) && !isEn

[PATCH] D121765: [CUDA][HIP] Fix hostness check with -fopenmp

yaxunl marked an inline comment as done. yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121765/new/ https://reviews.llvm.org/D121765 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] 4e88cb6 - [clang-format] Handle attributes before case label. Relanded.

Author: Marek Kurdej Date: 2022-03-23T16:24:24+01:00 New Revision: 4e88cb6825eefca3c0eb66b5ae40ab123fcc7073 URL: https://github.com/llvm/llvm-project/commit/4e88cb6825eefca3c0eb66b5ae40ab123fcc7073 DIFF: https://github.com/llvm/llvm-project/commit/4e88cb6825eefca3c0eb66b5ae40ab123fcc7073.diff

[PATCH] D121450: [clang-format] Handle attributes before case label.

curdeius added a comment. Relanded in https://github.com/llvm/llvm-project/commit/4e88cb6825eefca3c0eb66b5ae40ab123fcc7073 with a fix and a regression test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121450/new/ https://reviews.llvm.org/D12145

[PATCH] D122303: [pseudo] Sort nonterminals based on their reduction order.

sammccall added a comment. In D122303#3402375 , @sammccall wrote: > I think my main suggestion is to sort the symbols, not just the rules. > Having the rules in blocks grouped by the symbol they produce, but not in > symbol order, seems confusing to reas

[PATCH] D115248: [Clang] Fix PR28101

rZhBoYao updated this revision to Diff 417632. rZhBoYao marked 3 inline comments as done. rZhBoYao added a comment. This passes check-clang-semacxx on my machine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115248/new/ https://reviews.llvm.org/D115248 Files: clang/lib/Sema/SemaDecl

[PATCH] D115248: [Clang] Fix PR28101

erichkeane added a comment. Please add a 'release notes'. Otherwise, LGTM as long as the bots are ok with it! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115248/new/ https://reviews.llvm.org/D115248 ___ cfe-commits mailing list cfe-commit

[PATCH] D120573: [OpenMP] Support runtime user conditions in metadirective

abidmalikwaterloo added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1852 +int BestIdx = getBestVariantMatchForContext(StaticVMIs, OMPCtx); + +EmitStmt(StaticWhenClauses[BestIdx]->getDirective()); ggeorgakoudis wrote: > abidmalikwaterlo

<    1   2   3   4   >