[PATCH] D121098: [C++20][Modules][HU 4/5] Handle pre-processed header units.

ChuanqiXu added a comment. OK, I feel good if this one contains tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121098/new/ https://reviews.llvm.org/D121098 ___ cfe-commits mailing list cfe-commits@

[PATCH] D121678: [pseudo] Split greatergreater token.

zequanwu added a comment. This fails on windows bot at https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8819402935494502225/+/u/package_clang/stdout?format=raw. C:\b\s\w\ir\cache\builder\src\third_party\llvm\clang-tools-extra\pseudo\unittests\TokenTest.cpp(190): error: Valu

[PATCH] D121951: [AMDGPU] Only warn when mixing printf and hostcall

sameerds added a comment. The check for "__ockl_hostcall_internal" is not longer relevant with the new hostcall attribute. Can we simply remove this check? What is the situation where the warning is still useful? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D121749: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst

MyDeveloperDay added a comment. I’m not blocking it just using the observation to highlight that the rst generated isn’t conformant with best practices. The solution being that a volunteer offers to fix the dump_format_style.py or enduring Format.h isn’t making those mistakes Repository: rG

[PATCH] D121916: [clang-format] [doc] Add script to automatically update help output in ClangFormat.rst.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Wow! Now that’s what I’m talking about!! Awesome! Thank you so much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121916/new/ h

[PATCH] D121983: Driver: Don't warn on -mbranch-protection when linking

tstellar created this revision. tstellar added reviewers: chill, vhscampos, stuij, amilendra. Herald added a project: All. tstellar requested review of this revision. Herald added a project: clang. The -mbranch-protection definition in Options.td was not given a Group, so this was causing clang to

[PATCH] D121984: [RISCV][NFC] Moving RVV intrinsic type related util to llvm/Support

kito-cheng created this revision. Herald added subscribers: s, VincentWu, luke957, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook,

[PATCH] D70401: [RISCV] Complete RV32E/ilp32e implementation

khchen added a comment. Herald added a subscriber: s. In D70401#3384758 , @pcwang-thead wrote: > In D70401#3250049 , @khchen wrote: > >> 1. please add a check here >>

[PATCH] D121916: [clang-format] [doc] Add script to automatically update help output in ClangFormat.rst.

curdeius added inline comments. Comment at: clang/tools/clang-format/ClangFormat.cpp:105 +SortIncludes("sort-includes", + cl::desc("If set, overrides the include sorting behavior\n" + "determined by the SortIncludes style flag"), -

[PATCH] D121906: [clang-format] Indent import statements in JavaScript.

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. Can you please supply full context diff "Context not available." Comment at: clang/lib/Format/ContinuationIndenter.cpp:629 int PPColumnCorrection

[PATCH] D121753: [clang-format] Use a macro for non-C keywords

MyDeveloperDay requested changes to this revision. MyDeveloperDay added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Format/FormatToken.h:884 struct AdditionalKeywords { +#define LIST_ADDITIONAL_KEYWORDS

[PATCH] D121755: [clang-format] Join spaceRequiredBefore and spaceRequiredBetween

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. This just made a 300 lines function and a 500 line function with minimal comments into a 800 line function.. For no real benefit? Because from what I can tell you hav

[PATCH] D121756: [clang-format] Clean up code looking for if statements

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. Sorry I don't believe we've covered the changes with unit tests. Comment at: clang/lib/Format/FormatToken.h:528 + /// to be handled separately. +

[PATCH] D121983: Driver: Don't warn on -mbranch-protection when linking

vhscampos accepted this revision. vhscampos added a comment. This revision is now accepted and ready to land. LGTM, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121983/new/ https://reviews.llvm.org/D121983 _

[PATCH] D121754: [clang-format] Refactor determineStarAmpUsage

MyDeveloperDay requested changes to this revision. MyDeveloperDay added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Format/TokenAnnotator.cpp:2146-2147 +// know how they can be followed by a star or amp. +// co_await, delete - I

[PATCH] D118370: [clang-tidy] bugprone-signal-handler: Message improvement and code refactoring.

balazske updated this revision to Diff 416429. balazske added a comment. Applied the review proposals. Changed "system call" to "standard function". Put the string lists into constant std::initializer_list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D121758: [clang-format] Add support for formatting Verilog code

MyDeveloperDay added a comment. In D121758#3389181 , @sstwcw wrote: > Yes. I am surprised that you asked since everyone asked me to break it apart. Well I was thinking you move the unrelated parts out and then reduce the side of this patch, (but you'll

[PATCH] D121097: [C++20][Modules][HU 3/5] Emit module macros for header units.

iains added a comment. In D121097#3391236 , @ChuanqiXu wrote: > I feel good if we could add the test from: > http://eel.is/c++draft/cpp.import#8. I agree we should have tests based on all the relevant examples in the standard. However, that specific e

[PATCH] D121965: Add validation for number of arguments of __builtin_memcpy_inline

gchatelet accepted this revision. gchatelet added a comment. This revision is now accepted and ready to land. Thx! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121965/new/ https://reviews.llvm.org/D121965 _

[PATCH] D70401: [RISCV] Complete RV32E/ilp32e implementation

kito-cheng added a comment. > If I understand correctly, E can't be combined with D in current > specification since E must use ILP32E calling convention. Calling convention and extensions are separated, calling convention are specify the how argument passing and the register convention, so ILP

[clang] 33d020d - [CodeGen] Remove some uses of deprecated Address constructor

Author: Nikita Popov Date: 2022-03-18T11:01:25+01:00 New Revision: 33d020d010478e59e2cdc57300d4aae3fbac0611 URL: https://github.com/llvm/llvm-project/commit/33d020d010478e59e2cdc57300d4aae3fbac0611 DIFF: https://github.com/llvm/llvm-project/commit/33d020d010478e59e2cdc57300d4aae3fbac0611.diff

[PATCH] D118370: [clang-tidy] bugprone-signal-handler: Message improvement and code refactoring.

balazske updated this revision to Diff 416435. balazske added a comment. Additional documentation related fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118370/new/ https://reviews.llvm.org/D118370 Files: clang-tools-extra/clang-tidy/bugpr

[PATCH] D121755: [clang-format] Join spaceRequiredBefore and spaceRequiredBetween

owenpan added a comment. In D121755#3391606 , @MyDeveloperDay wrote: > This just made a 300 lines function and a 500 line function with minimal > comments into a 800 line function.. For no real benefit? > > Because from what I can tell you haven't worke

[clang] 74992f4 - [CodeGen] Store element type in DominatingValue

Author: Nikita Popov Date: 2022-03-18T11:13:25+01:00 New Revision: 74992f4a5bb79e2084abdef406ef2e5aa2024368 URL: https://github.com/llvm/llvm-project/commit/74992f4a5bb79e2084abdef406ef2e5aa2024368 DIFF: https://github.com/llvm/llvm-project/commit/74992f4a5bb79e2084abdef406ef2e5aa2024368.diff

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

fhahn added a comment. The test also failed in the Phabricator pre-commit CI, please keep an eye on it before re-submitting (failure link for latest diff was https://buildkite.com/llvm-project/premerge-checks/builds/83983#39c06525-7452-412d-af83-ae2cc2d30cdc) Repository: rG LLVM Github Monor

[PATCH] D115622: [Debugify] Optimize debugify original mode

djtodoro updated this revision to Diff 416438. djtodoro added a comment. Herald added a project: All. - Move the skipping into the for-loop since we want to collect metadata for the functions that are not observed in the previous Pass (for example the function wasn't of interest due to having an

[PATCH] D118935: [SYCL] Disallow explicit casts between mismatching address spaces

keryell added a comment. In D118935#3389452 , @hvdijk wrote: > It does make sense, then. A slightly more verbose commit message might have > helped though :) Even better, some comments in the code explaining the "why" would have helped. The commit mess

[PATCH] D121873: [clang][extract-api] Add enum support

dang added inline comments. Comment at: clang/lib/SymbolGraph/Serialization.cpp:343 + if (!Enum) +return; + zixuw wrote: > dang wrote: > > Quick design question: Do we want to be silently failing in these > > situations (especially since this shouldn't be h

[PATCH] D121965: Add validation for number of arguments of __builtin_memcpy_inline

royjacobson added a comment. @gchatelet In D121965#3391714 , @gchatelet wrote: > Thx! Thanks, will you be able to commit this for me as "Roy Jacobson "? I don't have write access :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D121754: [clang-format] Refactor determineStarAmpUsage

sstwcw updated this revision to Diff 416450. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121754/new/ https://reviews.llvm.org/D121754 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTest.cpp clang/unittests/Format/Tok

[PATCH] D121890: [clang-format] Copy help options to the doc directory.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfee94803f59d: [clang-format] Copy help options to the doc directory. (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121890/new/ https:/

[clang] fee9480 - [clang-format] Copy help options to the doc directory.

Author: sstwcw Date: 2022-03-18T10:51:36Z New Revision: fee94803f59dbd1a5b39c51036f181246d7d2fe6 URL: https://github.com/llvm/llvm-project/commit/fee94803f59dbd1a5b39c51036f181246d7d2fe6 DIFF: https://github.com/llvm/llvm-project/commit/fee94803f59dbd1a5b39c51036f181246d7d2fe6.diff LOG: [clang

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Models/ChromiumCheckModel.h:15 + +#include "clang/AST/ASTContext.h" +#include "clang/AST/DeclCXX.h" This is unnecessary. Commen

[PATCH] D121754: [clang-format] Refactor determineStarAmpUsage

sstwcw marked 5 inline comments as done. sstwcw added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2146-2147 +// know how they can be followed by a star or amp. +// co_await, delete - It doesn't make sense to have them followed by a unary +//

[PATCH] D121992: [Clang] [Driver] Add option to set alternative toolchain path

qiucf created this revision. qiucf added reviewers: hubert.reinterpretcast, jsji, nemanjai, collinbaker, rpenacob. Herald added a project: All. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In some cases, we need to set alternative

[PATCH] D121906: [clang-format] Indent import statements in JavaScript.

sstwcw updated this revision to Diff 416456. sstwcw added a comment. use `isJavascript` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121906/new/ https://reviews.llvm.org/D121906 Files: clang/lib/Format/ContinuationIndenter.cpp clang/lib/Forma

[PATCH] D121906: [clang-format] Indent import statements in JavaScript.

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:631 + Style.IndentPPDirectives == FormatStyle::PPDIS_AfterHash && Previous.is(tok::hash) && State.FirstIndent > 0 && (State.Line->Type == LT_PreprocessorDirective || ---

[PATCH] D121907: [clang-format] Use an enum for context types.

sstwcw updated this revision to Diff 416458. sstwcw added a comment. Remove comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121907/new/ https://reviews.llvm.org/D121907 Files: clang/lib/Format/TokenAnnotator.cpp Index: clang/lib/Format/T

[PATCH] D121907: [clang-format] Use an enum for context types. NFC

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. I think fundamentally this look ok? @curdeius and @owenpan I feel I want to bow to your better judgement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D121907: [clang-format] Use an enum for context types. NFC

MyDeveloperDay added a comment. Please wait for the other reviewers if you have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121907/new/ https://reviews.llvm.org/D121907 ___ cfe-commits m

[PATCH] D121955: [clang] NFC: Dead code removal in SemaDecl.cpp, CheckMultiVersionFunction().

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121955/new/ https://reviews.llvm.org/D121955

[PATCH] D121957: [clang] NFC: Redundant code removal in SemaDecl.cpp, CheckTargetCausesMultiVersioning().

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121957/new/ https://reviews.llvm.org/D121957

[PATCH] D121958: [clang] NFC: Remove forced type merging in multiversion function checks.

aaron.ballman added a comment. You should fix the clang-format issues (I leave @erichkeane to sign off on this one, but it looks reasonable to me). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121958/new/ https://reviews.llvm.org/D121958 ___

[PATCH] D121960: [clang] NFC: Rename 'MVType' variables to 'MVKind' for consistency with their type.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121960/new/ https://reviews.llvm.org/D121960

[PATCH] D121497: Lex: add support for `{,u}i128` Microsoft extension

iains added a comment. In D121497#3388870 , @aaron.ballman wrote: > In D121497#3388024 , @compnerd > wrote: > >> I don't have an example module sadly. It was something that I ran into with >> Swift code import

[PATCH] D121907: [clang-format] Use an enum for context types. NFC

sstwcw marked 2 inline comments as done. sstwcw added a comment. In D121907#3390226 , @MyDeveloperDay wrote: > So out of interest, what is the reason? my assumption is that you wanted to > add more for Verilog and you felt adding the extra bools was the

[PATCH] D121961: [clang] Produce a "multiversion" annotation in textual AST output.

aaron.ballman added a comment. Is there a need for this functionality? The text node dumper already dumps attributes associated with the function: https://godbolt.org/z/EbW8E74TT If the change is necessary, it needs some test coverage (I'd recommend adding the test to the `clang/test/AST` direc

[PATCH] D121755: [clang-format] Join spaceRequiredBefore and spaceRequiredBetween

sstwcw added a comment. By the way, last time I used a breakpoint on `spaceRequiredBefore` and stepped until return. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121755/new/ https://reviews.llvm.org/D121755 __

[PATCH] D121997: [clang][driver] Fix compilation database dump with multiple architectures

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman, jkorous. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Command lines with multiple `-arch` argume

[PATCH] D121906: [clang-format] Indent import statements in JavaScript.

sstwcw marked an inline comment as done. sstwcw added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:631 + Style.IndentPPDirectives == FormatStyle::PPDIS_AfterHash && Previous.is(tok::hash) && State.FirstIndent > 0 && (State.Line->Type =

[PATCH] D121907: [clang-format] Use an enum for context types. NFC

owenpan accepted this revision. owenpan added a comment. LGTM. Any comments, @curdeius? Comment at: clang/lib/Format/TokenAnnotator.cpp:116 // template parameter, not an argument. -Contexts.back().InTemplateArgument = -Left->Previous && Left->Previous->isNot(to

[clang] 33a9eac - [Clang] Support multiple attributes in a single pragma

Author: Egor Zhdan Date: 2022-03-18T12:20:41Z New Revision: 33a9eac6aaa495fce6fd9b17cd48aa57a95461e6 URL: https://github.com/llvm/llvm-project/commit/33a9eac6aaa495fce6fd9b17cd48aa57a95461e6 DIFF: https://github.com/llvm/llvm-project/commit/33a9eac6aaa495fce6fd9b17cd48aa57a95461e6.diff LOG: [C

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG33a9eac6aaa4: [Clang] Support multiple attributes in a single pragma (authored by egorzhdan). Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

aaron.ballman added a comment. In D117522#3390136 , @LegalizeAdulthood wrote: > I think I've got all the changes incorporated, but I'm getting a test failure > so I haven't uploaded a new diff. > > Honestly, I don't understand the test failure output.

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

thakis added a comment. The commit message got a bit mutilated: 33a9eac6aaa495fce6fd9b17cd48aa57a95461e6 Just FYI in case you didn't notice. In that case, update your commit workflow to make sure this doesn't happen next tim

[PATCH] D121907: [clang-format] Use an enum for context types. NFC

curdeius accepted this revision. curdeius added a comment. I really like this change. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121907/new/ https://reviews.llvm.org/D121907 ___ cfe-commits ma

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

egorzhdan added a comment. In D121283#3392137 , @thakis wrote: > The commit message got a bit mutilated: > 33a9eac6aaa495fce6fd9b17cd48aa57a95461e6 > > > Just FYI in case you didn't n

[PATCH] D121556: [randstruct] Add randomize structure layout support

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Randstruct.h:34 + +extern std::string SEED; + void wrote: > aaron.ballman wrote: > > Doing this with a global variable is unfortunate; it could make things > > harder when we multithread th

[clang] 52cc65d - [OpenMPRuntime] Specify correct pointer type

Author: Nikita Popov Date: 2022-03-18T14:25:51+01:00 New Revision: 52cc65d4740992a29ae8375498c3b470f003de26 URL: https://github.com/llvm/llvm-project/commit/52cc65d4740992a29ae8375498c3b470f003de26 DIFF: https://github.com/llvm/llvm-project/commit/52cc65d4740992a29ae8375498c3b470f003de26.diff

[PATCH] D121961: [clang] Produce a "multiversion" annotation in textual AST output.

erichkeane added a comment. In D121961#3391988 , @aaron.ballman wrote: > Is there a need for this functionality? The text node dumper already dumps > attributes associated with the function: https://godbolt.org/z/EbW8E74TT > > If the change is necessary

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

ymandel updated this revision to Diff 416479. ymandel marked an inline comment as done. ymandel added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121797/new/ https://reviews.llvm.org/D121797 Files: clang/include/cla

[PATCH] D121678: [pseudo] Split greatergreater token.

probinson added a comment. We had the same thing happen downstream. One of our guys speculates that because some allocations are "owned" by the returned TokenStream, but the returned TokenStream is a temporary, the lifetimes might not be sufficient and some deallocations can happen. If I chang

[PATCH] D121960: [clang] NFC: Rename 'MVType' variables to 'MVKind' for consistency with their type.

erichkeane added a comment. I'm ok with this, but please fix the clang-format before committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121960/new/ https://reviews.llvm.org/D121960 ___ cfe-commits

[PATCH] D121958: [clang] NFC: Remove forced type merging in multiversion function checks.

erichkeane added a comment. Hmm... my understanding is "MergeTypeWithPrevious" is important for cases where we decide that this is a redeclaration, right? We need to set it to 'false' when we "know" that this is a different declaration, right? So at least the '=false' was correct? Repositor

[PATCH] D121829: [clang][AArc64][SVE] Implement vector-scalar operators

DavidTruby updated this revision to Diff 416487. DavidTruby added a comment. Fix non-valid operation diagnostics Add correct float tests Add negative tests for invalid types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121829/new/ https://reviews.

[PATCH] D121954: [clang] Add test cases for multiversion function overload scenarios in C.

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. These all look like fine tests to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121954/new/ https://reviews.llvm.org/D121954 __

[PATCH] D121959: [clang] Add missing diagnostics for invalid overloads of multiversion functions in C.

erichkeane added a comment. In D121959#3390658 , @tahonermann wrote: > Intel issue CMPLRLLVM-28177. These words have no power here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121959/new/ https://revie

[clang] b6baab6 - [clang-format] Refactor BreakableBlockComment constructor. NFC.

Author: Marek Kurdej Date: 2022-03-18T15:01:40+01:00 New Revision: b6baab673a7c17747c245fa7b33d9b29ad9a107d URL: https://github.com/llvm/llvm-project/commit/b6baab673a7c17747c245fa7b33d9b29ad9a107d DIFF: https://github.com/llvm/llvm-project/commit/b6baab673a7c17747c245fa7b33d9b29ad9a107d.diff

[clang] acc7a7f - [clang-format] Use range-for loop. NFC.

Author: Marek Kurdej Date: 2022-03-18T15:01:41+01:00 New Revision: acc7a7f9a17f683b1bbf0a4913ebadb926e1f71b URL: https://github.com/llvm/llvm-project/commit/acc7a7f9a17f683b1bbf0a4913ebadb926e1f71b DIFF: https://github.com/llvm/llvm-project/commit/acc7a7f9a17f683b1bbf0a4913ebadb926e1f71b.diff

[clang] c79e18d - [clang-format] Expect instead of setting the same value in tests. NFC.

Author: Marek Kurdej Date: 2022-03-18T15:01:41+01:00 New Revision: c79e18da4f65c43bb8d94e95961e87e66d67b65a URL: https://github.com/llvm/llvm-project/commit/c79e18da4f65c43bb8d94e95961e87e66d67b65a DIFF: https://github.com/llvm/llvm-project/commit/c79e18da4f65c43bb8d94e95961e87e66d67b65a.diff

[clang] 4b3a27e - Add validation for number of arguments of __builtin_memcpy_inline

Author: Roy Jacobson Date: 2022-03-18T14:03:25Z New Revision: 4b3a27e2e026f9be703c1bdcb396c10559a87347 URL: https://github.com/llvm/llvm-project/commit/4b3a27e2e026f9be703c1bdcb396c10559a87347 DIFF: https://github.com/llvm/llvm-project/commit/4b3a27e2e026f9be703c1bdcb396c10559a87347.diff LOG:

[PATCH] D121965: Add validation for number of arguments of __builtin_memcpy_inline

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b3a27e2e026: Add validation for number of arguments of __builtin_memcpy_inline (authored by royjacobson, committed by gchatelet). Repository: rG

[PATCH] D121959: [clang] Add missing diagnostics for invalid overloads of multiversion functions in C.

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Generally looks fine to me. Just 1 test that looks suspicious. Comment at: clang/test/Sema/attr-cpuspecific.c:133 -// FIXME: Declaration of a non-overloadable func

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

ymandel updated this revision to Diff 416494. ymandel marked 6 inline comments as done. ymandel added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121797/new/ https://reviews.llvm.org/D121797 Files: clang/include/cla

[clang] f47e7e4 - [clang][SVE] Add support for bitwise operators on SVE types

Author: David Truby Date: 2022-03-18T14:06:47Z New Revision: f47e7e4a3480707f124db9622001d3a05a777d5d URL: https://github.com/llvm/llvm-project/commit/f47e7e4a3480707f124db9622001d3a05a777d5d DIFF: https://github.com/llvm/llvm-project/commit/f47e7e4a3480707f124db9622001d3a05a777d5d.diff LOG: [

[PATCH] D121119: [clang][SVE] Add support for bitwise operators on SVE types

This revision was automatically updated to reflect the committed changes. Closed by commit rGf47e7e4a3480: [clang][SVE] Add support for bitwise operators on SVE types (authored by DavidTruby). Changed prior to commit: https://reviews.llvm.org/D121119?vs=415858&id=416496#toc Repository: rG LL

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

ymandel added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/ChromiumCheckModelTest.cpp:122 + void transfer(const Stmt *S, NoopLattice &, Environment &Env) { +M.transfer(S, Env); + } xazax.hun wrote: > ymandel wrote: > > xazax.hun wrot

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski created this revision. awarzynski added reviewers: kiranchandramohan, clementval. Herald added a subscriber: mgorny. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. awarzynski requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert. Hera

[clang] c59c2b6 - [clang-format] Refactor ShouldBreakBeforeBrace to use switch. NFC.

Author: Marek Kurdej Date: 2022-03-18T15:16:01+01:00 New Revision: c59c2b6bd19eb7625f7c234eb68d347d8de17079 URL: https://github.com/llvm/llvm-project/commit/c59c2b6bd19eb7625f7c234eb68d347d8de17079 DIFF: https://github.com/llvm/llvm-project/commit/c59c2b6bd19eb7625f7c234eb68d347d8de17079.diff

[PATCH] D121837: [OpenMP][FIX] Allow device constructors for AMD GPU

kamaub added a comment. The test cases added with this commit failed on clang-ppc64be-linux-lnt # 13809 could you please revert this change, and recommit with the test case corrected? thank you. Repository: rG LLVM Github Monorepo

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

Izaron added inline comments. Comment at: clang/include/clang/Sema/Scope.h:518 void addNRVOCandidate(VarDecl *VD) { +// every candidate except VD is "spoiled" now, remove them from the set ChuanqiXu wrote: > Firstly I am wondering why here doesn't check

[clang] a36c2dd - [clang][dataflow] Add modeling of Chromium's CHECK functionality

Author: Yitzhak Mandelbaum Date: 2022-03-18T14:39:23Z New Revision: a36c2dd6d54c6ff854cb4872cd2831ed995e9275 URL: https://github.com/llvm/llvm-project/commit/a36c2dd6d54c6ff854cb4872cd2831ed995e9275 DIFF: https://github.com/llvm/llvm-project/commit/a36c2dd6d54c6ff854cb4872cd2831ed995e9275.diff

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa36c2dd6d54c: [clang][dataflow] Add modeling of Chromium's CHECK functionality (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D121532: [Clang][WIP] Fix Unevaluated Lambdas

aaron.ballman added a reviewer: clang-language-wg. aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:978-979 CXXRecordDecl *Class = createLambdaClosureType(Intro.Range, MethodTyInfo, KnownDependen

[PATCH] D119476: Generalize and harmonize sub-expression traversal

aaron.ballman accepted this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. Sorry for the delay in reviewing this, but this looks correct to me. I don't think the precommit CI failures on Debian relate to your patch, either, so this LGTM Repository: rG

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

xbolva00 added a comment. Why this should be maintained and developed by LLVM/Clang developers and not by Chromium? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121797/new/ https://reviews.llvm.org/D121797 ___

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski updated this revision to Diff 416513. awarzynski added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122008/new/ https://reviews.llvm.org/D122008 Files: clang/lib/Driver/ToolChains/Gnu.cpp flang/include/fla

[PATCH] D119477: Ignore FullExpr when traversing cast sub-expressions

aaron.ballman added a comment. The changes here generally look good, and I'm happy to see that more of our test cases are diagnosing similar to other compilers with the changes. Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:362-364 + { A k = to_lvalue_ref(A().ret_a()); }

[PATCH] D121951: [AMDGPU] Only warn when mixing printf and hostcall

scott.linder added a comment. In D121951#3391472 , @sameerds wrote: > The check for "__ockl_hostcall_internal" is not longer relevant with the new > hostcall attribute. Can we simply remove this check? What is the situation > where the warning is still

[PATCH] D121837: [OpenMP][FIX] Allow device constructors for AMD GPU

jdoerfert added a comment. In D121837#3392346 , @kamaub wrote: > The test cases added with this commit failed on clang-ppc64be-linux-lnt # > 13809 could you > please revert this change, and rec

[clang] 1df3a91 - [OpenMP][FIX] Make test check lines less strict

Author: Johannes Doerfert Date: 2022-03-18T10:53:32-05:00 New Revision: 1df3a913efc497b2ce63d856b25ba8903378d377 URL: https://github.com/llvm/llvm-project/commit/1df3a913efc497b2ce63d856b25ba8903378d377 DIFF: https://github.com/llvm/llvm-project/commit/1df3a913efc497b2ce63d856b25ba8903378d377.d

[PATCH] D121906: [clang-format] Indent import statements in JavaScript.

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:633 (State.Line->Type == LT_PreprocessorDirective || State.Line->Type == LT_ImportStatement)) { Spaces += State.FirstIndent; AfterHash - Could be true

[PATCH] D121907: [clang-format] Use an enum for context types. NFC

MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121907/new/ https://reviews.llvm.org/D121907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

ymandel added a comment. In D121797#3392444 , @xbolva00 wrote: > Why this should be maintained and developed by LLVM/Clang developers and not > by Chromium? That's a good question. I think the short answer, that skirts around the issue, is that this is

[PATCH] D119477: Ignore FullExpr when traversing cast sub-expressions

kimgr added inline comments. Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:362-364 + { A k = to_lvalue_ref(A().ret_a()); } // expected-error {{'alloc::A::ret_a' is not a constant expression}} expected-error {{'alloc::to_lvalue_ref' is not a constant expression}} + // exp

[clang] f5fea45 - [RISCV][NFC] Add tests to address invalid arch dependencies.

Author: Zakk Chen Date: 2022-03-18T09:41:04-07:00 New Revision: f5fea45d09e5bae2f141195d05cfcb055914b63f URL: https://github.com/llvm/llvm-project/commit/f5fea45d09e5bae2f141195d05cfcb055914b63f DIFF: https://github.com/llvm/llvm-project/commit/f5fea45d09e5bae2f141195d05cfcb055914b63f.diff LOG

[PATCH] D121578: [RISCV][NFC] Add tests to address invalid arch dependencies.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5fea45d09e5: [RISCV][NFC] Add tests to address invalid arch dependencies. (authored by khchen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121578/new/ h

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

xazax.hun added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/ChromiumCheckModelTest.cpp:122 + void transfer(const Stmt *S, NoopLattice &, Environment &Env) { +M.transfer(S, Env); + } ymandel wrote: > xazax.hun wrote: > > ymandel wrot

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood added a comment. I've worked through this issue before, I just need to spend some time on it. The basic problem is that the test fails and dumps a bunch of output to "help" you understand the failure, but the way it is formatted and mangled doesn't end up being useful. CHANGE

[PATCH] D122021: [CMake][Fuchsia] Include llvm-undname

phosek created this revision. phosek added reviewers: abrachet, haowei. Herald added a subscriber: mgorny. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is useful when developing on Windows. Repo

  1   2   >