iains added a comment. In D121097#3391236 <https://reviews.llvm.org/D121097#3391236>, @ChuanqiXu wrote:
> I feel good if we could add the test from: > http://eel.is/c++draft/cpp.import#8. I agree we should have tests based on all the relevant examples in the standard. However, that specific example is not connected with **building** header units, but instead is connected with consuming various preprocessor directives etc. when building a regular module. We actually already have some of the tests in diagnosing bad imports. So I think that (after this series is in) we should be in a position to add some more of the examples in the standard - as a follow-on patch, does that make sense? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121097/new/ https://reviews.llvm.org/D121097 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
