[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

JiahaoChenConor added a comment. Herald added subscribers: pcwang-thead, eopXD, VincentWu, luke957, achieveartificialintelligence. Herald added a project: All. Hi, do you still continue working on this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103313/new/ https://reviews.llv

[PATCH] D119144: [tests][Driver] Pass an empty sysroot for `DEFAULT_SYSROOT` builds

carlocab added a comment. Herald added a project: All. Per suggestion on Discord, here’s my git author line: Carlo Cabrera Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119144/new/ https://reviews.llvm.org/D119144 ___

[clang] 4f637c3 - [tests][Driver] Pass an empty sysroot for `DEFAULT_SYSROOT` builds

Author: Tim Northover Date: 2022-03-04T09:01:50Z New Revision: 4f637c30e1cd2d1d85f4f3b2ab042bfd75ae2865 URL: https://github.com/llvm/llvm-project/commit/4f637c30e1cd2d1d85f4f3b2ab042bfd75ae2865 DIFF: https://github.com/llvm/llvm-project/commit/4f637c30e1cd2d1d85f4f3b2ab042bfd75ae2865.diff LOG:

[PATCH] D120540: [Driver] Enable to use C++20 modules standalone by -fcxx-modules

iains added a comment. 1. I agree 100% that the driver needs to be able to process in "c++20 modules mode"; there is some handling of sources that should be changed accordingly. 2. I believe that it is a general objective of the tooling folks (roughly SG15 participants) that C++20 modules shoul

[PATCH] D120902: [clang-format] Fix assertion failure/crash with `AllowShortFunctionsOnASingleLine: Inline/InlineOnly`.

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:313 break; + if ((*J)->Level == TheLine->Level) +return false; curdeius wrote: > owenpan wrote: > > To be safe? > Good idea. Will do. > Any

[PATCH] D120540: [Driver] Enable to use C++20 modules standalone by -fcxx-modules

iains added a comment. of course, this meets your objective too - since you could put -fmodules=cxx20 (even without -std=c++20) .. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120540/new/ https://reviews.llvm.org/D120540

[PATCH] D118869: [clang-format] Non-latin comment prefix whitespace

krasimir added a comment. Herald added a project: All. It appears that this caused a regression by adding an additional space of indentation to line comments in some cases: % cat test.cc # (before) // Comment int i; % clang-format -style=google test.cc //  Comment int i; @ksyx coul

[PATCH] D120540: [Driver] Enable to use C++20 modules standalone by -fcxx-modules

ChuanqiXu added a comment. In D120540#3359394 , @iains wrote: > 1. I agree 100% that the driver needs to be able to process in "c++20 modules > mode"; Yeah, not all the projects could be able to run in c++20 mode. We use `-std=c++17` + `-fcoroutines-ts

[PATCH] D120540: [Driver] Enable to use C++20 modules standalone by -fcxx-modules

iains added a comment. In D120540#3359446 , @ChuanqiXu wrote: > In D120540#3359394 , @iains wrote: > >> 1. I agree 100% that the driver needs to be able to process in "c++20 >> modules mode"; > > Yeah, not all th

[PATCH] D120568: [flang][driver] Add support for -S and implement -c/-emit-obj

awarzynski updated this revision to Diff 412963. awarzynski added a comment. Rebase on top of D120897 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120568/new/ https://reviews.llvm.org/D120568 Files: clang/incl

[PATCH] D120984: [clang][dataflow] Extend flow conditions from block terminators

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. sgatev requested review of this revision. Herald added a project: clang. This is part of the implementation of the dataflow ana

[PATCH] D120984: [clang][dataflow] Extend flow conditions from block terminators

sgatev updated this revision to Diff 412969. sgatev added a comment. Minor tweaks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120984/new/ https://reviews.llvm.org/D120984 Files: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h

[PATCH] D120967: [NFC] Divide tests into smaller files

fhahn accepted this revision. fhahn added a comment. Thanks for splitting up the tests! Looks like pre-commit CI is happy again! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120967/new/ https://reviews.llvm.org/D120967 ___

[PATCH] D120875: [Driver] Split up huge aarch64-cpus.c test.

fhahn updated this revision to Diff 412971. fhahn added a comment. Thanks everyone! I added a TODO for splitting up by category and plan to land this soon. The update also adds a missing GENERIC check line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D120875: [Driver] Split up huge aarch64-cpus.c test.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f5bdaf481c3: [Driver] Split up huge aarch64-cpus.c test. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[clang] 8f5bdaf - [Driver] Split up huge aarch64-cpus.c test.

Author: Florian Hahn Date: 2022-03-04T11:24:12Z New Revision: 8f5bdaf481c3f4e6876a5ae0e4d7c6ed2042e6a6 URL: https://github.com/llvm/llvm-project/commit/8f5bdaf481c3f4e6876a5ae0e4d7c6ed2042e6a6 DIFF: https://github.com/llvm/llvm-project/commit/8f5bdaf481c3f4e6876a5ae0e4d7c6ed2042e6a6.diff LOG:

[PATCH] D120876: [Driver] Split up huge arm-cortex-cpus.c test.

fhahn updated this revision to Diff 412974. fhahn added a comment. Thanks! I added a TODO to split it up by categories and I'll plan to land the change soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120876/new/ https://reviews.llvm.org/D1208

[clang] fb42e55 - [Driver] Split up huge arm-cortex-cpus.c test.

Author: Florian Hahn Date: 2022-03-04T11:37:00Z New Revision: fb42e557d8b4c8430a75391bbb5af309b5472685 URL: https://github.com/llvm/llvm-project/commit/fb42e557d8b4c8430a75391bbb5af309b5472685 DIFF: https://github.com/llvm/llvm-project/commit/fb42e557d8b4c8430a75391bbb5af309b5472685.diff LOG:

[PATCH] D120876: [Driver] Split up huge arm-cortex-cpus.c test.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfb42e557d8b4: [Driver] Split up huge arm-cortex-cpus.c test. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

urnathan added a comment. In D118352#3358864 , @ChuanqiXu wrote: > If I don't misread the codes, it looks like `mangleModuleInitializer` is not > called. > Now we could add test for partitions. Correct, it is not called as the global initializer piec

[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

ksyx added a comment. In D103313#3359310 , @JiahaoChenConor wrote: > Hi, do you still continue working on this patch? In fact, not pretty sure what else I need to improve on this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103313/new/ http

[PATCH] D120949: [clang][AST matchers] adding attributedStmt AST matcher

aaron.ballman added a subscriber: sammccall. aaron.ballman added a comment. In D120949#3358707 , @ajohnson-uoregon wrote: > Okay this is actually the right commits now, sorry about the spam, Aaron. 🙃 > Didn't realize I'd put unrelated things in the firs

[PATCH] D120967: [NFC] Divide tests into smaller files

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a148869d336: [NFC] Divide tests into smaller files (authored by 4vtomat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120967/new/ https://reviews.llvm.or

[clang] 6afe035 - Revert "[analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions"

Author: Aaron Ballman Date: 2022-03-04T07:21:52-05:00 New Revision: 6afe0354048f350442708eff0875101fe6f2bf44 URL: https://github.com/llvm/llvm-project/commit/6afe0354048f350442708eff0875101fe6f2bf44 DIFF: https://github.com/llvm/llvm-project/commit/6afe0354048f350442708eff0875101fe6f2bf44.diff

Re: [clang] 9c300c1 - [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

Can you explain this commit please? I had to revert it in 6afe0354048f350442708eff0875101fe6f2bf44 because it broke the Sphinx bot, but this looks like an unintentional commit and I wanted to double-check (I had fixed this exact issue in d74a3a514cf64731ecd21e1453aa78af79a565f2 and your changes her

[PATCH] D120989: Support debug info for alias variable

kavitha-natarajan created this revision. kavitha-natarajan added reviewers: kamleshbhalui, umesh.kalappa0, probinson, dblaikie. kavitha-natarajan added a project: debug-info. Herald added a subscriber: jeroen.dobbelaere. Herald added a project: All. kavitha-natarajan requested review of this revis

[PATCH] D120952: [clang][AST matchers] adding submatchers under cudaKernelCallExpr to match kernel launch config

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. Typically, we only add AST matchers when there's an obvious need for them (we do this because compiling this file takes a *long* time and generates quite a few symbols in the executable). I'm not certain that these CUD

[PATCH] D120959: [clang][AST matchers] new hasExpectedReturnType submatcher for ReturnStmts

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. As mentioned in another review, it's not clear that this rises to the level of need to add it to the general AST matching interfaces. Can you explain the intended in-tree use cases for this? Repository: rG LLVM Git

[PATCH] D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation.

Trass3r added a comment. Herald added a project: All. @sammccall pls merge Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120258/new/ https://reviews.llvm.org/D120258 ___ cfe-commits mailing list cfe-comm

[PATCH] D120956: [clang][AST matchers] new AST matcher argumentsGivenCountIs(n) that checks the actual number of arguments given in a function call

aaron.ballman added a comment. This seems somewhat more generally applicable as an AST matcher, but I'm still curious what the in-tree use will be for it. (Same suggestion for test coverage and regenerating the documentation as before.) Comment at: clang/include/clang/ASTMatc

[PATCH] D118869: [clang-format] Non-latin comment prefix whitespace

ksyx added a comment. In D118869#3359439 , @krasimir wrote: > It appears that this caused a regression by adding an additional space of > indentation to line comments in some cases: > > % cat test.cc # (before) > // Comment > int i; > % clang-fo

[PATCH] D120947: [tooling] Explain how to create a compilation database on Windows [NFC]

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a formatting nit, thank you -- this is really helpful information! I confirmed the instructions work for me on Windows. Comment at: clang/docs/

[PATCH] D120911: [CUDA][HIP] Fix offloading kind for linking C++ programs

yaxunl updated this revision to Diff 412989. yaxunl added a comment. add more tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120911/new/ https://reviews.llvm.org/D120911 Files: clang/include/clang/Driver/Action.h clang/lib/Driver/Driver.cpp clang/test/Driver/hip-phases.hip

[PATCH] D120992: [analyzer] ReverseNull: New checker to warn for pointer value conditions, if the pointer value is unconditionally non-null

Szelethus created this revision. Szelethus added reviewers: NoQ, steakhal, xazax.hun, balazske, martong. Szelethus added a project: clang. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, mgorny. Herald

[PATCH] D120888: [clang] Stop dragging a EndLoc around when parsing attributes

aaron.ballman added a comment. Thank you for working on this! We've (very) slowly been working towards all of the attribute parsing functions taking a `ParsedAttributesWithRange` so that we don't lose this information in the AST, and this is a good step in the right direction towards that. =

[PATCH] D118869: [clang-format] Non-latin comment prefix whitespace

krasimir added a comment. Thank you! Turns out the original source wasn't using an ascii space for the comment indentation but a unicode [c2 a0] no-break space: 2f 2f c2 a0 43 6f 6d 6d 65 6e 74 0a 69 6e 74 20 |//..Comment.int | IMO we shouldn't aim to handle non-ascii spaces for indentation

[PATCH] D120992: [analyzer] ReverseNull: New checker to warn for pointer value conditions, if the pointer value is unconditionally non-null

steakhal added a comment. In addition to the excellent summary, I'd like to highlight that this is intended to catch only the cases where the use of the constrained pointer is in the very same stack frame where it was constrained. This leads to a really nice property: local reasoning, which gre

[PATCH] D120888: [clang] Stop dragging a EndLoc around when parsing attributes

tbaeder marked an inline comment as done. tbaeder added a comment. In D120888#3359798 , @aaron.ballman wrote: > Thank you for working on this! We've (very) slowly been working towards all > of the attribute parsing functions taking a `ParsedAttributesWi

[PATCH] D120888: [clang] Stop dragging a EndLoc around when parsing attributes

tbaeder updated this revision to Diff 412994. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120888/new/ https://reviews.llvm.org/D120888 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/DeclSpec.h clang/lib/Parse/ParseDecl

[PATCH] D120992: [analyzer] ReverseNull: New checker to warn for pointer value conditions, if the pointer value is unconditionally non-null

steakhal added a comment. Looks great. I'm loving it! BTW what is the semantics of `[p retain]` in ObjC? Can `p` be null in that context? Or does it count as a dereferences, hence it constraints the pointer? Why did you touch the `AnalysisOrderChecker`, should we separate those changes? Additio

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 412996. jhuber6 added a comment. Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120272/new/ https://reviews.llvm.org/D120272 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang

[PATCH] D120323: [clang][SVE] Add support for arithmetic operators on SVE types

bsmith added a comment. Herald added a project: All. This all looks reasonable to me, but I'll let @peterwaller-arm have the final say. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120323/new/ https://reviews.llvm.org/D120323 ___

[PATCH] D119184: [clang] [concepts] Check constrained-auto return types for void-returning functions

Quuxplusone updated this revision to Diff 413006. Quuxplusone added a comment. Herald added a project: All. Rebased, poke CI one last time. If this is green, imma land it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119184/new/ https://reviews.ll

[clang-tools-extra] e86324f - [clang-tidy][NFC] Document bugprone-narrowing-conversions check alias

Author: Balazs Benics Date: 2022-03-04T16:47:11+01:00 New Revision: e86324f80031fb5596f9f7437cb8c0b24fcf3143 URL: https://github.com/llvm/llvm-project/commit/e86324f80031fb5596f9f7437cb8c0b24fcf3143 DIFF: https://github.com/llvm/llvm-project/commit/e86324f80031fb5596f9f7437cb8c0b24fcf3143.diff

[PATCH] D120449: [RISCV][RVV] Add strict vfcvt intrinsics that have side effects for dynamically-set rounding mode

khchen added a comment. Makes sense to me, but I'd appreciate someone else for a final LGTM. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:4683 +Ops.push_back(VL); +Ops.push_back(DAG.getUNDEF(XLenVT)); // Policy + } arcbbb wrote: > kito-cheng

[clang] 7ee97c2 - [clang][dataflow] Add a lattice to track source locations.

Author: Yitzhak Mandelbaum Date: 2022-03-04T17:13:24Z New Revision: 7ee97c24efab4b2617da7f188760b0ad2dcc2125 URL: https://github.com/llvm/llvm-project/commit/7ee97c24efab4b2617da7f188760b0ad2dcc2125 DIFF: https://github.com/llvm/llvm-project/commit/7ee97c24efab4b2617da7f188760b0ad2dcc2125.diff

[PATCH] D120890: [clang][dataflow] Add a lattice to track source locations.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7ee97c24efab: [clang][dataflow] Add a lattice to track source locations. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D120967: [NFC] Divide tests into smaller files

jrtc27 added a comment. With one exception, every RISC-V Clang CodeGen test (and with 9 exceptions, every RISC-V LLVM CodeGen test) is kebab-case not snake_case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120967/new/ https://reviews.llvm.org/D12

[clang] c88deef - [clang][dataflow] Add `MatchSwitch` utility library.

Author: Yitzhak Mandelbaum Date: 2022-03-04T17:19:51Z New Revision: c88deef0a7218dd5c30500e7d3f58fc23283d3e5 URL: https://github.com/llvm/llvm-project/commit/c88deef0a7218dd5c30500e7d3f58fc23283d3e5 DIFF: https://github.com/llvm/llvm-project/commit/c88deef0a7218dd5c30500e7d3f58fc23283d3e5.diff

[PATCH] D120900: [clang][dataflow] Add `MatchSwitch` utility library.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc88deef0a721: [clang][dataflow] Add `MatchSwitch` utility library. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D112181: [docs] Remove hard-coded version numbers from sphinx configs

MyDeveloperDay added a comment. Herald added a project: All. Can we drop the git from everywhere? F22325692: image.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112181/new/ https://reviews.llvm.org/D112181

[PATCH] D114231: [clang][docs][dataflow] Added an introduction to dataflow analysis

MyDeveloperDay added a comment. Herald added a project: All. Did you add somewhere what dependency we need in order to build the documentation now as mine is having problems with "recommonmark" /usr/bin/sphinx-build -n ./docs ./html Running Sphinx v3.4.3 Configuration error: There is

[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

craig.topper added a comment. In D103313#3359628 , @ksyx wrote: > In D103313#3359310 , > @JiahaoChenConor wrote: > >> Hi, do you still continue working on this patch? > > In fact, not pretty sure what else I need

[clang] adf6703 - [clang] [NFC] Add `const` to a parameter that's not modified.

Author: Arthur O'Dwyer Date: 2022-03-04T12:43:05-05:00 New Revision: adf6703f75b09564ca887b0eea0c3b37e65237d7 URL: https://github.com/llvm/llvm-project/commit/adf6703f75b09564ca887b0eea0c3b37e65237d7 DIFF: https://github.com/llvm/llvm-project/commit/adf6703f75b09564ca887b0eea0c3b37e65237d7.diff

[clang] f0891cd - [clang] [concepts] Check constrained-auto return types for void-returning functions

Author: Arthur O'Dwyer Date: 2022-03-04T12:43:06-05:00 New Revision: f0891cd61b2f7cd57d906406ae785722bfd87603 URL: https://github.com/llvm/llvm-project/commit/f0891cd61b2f7cd57d906406ae785722bfd87603 DIFF: https://github.com/llvm/llvm-project/commit/f0891cd61b2f7cd57d906406ae785722bfd87603.diff

[PATCH] D119184: [clang] [concepts] Check constrained-auto return types for void-returning functions

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0891cd61b2f: [clang] [concepts] Check constrained-auto return types for void-returning… (authored by arthur.j.odwyer). Changed prior to commit: https://reviews.llvm.org/D119184?vs=413006&id=413046#toc

[PATCH] D120449: [RISCV][RVV] Add strict vfcvt intrinsics that have side effects for dynamically-set rounding mode

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVVLPatterns.td:624 + (mask_type true_mask), + VLOpFrag, (XLenVT undef))), +(!cast(inst#"_"#kind#"_"#vlmul.MX)

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112774/new/ https://reviews.llvm.org/D112774 ___

[PATCH] D120931: [clang-format] fix namepsace format when the name is macro expansion

curdeius added a comment. Please update the summary, the name is no longer empty. Also, if you can add some info in the summary about how it looked before (copying a part of the Chromium bug report seems enough), it would be awesome. Otherwise, some small comments only. Comme

[PATCH] D120992: [analyzer] ReverseNull: New checker to warn for pointer value conditions, if the pointer value is unconditionally non-null

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/NullPtrInterferenceChecker.cpp:166 +/// child is a sink node. +static bool unconditionallyLeadsHere(const ExplodedNode *N) { + size_t NonSinkNodeCount = llvm::count_if( Consider the f

[PATCH] D120931: [clang-format] Fix namespace format when the name is a macro expansion

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/NamespaceEndCommentsFixerTest.cpp:112 + EXPECT_EQ("#define M(x) x##x\n" +"namespace [[deprecated(\"foo\")]] A::inline M(x)::A {\n" +"int i;\n" Is this 2 bugs in one?

[PATCH] D120931: [clang-format] Fix namespace format when the name is a macro expansion

MyDeveloperDay added a comment. > Its assignment only happens in MacroExpander which is never used This is something that @klimek was working on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120931/new/ https://reviews.llvm.org/D120931 _

[PATCH] D120992: [analyzer] ReverseNull: New checker to warn for pointer value conditions, if the pointer value is unconditionally non-null

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/NullPtrInterferenceChecker.cpp:166 +/// child is a sink node. +static bool unconditionallyLeadsHere(const ExplodedNode *N) { + size_t NonSinkNodeCount = llvm::count_if( xazax.hun wrot

[PATCH] D120989: Support debug info for alias variable

dblaikie added a comment. I think it'd potentially go somewhere in `DWARFDebugLine::LineTable::getFileLineInfoForAddress` for instance - which could inspect the candidate row in the line table, and if it's line zero, it could go back one row in the table. This would avoid probing addresses that

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

rnk added inline comments. Herald added a project: All. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5372 + // This controls whether or not we perform JustMyCode instrumentation. + if (TC.getTriple().isOSBinFormatELF() && Args.hasArg(options::OPT_fjmc)) { +if (DebugInf

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

tra added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4107 + options::OPT_no_offload_arch_EQ)) { +C.getDriver().Diag(diag::err_opt_not_valid_with_opt) << "--offload-arch" + << "--offl

[PATCH] D120888: [clang] Stop dragging a EndLoc around when parsing attributes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from two formatting nits, thank you for the cleanup! Comment at: clang/lib/Parse/ParsePragma.cpp:1373 - PragmaAttributeInfo(ParsedAttributes &Attr

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

JonChesterfield added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4132-4134 + Archs.insert(CudaArchToString(CudaArch::SM_35)); +else if (Kind == Action::OFK_HIP) + Archs.insert(CudaArchToString(CudaArch::GFX803)); tra wrote: > If we do

[PATCH] D120984: [clang][dataflow] Extend flow conditions from block terminators

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:99 + const Environment &Env2, Value &MergedVal, + Environment &Env) { return false; `MergedEnv`? Also,

[PATCH] D121014: [WebAssembly] Check bulk-memory when adjusting lang opts

tlively created this revision. tlively added a reviewer: sbc100. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, dschuff. Herald added a project: All. tlively requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. We

[PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

ldionne added a comment. Herald added a project: All. Shall we land this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119918/new/ https://reviews.llvm.org/D119918 ___ cfe-commits mailing list cfe-commi

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

tra added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4132-4134 + Archs.insert(CudaArchToString(CudaArch::SM_35)); +else if (Kind == Action::OFK_HIP) + Archs.insert(CudaArchToString(CudaArch::GFX803)); JonChesterfield wrote: > tra wrote

[PATCH] D120934: [OpenMP][NFC] Refactor new driver to be more general

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120934/new/ https://reviews.llvm.org/D120934 ___

[PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

Amir accepted this revision. Amir added a comment. LGTM from BOLT side Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119918/new/ https://reviews.llvm.org/D119918 ___ cfe-commits mailing list cfe-commits@

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

aaron.ballman added a comment. Herald added a project: All. Thanks for working on this! It's worth noting that http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2935.pdf was what was adopted by WG14 a few weeks ago, so you should be checking against that one, not the initial version of the paper

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 413087. jhuber6 added a comment. Herald added a subscriber: dexonsmith. Addressing nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120272/new/ https://reviews.llvm.org/D120272 Files: clang/include/clang/

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4132-4134 + Archs.insert(CudaArchToString(CudaArch::SM_35)); +else if (Kind == Action::OFK_HIP) + Archs.insert(CudaArchToString(CudaArch::GFX803)); tra wrote: > JonChesterfield w

[PATCH] D119778: [clang] Add a note "deducing return type for 'foo'"

Quuxplusone updated this revision to Diff 413089. Quuxplusone added a comment. Herald added a project: All. Rebased after landing D119184 . I'm no longer necessarily trying to land this note (it's not directly relevant to my interests anymore), but I'd like to s

[PATCH] D120947: [tooling] Explain how to create a compilation database on Windows [NFC]

LegalizeAdulthood updated this revision to Diff 413093. LegalizeAdulthood marked an inline comment as done. LegalizeAdulthood added a comment. Update from review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120947/new/ https://reviews.llvm.org/D120947 Files: clang/docs/HowT

[clang] d5d0313 - [tooling] Explain how to create a compilation database on Windows [NFC]

Author: Richard Date: 2022-03-04T13:06:08-07:00 New Revision: d5d03135a7160586e2b09dc47c7021379252fbbd URL: https://github.com/llvm/llvm-project/commit/d5d03135a7160586e2b09dc47c7021379252fbbd DIFF: https://github.com/llvm/llvm-project/commit/d5d03135a7160586e2b09dc47c7021379252fbbd.diff LOG:

[PATCH] D120947: [tooling] Explain how to create a compilation database on Windows [NFC]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd5d03135a716: [tooling] Explain how to create a compilation database on Windows [NFC] (authored by LegalizeAdulthood). Repository: rG LLVM Github

[PATCH] D121019: [clang-tools-extra] Document clang tidy unit tests target

LegalizeAdulthood created this revision. LegalizeAdulthood added reviewers: aaron.ballman, njames93, ymandel. LegalizeAdulthood added a project: clang-tools-extra. Herald added a project: All. LegalizeAdulthood requested review of this revision. Repository: rG LLVM Github Monorepo https://revie

[clang] e22e277 - [RGT] DistroTest: Separate environment-specific test functions

Author: Paul Robinson Date: 2022-03-04T12:28:38-08:00 New Revision: e22e2774d93379d6bad41ae20194b076fdb44915 URL: https://github.com/llvm/llvm-project/commit/e22e2774d93379d6bad41ae20194b076fdb44915 DIFF: https://github.com/llvm/llvm-project/commit/e22e2774d93379d6bad41ae20194b076fdb44915.diff

[clang] bde13a8 - [HIP] Fix job action offloading kind for mixed HIP/C++ compilation

Author: Yaxun (Sam) Liu Date: 2022-03-04T15:34:02-05:00 New Revision: bde13a8102baef4d79723064e6bd27cd39124d91 URL: https://github.com/llvm/llvm-project/commit/bde13a8102baef4d79723064e6bd27cd39124d91 DIFF: https://github.com/llvm/llvm-project/commit/bde13a8102baef4d79723064e6bd27cd39124d91.dif

[PATCH] D120910: [HIP] Fix job action offloading kind for mixed HIP/C++ compilation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbde13a8102ba: [HIP] Fix job action offloading kind for mixed HIP/C++ compilation (authored by yaxunl). Herald added a project: clang. Repository:

[PATCH] D120931: [clang-format] Fix namespace format when the name is a macro expansion

zequanwu updated this revision to Diff 413109. zequanwu marked 4 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120931/new/ https://reviews.llvm.org/D120931 Files: clang/lib/For

[PATCH] D120931: [clang-format] Fix namespace format when the name is a macro expansion

zequanwu added inline comments. Comment at: clang/unittests/Format/NamespaceEndCommentsFixerTest.cpp:112 + EXPECT_EQ("#define M(x) x##x\n" +"namespace [[deprecated(\"foo\")]] A::inline M(x)::A {\n" +"int i;\n" MyDeveloperDay wrote: > Is t

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

ychen added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5372 + // This controls whether or not we perform JustMyCode instrumentation. + if (TC.getTriple().isOSBinFormatELF() && Args.hasArg(options::OPT_fjmc)) { +if (DebugInfoKind >= codegenoptions::De

[PATCH] D120931: [clang-format] Fix namespace format when the name is a macro expansion

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/NamespaceEndCommentsFixerTest.cpp:112 + EXPECT_EQ("#define M(x) x##x\n" +"namespace [[deprecated(\"foo\")]] A::inline M(x)::A {\n" +"int i;\n" zequanwu wrote: > MyDe

[PATCH] D119040: Fix LookupTest where it was missing an assertion

probinson added a reviewer: hokein. probinson added a subscriber: hokein. probinson added a comment. Herald added a project: All. + @hokein who has done work in the one place where `replaceNestedName` is used. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119040/new/ https://reviews.ll

[PATCH] D120911: [CUDA][HIP] Fix offloading kind for linking C++ programs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe5eb365069cc: [CUDA][HIP] Fix offloading kind for linking C++ programs (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Gi

[clang] e5eb365 - [CUDA][HIP] Fix offloading kind for linking C++ programs

Author: Yaxun (Sam) Liu Date: 2022-03-04T15:56:54-05:00 New Revision: e5eb365069cce7bb642421d53a1d3964f8d5bdb7 URL: https://github.com/llvm/llvm-project/commit/e5eb365069cce7bb642421d53a1d3964f8d5bdb7 DIFF: https://github.com/llvm/llvm-project/commit/e5eb365069cce7bb642421d53a1d3964f8d5bdb7.dif

[PATCH] D120931: [clang-format] Fix namespace format when the name is a macro expansion

zequanwu added inline comments. Comment at: clang/unittests/Format/NamespaceEndCommentsFixerTest.cpp:112 + EXPECT_EQ("#define M(x) x##x\n" +"namespace [[deprecated(\"foo\")]] A::inline M(x)::A {\n" +"int i;\n" MyDeveloperDay wrote: > zequ

[clang] 22b6e81 - Fix test failure in openmp-offload.c

Author: Yaxun (Sam) Liu Date: 2022-03-04T16:32:30-05:00 New Revision: 22b6e8173cb258fae5a7d332b6f9eb19e9ddf86f URL: https://github.com/llvm/llvm-project/commit/22b6e8173cb258fae5a7d332b6f9eb19e9ddf86f DIFF: https://github.com/llvm/llvm-project/commit/22b6e8173cb258fae5a7d332b6f9eb19e9ddf86f.dif

[PATCH] D120931: [clang-format] Fix namespace format when the name is a macro expansion

owenpan added inline comments. Comment at: clang/lib/Format/NamespaceEndCommentsFixer.cpp:45-54 + int NestLevel = 1; + while (Tok && NestLevel > 0) { +Tok = Tok->getNextNonComment(); +if (Tok) { + if (Tok->is(tok::l_square)) +++NestL

[PATCH] D120931: [clang-format] Fix namespace format when the name is a macro expansion

owenpan added inline comments. Comment at: clang/lib/Format/NamespaceEndCommentsFixer.cpp:59-60 + +// Use the string after `namespace` until `{` or `::` or `(` as a name +// candidate. If the name is empty, use the candicate. +std::string FirstNSName;

[PATCH] D120931: [clang-format] Fix namespace format when the name is a macro expansion

zequanwu updated this revision to Diff 413139. zequanwu marked 2 inline comments as done. zequanwu added a comment. update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120931/new/ https://reviews.llvm.org/D120931 Files: clang/lib/Format/Namesp

[PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

phosek updated this revision to Diff 413141. phosek added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119918/new/ https://reviews.llvm.org/D119918 Files: bolt/test/Unit/lit.site.cfg.py.in bolt/test/lit.site.cfg.py.in clang-tools-extra/clangd/test/lit.site.cfg.

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

ychen updated this revision to Diff 413146. ychen added a comment. Herald added a subscriber: dang. - Address Reid's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119910/new/ https://reviews.llvm.org/D119910 Files: clang/include/clang/B

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

ychen marked 2 inline comments as done. ychen added a comment. @rnk, thanks for taking a look. Patch updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119910/new/ https://reviews.llvm.org/D119910 __

  1   2   >