craig.topper added inline comments.

================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVVLPatterns.td:624
+                              (mask_type true_mask),
+                              VLOpFrag, (XLenVT undef))),
+            (!cast<Instruction>(inst#"_"#kind#"_"#vlmul.MX)
----------------
I don't like using Undef for a field that should be a constant. Can we use 0?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120449/new/

https://reviews.llvm.org/D120449

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D120449: [RISCV][RVV]... Craig Topper via Phabricator via cfe-commits

Reply via email to