[PATCH] D118196: [syntax][pseudo] Implement LR parsing table.

hokein updated this revision to Diff 410725. hokein marked 3 inline comments as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118196/new/ https://reviews.llvm.org/D118196 Files: clang/include/clang/

[PATCH] D120391: [Driver] Add -fno-sanitize-address-globals-dead-stripping

MaskRay created this revision. MaskRay added reviewers: kstoimenov, vitalybuka. Herald added a subscriber: dang. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It's customary for these options to have the -fno- form which is someti

[PATCH] D120359: [clang-format][NFC] Remove redundant semi

curdeius added a comment. I don't really understand this change. You say in the description that you remove the semicolon, but you actually add it. Also, it's a common pattern not to add a semicolon and make all macro calls look like a normal statement (with a semi at the call place). I'm not op

[clang] a2fab82 - [pseudo] Implement LRTable.

Author: Haojian Wu Date: 2022-02-23T09:21:34+01:00 New Revision: a2fab82f33bb8cc38cd1dfe7856dae706ce4297a URL: https://github.com/llvm/llvm-project/commit/a2fab82f33bb8cc38cd1dfe7856dae706ce4297a DIFF: https://github.com/llvm/llvm-project/commit/a2fab82f33bb8cc38cd1dfe7856dae706ce4297a.diff LO

[PATCH] D118196: [syntax][pseudo] Implement LR parsing table.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa2fab82f33bb: [pseudo] Implement LRTable. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[clang] 7ea103d - [clang][dataflow] Add support for global storage values

Author: Stanislav Gatev Date: 2022-02-23T08:27:58Z New Revision: 7ea103de140b59a64fc884fa90afd2213619384d URL: https://github.com/llvm/llvm-project/commit/7ea103de140b59a64fc884fa90afd2213619384d DIFF: https://github.com/llvm/llvm-project/commit/7ea103de140b59a64fc884fa90afd2213619384d.diff LO

[PATCH] D120149: [clang][dataflow] Add support for global storage values

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ea103de140b: [clang][dataflow] Add support for global storage values (authored by sgatev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120149/new/ https:

[clang] f85a6a8 - [NFC] Add unittest for Decl::isInExportDeclContext

Author: Chuanqi Xu Date: 2022-02-23T16:29:42+08:00 New Revision: f85a6a812718cfdaeb1d0dc971ce3875aa82fafe URL: https://github.com/llvm/llvm-project/commit/f85a6a812718cfdaeb1d0dc971ce3875aa82fafe DIFF: https://github.com/llvm/llvm-project/commit/f85a6a812718cfdaeb1d0dc971ce3875aa82fafe.diff LO

[clang] c34d898 - [ASTMatchers] Expand isInline matcher to VarDecl

Author: Nathan James Date: 2022-02-23T08:34:00Z New Revision: c34d89818341b3c7c96bc8f59e3f98063d4ae9fd URL: https://github.com/llvm/llvm-project/commit/c34d89818341b3c7c96bc8f59e3f98063d4ae9fd DIFF: https://github.com/llvm/llvm-project/commit/c34d89818341b3c7c96bc8f59e3f98063d4ae9fd.diff LOG:

[PATCH] D118900: [ASTMatchers] Expand isInline matcher to VarDecl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc34d89818341: [ASTMatchers] Expand isInline matcher to VarDecl (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[clang-tools-extra] 79353f9 - [clang-tidy][NFC] Remove Tristate from CachedGlobList

Author: Nathan James Date: 2022-02-23T08:35:31Z New Revision: 79353f940cf441e69f32af0a78a48baee89e8517 URL: https://github.com/llvm/llvm-project/commit/79353f940cf441e69f32af0a78a48baee89e8517 DIFF: https://github.com/llvm/llvm-project/commit/79353f940cf441e69f32af0a78a48baee89e8517.diff LOG:

[PATCH] D120196: [clang-tidy][NFC] Remove Tristate from CachedGlobList

This revision was automatically updated to reflect the committed changes. Closed by commit rG79353f940cf4: [clang-tidy][NFC] Remove Tristate from CachedGlobList (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120196/new/ https:

[PATCH] D120359: [clang-format][NFC] Remove redundant semi

owenpan requested changes to this revision. owenpan added a comment. This revision now requires changes to proceed. Oops! For some reason, I thought the patch was //removing// the semi. See also D117301 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D120331: [clang-tidy][run-clang-tidy.py] Add --config-file= option

SAtacker updated this revision to Diff 410736. SAtacker marked an inline comment as done. SAtacker added a comment. Squash commits D120385 , D120387 into D120331 Repository: rG LLVM Github

[PATCH] D120333: [NFC][Lexer] Make access to LangOpts more consistent

serge-sans-paille added a comment. I don't object to the change but it may me wonder if there would be a way to remove the apparent redundancy in the API here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120333/new/ https://reviews.llvm.org/D120

[PATCH] D119077: clangd SemanticHighlighting: added support for highlighting overloaded operators

nridge added a comment. In D119077#3337107 , @nridge wrote: > 1. The AST nodes that reference operator names should store source ranges > associated with the operator names, such that we shouldn't need to do > token-by-token manipulation. For example,

[PATCH] D120310: [clang][analyzer] Add modeling of 'errno' (work-in-progress).

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:767-768 s->getType()->isBlockPointerType()); -assert(isa(sreg) || isa(sreg)); +assert(isa(sreg) || isa(sreg) || + isa(sreg)); } -

[PATCH] D120394: [asan] Allow -fsanitize-address-globals-dead-stripping with -fno-data-sections for ELF

MaskRay created this revision. MaskRay added reviewers: Sanitizers, eugenis, kstoimenov, vitalybuka. Herald added a subscriber: ormris. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. -fdata-sections decides whether global variables

[PATCH] D120395: [X86] Prohibit arithmatic operations on type `__bfloat16`

pengfei created this revision. pengfei added reviewers: skan, RKSimon, craig.topper, FreddyYe, LuoYuanke. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `__bfloat16` is defined as X86 specific type that represents the brain floatin

[PATCH] D120334: [NFC][Lexer] Use more appropriate LangOptionsBase type for Lexer::LangOpts

serge-sans-paille added a comment. A small local test hints that using a ``SmallVector`` instead of a ``std::vector`` also fixes the assembly bloat. I don't know if it's worth considering as an alternative or as an extra step. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113319: [clang-format] Improve require and concept handling

curdeius added a comment. @HazardyKnusperkeks, forget my previous comment, I think I found what changed. Before, the `*` was annotated twice, first as a BinaryOperator, then, on a second run, it was correctly annotated as a UnaryOperator. In this revision you whitelisted BinaryOperator in `resetT

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119061/new/ https://reviews.llvm.org/D119061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D120397: [C++20] [Modules] Make the linkage consistent for template and its specialization

ChuanqiXu created this revision. ChuanqiXu added reviewers: urnathan, iains, rsmith, aaron.ballman, erichkeane. ChuanqiXu added a project: clang. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. Before the patch, the compiler would crash for the test due to inco

[PATCH] D113319: [clang-format] Improve require and concept handling

curdeius added a comment. Yep, confirmed, but I don't know how to fix it. Just removing `TT_BinaryOperator` from `resetTokenMetadata` provokes these failures: [ FAILED ] FormatTest.Concepts [ FAILED ] FormatTest.RequiresClauses [ FAILED ] TokenAnnotatorTest.UnderstandsRequiresClauses

[PATCH] D119077: clangd SemanticHighlighting: added support for highlighting overloaded operators

iannisdezwart added a comment. Thank you for the comment, it's very helpful. I didn't know exactly how to get all operator token locations and `getCXXOperatorNameRange()`. This is going to be extremely helpful and will clean up the code to make it more readable. Thank you for the detailed list

[clang] fa0a80e - Revert "Revert "[analyzer] Add failing test case demonstrating buggy taint propagation""

Author: Balazs Benics Date: 2022-02-23T10:48:06+01:00 New Revision: fa0a80e017ebd58a71bdb4e4493bb022f80fe791 URL: https://github.com/llvm/llvm-project/commit/fa0a80e017ebd58a71bdb4e4493bb022f80fe791 DIFF: https://github.com/llvm/llvm-project/commit/fa0a80e017ebd58a71bdb4e4493bb022f80fe791.diff

[PATCH] D120236: [analyzer] Add more sources to Taint analysis

gamesh411 updated this revision to Diff 410747. gamesh411 marked 9 inline comments as done. gamesh411 added a comment. - s/getcw/getwd - add gets_s - remove getopt variants - add realinkat - discuss getnameinfo? - rename tests - update getnameinfo - comment on source/propagator discrepancy - updat

[PATCH] D120236: [analyzer] Add more sources to Taint analysis

gamesh411 added inline comments. Comment at: clang/docs/analyzer/checkers.rst:2358 Default sources defined by ``GenericTaintChecker``: -``fdopen``, ``fopen``, ``freopen``, ``getch``, ``getchar``, ``getchar_unlocked``, ``gets``, ``scanf``, ``socket``, ``wgetch`` + ``_IO_getc``,

[clang] 9d91e03 - [clang] CIndex.cpp - use cast<> instead of dyn_cast<> to avoid dereference of nullptr

Author: Simon Pilgrim Date: 2022-02-23T10:09:44Z New Revision: 9d91e03b7d075239483e9a5793e1e5db9152bdf1 URL: https://github.com/llvm/llvm-project/commit/9d91e03b7d075239483e9a5793e1e5db9152bdf1 DIFF: https://github.com/llvm/llvm-project/commit/9d91e03b7d075239483e9a5793e1e5db9152bdf1.diff LOG:

[PATCH] D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum

dmgreen added a comment. I have a high level question regarding RDF, as I've not seen it used in many other places, so it may be under-tested on Arm systems at the moment. This currently, for all code, builds an rdf graph, analyze the rdf graph for a fairly rare instructions, then fixes up the

[PATCH] D120398: [format] follow up: Use unsigned char as the base of all enums in FormatStyle

kwk created this revision. kwk requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Analogous to https://reviews.llvm.org/D93758, this patch uses `unsigned char` for all enums in `FormatStyle`. Repository: rG LLVM Github Monorepo https://re

[clang] 5a74e6a - [Modules] Add module structure output to -module-file-info.

Author: Iain Sandoe Date: 2022-02-23T10:26:42Z New Revision: 5a74e6a21c9520e0619c98a66815fc8b5117e321 URL: https://github.com/llvm/llvm-project/commit/5a74e6a21c9520e0619c98a66815fc8b5117e321 DIFF: https://github.com/llvm/llvm-project/commit/5a74e6a21c9520e0619c98a66815fc8b5117e321.diff LOG: [

[PATCH] D119823: [Modules] Add module structure output to -module-file-info.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5a74e6a21c95: [Modules] Add module structure output to -module-file-info. (authored by iains). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D120334: [NFC][Lexer] Use more appropriate LangOptionsBase type for Lexer::LangOpts

serge-sans-paille added a comment. https://llvm-compile-time-tracker.com/compare.php?from=79c9072dc009693477242bc1347a2a6c3e419423&to=702bdad5179ebb90c8d8a16c800ffd1b3c44744d&stat=instructions << indeed a lot of green there! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D120333: [NFC][Lexer] Make access to LangOpts more consistent

yurai007 added a comment. Thank you all for review! In D120333#3339730 , @serge-sans-paille wrote: > I don't object to the change but it may me wonder if there would be a way to > remove the apparent redundancy in the API here? If you don't mind let m

[clang] 169e1ab - Revert "[clang][dataflow] Add support for global storage values"

Author: Stanislav Gatev Date: 2022-02-23T10:32:17Z New Revision: 169e1aba55bed9f7ffa000f9f170ab2defbc40b2 URL: https://github.com/llvm/llvm-project/commit/169e1aba55bed9f7ffa000f9f170ab2defbc40b2 DIFF: https://github.com/llvm/llvm-project/commit/169e1aba55bed9f7ffa000f9f170ab2defbc40b2.diff LO

[PATCH] D117090: [clang-tidy] Fix `readability-non-const-parameter` for parameter referenced by an lvalue

Sockke updated this revision to Diff 410753. Sockke added a comment. Add a release note and improve test description information. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117090/new/ https://reviews.llvm.org/D117090 Files: clang-tools-extra/clang-tidy/readability/NonConstParamet

[clang] e0f1dd0 - [C++20][Modules] Rework testcase to use split file [NFC].

Author: iains Date: 2022-02-23T11:07:36Z New Revision: e0f1dd018e0f94a7d694bc615975c3a7d26d9e50 URL: https://github.com/llvm/llvm-project/commit/e0f1dd018e0f94a7d694bc615975c3a7d26d9e50 DIFF: https://github.com/llvm/llvm-project/commit/e0f1dd018e0f94a7d694bc615975c3a7d26d9e50.diff LOG: [C++20]

[PATCH] D120352: [C++20][Modules] Rework testcase to use split file [NFC].

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe0f1dd018e0f: [C++20][Modules] Rework testcase to use split file [NFC]. (authored by iains). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang] fbe38a7 - [NFC][Lexer] Make access to LangOpts more consistent

Author: Dawid Jurczak Date: 2022-02-23T12:46:13+01:00 New Revision: fbe38a784e2852b22f5a44ad417e071ff583d57d URL: https://github.com/llvm/llvm-project/commit/fbe38a784e2852b22f5a44ad417e071ff583d57d DIFF: https://github.com/llvm/llvm-project/commit/fbe38a784e2852b22f5a44ad417e071ff583d57d.diff

[PATCH] D120333: [NFC][Lexer] Make access to LangOpts more consistent

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfbe38a784e28: [NFC][Lexer] Make access to LangOpts more consistent (authored by yurai007). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D120310: [clang][analyzer] Add modeling of 'errno' (work-in-progress).

steakhal added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:767-768 s->getType()->isBlockPointerType()); -assert(isa(sreg) || isa(sreg)); +assert(isa(sreg) || isa(sreg) || + isa(sreg)); }

[PATCH] D120401: [clang-format][NFC] Rename test and remove comments

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Why put "I

[clang] a848a5c - Revert "Revert "[analyzer] Fix taint propagation by remembering to the location context""

Author: Balazs Benics Date: 2022-02-23T12:53:07+01:00 New Revision: a848a5cf2f2f2f8a621bdc5a12e0fe49dc743176 URL: https://github.com/llvm/llvm-project/commit/a848a5cf2f2f2f8a621bdc5a12e0fe49dc743176 DIFF: https://github.com/llvm/llvm-project/commit/a848a5cf2f2f2f8a621bdc5a12e0fe49dc743176.diff

[clang] 7036413 - Revert "Revert "[analyzer] Fix taint rule of fgets and setproctitle_init""

Author: Balazs Benics Date: 2022-02-23T12:55:31+01:00 New Revision: 7036413dc21254c8bf2f4ac62a3b087bc4b94ce8 URL: https://github.com/llvm/llvm-project/commit/7036413dc21254c8bf2f4ac62a3b087bc4b94ce8 DIFF: https://github.com/llvm/llvm-project/commit/7036413dc21254c8bf2f4ac62a3b087bc4b94ce8.diff

[PATCH] D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC)

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. I'm satisfied. I cannot see any issues. AFAI remember the tests runs uncovered no report changes - as expected from an NFC change. So it's good to go on my part. Wait for a review from @NoQ

[PATCH] D118987: [analyzer] Add failing test case demonstrating buggy taint propagation

steakhal added a comment. In D118987#3332940 , @jrtc27 wrote: > In D118987#3319697 , @steakhal > wrote: > >> It seems like the `clang-ve-ninja` doesn't really want to accept any patches >> from me :D >> I hope i

[PATCH] D118987: [analyzer] Add failing test case demonstrating buggy taint propagation

steakhal closed this revision. steakhal added a comment. Committed as fa0a80e017ebd58a71bdb4e4493bb022f80fe791 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118987/new/ https:/

[PATCH] D119128: [analyzer] Fix taint propagation by remembering to the location context

steakhal added a comment. Committed as a848a5cf2f2f2f8a621bdc5a12e0fe49dc743176 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119128/new/ https://reviews.llvm.org/D119128

[PATCH] D119129: [analyzer] Fix taint rule of fgets and setproctitle_init

steakhal added a comment. Committed as 7036413dc21254c8bf2f4ac62a3b087bc4b94ce8 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119129/new/ https://reviews.llvm.org/D119129

[PATCH] D119063: [SemaCXX] Properly scope ArgumentPackSubstitutionIndex when expanding base types

RKSimon added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:2536 - TypeSourceInfo *BaseTypeLoc = SubstType(Base.getTypeSourceInfo(), - TemplateArgs, -

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

svenvh marked an inline comment as done. svenvh added inline comments. Comment at: clang/lib/Headers/opencl-c-base.h:85 +// Internal feature macro to provide subgroup builtins. +#define __opencl_subgroup_builtins 1 +#endif azabaznov wrote: > svenvh wrote: > > I'm

[PATCH] D119162: [Pseudo] Token/TokenStream, PP directive parser.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/include/clang/Tooling/Syntax/Pseudo/Token.h:81 +}; +static_assert(sizeof(Token) <= sizeof(char *) + 16, "Careful with layout!"); +llvm::raw_ostream

[clang] aa9c2d1 - [OpenCL] Align subgroup builtin guards

Author: Sven van Haastregt Date: 2022-02-23T12:22:09Z New Revision: aa9c2d19d9b73589d72114d6e0a4fb4ce42b922b URL: https://github.com/llvm/llvm-project/commit/aa9c2d19d9b73589d72114d6e0a4fb4ce42b922b DIFF: https://github.com/llvm/llvm-project/commit/aa9c2d19d9b73589d72114d6e0a4fb4ce42b922b.diff

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. svenvh marked an inline comment as done. Closed by commit rGaa9c2d19d9b7: [OpenCL] Align subgroup builtin guards (authored by svenvh). Repository: rG LLVM Github Mon

[PATCH] D120395: [X86] Prohibit arithmatic operations on type `__bfloat16`

RKSimon added a comment. but its still OK to perform arithmetic with __m128bh ? https://simd.godbolt.org/z/Ef59Ws4M3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120395/new/ https://reviews.llvm.org/D120395 __

[PATCH] D120404: [NFC][Lexer] Remove getLangOpts function from Lexer

yurai007 created this revision. yurai007 added reviewers: serge-sans-paille, cor3ntin, jansvoboda11, ymandel, nikic, xbolva00. yurai007 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Give that there is only one external user of Lexer::get

[PATCH] D120236: [analyzer] Add more sources to Taint analysis

steakhal added a comment. Fewer nits this time. We are converging! Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:559 + {{"gethostname"}, TR::Source({{0}})}, + {{"getnameinfo"}, TR::Source({{2, 4}})}, + {{"getseuserbyname"}, TR::Source({{1,

[PATCH] D120333: [NFC][Lexer] Make access to LangOpts more consistent

yurai007 added a comment. Mentioned follow-up: https://reviews.llvm.org/D120404 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120333/new/ https://reviews.llvm.org/D120333 ___ cfe-commits mailing list cfe

[PATCH] D120375: Trim unnecessary component/library dependencies.

kadircet added a comment. Mostly a review of the clangd changes, I am not familiar with all the other parts (and not necessarily everyone will be) hence some explicit testing results would be great. Also please upload the patch with full context. Comment at: clang-tools-extra

[PATCH] D113775: [clang][modules] Umbrella with missing submodule: unify implicit & explicit

jansvoboda11 abandoned this revision. jansvoboda11 added a comment. Abandoning, since we have a better solution: disable implicit module maps in explicit modules builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113775/new/ https://reviews.llv

[PATCH] D112916: Confusable identifiers detection

serge-sans-paille updated this revision to Diff 410776. serge-sans-paille added a comment. Rebased on `main` branch and (should) fix @aaron.ballman portability issue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112916/new/ https://reviews.llvm.org/D112916 Files: clang-tools-extra/c

Re: [PATCH] D120333: [NFC][Lexer] Make access to LangOpts more consistent

Sure! ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D120404: [NFC][Lexer] Remove getLangOpts function from Lexer

yurai007 added inline comments. Comment at: clang/lib/Lex/ModuleMap.cpp:1617 const char *Start = SpellingBuffer.data(); -unsigned Length = -Lexer::getSpelling(LToken, Start, SourceMgr, L.getLangOpts()); +unsigned Length = L.getSpelling(LToken, Start, SourceMg

[PATCH] D120404: [NFC][Lexer] Remove getLangOpts function from Lexer

serge-sans-paille accepted this revision. serge-sans-paille added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Lex/Lexer.h:313 + /// getSpelling - This is non-staic variant of getSpelling method which + /// doesn't require

[PATCH] D119926: [Clang][AArch64] Enable _Float16 _Complex type

peterwaller-arm added inline comments. Comment at: clang/test/CodeGen/aarch64-complex-half-math.c:3 +// RUN: %clang_cc1 %s -emit-llvm -triple aarch64-unknown-unknown -o - | FileCheck %s --check-prefix=AARCH64 +// REQUIRES: aarch64-registered-target + aaron.ballm

[PATCH] D120395: [X86] Prohibit arithmatic operations on type `__bfloat16`

pengfei added a comment. In D120395#3340041 , @RKSimon wrote: > but its still OK to perform arithmetic with __m128bh ? > https://simd.godbolt.org/z/Ef59Ws4M3 Good point! I'd think the define of `__m128bh` is wrong direction. We should use `__m128i` lik

[clang] 2f300d3 - [clang][driver][wasm] Fix libstdc++ target-dependent include dir

Author: Timm Bäder Date: 2022-02-23T14:38:34+01:00 New Revision: 2f300d34decba547dd07f5cd6034a6b2b2ca11a2 URL: https://github.com/llvm/llvm-project/commit/2f300d34decba547dd07f5cd6034a6b2b2ca11a2 DIFF: https://github.com/llvm/llvm-project/commit/2f300d34decba547dd07f5cd6034a6b2b2ca11a2.diff LO

[PATCH] D120251: [clang][driver][wasm] Fix libstdc++ target-dependent include dir

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f300d34decb: [clang][driver][wasm] Fix libstdc++ target-dependent include dir (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D113880: [clang][modules] Infer framework modules in explicit builds

jansvoboda11 updated this revision to Diff 410785. jansvoboda11 edited the summary of this revision. jansvoboda11 added a comment. Remove changes related to dependency scanning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113880/new/ https://revie

[clang] 27d9a58 - [clang][modules] Infer framework modules in explicit builds

Author: Jan Svoboda Date: 2022-02-23T14:46:23+01:00 New Revision: 27d9a58407c44c8bb3fe7b94ff8d3b9bea25afc4 URL: https://github.com/llvm/llvm-project/commit/27d9a58407c44c8bb3fe7b94ff8d3b9bea25afc4 DIFF: https://github.com/llvm/llvm-project/commit/27d9a58407c44c8bb3fe7b94ff8d3b9bea25afc4.diff L

[PATCH] D113880: [clang][modules] Infer framework modules in explicit builds

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG27d9a58407c4: [clang][modules] Infer framework modules in explicit builds (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D120374: [clang-format] Do not insert space after new/delete keywords in C function declarations

penagos updated this revision to Diff 410788. penagos added a comment. Add missing space in unittest. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120374/new/ https://reviews.llvm.org/D120374 Files: clang/lib/Format/TokenAnnotator.cpp clang/u

[PATCH] D120374: [clang-format] Do not insert space after new/delete keywords in C function declarations

penagos marked an inline comment as done. penagos added a comment. In D120374#3339554 , @curdeius wrote: > In D120374#3339337 , @penagos wrote: > >> Though it's still unclear to me whether or not it'd make more se

RE: [clang] 4bafe65 - Add support for floating-point option `ffp-eval-method` and for

https://reviews.llvm.org/D109239 -Original Message- From: Roman Lebedev Sent: Tuesday, February 15, 2022 5:26 PM To: Ammarguellat, Zahira ; Zahira Ammarguellat Cc: cfe-commits@lists.llvm.org Subject: Re: [clang] 4bafe65 - Add support for floating-point option `ffp-eval-method` and for

[clang] 03dff12 - Revert "Revert "[clang][dataflow] Add support for global storage values""

Author: Stanislav Gatev Date: 2022-02-23T13:57:34Z New Revision: 03dff12197d15161ffc9ec7afeb9501551d6119e URL: https://github.com/llvm/llvm-project/commit/03dff12197d15161ffc9ec7afeb9501551d6119e DIFF: https://github.com/llvm/llvm-project/commit/03dff12197d15161ffc9ec7afeb9501551d6119e.diff LO

[PATCH] D119165: [clang-tidy] Add processing lambda captures at bugprone-use-after-move check

mboehme added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp:403 hasArgument(0, declRefExpr().bind("arg")), - anyOf(hasAncestor(lambdaExpr().bind("containing-lambda")), - hasAncestor(funct

[PATCH] D120334: [NFC][Lexer] Use more appropriate LangOptionsBase type for Lexer::LangOpts

yurai007 added a comment. In D120334#3339764 , @serge-sans-paille wrote: > A small local test hints that using a ``SmallVector`` instead of a > ``std::vector`` also fixes the assembly bloat. I don't know if it's worth > considering as an alternative or

[PATCH] D120408: clang-format.el: Make clang-format work in indirect buffers.

phst created this revision. phst added a reviewer: sammccall. phst requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In an indirect buffer, buffer-file-name is nil, so check the base buffer instead. This works fine in direct buffers where bu

[clang] 841355c - Remove unused function; NFC

Author: Aaron Ballman Date: 2022-02-23T09:08:27-05:00 New Revision: 841355c1e4e35fc02b5b171419979f5f9af0ebc8 URL: https://github.com/llvm/llvm-project/commit/841355c1e4e35fc02b5b171419979f5f9af0ebc8 DIFF: https://github.com/llvm/llvm-project/commit/841355c1e4e35fc02b5b171419979f5f9af0ebc8.diff

[PATCH] D120395: [X86] Prohibit arithmatic operations on type `__bfloat16`

pengfei added a comment. In D120395#3340153 , @pengfei wrote: > In D120395#3340041 , @RKSimon wrote: > >> but its still OK to perform arithmetic with __m128bh ? >> https://simd.godbolt.org/z/Ef59Ws4M3 > > Good po

[PATCH] D119926: [Clang][AArch64] Enable _Float16 _Complex type

aaron.ballman added inline comments. Comment at: clang/test/CodeGen/aarch64-complex-half-math.c:3 +// RUN: %clang_cc1 %s -emit-llvm -triple aarch64-unknown-unknown -o - | FileCheck %s --check-prefix=AARCH64 +// REQUIRES: aarch64-registered-target + peterwaller-a

[PATCH] D120397: [C++20] [Modules] Make the linkage consistent for template and its specialization

erichkeane added a comment. Linkage stuff is where I get lost quickly, hopefully @urnathan can comment here. Codewise I think this looks right. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120397/new/ https://reviews.llvm.org/D120397 __

[clang] b1a8dcf - Silence some "not all control paths return a value" warnings; NFC

Author: Aaron Ballman Date: 2022-02-23T09:18:56-05:00 New Revision: b1a8dcf8c186ddfeeb062ab8475fe30365557955 URL: https://github.com/llvm/llvm-project/commit/b1a8dcf8c186ddfeeb062ab8475fe30365557955 DIFF: https://github.com/llvm/llvm-project/commit/b1a8dcf8c186ddfeeb062ab8475fe30365557955.diff

[PATCH] D120334: [NFC][Lexer] Make Lexer::LangOpts const reference

yurai007 updated this revision to Diff 410801. yurai007 retitled this revision from "[NFC][Lexer] Use more appropriate LangOptionsBase type for Lexer::LangOpts" to "[NFC][Lexer] Make Lexer::LangOpts const reference". yurai007 edited the summary of this revision. Repository: rG LLVM Github Mono

[PATCH] D120262: [OpenCL] Handle TypeExtensions in OpenCLBuiltinFileEmitter

arkangath added inline comments. Comment at: clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp:296-298 + // Emit an #if guard for all type extensions required for the given type + // strings. Shouldn't what the return value means be documented here? ==

[PATCH] D120334: [NFC][Lexer] Make Lexer::LangOpts const reference

yurai007 added a comment. Use simpler approach with const LangOptions reference + rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120334/new/ https://reviews.llvm.org/D120334 ___ cfe-commits mailin

[PATCH] D120404: [NFC][Lexer] Remove getLangOpts function from Lexer

yurai007 updated this revision to Diff 410802. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120404/new/ https://reviews.llvm.org/D120404 Files: clang/include/clang/Lex/Lexer.h clang/lib/Lex/Lexer.cpp clang/lib/Lex/ModuleMap.cpp Index: clang/

[PATCH] D119290: [Clang] Add support for -fcx-limited-range, -fcx-fortran-rules options.

aaron.ballman added reviewers: jansvoboda11, aaron.ballman, erichkeane. aaron.ballman added a comment. Adding some reviewers, but the changes here look reasonable to me. You should fix the clang-format issues, though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam updated this revision to Diff 410803. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 Files: clang/docs/LanguageExtensions.rst clang/docs/UsersManual.rst clang/include/clang/Basic/DiagnosticLexKinds.td clang/include/clang/Basic/

[PATCH] D119290: [Clang] Add support for -fcx-limited-range, -fcx-fortran-rules options.

erichkeane added a subscriber: mdtoguchi. erichkeane added a comment. Same, other than the clang-format, I see nothing to be concerned about. @mdtoguchi is my driver expert however. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119290/new/ https:

[PATCH] D120408: clang-format.el: Make clang-format work in indirect buffers.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Makes sense, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120408/new/ https://reviews.llvm.org/D120408 _

[PATCH] D119271: CGCall: also emit LLVM `allocalign` attribute when handling AllocAlign

jyknight added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:4605 + TryEmitAsCallSiteAttribute(const llvm::AttributeList &Attrs) { +llvm::AttributeList NewAttrs = Attrs; +if (AA) durin42 wrote: > jyknight wrote: > > We do need to fallback to

[PATCH] D119291: [Clang] Add support for STDC CX_LIMITED_RANGE pragma.

aaron.ballman added reviewers: aaron.ballman, rjmccall, tahonermann, erichkeane. aaron.ballman added a comment. Adding some more reviewers for visibility. Please address the clang-format issues; also, this seems to be missing all of the test I would expect to see in Preprocessor or Parser for ch

[PATCH] D117611: [Sema] Warn about printf %n on Android and Fuchsia

aaron.ballman added a comment. In D117611#3339137 , @glandium wrote: > This doesn't leave much room to use `__attribute__((format(printf)))` on > custom printf implementations that do support `%n` on Android does it? +1 to this point; whether this is or

[PATCH] D119063: [SemaCXX] Properly scope ArgumentPackSubstitutionIndex when expanding base types

colavitam added a comment. Yes, in my opinion the original shadow was accidental—you can see that every usage of BaseTypeLoc is immediately preceded by an initialization, though sometimes in a more nested scope. When initialized in the parameter pack loop, we skip to the next iteration of the o

[clang] 80a6968 - [clang][deps] NFC: Update documentation

Author: Jan Svoboda Date: 2022-02-23T15:46:20+01:00 New Revision: 80a696898cd57f00297e06714bd5118ce7308f3e URL: https://github.com/llvm/llvm-project/commit/80a696898cd57f00297e06714bd5118ce7308f3e DIFF: https://github.com/llvm/llvm-project/commit/80a696898cd57f00297e06714bd5118ce7308f3e.diff L

[clang] 19017c2 - [clang][deps] Return the whole TU command line

Author: Jan Svoboda Date: 2022-02-23T15:46:20+01:00 New Revision: 19017c2435d76fe453a2500eeafd045ba92ece67 URL: https://github.com/llvm/llvm-project/commit/19017c2435d76fe453a2500eeafd045ba92ece67 DIFF: https://github.com/llvm/llvm-project/commit/19017c2435d76fe453a2500eeafd045ba92ece67.diff L

[PATCH] D118986: [clang][deps] Return the whole TU command line

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG19017c2435d7: [clang][deps] Return the whole TU command line (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D118986

[PATCH] D120408: clang-format.el: Make clang-format work in indirect buffers.

phst added a comment. Thanks for the review! I think you have to commit this (I don't have commit access). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120408/new/ https://reviews.llvm.org/D120408 ___

  1   2   3   >