aaron.ballman added inline comments.
================ Comment at: clang/test/CodeGen/aarch64-complex-half-math.c:3 +// RUN: %clang_cc1 %s -emit-llvm -triple aarch64-unknown-unknown -o - | FileCheck %s --check-prefix=AARCH64 +// REQUIRES: aarch64-registered-target + ---------------- peterwaller-arm wrote: > aaron.ballman wrote: > > There's nothing AArch64-specific about the change, so I'd expect some more > > general codegen tests. > > > > Actually, I took a look to see what calls > > `getFloatingTypeOfSizeWithinDomain()` and I can't find any callers of that. > > Do you have a test case where you were hitting that particular unreachable? > Thanks for your observation @aaron.ballman. > > It appears this has been working since D105331, which enabled it for X86. > > Unless I'm missing something, the function in question appears to have been > unused since 2010 (the last use was removed in > d005ac937e4c08e0c607ddc42708f8bf2064c243 by @rjmccall), I presume > `getFloatingTypeOfSizeWithinDomain` should be removed then. > I presume getFloatingTypeOfSizeWithinDomain should be removed then. Agreed; I've gone ahead and removed it in 841355c1e4e35fc02b5b171419979f5f9af0ebc8. I think this patch can be abandoned, unless you think the extra test coverage is worth adding as an NFC commit? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119926/new/ https://reviews.llvm.org/D119926 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
