[PATCH] D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation.

sammccall added a comment. I don't know a good way to automatically reduce examples, I usually do it by hand. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120258/new/ https://reviews.llvm.org/D120258 _

[PATCH] D120270: [OpenMP] Try to embed offloading objects after codegen

jdoerfert added a comment. Can we have a test for this? Comment at: clang/include/clang/CodeGen/BackendUtil.h:48 - void EmbedObject(llvm::Module *M, const CodeGenOptions &CGOpts, DiagnosticsEngine &Diags); Seems unrelated, please remove i

[PATCH] D120271: [Clang] Add offload kind to embedded offload object

jdoerfert added a comment. The failing test needs to be adjusted, right? Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:187 +return LHS.OffloadKind == RHS.OffloadKind && + LHS.TheTriple == RHS.TheTriple && LHS.Arch == RHS.Arch; + } --

[PATCH] D120271: [Clang] Add offload kind to embedded offload object

jhuber6 added a comment. In D120271#3336277 , @jdoerfert wrote: > The failing test needs to be adjusted, right? Yes, forgot about that. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:187 +return LHS.OffloadKin

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jdoerfert added a comment. Tests? Comment at: clang/lib/Driver/Driver.cpp:3956 LA = C.MakeAction(LinkerInputs, types::TY_Image); - LA->propagateHostOffloadInfo(OffloadKinds, + LA->propagateHostOffloadInfo(C.getActiveOffloadKinds(),

[PATCH] D120270: [OpenMP] Try to embed offloading objects after codegen

jhuber6 added a comment. In D120270#3336272 , @jdoerfert wrote: > Can we have a test for this? Sure. Comment at: clang/include/clang/CodeGen/BackendUtil.h:48 - void EmbedObject(llvm::Module *M, const CodeGenOptions &CGOpts,

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6041 + llvm::Value *EVal = CGF.EmitScalarExpr(E->IgnoreImpCasts()); + llvm::Value *DVal = D ? CGF.EmitScalarExpr(D->IgnoreImpCasts()) : nullptr; + tianshilei1992 wrote: > tianshilei19

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_compare_codegen.cpp:1990 +// CHECK-NEXT:[[DD:%.*]] = alloca double, align 8 +// CHECK-NEXT:[[TMP0:%.*]] = load i8, i8* [[CE]], align 1 +// CHECK-NEX

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

sstwcw marked 3 inline comments as done. sstwcw added a comment. About the unit tests that failed in B150668 . It looks like they were stopped because they took over 1 minute. I ran the first test on my laptop. Both this revision and main took about 2 minute

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

sstwcw updated this revision to Diff 410400. sstwcw marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ https://reviews.llvm.org/D119599 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/tools/dump_

[PATCH] D116153: [ARM][AArch64] Add missing v8.x checks

tyb0807 updated this revision to Diff 410403. tyb0807 added a comment. Add checks for default ACLE macros for different architecture versions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116153/new/ https://reviews.llvm.org/D116153 Files: clang

[PATCH] D118589: [C++20][Modules][6/8] Record direct module imports.

iains updated this revision to Diff 410404. iains added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118589/new/ https://reviews.llvm.org/D118589 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaModule.cpp Index:

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

ABataev added inline comments. Comment at: clang/test/OpenMP/atomic_compare_codegen.cpp:1990 +// CHECK-NEXT:[[DD:%.*]] = alloca double, align 8 +// CHECK-NEXT:[[TMP0:%.*]] = load i8, i8* [[CE]], align 1 +// CHECK-NEXT:[[TMP1:%.*]] = atomicrmw umin i8* [[CX]], i8 [[TMP

[PATCH] D120270: [OpenMP] Try to embed offloading objects after codegen

jhuber6 updated this revision to Diff 410405. jhuber6 added a comment. Removing unrelated changes and adding test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120270/new/ https://reviews.llvm.org/D120270 Files: clang/lib/CodeGen/CodeGenModule.

[PATCH] D120270: [OpenMP] Try to embed offloading objects after codegen

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, wait for the other patches though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120270/new/ https://reviews.llvm.org/D120270 ___

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_compare_codegen.cpp:1990 +// CHECK-NEXT:[[DD:%.*]] = alloca double, align 8 +// CHECK-NEXT:[[TMP0:%.*]] = load i8, i8* [[CE]], align 1 +// CHECK-NEX

[PATCH] D120288: [OpenMP] Implement dense map info for device file

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch implements a DenseMap info struct fo

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6041 + llvm::Value *EVal = CGF.EmitScalarExpr(E->IgnoreImpCasts()); + llvm::Value *DVal = D ? CGF.EmitScalarExpr(D->IgnoreImpCasts()) : nullptr;

[PATCH] D120289: [clang][dataflow] Add SAT solver interface and implementation

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: tschuett, steakhal, mstorsjo, rnkovacs, mgorny. sgatev requested review of this revision. Herald added a project: clang. This is part of the implementation of the dataflow analysis frame

[PATCH] D120271: [Clang] Add offload kind to embedded offload object

jhuber6 updated this revision to Diff 410413. jhuber6 added a comment. Updating after moving dense map implementation out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120271/new/ https://reviews.llvm.org/D120271 Files: clang/lib/Driver/ToolCha

[PATCH] D120273: [OpenMP] Allow CUDA to be linked with OpenMP using the new driver

jhuber6 updated this revision to Diff 410414. jhuber6 added a comment. Changing after rebasing previous commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120273/new/ https://reviews.llvm.org/D120273 Files: clang/tools/clang-linker-wrapper/C

[PATCH] D120290: [WIP][Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev. Herald added subscribers: guansong, yaxunl. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds the codegen suppor

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6041 + llvm::Value *EVal = CGF.EmitScalarExpr(E->IgnoreImpCasts()); + llvm::Value *DVal = D ? CGF.EmitScalarExpr(D->IgnoreImpCasts()) : nullptr; + tianshilei1992 wrote: > ABataev wrot

[PATCH] D118875: [compiler-rt][builtins] build the macOS compiler-rt built-ins with Mac Catalyst support

ravikandhadai accepted this revision. ravikandhadai added a comment. This revision is now accepted and ready to land. LGTM. Thanks Alex. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118875/new/ https://reviews.llvm.org/D118875 ___ cfe-commit

[PATCH] D118757: [AArch64] Remove unused feature flags from AArch64TargetInfo

tyb0807 updated this revision to Diff 410418. tyb0807 added a comment. Revert latest change, as it is likely that people still rely on `ARM_FEATURE_CRYPTO` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118757/new/ https://reviews.llvm.org/D118757

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 marked 3 inline comments as done. tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_compare_codegen.cpp:1990 +// CHECK-NEXT:[[DD:%.*]] = alloca double, align 8 +// CHECK-NEXT:[[TMP0:%.*]] = load i8, i8* [[CE]], align 1 +// CHECK-NEX

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

ABataev added inline comments. Comment at: clang/test/OpenMP/atomic_compare_codegen.cpp:1990 +// CHECK-NEXT:[[DD:%.*]] = alloca double, align 8 +// CHECK-NEXT:[[TMP0:%.*]] = load i8, i8* [[CE]], align 1 +// CHECK-NEXT:[[TMP1:%.*]] = atomicrmw umin i8* [[CX]], i8 [[TMP

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

ChuanqiXu added a comment. (May off the patch) BTW, I know you also work on GCC frontend. I want to consultant what's your opinion to uniform the command line options between Clang and GCC. Now it looks totally different. I feel it would be a problem for clang. Since the command line between c

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_compare_codegen.cpp:1990 +// CHECK-NEXT:[[DD:%.*]] = alloca double, align 8 +// CHECK-NEXT:[[TMP0:%.*]] = load i8, i8* [[CE]], align 1 +// CHECK-NEX

[PATCH] D120289: [clang][dataflow] Add SAT solver interface and implementation

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/Solver.h:39 + /// All elements in `Vals` must be non-null. + virtual Result solve(llvm::DenseSet Vals) = 0; +}

[PATCH] D117924: [compiler_rt] Add a seperate runtime for Mac Catalyst

bc-lee abandoned this revision. bc-lee added a comment. Closed in favor of https://reviews.llvm.org/D118862 and https://reviews.llvm.org/D118875 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117924/new/ https://reviews.llvm.org/D117924 __

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

yonghong-song created this revision. yonghong-song added a reviewer: aaron.ballman. yonghong-song requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Current ASTContext.getAttributedType() takes attribute kind, ModifiedType and EquivType as the

[PATCH] D120297: [Driver][RISCV] Add missing rv64 test case

eopXD created this revision. eopXD added a reviewer: rogfer01. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jone

[PATCH] D119541: [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-ISA features back after implication

eopXD marked an inline comment as done. eopXD added inline comments. Comment at: clang/test/Driver/riscv-default-features.c:4 +// RV32: "target-features"="+a,+c,+m,+relax,-save-restore" +// RV64: "target-features"="+64bit,+a,+c,+m,+relax,-save-restore" + rogfer01

[PATCH] D120298: [HIP] Support `--default-stream`

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: dexonsmith, dang. yaxunl requested review of this revision. Introduce `--default-stream={legacy|per-thread}` option to support per-thread default stream for HIP runtime. When `--default-stream=per-thread`, HIP k

[clang] 95fed2b - [Driver][OpenBSD] Pass sysroot to the linker

Author: Brad Smith Date: 2022-02-21T23:11:13-05:00 New Revision: 95fed2b267ee87e6cba72ebe73f0d6fdab37f995 URL: https://github.com/llvm/llvm-project/commit/95fed2b267ee87e6cba72ebe73f0d6fdab37f995 DIFF: https://github.com/llvm/llvm-project/commit/95fed2b267ee87e6cba72ebe73f0d6fdab37f995.diff LO

[clang] 77e60bc - [clang-format] Add option to insert braces after control statements

Author: owenca Date: 2022-02-21T20:16:25-08:00 New Revision: 77e60bc42c48e16d646488d43210b1630cd4db49 URL: https://github.com/llvm/llvm-project/commit/77e60bc42c48e16d646488d43210b1630cd4db49 DIFF: https://github.com/llvm/llvm-project/commit/77e60bc42c48e16d646488d43210b1630cd4db49.diff LOG: [

[PATCH] D120217: [clang-format] Add an option to insert braces after control statements

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG77e60bc42c48: [clang-format] Add option to insert braces after control statements (authored by owenpan). Repository: rG LLVM Github Monorepo CHAN

[clang] 289b725 - [Driver][OpenBSD] Test tweaking and clean up

Author: Brad Smith Date: 2022-02-21T23:44:53-05:00 New Revision: 289b725051cfb4a7167936db89583aa6b8a12d18 URL: https://github.com/llvm/llvm-project/commit/289b725051cfb4a7167936db89583aa6b8a12d18 DIFF: https://github.com/llvm/llvm-project/commit/289b725051cfb4a7167936db89583aa6b8a12d18.diff LO

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

achieveartificialintelligence updated this revision to Diff 410444. achieveartificialintelligence added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112774/new/ https://reviews.llvm.org/D112774 Files: clang/include/clang/Basic

[clang] 8d9eeb0 - [Driver][OpenBSD] Add comments for C++ tests

Author: Brad Smith Date: 2022-02-22T00:20:46-05:00 New Revision: 8d9eeb03b3e9c800843659f243242f262d7bd786 URL: https://github.com/llvm/llvm-project/commit/8d9eeb03b3e9c800843659f243242f262d7bd786 DIFF: https://github.com/llvm/llvm-project/commit/8d9eeb03b3e9c800843659f243242f262d7bd786.diff LO

[PATCH] D120290: [WIP][Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 updated this revision to Diff 410448. tianshilei1992 added a comment. add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120290/new/ https://reviews.llvm.org/D120290 Files: clang/include/clang/AST/StmtOpenMP.h clang/lib/AST

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

iains added a comment. In D118586#3336612 , @ChuanqiXu wrote: > (May off the patch) I am not sure what you mean here. > BTW, I know you also work on GCC frontend. I want to consultant what's your > opinion to uniform the command line options between Cl

[PATCH] D120301: clang-tools-extra: Make test dependency on LLVMHello optional

tstellar created this revision. tstellar added a reviewer: vtjnash. Herald added a subscriber: mgorny. tstellar requested review of this revision. Herald added a project: clang-tools-extra. This fixes clang + clang-tools-extra standalone build after 36892727e4f19a60778e371d78f8fb09d8122c85

[PATCH] D111100: enable plugins for clang-tidy

tstellar added a comment. I've proposed a fix for the standalone builds here D120301 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 __

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

ChuanqiXu added a comment. In D118586#3336865 , @iains wrote: > In D118586#3336612 , @ChuanqiXu > wrote: > >> (May off the patch) > > I am not sure what you mean here. I mean this comment is not related to the p

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

iains added a comment. In D118586#3336892 , @ChuanqiXu wrote: > In D118586#3336865 , @iains wrote: > >> In D118586#3336612 , @ChuanqiXu >> wrote: >> >>> (May off the patc

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

ChuanqiXu added a comment. In D118586#3336933 , @iains wrote: > In D118586#3336892 , @ChuanqiXu > wrote: > >> In D118586#3336865 , @iains wrote: >> >>> In D118586#3336612

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

curdeius added a comment. Nice job! Please let us a bit of time to review that. Also, I think it would be good to get a reviewer that knows well the yaml parts. Or even split it to a separate revision. And this part needs tests too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

jansvoboda11 added inline comments. Comment at: clang/test/Modules/cxx20-multiple-partitions.cpp:48 +#else +#error "no TU set" +#endif Instead of splitting the file with preprocessor, you could use the `split-file` utility (introduced in D83834). Repository:

[PATCH] D120289: [clang][dataflow] Add SAT solver interface and implementation

sgatev updated this revision to Diff 410460. sgatev marked 6 inline comments as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120289/new/ https://reviews.llvm.org/D120289 Files: clang/in

[PATCH] D120289: [clang][dataflow] Add SAT solver interface and implementation

sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Solver.h:39 + /// All elements in `Vals` must be non-null. + virtual Result solve(llvm::DenseSet Vals) = 0; +}; ymandel wrote: > Which `Result` is expected if the `Solver` giv

<    1   2