[PATCH] D120217: [clang-format] Add an option to insert braces after control statements

curdeius accepted this revision. curdeius added a comment. LGTM! Comment at: clang/lib/Format/Format.cpp:1850 + for (FormatToken *Token = Line->First; Token; Token = Token->Next) { +if (Token->Finalized || Token->BraceCount == 0) + continue; --

[PATCH] D119221: [clang][lexer] Allow u8 character literal prefixes in C2x

tbaeder updated this revision to Diff 410236. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119221/new/ https://reviews.llvm.org/D119221 Files: clang/docs/ReleaseNotes.rst clang/lib/Lex/Lexer.cpp clang/lib/Sema/SemaExpr.cpp clang/test/Lexer/utf8-char-literal.cpp clang/www/c_sta

[PATCH] D119221: [clang][lexer] Allow u8 character literal prefixes in C2x

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/test/Lexer/utf8-char-literal.cpp:24 +char g = u8'\x80'; // expected-warning {{implicit conversion from 'int' to 'char' changes value from 128 to -128}} #endif ta

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

Jim marked 2 inline comments as done. Jim added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoP.td:909 + +// kmar64 has a aliased instruction kmada32 belong to zpn sub-extension on RV64. +let DecoderNamespace = "RISCV32Zpsfoperand_", Jim wrote

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

Jim marked an inline comment as done. Jim added inline comments. Comment at: llvm/test/CodeGen/RISCV/rvv/fixed-vectors-int.ll:4360 ; LMULMAX1-RV64-NEXT:vid.v v10 +; LMULMAX1-RV64-NEXT:vadd.vi v11, v10, 2 +; LMULMAX1-RV64-NEXT:lui a2, %hi(.LCPI132_2)

[clang] ab28488 - [C++20][Modules][1/8] Track valid import state.

Author: Iain Sandoe Date: 2022-02-21T09:09:37Z New Revision: ab28488efe6de6f8fa856a1dfd8c0320d41d7608 URL: https://github.com/llvm/llvm-project/commit/ab28488efe6de6f8fa856a1dfd8c0320d41d7608 DIFF: https://github.com/llvm/llvm-project/commit/ab28488efe6de6f8fa856a1dfd8c0320d41d7608.diff LOG: [

[PATCH] D118196: [syntax][pseudo] Implement LR parsing table.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks, I really like the way the tests look now! Comment at: clang/include/clang/Tooling/Syntax/Pseudo/LRTable.h:78 + Shift, + // Reduce by a rule, the value

[PATCH] D120236: Add more sources to Taint analysis

gamesh411 created this revision. gamesh411 added a reviewer: steakhal. Herald added subscribers: martong, Szelethus, dkrupp. Herald added a reviewer: Szelethus. gamesh411 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add more functions as

[PATCH] D120217: [clang-format] Add an option to insert braces after control statements

owenpan updated this revision to Diff 410244. owenpan added a comment. In `insertBraces()` in `Format.cpp`, skip an annotated line if its first token is finalized. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120217/new/ https://reviews.llvm.org/D120217 Files: clang/docs/ClangForma

[PATCH] D120217: [clang-format] Add an option to insert braces after control statements

owenpan marked an inline comment as done. owenpan added inline comments. Comment at: clang/lib/Format/Format.cpp:1850 + for (FormatToken *Token = Line->First; Token; Token = Token->Next) { +if (Token->Finalized || Token->BraceCount == 0) + continue;

[PATCH] D120237: [clang-format][NFC] Simplify if in ContinuationIndenter::addTokenOCL

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Setting a

[PATCH] D120196: [clang-tidy][NFC] Remove Tristate from CachedGlobList

salman-javed-nz accepted this revision. salman-javed-nz added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120196/new/ https://reviews.llvm.org/D120196 _

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

nikic added a comment. Because I happened to also run into this, reduced IR for `-mtriple=riscv32 -mattr=+d` is: define float @test(float %x) { %1 = tail call float asm sideeffect alignstack "mv a0, a0", "={x10},{x10}"(float 0.00e+00) ret float 0.00e+00 } Repository: rG

[clang] b32ead4 - Increase the limit on parser diagnostics

Author: Benjamin Kramer Date: 2022-02-21T11:44:48+01:00 New Revision: b32ead41b16af993918b14b243d08d04dcdcd4c9 URL: https://github.com/llvm/llvm-project/commit/b32ead41b16af993918b14b243d08d04dcdcd4c9 DIFF: https://github.com/llvm/llvm-project/commit/b32ead41b16af993918b14b243d08d04dcdcd4c9.dif

[PATCH] D116290: [clang-format] Add enforcement of consistent `class`/typename` keyword for template arguments

avogelsgesang added a comment. > Will you still work on this? I don't know. I currently have more high-priority work, and don't know whether/when I will find time for this review again. Also, I realized that I will have to read up more about class-template parameters, e.g. I don't quite underst

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

sstwcw updated this revision to Diff 410271. sstwcw retitled this revision from "Add option to align compound assignments like `+=`" to "[clang-format] Add option to align compound assignments like `+=`". sstwcw added a comment. Herald added subscribers: llvm-commits, dexonsmith. Herald added a p

[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

ChuanqiXu updated this revision to Diff 410270. ChuanqiXu edited the summary of this revision. ChuanqiXu added a reviewer: iains. ChuanqiXu added a comment. Implement reachable definition initially/partially. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113545/new/ https://reviews.llvm

[PATCH] D113972: [RFC] [C++20] [Module] Support module partitions initially

ChuanqiXu abandoned this revision. ChuanqiXu added a subscriber: iains. ChuanqiXu added a comment. Now we prefer @iains's patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113972/new/ https://reviews.llvm.org/D113972 __

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

ChuanqiXu added a comment. I think it is helpful to add some tests from https://reviews.llvm.org/D113972 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118586/new/ https://reviews.llvm.org/D118586 ___ cfe

[PATCH] D119537: [clangd] Treat 'auto' params as deduced if there's a single instantiation.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:491 + // We'll examine visible specializations and see if they yield a unique type. + bool VisitParmVarDecl(ParmVarDecl *PVD) { +if (!PVD->getType()->is

[PATCH] D119537: [clangd] Treat 'auto' params as deduced if there's a single instantiation.

sammccall marked an inline comment as done. sammccall added a comment. BTW, D120131 demonstrates the other idea of actually using the instantiated AST instead of the template. It's pretty cool but would need some refinement to be production-ready I suppose. R

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

iains added a comment. In D118586#3335167 , @ChuanqiXu wrote: > I think it is helpful to add some tests from https://reviews.llvm.org/D113972 Actually, in response to your concerns, this morning I wrote a multi-partition test case to add to this (which

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, tahonermann. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This implements N2393. I am a bit confused by the proposal only taking about adding "true" and "fal

[clang-tools-extra] b9b6938 - [clangd] Treat 'auto' params as deduced if there's a single instantiation.

Author: Sam McCall Date: 2022-02-21T13:24:11+01:00 New Revision: b9b6938183e837e66ff7450fb2b8a73dce5889c0 URL: https://github.com/llvm/llvm-project/commit/b9b6938183e837e66ff7450fb2b8a73dce5889c0 DIFF: https://github.com/llvm/llvm-project/commit/b9b6938183e837e66ff7450fb2b8a73dce5889c0.diff LO

[PATCH] D119537: [clangd] Treat 'auto' params as deduced if there's a single instantiation.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb9b6938183e8: [clangd] Treat 'auto' params as deduced if there's a single instantiation. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

ChuanqiXu added a comment. In D118586#3335191 , @iains wrote: > In D118586#3335167 , @ChuanqiXu > wrote: > >> I think it is helpful to add some tests from https://reviews.llvm.org/D113972 > > Actually, in respons

[clang] 071a9b7 - [NFC][RISCV] Fix path checking issue if default sysroot is given

Author: Kito Cheng Date: 2022-02-21T20:43:51+08:00 New Revision: 071a9b751a46205dc276069dfbc0d38582736990 URL: https://github.com/llvm/llvm-project/commit/071a9b751a46205dc276069dfbc0d38582736990 DIFF: https://github.com/llvm/llvm-project/commit/071a9b751a46205dc276069dfbc0d38582736990.diff LO

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

iains added a comment. In D118586#3335235 , @ChuanqiXu wrote: > In D118586#3335191 , @iains wrote: > >> In D118586#3335167 , @ChuanqiXu >> wrote: >> >>> I think it is hel

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

tbaeder added inline comments. Comment at: clang/test/Sema/c2x-bool.c:10 +_Static_assert(_Generic(true, bool : true, default: false)); +_Static_assert(_Generic(false, bool : true, default: false)); + Not that clang-format wanted me to format these two lines, but

[PATCH] D120200: [Clang][OpenMP] Add Sema support for atomic compare capture

ABataev added a comment. Do we have ast print/dump tests for correct constructs? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120200/new/ https://reviews.llvm.org/D120200 ___ cfe-commits mailing list cf

[PATCH] D120225: [Clang][Sema] Check unexpected else statement in cond-update-stmt

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120225/new/ https://reviews.llvm.org/D120225 ___

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth added a comment. Another full run on LLVM with: $ ./clang-tools-extra/clang-tidy/tool/run-clang-tidy.py \ -clang-tidy-binary ~/software/llvm-project/build_clang_tidy/bin/clang-tidy \ -checks="-*,cppcoreguidelines-const-correctness" \ -config "{CheckOptions: [{

[PATCH] D120246: [flang][driver] Add support for `--target`/`--triple`

awarzynski created this revision. awarzynski added reviewers: rovka, clementval, schweitz, Leporacanthicus. Herald added subscribers: dang, usaxena95, kadircet. Herald added a reviewer: sscalpone. Herald added a project: Flang. awarzynski requested review of this revision. Herald added subscribers:

[PATCH] D120200: [Clang][OpenMP] Add Sema support for atomic compare capture

tianshilei1992 added a comment. In D120200#3335250 , @ABataev wrote: > Do we have ast print/dump tests for correct constructs? It's in the parser patch which has already been merged. https://reviews.llvm.org/D116261 Repository: rG LLVM Github Monore

[clang] 6da6064 - [Clang][Sema] Check unexpected else statement in cond-update-stmt

Author: Shilei Tian Date: 2022-02-21T08:20:34-05:00 New Revision: 6da60647cda2fad4d93e359ef3afaea18599b2ba URL: https://github.com/llvm/llvm-project/commit/6da60647cda2fad4d93e359ef3afaea18599b2ba DIFF: https://github.com/llvm/llvm-project/commit/6da60647cda2fad4d93e359ef3afaea18599b2ba.diff L

[PATCH] D120225: [Clang][Sema] Check unexpected else statement in cond-update-stmt

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6da60647cda2: [Clang][Sema] Check unexpected else statement in cond-update-stmt (authored by tianshilei1992). Repository: rG LLVM Github Monorepo

[PATCH] D120200: [Clang][OpenMP] Add Sema support for atomic compare capture

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120200/new/ https://reviews.llvm.org/D120200 ___

[PATCH] D120236: Add more sources to Taint analysis

steakhal added a comment. Sorry for the wall-of-nits. Overall, looks great. Comment at: clang/docs/analyzer/checkers.rst:2358 Default sources defined by ``GenericTaintChecker``: -``fdopen``, ``fopen``, ``freopen``, ``getch``, ``getchar``, ``getchar_unlocked``, ``gets``, ``sca

[PATCH] D120236: Add more sources to Taint analysis

steakhal added a comment. Also great to see that the docs are in-sync to the code, which is a great plus! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120236/new/ https://reviews.llvm.org/D120236 ___ cf

[PATCH] D120236: [analyzer] Add more sources to Taint analysis

steakhal added a comment. The pre-merge checks failed due to an unrelated test case: `Driver/hip-link-bundle-archive.hip` (on Windows); so I think we are good to go on that part. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120236/new/ https://r

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

protze.joachim added a comment. I think in openmp/tools currently only libraries and header files get installed, but no binaries. I suggest to define `OPENMP_TOOLS_INSTALL_BINDIR`, `OPENMP_TOOLS_INSTALL_LIBDIR`, and `OPENMP_TOOLS_INSTALL_INCLUDEDIR` and probably base these variables on OPENMP_

[PATCH] D120251: [clang][driver][wasm] Fix libstdc++ target-dependent include dir

tbaeder created this revision. tbaeder added a reviewer: sbc100. Herald added subscribers: sunfish, jgravelle-google, dschuff. tbaeder requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. As an alternative to https://reviews.llvm.org/D11

[PATCH] D120252: [Clang][OpenMP] Fix wrong form of 'cond-update-stmt' in atomic_ast_print.cpp

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev. Herald added subscribers: guansong, yaxunl. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. In `clang/test/OpenMP/atomic_ast_p

[PATCH] D120252: [Clang][OpenMP] Fix wrong form of 'cond-update-stmt' in atomic_ast_print.cpp

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120252/new/ https://reviews.llvm.org/D120252 ___

[PATCH] D112932: [WIP] Use llvm.is_fpclass to implement FP classification functions

sepavloff updated this revision to Diff 410303. sepavloff added a comment. Updated patch because the base revision is updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112932/new/ https://reviews.llvm.org/D112932 Files: clang/include/clang/B

[PATCH] D116153: [ARM][AArch64] Add missing v8.x checks

vhscampos added a comment. I don't see any problem with the patch, but we should wait on @SjoerdMeijer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116153/new/ https://reviews.llvm.org/D116153 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D114714: [C++20][Modules][2/8] Add enumerations for partition modules and stream them.

iains updated this revision to Diff 410305. iains added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114714/new/ https://reviews.llvm.org/D114714 Files: clang/include/clang/Basic/Module.h clang/lib/AST/Decl.cpp clang/lib/

[PATCH] D116153: [ARM][AArch64] Add missing v8.x checks

SjoerdMeijer added a comment. Ah, sorry, forgot about this. Can you upload the patch with some more context please so I can have a quick look again? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116153/new/ https://reviews.llvm.org/D116153

[PATCH] D116153: [ARM][AArch64] Add missing v8.x checks

tyb0807 updated this revision to Diff 410310. tyb0807 edited the summary of this revision. tyb0807 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116153/new/ https://reviews.llvm.org/D116153 Files: clang/lib/Basic/Targets/

[PATCH] D116153: [ARM][AArch64] Add missing v8.x checks

SjoerdMeijer added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:958 case llvm::ARM::ArchKind::ARMV8_6A: + case llvm::ARM::ArchKind::ARMV8_7A: case llvm::ARM::ArchKind::ARMV8_8A: I see tests for the crypto stuff, but is there or do we need a

[PATCH] D114382: [clang] Fix wrong -Wunused-local-typedef warning within a template function

krisb added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114382/new/ https://reviews.llvm.org/D114382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D116153: [ARM][AArch64] Add missing v8.x checks

tyb0807 added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:958 case llvm::ARM::ArchKind::ARMV8_6A: + case llvm::ARM::ArchKind::ARMV8_7A: case llvm::ARM::ArchKind::ARMV8_8A: SjoerdMeijer wrote: > I see tests for the crypto stuff, but is ther

[PATCH] D116153: [ARM][AArch64] Add missing v8.x checks

SjoerdMeijer added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:958 case llvm::ARM::ArchKind::ARMV8_6A: + case llvm::ARM::ArchKind::ARMV8_7A: case llvm::ARM::ArchKind::ARMV8_8A: tyb0807 wrote: > SjoerdMeijer wrote: > > I see tests for the c

[PATCH] D120200: [Clang][OpenMP] Add Sema support for atomic compare capture

tianshilei1992 updated this revision to Diff 410313. tianshilei1992 added a comment. fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120200/new/ https://reviews.llvm.org/D120200 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td c

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

svenvh created this revision. svenvh added a reviewer: azabaznov. Herald added subscribers: Naghasan, ldrumm, yaxunl. svenvh requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Until now, subgroup builtins are available with `opencl-c.h` when a

[clang] 3a3d9ae - [Clang][OpenMP] Fix wrong form of 'cond-update-stmt' in atomic_ast_print.cpp

Author: Shilei Tian Date: 2022-02-21T11:40:09-05:00 New Revision: 3a3d9ae545925162ebbe820639cd2fe072ff4dd8 URL: https://github.com/llvm/llvm-project/commit/3a3d9ae545925162ebbe820639cd2fe072ff4dd8 DIFF: https://github.com/llvm/llvm-project/commit/3a3d9ae545925162ebbe820639cd2fe072ff4dd8.diff L

[PATCH] D120252: [Clang][OpenMP] Fix wrong form of 'cond-update-stmt' in atomic_ast_print.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3a3d9ae54592: [Clang][OpenMP] Fix wrong form of 'cond-update-stmt' in atomic_ast_print.cpp (authored by tianshilei1992). Repository: rG LLVM Gith

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

svenvh added inline comments. Comment at: clang/lib/Headers/opencl-c-base.h:85 +// Internal feature macro to provide subgroup builtins. +#define __opencl_subgroup_builtins 1 +#endif I'm in doubt whether we could just reuse `__opencl_c_subgroups` for this? Repos

[PATCH] D116153: [ARM][AArch64] Add missing v8.x checks

tyb0807 added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:958 case llvm::ARM::ArchKind::ARMV8_6A: + case llvm::ARM::ArchKind::ARMV8_7A: case llvm::ARM::ArchKind::ARMV8_8A: SjoerdMeijer wrote: > tyb0807 wrote: > > SjoerdMeijer wrote: > > >

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

fonzvermund added a comment. https://njonlinecasinos.webgarden.com/casinos/nj-casino-reviews/tropicana-online-casino http://playlegalsportsbetting.com/borgata-online-casino-pa/ https://casinowatchnj.com/borgata-online-casino/ https://casinowatchnj.com/betmgm-online-casino/ https://casinowatchpa.co

[PATCH] D120200: [Clang][OpenMP] Add Sema support for atomic compare capture

tianshilei1992 updated this revision to Diff 410318. tianshilei1992 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120200/new/ https://reviews.llvm.org/D120200 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clan

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

fonzvermund added a comment. http://webonlinegambling.idea.informer.com/ https://webonlinegambling.com/mobile-casinos/ http://playlegalsportsbetting.idea.informer.com/ http://legalsportsbetting.idea.informer.com/ https://sourceforge.net/u/legalsportsbet/profile https://www.theodysseyonline.com/use

[PATCH] D116153: [ARM][AArch64] Add missing v8.x checks

SjoerdMeijer added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:958 case llvm::ARM::ArchKind::ARMV8_6A: + case llvm::ARM::ArchKind::ARMV8_7A: case llvm::ARM::ArchKind::ARMV8_8A: tyb0807 wrote: > SjoerdMeijer wrote: > > tyb0807 wrote: > > >

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

iains updated this revision to Diff 410320. iains added a comment. rebased, added a multi-partition testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118586/new/ https://reviews.llvm.org/D118586 Files: clang/include/clang/AST/Decl.h clan

[PATCH] D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation.

sammccall created this revision. sammccall added reviewers: nridge, Trass3r. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This takes a

[PATCH] D119537: [clangd] Treat 'auto' params as deduced if there's a single instantiation.

sammccall added a comment. D120258 is the followup with inlay hints. It rearranges some of the code from this patch for reuse, and proposes dropping support for multiple instantiations yielding the same result, as this inevitably pushes complexity into each pl

[PATCH] D119481: run-clang-tidy: Fix infinite loop on windows

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. LGTM with a small nit Comment at: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py:69 while not os.path.isfile(os.path.join(result, path)): -if os.path.realpa

[PATCH] D120160: [Clang] Add `-funstable` flag to enable unstable and experimental features

zoecarver accepted this revision. zoecarver added a comment. This revision is now accepted and ready to land. This looks great, thanks Egor! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120160/new/ https://reviews.llvm.org/D120160 ___

[PATCH] D54141: [clang-tidy] add deduplication support for run-clang-tidy.py

JonasToth abandoned this revision. JonasToth added a comment. Herald added a subscriber: mgehre. won't happen anymore realistically. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54141/new/ https://reviews.llvm.org/D54141 __

[PATCH] D120262: [OpenCL] Handle TypeExtensions in OpenCLBuiltinFileEmitter

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Until now, any types that had TypeExtensions attached to them were

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119051/new/ https://reviews.llvm.org/D119051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests

cristian.adam added a comment. `release/14.x` now configures but fails to build on MSVC2019 with `-D LLVM_EXPORT_SYMBOLS_FOR_PLUGINS=ON` like at https://reviews.llvm.org/D00 FAILED: bin/CTTestTidyModule.dll cmd.exe /C "cd . && C:\tools\cmake\bin\cmake.exe -E vs_link_dll --intdir=tools\c

[PATCH] D119162: [Pseudo] Token/TokenStream, PP directive parser.

sammccall updated this revision to Diff 410340. sammccall marked 26 inline comments as done. sammccall added a comment. Herald added a subscriber: dexonsmith. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119162/new/ https:/

[PATCH] D119162: [Pseudo] Token/TokenStream, PP directive parser.

sammccall added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Pseudo/Preprocess.h:49 +/// | `printf("hello, "); +/// |-+ Conditional -+ Directive #ifndef NDEBUG +/// | |-+ Code printf("debug\n"); --

[clang] e2855e1 - [Clang][OpenMP] Add Sema support for atomic compare capture

Author: Shilei Tian Date: 2022-02-21T14:21:02-05:00 New Revision: e2855e17601e8a193bf07b0533be69dbf85b811c URL: https://github.com/llvm/llvm-project/commit/e2855e17601e8a193bf07b0533be69dbf85b811c DIFF: https://github.com/llvm/llvm-project/commit/e2855e17601e8a193bf07b0533be69dbf85b811c.diff L

[PATCH] D120200: [Clang][OpenMP] Add Sema support for atomic compare capture

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe2855e17601e: [Clang][OpenMP] Add Sema support for atomic compare capture (authored by tianshilei1992). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D120266: [clang][CodeGen] Avoid emitting ifuncs with undefined resolvers

ibookstein created this revision. ibookstein added reviewers: erichkeane, rsmith, MaskRay. ibookstein requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The purpose of this change is to fix the following codegen bug: // main.c __attribute__((

[PATCH] D118587: [C++20][Modules][4/8] Handle generation of partition implementation CMIs.

iains updated this revision to Diff 410348. iains added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118587/new/ https://reviews.llvm.org/D118587 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaModule.cpp clang/

[PATCH] D120270: [OpenMP] Try to embed offloading objects after codegen

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield. Herald added subscribers: ormris, guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Currently we use the `-fembed-offload-o

[PATCH] D120271: [Clang] Add offload kind to embedded offload object

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds the offload kind to the embedded section name in preparation for offloading

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, tra, yaxunl. Herald added a subscriber: carlosgalvezp. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds the basic support fo

[PATCH] D120273: [OpenMP] Allow CUDA to be linked with OpenMP using the new driver

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. After basic support for embedding and handling

[PATCH] D120266: [clang][CodeGen] Avoid emitting ifuncs with undefined resolvers

ibookstein updated this revision to Diff 410360. ibookstein added a comment. clang-format + description wording Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120266/new/ https://reviews.llvm.org/D120266 Files: clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D118632: [Clang]OpenMP] Add the codegen support for `atomic compare`

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit Comment at: clang/include/clang/AST/StmtOpenMP.h:2970 + } + /// Get + Expr *getCondExpr() { Fix comment Repository: rG LLVM Github Mon

[PATCH] D120217: [clang-format] Add an option to insert braces after control statements

owenpan updated this revision to Diff 410365. owenpan marked an inline comment as done. owenpan added a comment. If the line immediately following `// clang-format off` is a line comment, `assert(!Token->Finalized)` will fail. Fixed it and updated the corresponding unit test. CHANGES SINCE LAS

[clang] f9c3310 - [OPENMP]Fix PR49366: crash on VLAs in task untied regions.

Author: Alexey Bataev Date: 2022-02-21T12:28:47-08:00 New Revision: f9c3310d32c62b28c10084a0104563aeeecc06ec URL: https://github.com/llvm/llvm-project/commit/f9c3310d32c62b28c10084a0104563aeeecc06ec DIFF: https://github.com/llvm/llvm-project/commit/f9c3310d32c62b28c10084a0104563aeeecc06ec.diff

[PATCH] D99436: [OPENMP]Fix PR49366: crash on VLAs in task untied regions.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf9c3310d32c6: [OPENMP]Fix PR49366: crash on VLAs in task untied re

[libunwind] 3fa2e66 - [libunwind] Further fix for 32-bit PowerPC processors without AltiVec

Author: George Koehler Date: 2022-02-21T15:31:23-05:00 New Revision: 3fa2e66c10aadac1d209afadba34d90c9bd95221 URL: https://github.com/llvm/llvm-project/commit/3fa2e66c10aadac1d209afadba34d90c9bd95221 DIFF: https://github.com/llvm/llvm-project/commit/3fa2e66c10aadac1d209afadba34d90c9bd95221.diff

[PATCH] D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation.

Trass3r added a comment. Looks like this only covers a subset. I see hints for some generic lambdas but not for others while hovering over auto reveals the type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120258/new/ https://reviews.llvm.org/D1

[PATCH] D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation.

sammccall added a comment. Thanks - any chance you can reduce an example where hover works and inlay hints do not? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120258/new/ https://reviews.llvm.org/D120258

[PATCH] D118632: [Clang]OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 added a comment. In D118632#3336094 , @ABataev wrote: > LG with a nit Actually I got two question in the inline comments. Can you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D120273: [OpenMP] Allow CUDA to be linked with OpenMP using the new driver

jhuber6 updated this revision to Diff 410370. jhuber6 added a comment. Make sure we don't pass PTX to nvlink. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120273/new/ https://reviews.llvm.org/D120273 Files: clang/tools/clang-linker-wrapper/Clan

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

ABataev added a comment. In D118632#3336133 , @tianshilei1992 wrote: > In D118632#3336094 , @ABataev wrote: > >> LG with a nit > > Actually I got two question in the inline comments. Can you please take a > look

[PATCH] D118588: [C++20][Modules]5/8] Diagnose wrong import/export for partition CMIs.

iains updated this revision to Diff 410371. iains added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118588/new/ https://reviews.llvm.org/D118588 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaMo

[PATCH] D120278: [clang-format] Don't break semi after requires clause regardless of the chosen style

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius, JohelEGP. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D120280: [CMake][Fuchsia] Disable assertions and analyzer for stage 1

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeec3488cf1d8: [CMake][Fuchsia] Disable assertions and analyzer for stage 1 (authored by phosek). Herald added a project: clang. Herald added a subscr

[clang] eec3488 - [CMake][Fuchsia] Disable assertions and analyzer for stage 1

Author: Petr Hosek Date: 2022-02-21T13:31:13-08:00 New Revision: eec3488cf1d84d3503d5a8535b64374b79287bb9 URL: https://github.com/llvm/llvm-project/commit/eec3488cf1d84d3503d5a8535b64374b79287bb9 DIFF: https://github.com/llvm/llvm-project/commit/eec3488cf1d84d3503d5a8535b64374b79287bb9.diff LO

[PATCH] D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation.

Trass3r added a comment. No apparent differences. Is there a way to automatically reduce it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120258/new/ https://reviews.llvm.org/D120258 ___ cfe-commits mai

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 added a comment. In D118632#3336145 , @ABataev wrote: > In D118632#3336133 , > @tianshilei1992 wrote: > >> In D118632#3336094 , @ABataev >> wrote: >> >>>

[PATCH] D120282: [Format] Remove unused LineContainsContinuedForLoopSection. NFC

sammccall created this revision. sammccall added a reviewer: MyDeveloperDay. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D120282 Files: clang/lib/Format/Contin

  1   2   >