ChuanqiXu added a comment. In D118586#3335191 <https://reviews.llvm.org/D118586#3335191>, @iains wrote:
> In D118586#3335167 <https://reviews.llvm.org/D118586#3335167>, @ChuanqiXu > wrote: > >> I think it is helpful to add some tests from https://reviews.llvm.org/D113972 > > Actually, in response to your concerns, this morning I wrote a > multi-partition test case to add to this (which does pass). Thanks. I think it would be helpful to add it here. > Would you be able to split out the important test cases from D113972 > <https://reviews.llvm.org/D113972> as a separate patch ? I found the meaningful test case mainly comes from the example in spec. e.g., http://eel.is/c++draft/module.unit#4, http://eel.is/c++draft/module.unit#4, http://eel.is/c++draft/module.unit#4 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118586/new/ https://reviews.llvm.org/D118586 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
