[PATCH] D120066: FileCheck’s regexp stumped on Windows.

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Feel free to commit with the suggestions I added above. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120066/new/ https://reviews.llvm.o

[PATCH] D119184: [clang] [concepts] Check constrained-auto return types for void-returning functions

Quuxplusone added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3766 +Expr *&RetExpr, const AutoType *AT, +bool HasReturnStmt) { + // If this is the conversion function for a lambd

[PATCH] D120066: FileCheck’s regexp stumped on Windows.

zahiraam updated this revision to Diff 409678. zahiraam marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120066/new/ https://reviews.llvm.org/D120066 Files: clang/test/CodeGenCXX/debug-info-hotpatch.cpp Index: clang/test/CodeGenCXX/debug-info-hotpatch.c

[PATCH] D119184: [clang] [concepts] Check constrained-auto return types for void-returning functions

Quuxplusone added inline comments. Comment at: clang/test/SemaCXX/deduced-return-type-cxx14.cpp:116 -auto &void_ret_2() {} // expected-error {{cannot deduce return type 'auto &' for function with no return statements}} +auto &void_ret_2() {} // expected-error {{cannot form a r

[clang] 7adb858 - [clang] [NFC] More exhaustive tests for deducing void return types

Author: Arthur O'Dwyer Date: 2022-02-17T11:56:49-05:00 New Revision: 7adb85884b35be033b6c54d5916aed5edcb354fb URL: https://github.com/llvm/llvm-project/commit/7adb85884b35be033b6c54d5916aed5edcb354fb DIFF: https://github.com/llvm/llvm-project/commit/7adb85884b35be033b6c54d5916aed5edcb354fb.diff

[PATCH] D119772: [clang] [NFC] More exhaustive tests for deducing void return types

This revision was automatically updated to reflect the committed changes. Closed by commit rG7adb85884b35: [clang] [NFC] More exhaustive tests for deducing void return types (authored by arthur.j.odwyer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang] 32b73bc - Add support for floating-point option `ffp-eval-method` and for

Author: Zahira Ammarguellat Date: 2022-02-17T08:59:21-08:00 New Revision: 32b73bc6ab8234b670c34d5ef999300e072cc706 URL: https://github.com/llvm/llvm-project/commit/32b73bc6ab8234b670c34d5ef999300e072cc706 DIFF: https://github.com/llvm/llvm-project/commit/32b73bc6ab8234b670c34d5ef999300e072cc706

[clang] 5fe64d2 - [clang] Sema::CheckEquivalentExceptionSpec - remove useless nullptr test

Author: Simon Pilgrim Date: 2022-02-17T16:59:50Z New Revision: 5fe64d238b8b5ed1861de63a2072ddf3e81af806 URL: https://github.com/llvm/llvm-project/commit/5fe64d238b8b5ed1861de63a2072ddf3e81af806 DIFF: https://github.com/llvm/llvm-project/commit/5fe64d238b8b5ed1861de63a2072ddf3e81af806.diff LOG:

[PATCH] D111100: enable plugins for clang-tidy

tstellar added inline comments. Comment at: clang-tools-extra/test/CMakeLists.txt:91 + if(TARGET CTTestTidyModule) + list(APPEND CLANG_TOOLS_TEST_DEPS CTTestTidyModule LLVMHello) + target_include_directories(CTTestTidyModule PUBLIC BEFORE "${CLANG_TOOLS_SOURCE_DIR}")

[PATCH] D119989: [clangd] Fix building SerializationTests unit test on OpenBSD

brad added a comment. In D119989#3329413 , @kadircet wrote: > thanks Yes, I will do so. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119989/new/ https://reviews.llvm.org/D119989

[PATCH] D119727: [RISCV] Add the policy operand for nomask vector Multiply-Add IR intrinsics.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGca783124073f: [RISCV] Add the policy operand for nomask vector Multiply-Add IR intrinsics. (authored by khchen). Changed prior to commit: https://

[clang-tools-extra] f374c8d - [clangd] Fix building SerializationTests unit test on OpenBSD

Author: Brad Smith Date: 2022-02-17T12:17:12-05:00 New Revision: f374c8ddf2dd4920190cac0ea81e18a74040ddda URL: https://github.com/llvm/llvm-project/commit/f374c8ddf2dd4920190cac0ea81e18a74040ddda DIFF: https://github.com/llvm/llvm-project/commit/f374c8ddf2dd4920190cac0ea81e18a74040ddda.diff LO

[PATCH] D119989: [clangd] Fix building SerializationTests unit test on OpenBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rGf374c8ddf2dd: [clangd] Fix building SerializationTests unit test on OpenBSD (authored by brad). Changed prior to commit: https://reviews.llvm.org/D119989?vs=409445&id=409689#toc Repository: rG LLVM G

[PATCH] D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

jlebar added a comment. In D119207#3327476 , @shangwuyao wrote: > Thanks for the review, if it looks good, can we get this to land now? > Otherwise more comments are welcome! I'll land this for you! At some point you should get commit access yourself,

[clang] 9de4fc0 - [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

Author: Shangwu Yao Date: 2022-02-17T09:38:06-08:00 New Revision: 9de4fc0f2d3b60542956f7e5254951d049edeb1f URL: https://github.com/llvm/llvm-project/commit/9de4fc0f2d3b60542956f7e5254951d049edeb1f DIFF: https://github.com/llvm/llvm-project/commit/9de4fc0f2d3b60542956f7e5254951d049edeb1f.diff L

[PATCH] D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG9de4fc0f2d3b: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments (authored by shangwuyao, committed by jle

[PATCH] D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

jlebar added a comment. commit 9de4fc0f2d3b60542956f7e5254951d049edeb1f (HEAD -> main, origin/main, origin/HEAD) Author: Shangwu Yao Date: Thu Feb 17 09:38:06 2022 -0800 [CUDA][SPIRV] Assign global address space to CUDA kernel arguments This patch converts CUDA pointer

[PATCH] D120070: [HIP] Support linking archive of bundled bitcode

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. HIP programs compiled with -c -fgpu-rdc generate clang-offload-bundler bundles which contain bitcode for different GPU's. Such files can be archived to an archive file which can be linked with HI

[PATCH] D111100: enable plugins for clang-tidy

vtjnash added inline comments. Comment at: clang-tools-extra/test/CMakeLists.txt:91 + if(TARGET CTTestTidyModule) + list(APPEND CLANG_TOOLS_TEST_DEPS CTTestTidyModule LLVMHello) + target_include_directories(CTTestTidyModule PUBLIC BEFORE "${CLANG_TOOLS_SOURCE_DIR}") -

[PATCH] D119040: Fix LookupTest where it was missing an assertion

probinson added a subscriber: bkramer. probinson added a comment. Ping; + @bkramer who reviewed the original patch that added this test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119040/new/ https://reviews.llvm.org/D119040 ___ cfe-commit

[PATCH] D120070: [HIP] Support linking archive of bundled bitcode

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/test/Driver/hip-link-bundle-archive.hip:3 + +// RUN: touch %T/libhipBundled.a + Is this file necessary? `clang -###` should not need the fi

[PATCH] D118977: [NVPTX] Add more FMA intriniscs/builtins

tra added a comment. In D118977#3329146 , @jchlanda wrote: > @tra I've fixed the test failure (`math-intrins.ll`) the rest seems to be > unrelated timeouts, Thank you. > would you be able to merge those patches in, as I don't have the commit > access

[clang] e0e1748 - [analyzer] Fix a crash in NoStateChangeVisitor with body-farmed stack frames.

Author: Artem Dergachev Date: 2022-02-17T10:13:34-08:00 New Revision: e0e174845b08b36a3888f47f6b06e496f75cf847 URL: https://github.com/llvm/llvm-project/commit/e0e174845b08b36a3888f47f6b06e496f75cf847 DIFF: https://github.com/llvm/llvm-project/commit/e0e174845b08b36a3888f47f6b06e496f75cf847.dif

[PATCH] D119509: [analyzer] Fix a crash in NoStateChangeVisitor with body-farmed stack frames.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe0e174845b08: [analyzer] Fix a crash in NoStateChangeVisitor with body-farmed stack frames. (authored by dergachev.a). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

davidstone updated this revision to Diff 409710. davidstone added a comment. Add unit test requested by Richard Smith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99134/new/ https://reviews.llvm.org/D99134 Files: clang/lib/Sema/SemaTemplateInst

[clang] b9f4dff - [Driver][Fuchsia][NFC] Use GetLinkerPath to see if linker is lld

Author: Alex Brachet Date: 2022-02-17T18:20:23Z New Revision: b9f4dff8ab40250aac2343e86c1289de46af5585 URL: https://github.com/llvm/llvm-project/commit/b9f4dff8ab40250aac2343e86c1289de46af5585 DIFF: https://github.com/llvm/llvm-project/commit/b9f4dff8ab40250aac2343e86c1289de46af5585.diff LOG:

[PATCH] D120074: [Driver][Fuchsia][NFC] Use GetLinkerPath to see if linker is lld

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb9f4dff8ab40: [Driver][Fuchsia][NFC] Use GetLinkerPath to see if linker is lld (authored by abrachet). Herald added a project: clang. Herald added a

[PATCH] D120070: [HIP] Support linking archive of bundled bitcode

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/test/Driver/hip-link-bundle-archive.hip:3 + +// RUN: touch %T/libhipBundled.a + tra wrote: > Is this file necessary? `clang -###` should not need the file to be present > in

[clang] 383f3a4 - [OpenMP] Diagnose bad 'omp declare variant' that references itself.

Author: Mike Rice Date: 2022-02-17T10:36:28-08:00 New Revision: 383f3a467c92499956ed804eb2bd69ad8576615b URL: https://github.com/llvm/llvm-project/commit/383f3a467c92499956ed804eb2bd69ad8576615b DIFF: https://github.com/llvm/llvm-project/commit/383f3a467c92499956ed804eb2bd69ad8576615b.diff LOG

[PATCH] D119979: [OpenMP] Diagnose bad 'omp declare variant' that references itself

This revision was automatically updated to reflect the committed changes. Closed by commit rG383f3a467c92: [OpenMP] Diagnose bad 'omp declare variant' that references itself. (authored by mikerice). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Githu

[PATCH] D116774: AST: Move __va_list tag back to std conditionally on AArch64.

pcc updated this revision to Diff 409716. pcc added a comment. Use isARM() etc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116774/new/ https://reviews.llvm.org/D116774 Files: clang/lib/AST/ASTContext.cpp clang/lib/AST/ItaniumMangle.cpp cla

[PATCH] D119612: [clang] Pass more flags to ld64.lld

int3 accepted this revision. int3 added a comment. This revision is now accepted and ready to land. lgtm! Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:272 - // ld64 version 262 and above run the deduplicate pass by default. - if (Version >= VersionTuple(262) && shoul

[clang] 5364b36 - Revert "[Driver][Fuchsia][NFC] Use GetLinkerPath to see if linker is lld"

Author: Alex Brachet Date: 2022-02-17T18:41:49Z New Revision: 5364b36868210364b2ccf8e9f9169ed1fd545ae0 URL: https://github.com/llvm/llvm-project/commit/5364b36868210364b2ccf8e9f9169ed1fd545ae0 DIFF: https://github.com/llvm/llvm-project/commit/5364b36868210364b2ccf8e9f9169ed1fd545ae0.diff LOG:

[PATCH] D116774: AST: Move __va_list tag back to std conditionally on AArch64.

pcc marked 2 inline comments as done. pcc added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116774/new/ https://reviews.llvm.org/D116774 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D119612: [clang] Pass more flags to ld64.lld

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:272 - // ld64 version 262 and above run the deduplicate pass by default. - if (Version >= VersionTuple(262) && shouldLinkerNotDedup(C.getJobs().empty(), Args)) + // ld64 version 262 and above

[PATCH] D119979: [OpenMP] Diagnose bad 'omp declare variant' that references itself

jdoerfert reopened this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Why is this supposed to be a user error? I don't remember the standard disallowing this and I can see use cases for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D116774: AST: Move __va_list tag back to std conditionally on AArch64.

jrtc27 accepted this revision. jrtc27 added a comment. This revision is now accepted and ready to land. Thanks, looks good to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116774/new/ https://reviews.llvm.org/D116774 ___

[PATCH] D116773: AST: Make getEffectiveDeclContext() a member function of ItaniumMangleContextImpl. NFCI.

jrtc27 accepted this revision. jrtc27 added a comment. This revision is now accepted and ready to land. This makes sense to me but I don't know if you want someone with more authority in these parts to review it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[clang] 5824d2b - Fix the declaration printer to properly handle prototypes in C

Author: Aaron Ballman Date: 2022-02-17T13:54:09-05:00 New Revision: 5824d2bb0f036e631419ae0993fd03d633398266 URL: https://github.com/llvm/llvm-project/commit/5824d2bb0f036e631419ae0993fd03d633398266 DIFF: https://github.com/llvm/llvm-project/commit/5824d2bb0f036e631419ae0993fd03d633398266.diff

[PATCH] D119979: [OpenMP] Diagnose bad 'omp declare variant' that references itself

mikerice added a comment. What's the use case? I wasn't aware of any. We saw it from someone who did it accidently and caused the compiler to crash in codegen. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119979/new/ https://reviews.llvm.org/D11

[clang] 2c91754 - [Clang] Add attributes alloc_size and alloc_align to mm_malloc

Author: Dávid Bolvanský Date: 2022-02-17T19:59:18+01:00 New Revision: 2c91754a13f333d7fe9f9d3d40fb618e40c48cab URL: https://github.com/llvm/llvm-project/commit/2c91754a13f333d7fe9f9d3d40fb618e40c48cab DIFF: https://github.com/llvm/llvm-project/commit/2c91754a13f333d7fe9f9d3d40fb618e40c48cab.dif

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG2c91754a13f3: [Clang] Add attributes alloc_size and alloc_align to mm_malloc (authored by xbolva00). Repository: rG LLV

[clang] 4dfa68e - [NFC] Fix debug-info-hotpatch.cpp failure due to downstream regex issue.

Author: Zahira Ammarguellat Date: 2022-02-17T10:59:54-08:00 New Revision: 4dfa68e483137cc13eb9027c0dd834ede19f2fd4 URL: https://github.com/llvm/llvm-project/commit/4dfa68e483137cc13eb9027c0dd834ede19f2fd4 DIFF: https://github.com/llvm/llvm-project/commit/4dfa68e483137cc13eb9027c0dd834ede19f2fd4

[clang] b0aa194 - [AMDGPU] Promote recursive loads from kernel argument to constant

Author: Stanislav Mekhanoshin Date: 2022-02-17T11:07:03-08:00 New Revision: b0aa1946dfe1d204e49b8238c4960f64a68f31d5 URL: https://github.com/llvm/llvm-project/commit/b0aa1946dfe1d204e49b8238c4960f64a68f31d5 DIFF: https://github.com/llvm/llvm-project/commit/b0aa1946dfe1d204e49b8238c4960f64a68f31

[PATCH] D119886: [AMDGPU] Promote recursive loads from kernel argument to constant

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb0aa1946dfe1: [AMDGPU] Promote recursive loads from kernel argument to constant (authored by rampitec). Herald added a project: clang. Herald added a

[PATCH] D119979: [OpenMP] Diagnose bad 'omp declare variant' that references itself

jdoerfert added a comment. In D119979#3330343 , @mikerice wrote: > What's the use case? I wasn't aware of any. We saw it from someone who did > it accidently and caused the compiler to crash in codegen. If you have N overloads/variants and you want to

[clang] f56cb52 - [DEBUGINFO] [LLDB] Add support for generating debug-info for structured bindings of structs and arrays

Author: Shafik Yaghmour Date: 2022-02-17T11:14:14-08:00 New Revision: f56cb520d8554ca42a215e82ecfa58d0b6c178e4 URL: https://github.com/llvm/llvm-project/commit/f56cb520d8554ca42a215e82ecfa58d0b6c178e4 DIFF: https://github.com/llvm/llvm-project/commit/f56cb520d8554ca42a215e82ecfa58d0b6c178e4.dif

[PATCH] D119178: Add support for generating debug-info for structured bindings of structs and arrays

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf56cb520d855: [DEBUGINFO] [LLDB] Add support for generating debug-info for structured… (authored by shafik). Herald added projects: clang, LLDB. Rep

[PATCH] D116774: AST: Move __va_list tag back to std conditionally on AArch64.

aaron.ballman added a comment. Only a small nit from me. Comment at: clang/lib/AST/ASTContext.cpp:8555-8556 +// namespace std { struct __va_list { +NamespaceDecl *NS; +NS = NamespaceDecl::Create(const_cast(*Context), + Context->getTrans

[PATCH] D116774: AST: Move __va_list tag back to std conditionally on AArch64.

jrtc27 added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:8555-8556 +// namespace std { struct __va_list { +NamespaceDecl *NS; +NS = NamespaceDecl::Create(const_cast(*Context), + Context->getTranslationUnitDecl(), ---

[PATCH] D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

dyung added a comment. Hi, the test you added is failing on the PS4 Linux bot, can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/17199 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119207/new/ https://reviews.llvm.org/D11920

[PATCH] D116774: AST: Move __va_list tag back to std conditionally on AArch64.

aaron.ballman added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:8555-8556 +// namespace std { struct __va_list { +NamespaceDecl *NS; +NS = NamespaceDecl::Create(const_cast(*Context), + Context->getTranslationUnitDecl(),

[PATCH] D119309: [Driver][test] Clean up some AIX tests

MaskRay added a comment. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119309/new/ https://reviews.llvm.org/D119309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D119829: [Driver] Support Solaris/amd64 GetTls

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/solaris-ld-sanitizer.c:1 +// General tests that the ld -z relax=transtls workaround is only applied +// on Solaris/amd64. Note that we use

[PATCH] D116773: AST: Make getEffectiveDeclContext() a member function of ItaniumMangleContextImpl. NFCI.

This revision was automatically updated to reflect the committed changes. Closed by commit rG18ead23385a4: AST: Make getEffectiveDeclContext() a member function of… (authored by pcc). Changed prior to commit: https://reviews.llvm.org/D116773?vs=398007&id=409733#toc Repository: rG LLVM Github

[clang] 18ead23 - AST: Make getEffectiveDeclContext() a member function of ItaniumMangleContextImpl. NFCI.

Author: Peter Collingbourne Date: 2022-02-17T11:31:40-08:00 New Revision: 18ead23385a4e0e6421d658591b1ee6a1c592b53 URL: https://github.com/llvm/llvm-project/commit/18ead23385a4e0e6421d658591b1ee6a1c592b53 DIFF: https://github.com/llvm/llvm-project/commit/18ead23385a4e0e6421d658591b1ee6a1c592b53

[clang] 82e5f95 - AST: Move __va_list tag back to std conditionally on AArch64.

Author: Peter Collingbourne Date: 2022-02-17T11:31:40-08:00 New Revision: 82e5f951fd6e6ad6323067d8afcf025fc72d9c33 URL: https://github.com/llvm/llvm-project/commit/82e5f951fd6e6ad6323067d8afcf025fc72d9c33 DIFF: https://github.com/llvm/llvm-project/commit/82e5f951fd6e6ad6323067d8afcf025fc72d9c33

[PATCH] D116774: AST: Move __va_list tag back to std conditionally on AArch64.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG82e5f951fd6e: AST: Move __va_list tag back to std conditionally on AArch64. (authored by pcc). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D120078: Insert MIRProfile into LLD

Roger created this revision. Herald added subscribers: ormris, steven_wu, hiraditya. Roger requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D120078 Files: c

[PATCH] D116774: AST: Move __va_list tag back to std conditionally on AArch64.

pcc added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116774/new/ https://reviews.llvm.org/D116774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D119562: Provide fine control of color in run-clang-tidy

kesyog marked an inline comment as done. kesyog added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119562/new/ https://reviews.llvm.org/D119562 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D119184: [clang] [concepts] Check constrained-auto return types for void-returning functions

Quuxplusone updated this revision to Diff 409740. Quuxplusone added a comment. Rebase and update — this is becoming more and more of a trivial patch, which I guess is good! Add a test case for https://github.com/llvm/llvm-project/issues/53911 (which I finally thought to test, and was surprised t

[PATCH] D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

shangwuyao added a comment. In D119207#3330385 , @dyung wrote: > Hi, the test you added is failing on the PS4 Linux bot, can you take a look? > > https://lab.llvm.org/buildbot/#/builders/139/builds/17199 Looks like the compiled SPIR-V is slightly differe

[PATCH] D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

dyung added a comment. In D119207#3330494 , @shangwuyao wrote: > In D119207#3330385 , @dyung wrote: > >> Hi, the test you added is failing on the PS4 Linux bot, can you take a look? >> >> https://lab.llvm.org/bui

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood added a comment. Ping. Waiting for review feedback for about a week now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117522/new/ https://reviews.llvm.org/D117522 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D119601: [analyzer] Refactor makeNull to makeNullWithWidth

vabridgers updated this revision to Diff 409750. vabridgers added a comment. Address NoQ comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119601/new/ https://reviews.llvm.org/D119601 Files: clang/include/clang/StaticAnalyzer/Core/PathSensi

[clang] f5b85f1 - Use functions with prototypes when appropriate; NFC

Author: Aaron Ballman Date: 2022-02-17T15:33:50-05:00 New Revision: f5b85f15510db409277d8492524b2fc040e776d8 URL: https://github.com/llvm/llvm-project/commit/f5b85f15510db409277d8492524b2fc040e776d8 DIFF: https://github.com/llvm/llvm-project/commit/f5b85f15510db409277d8492524b2fc040e776d8.diff

[PATCH] D119601: [analyzer] Refactor makeNull to makeNullWithWidth

vabridgers marked 5 inline comments as done. vabridgers added a comment. I believe I've addressed all of Artem's comments thus far. This is a NFC patch, so will include no test cases. We detected these inconsistencies in getting NULL pointers in our downstream target, that supports 2 different p

[PATCH] D120065: [clang][SemaTemplate] Fix a stack use after scope

kadircet updated this revision to Diff 409752. kadircet marked 2 inline comments as done. kadircet added a comment. - Inline `Params.size()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120065/new/ https://reviews.llvm.org/D120065 Files: clang/

[PATCH] D120065: [clang][SemaTemplate] Fix a stack use after scope

kadircet added inline comments. Comment at: clang/include/clang/AST/DeclTemplate.h:2464 FriendTemplateDecl(DeclContext *DC, SourceLocation Loc, - MutableArrayRef Params, + TemplateParameterList **Params, unsigned NumParams,

[clang] c79c13c - [clang][SemaTemplate] Fix a stack use after scope

Author: Kadir Cetinkaya Date: 2022-02-17T21:47:50+01:00 New Revision: c79c13cae61564d3a03831013ea24ff483ee3e82 URL: https://github.com/llvm/llvm-project/commit/c79c13cae61564d3a03831013ea24ff483ee3e82 DIFF: https://github.com/llvm/llvm-project/commit/c79c13cae61564d3a03831013ea24ff483ee3e82.dif

[PATCH] D120065: [clang][SemaTemplate] Fix a stack use after scope

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc79c13cae615: [clang][SemaTemplate] Fix a stack use after scope (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D112081: Define __STDC_NO_THREADS__ when targeting windows-msvc (PR48704)

emmenlau added a comment. Current OpenSSL 1.1.1m requires `__STDC_NO_ATOMICS__` to build with clang-cl against MSVC. Is this on-topic here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112081/new/ https://reviews.llvm.org/D112081 ___

[PATCH] D112081: Define __STDC_NO_THREADS__ when targeting windows-msvc (PR48704)

rnk added a comment. In D112081#3330585 , @emmenlau wrote: > Current OpenSSL 1.1.1m requires `__STDC_NO_ATOMICS__` to build with clang-cl > against MSVC. Is this on-topic here? I think stdatomic.h is supposed to work with clang-cl, see this comment here

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

urnathan updated this revision to Diff 409761. urnathan added a subscriber: cfe-commits. urnathan added a comment. rebase on top of D116773 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118352/new/ https://reviews.llvm.org/D118352 Files: clang/inclu

[PATCH] D120081: [clang][ASTReader] Fix memory leak while reading FriendTemplateDecls

kadircet created this revision. kadircet added a reviewer: sammccall. kadircet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Allocate on ASTContext, rather than just on heap, so that template parameter lists are freed up. Repository:

[PATCH] D120034: [clang-format] PROPOSAL - WIP: Added ability to parse template arguments

owenpan added a comment. +1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120034/new/ https://reviews.llvm.org/D120034 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang] 331e8e4 - [clang-format] Do not add space after return-like keywords in macros.

Author: Marek Kurdej Date: 2022-02-17T22:12:39+01:00 New Revision: 331e8e4e27be5dd673898a89a7cf00e76903216a URL: https://github.com/llvm/llvm-project/commit/331e8e4e27be5dd673898a89a7cf00e76903216a DIFF: https://github.com/llvm/llvm-project/commit/331e8e4e27be5dd673898a89a7cf00e76903216a.diff

[PATCH] D120028: [clang-format] Do not add space after return-like keywords in macros.

This revision was automatically updated to reflect the committed changes. Closed by commit rG331e8e4e27be: [clang-format] Do not add space after return-like keywords in macros. (authored by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120

[PATCH] D119392: [Clang][OpenMP][Sema] Remove support for floating point values in atomic compare

ABataev added a comment. Tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119392/new/ https://reviews.llvm.org/D119392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D118632: [Clang]OpenMP] Add the codegen support for `atomic compare`

ABataev added inline comments. Comment at: clang/test/OpenMP/atomic_compare_codegen.cpp:6 + +// RUN: %clang_cc1 -verify -triple x86_64-apple-darwin10 -target-cpu core2 -fopenmp-simd -fopenmp-version=51 -x c -emit-llvm %s -o - | FileCheck --check-prefix SIMD-ONLY0 %s +// %clang_

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

ABataev added a comment. Erroneous tests? Comment at: clang/lib/Sema/SemaOpenMP.cpp:11320 + bool MutexClauseEncountered = false; + llvm::SmallSet EncounteredAtomicKinds; for (const OMPClause *C : Clauses) { tianshilei1992 wrote: > ABataev wrote: > > ABatae

[PATCH] D120084: [clang][DOC] Document module mangler changes

urnathan created this revision. urnathan added reviewers: ChuanqiXu, iains, rsmith. urnathan requested review of this revision. Note that the mangling has changed and the demangler's learnt a new trick. Obviously dependent upon the mangler and demangler patches. https://reviews.llvm.org/D12008

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 added a comment. We don't have Sema yet, so there is no erroneous test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116261/new/ https://reviews.llvm.org/D116261 ___ cfe-commits mailing l

[clang] 1689b10 - unbreak Modules/cxx20-export-import.cpp with LLVM_APPEND_VC_REV after 32b73bc6ab82

Author: Nico Weber Date: 2022-02-17T16:33:39-05:00 New Revision: 1689b1092ebb2c630f8ef1d3880a9fb4808d16fa URL: https://github.com/llvm/llvm-project/commit/1689b1092ebb2c630f8ef1d3880a9fb4808d16fa DIFF: https://github.com/llvm/llvm-project/commit/1689b1092ebb2c630f8ef1d3880a9fb4808d16fa.diff LO

[PATCH] D118632: [Clang]OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_compare_codegen.cpp:6 + +// RUN: %clang_cc1 -verify -triple x86_64-apple-darwin10 -target-cpu core2 -fopenmp-simd -fopenmp-version=51 -x c -emit-llvm %s -o

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

ABataev added a comment. In D116261#3330732 , @tianshilei1992 wrote: > We don't have Sema yet, so there is no erroneous test. But you have the checks for the clauses, repeated several times in a construct. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D120086: Explicitly document that `__is_trivially_relocatable(T)` implies that `T` is implicit-lifetime.

devin.jeanpierre created this revision. devin.jeanpierre added reviewers: rsmith, rjmccall. devin.jeanpierre requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previous change: D114732 The wording here might

[clang] 383ed82 - [clang] Pass more flags to ld64.lld

Author: Nico Weber Date: 2022-02-17T16:45:52-05:00 New Revision: 383ed82dd1f8c4ea7e88a4cf92dd918dda794854 URL: https://github.com/llvm/llvm-project/commit/383ed82dd1f8c4ea7e88a4cf92dd918dda794854 DIFF: https://github.com/llvm/llvm-project/commit/383ed82dd1f8c4ea7e88a4cf92dd918dda794854.diff LO

[PATCH] D119612: [clang] Pass more flags to ld64.lld

This revision was automatically updated to reflect the committed changes. Closed by commit rG383ed82dd1f8: [clang] Pass more flags to ld64.lld (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119612/n

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

thakis added a comment. I saw that test failing again. I could repro the problem locally and fixed it in 1689b1092ebb2c630f8ef1d3880a9fb4808d16fa . I guess this did make it into the pch somehow after all. But all good now. R

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

thakis closed this revision. thakis added a comment. If you put "Differential Revision: https://reviews.llvm.org/D109239"; instead of just "https://reviews.llvm.org/D109239"; in the commit message, phabricator will auto-close the review when the commit lands. Repository: rG LLVM Github Monor

[PATCH] D120086: Explicitly document that `__is_trivially_relocatable(T)` implies that `T` is implicit-lifetime.

Quuxplusone added a comment. FWIW, I think this is a good idea. I even think that the parentheses and "Note:" are too self-deprecating, and this deserves to be a bigger deal. Perhaps `__is_implicit_lifetime(T)` should be an intrinsic in its own right! Then you could say very concretely that `__

[PATCH] D119612: [clang] Pass more flags to ld64.lld

thakis added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119612/new/ https://reviews.llvm.org/D119612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D119479: [clang][extract-api] Add global record support

zixuw updated this revision to Diff 409783. zixuw added a comment. Use `%/t` for path substitution to normalize path separators for file URI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119479/new/ https://reviews.llvm.org/D119479 Files: clang/

[clang] 0e219af - [clang] Remove Address::deprecated() call in CGExprCXX.cpp

Author: Arthur Eubanks Date: 2022-02-17T13:58:26-08:00 New Revision: 0e219af475430ab338c9d76a101a78304a64f78a URL: https://github.com/llvm/llvm-project/commit/0e219af475430ab338c9d76a101a78304a64f78a DIFF: https://github.com/llvm/llvm-project/commit/0e219af475430ab338c9d76a101a78304a64f78a.diff

[PATCH] D119392: [Clang][OpenMP][Sema] Remove support for floating point values in atomic compare

tianshilei1992 updated this revision to Diff 409784. tianshilei1992 added a comment. add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119392/new/ https://reviews.llvm.org/D119392 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/a

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 updated this revision to Diff 409791. tianshilei1992 added a comment. add a small test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116261/new/ https://reviews.llvm.org/D116261 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/li

[PATCH] D120086: Explicitly document that `__is_trivially_relocatable(T)` implies that `T` is implicit-lifetime.

devin.jeanpierre updated this revision to Diff 409794. devin.jeanpierre added a comment. Rebase off of D119385 . Sorry, I'm bad at git. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120086/new/ https://reviews.llvm

[clang] ba9944e - [clang] Remove Address::deprecated() in CGCXXABI.h

Author: Arthur Eubanks Date: 2022-02-17T14:23:02-08:00 New Revision: ba9944ea1dff507839df8e4cf9897a5d4916ec68 URL: https://github.com/llvm/llvm-project/commit/ba9944ea1dff507839df8e4cf9897a5d4916ec68 DIFF: https://github.com/llvm/llvm-project/commit/ba9944ea1dff507839df8e4cf9897a5d4916ec68.diff

<    1   2   3   >