aaron.ballman added inline comments.
================
Comment at: clang/lib/AST/ASTContext.cpp:8555-8556
+ // namespace std { struct __va_list {
+ NamespaceDecl *NS;
+ NS = NamespaceDecl::Create(const_cast<ASTContext &>(*Context),
+ Context->getTranslationUnitDecl(),
----------------
jrtc27 wrote:
> aaron.ballman wrote:
> >
> Hm, the advantage of leaving it as it is is then it completely reverts
> D104830 (ignoring the added CFI test) rather than being written in a slightly
> different but equivalent way. Don't really care either way myself though,
> both have their merits.
I don't insist on the change; I mostly found it odd to have an uninitialized
local that is initialized on the very next line.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116774/new/
https://reviews.llvm.org/D116774
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
