[PATCH] D119599: Add option to align compound assignments like `+=`

HazardyKnusperkeks added a comment. I think we are going a very good way. Just some steps ahead. Comment at: clang/include/clang/Format/Format.h:157 + /// a &= 2; + /// bbb = 2; + /// sstwcw wrote: > HazardyKnusperkeks wrote: > > sstwcw wrote: > > > H

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

carlosgalvezp added a comment. In D112730#3316646 , @carlosgalvezp wrote: > Thanks a lot @tonic for your update and for the work done in the last months > ! It's indeed very sad to hear the news. It's a pity that the work will > probably be duplicated

[clang] e01f624 - [clang-format] Fix PointerAlignment within lambdas in a multi-variable declaration statement.

Author: Marek Kurdej Date: 2022-02-14T09:41:24+01:00 New Revision: e01f624adb0ed5d0f1369b0679a64484bac10d02 URL: https://github.com/llvm/llvm-project/commit/e01f624adb0ed5d0f1369b0679a64484bac10d02 DIFF: https://github.com/llvm/llvm-project/commit/e01f624adb0ed5d0f1369b0679a64484bac10d02.diff

[PATCH] D119648: [clang-format] Fix PointerAlignment within lambdas in a multi-variable declaration statement.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe01f624adb0e: [clang-format] Fix PointerAlignment within lambdas in a multi-variable… (authored by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[clang] e967d97 - [clang-format] Fix SpacesInLineCommentPrefix deleting tokens.

Author: Marek Kurdej Date: 2022-02-14T09:53:16+01:00 New Revision: e967d97a35a93c883528a9672159edff05f5addb URL: https://github.com/llvm/llvm-project/commit/e967d97a35a93c883528a9672159edff05f5addb DIFF: https://github.com/llvm/llvm-project/commit/e967d97a35a93c883528a9672159edff05f5addb.diff

[PATCH] D119680: [clang-format] Fix SpacesInLineCommentPrefix deleting tokens.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe967d97a35a9: [clang-format] Fix SpacesInLineCommentPrefix deleting tokens. (authored by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119680/new/

[PATCH] D119138: [clang-format] Further improve support for requires expressions

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119138/new/ https://reviews.llvm.org/D119138 ___ cfe-commits mailing list cfe-comm

[PATCH] D119656: [Driver][DragonFly] -r: imply -nostdlib like GCC

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119656/new/ https://reviews.llvm.org/D119656 _

[PATCH] D118700: Add support to --gcc-toolchain flag for GCC compiled with --enable-version-specific-runtime-libs.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. The library path (`lib/gcc/$triple/$libdir`) still looks weird and I think I don't understand the GCC rationale well. If you still think it's the right thing the do, let's do it. For driver

[PATCH] D119537: [clangd] Treat 'auto' params as deduced if there's a single instantiation.

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Very neat! A few minor suggestions but generally looks good. Comment at: clang-tools-extra/clangd/AST.cpp:519 + if (Spec->getTemplateSpecializationKind() != TSK_Implicit

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. My naming suggestion is not binding. I have no strong opinion on this, but a shorter name would get my 👍 :). So please sync with other reviewers. Comment at: clang

[PATCH] D119409: [C++20] [Modules] Remain variable's definition in module interface

ChuanqiXu added inline comments. Comment at: clang/test/CodeGenCXX/static-variable-in-module.cpp:2-8 +// RUN: mkdir %t +// RUN: echo "struct S { S(); };" >> %t/foo.h +// RUN: echo "static S s = S();" >> %t/foo.h +// RUN: %clang -std=c++20 -I%t %s -S -emit-llvm -o - | FileCheck %s

[PATCH] D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also

simon_tatham added a comment. I gave this patch a test against our downstream code, and found that it doesn't stop me needing the change I suggested in D119199 : in `clang/tools/driver/CMakeLists.txt`, I had to change if(CLANG_PLUGIN_SUPPORT) export_exec

[PATCH] D119655: [Driver][NetBSD] -r: imply -nostdlib like GCC

joerg added a comment. Well, it doesn't work with GCC either, that's why I don't care much about this change. It just attempts to legalize a user bug (using a linker option directly as a compiler flag). But I don't care enough to object either. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D119599: Add option to align compound assignments like `+=`

curdeius added a comment. I'd really want to see simpler tests and everything put into a single `AlignConsecutiveAssignment` option. Comment at: clang/include/clang/Format/Format.h:163 + /// \endcode + bool AlignCompoundAssignments; + HazardyKnusperkeks wrot

[PATCH] D119599: Add option to align compound assignments like `+=`

curdeius added a comment. @sstwcw, would it help if I created a parent revision that only splits the current enum-based option into a struct, so that you only add compound ops and padding? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/

[PATCH] D119701: [clangd] Re-enable clang-tidy's nolint blocks

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. The previous inefficient implementation is polished

[clang-tools-extra] fc84ebf - [clang-tidy] Ignore variable template partial specializations in `misc-definitions-in-headers`

Author: Evgeny Shulgin Date: 2022-02-14T11:38:27+01:00 New Revision: fc84ebfff3a3dd373129f465f2ad5763ed4423c6 URL: https://github.com/llvm/llvm-project/commit/fc84ebfff3a3dd373129f465f2ad5763ed4423c6 DIFF: https://github.com/llvm/llvm-project/commit/fc84ebfff3a3dd373129f465f2ad5763ed4423c6.diff

[PATCH] D119098: [clang-tidy] Ignore variable template partial specializations in `misc-definitions-in-headers`

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc84ebfff3a3: [clang-tidy] Ignore variable template partial specializations in `misc… (authored by Izaron, committed by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D114413: [OpenMPIRBuilder] Implement static-chunked workshare-loop schedules.

peixin added a comment. Except for three nits. LGTM. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1505 + /// valid in the condition block (i.e., defined in the preheader) and is + /// interpreted as an unsigned integer. + void setTripCount(Value *TripCount);

[PATCH] D119599: Add option to align compound assignments like `+=`

sstwcw added a comment. @curdeius That would be great. Comment at: clang/include/clang/Format/Format.h:163 + /// \endcode + bool AlignCompoundAssignments; + curdeius wrote: > HazardyKnusperkeks wrote: > > MyDeveloperDay wrote: > > > This option is not indepen

[PATCH] D119409: [C++20] [Modules] Remain variable's definition in module interface

urnathan added inline comments. Comment at: clang/test/CXX/modules-ts/basic/basic.def.odr/p4/module.cpp:5 // CHECK-DAG: @extern_var_exported = external {{(dso_local )?}}global -// CHECK-DAG: @inline_var_exported = linkonce_odr {{(dso_local )?}}global +// CHECK-DAG: @inline_var_e

[clang] c72fdad - [clang-format] Reformat. NFC.

Author: Marek Kurdej Date: 2022-02-14T14:05:05+01:00 New Revision: c72fdad71b6a9e5ca39fdcc7cb8bd476ecc5bbd7 URL: https://github.com/llvm/llvm-project/commit/c72fdad71b6a9e5ca39fdcc7cb8bd476ecc5bbd7 DIFF: https://github.com/llvm/llvm-project/commit/c72fdad71b6a9e5ca39fdcc7cb8bd476ecc5bbd7.diff

[PATCH] D109611: Fix CLANG_ENABLE_STATIC_ANALYZER=OFF building all analyzer source

hans added a comment. I tried cmake -GNinja -DCLANG_ENABLE_STATIC_ANALYZER=OFF -DLLVM_ENABLE_PROJECTS="llvm;clang;clang-tools-extra" -DCLANG_ENABLE_ARCMT=OFF ../llvm and verified that the breakage occurs at 6d7b3d6b3a8dbd62650b6c3dae1fe904a8ae9048

[PATCH] D119707: [C2x] Implement WG14 N2764 the [[noreturn]] attribute

aaron.ballman created this revision. aaron.ballman added reviewers: erichkeane, jyknight, rsmith. aaron.ballman requested review of this revision. Herald added a project: clang. This adds support for http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2764.pdf, which was adopted at the Feb 2022 WG1

[PATCH] D119574: [clang] Expose -fprofile-use in clang-cl

hans added a comment. In D119574#3316216 , @paulkirth wrote: > Hi, > > I think we hit a test failure due to this patch in Fuchsia's Clang canary for > Windows. We've had a lot of breakages on Windows today, so this was hidden > until 0574b5fc >

[clang] 76032b0 - Check for the overloadable attribute in all the appropriate syntactic locations

Author: Aaron Ballman Date: 2022-02-14T08:54:21-05:00 New Revision: 76032b0e3f58d4abe8d00ac61ff1b2044e076ba7 URL: https://github.com/llvm/llvm-project/commit/76032b0e3f58d4abe8d00ac61ff1b2044e076ba7 DIFF: https://github.com/llvm/llvm-project/commit/76032b0e3f58d4abe8d00ac61ff1b2044e076ba7.diff

[PATCH] D119664: Check for the overloadable attribute in all the appropriate syntactic locations

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks! I've commit in 76032b0e3f58d4abe8d00ac61ff1b2044e076ba7 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] f208644 - [CGBuilder] Remove CreateBitCast() method

Author: Nikita Popov Date: 2022-02-14T15:06:04+01:00 New Revision: f208644ed3618fb1db195adbd35ae0acf2819f23 URL: https://github.com/llvm/llvm-project/commit/f208644ed3618fb1db195adbd35ae0acf2819f23 DIFF: https://github.com/llvm/llvm-project/commit/f208644ed3618fb1db195adbd35ae0acf2819f23.diff

[PATCH] D119708: [clang][lex] Remove `PPCallbacks::FileNotFound()`

jansvoboda11 created this revision. jansvoboda11 added reviewers: ahoppen, Bigcheese, dexonsmith. Herald added subscribers: usaxena95, shchenz, kadircet, arphaman, kbarton, nemanjai. jansvoboda11 requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a sub

[PATCH] D119651: [clang] Fix evaluation context type for consteval function calls in instantiations

erichkeane added a comment. In D119651#3317619 , @Izaron wrote: >> Should we maybe always treat `PotentiallyEvaluated` as `ConstantEvaluated` >> in constant evaluated contexts? could that work ? > > Indeed, within this patch we can prevent similars bugs

[PATCH] D109611: Fix CLANG_ENABLE_STATIC_ANALYZER=OFF building all analyzer source

arichardson reopened this revision. arichardson added a comment. This revision is now accepted and ready to land. I will try to get back to this soon, but it will probably not be this week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109611/new/

[PATCH] D109611: Fix CLANG_ENABLE_STATIC_ANALYZER=OFF building all analyzer source

arichardson planned changes to this revision. arichardson added a comment. Have to fix `cmake -GNinja -DCLANG_ENABLE_STATIC_ANALYZER=OFF -DLLVM_ENABLE_PROJECTS="llvm;clang;clang-tools-extra" -DCLANG_ENABLE_ARCMT=OFF ../llvm` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D119710: [Docs][OpenCL] Release 14 notes

Anastasia created this revision. Anastasia added reviewers: svenvh, azabaznov. Herald added subscribers: Naghasan, ebevhan, yaxunl. Anastasia requested review of this revision. Summary of important changes for OpenCL in release 14. https://reviews.llvm.org/D119710 Files: clang/docs/ReleaseNot

[clang] 1aeb4c6 - [ItaniumCXXABI] Avoid pointer element type accesses

Author: Nikita Popov Date: 2022-02-14T15:17:14+01:00 New Revision: 1aeb4c6b5081944fd1e53a8f6ee0488ca33644c1 URL: https://github.com/llvm/llvm-project/commit/1aeb4c6b5081944fd1e53a8f6ee0488ca33644c1 DIFF: https://github.com/llvm/llvm-project/commit/1aeb4c6b5081944fd1e53a8f6ee0488ca33644c1.diff

[PATCH] D119528: [Clang][Sema] Add a missing regression test about Wliteral-range

aaron.ballman added a comment. In D119528#3316311 , @junaire wrote: >> I think we should probably have test coverage for `long double` as well, but >> I also wonder whether it makes sense to add coverage for the small >> floating-point types (like `_Flo

[PATCH] D119711: Add asan support for MSVC debug runtimes

lo1ol created this revision. lo1ol added a reviewer: rnk. lo1ol requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use special debug asan versions (prefixed with asan_dbg) for MSVC debug runtimes (/MTd, /MDd, /LDd). Resolves: https://github

[PATCH] D119710: [Docs][OpenCL] Release 14 notes

Anastasia added inline comments. Comment at: clang/docs/ReleaseNotes.rst:259-268 +OpenCL 3.0 (see :ref:`OpenCL 3.0 status page ` for more details): + +- Added parsing support for optionality of device side enqueue and blocks (not + fully incomplete yet!). +- Added missing suppor

[PATCH] D119713: [Docs] Release 14 notes for SPIR-V in clang

Anastasia created this revision. Anastasia added reviewers: svenvh, linjamaki. Herald added a subscriber: ebevhan. Anastasia requested review of this revision. Added important information about SPIR-V support in the upcoming release. https://reviews.llvm.org/D119713 Files: clang/docs/ReleaseN

[PATCH] D119713: [Docs] Release 14 notes for SPIR-V in clang

Anastasia added a comment. @linjamaki feel free to suggest other topics to document for the release. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119713/new/ https://reviews.llvm.org/D119713 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

ro updated this revision to Diff 408389. ro added a subscriber: nikic. ro added a comment. Since the build-time check for the `ld -z relax=transtls` option was met with massive resistance and was only necessary for Illumos anyway, this revision just uses it unconditionally. Tested on `amd64-pc-

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

ro added a comment. @vitalybuka , @MaskRay could I persuade you to review the revision version which should be much less controversial and completely Solaris-specific? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91605/new/ https://revi

[PATCH] D119714: [clang][lex] Remove `Preprocessor::GetCurDirLookup()`

jansvoboda11 created this revision. jansvoboda11 added reviewers: ahoppen, Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `Preprocessor` exposes the search directory iterator via `GetCurDirLookup()` get

[PATCH] D119462: [analyzer][NFCi] Use the correct BugType in CStringChecker.

phyBrackets added a comment. Hey @steakhal , any updates on this ? should I commit it ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119462/new/ https://reviews.llvm.org/D119462 ___ cfe-commits mailing

[clang] 5029dce - Implement WG14 N2764 the [[noreturn]] attribute

Author: Aaron Ballman Date: 2022-02-14T09:38:26-05:00 New Revision: 5029dce492b3cf3ac191eda0b5bf268c3acac2e0 URL: https://github.com/llvm/llvm-project/commit/5029dce492b3cf3ac191eda0b5bf268c3acac2e0 DIFF: https://github.com/llvm/llvm-project/commit/5029dce492b3cf3ac191eda0b5bf268c3acac2e0.diff

[PATCH] D119707: [C2x] Implement WG14 N2764 the [[noreturn]] attribute

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the quick review. I've landed in 5029dce492b3cf3ac191eda0b5bf268c3acac2e0 , but if anyone has post commit review comments (I landed this pretty quic

[clang] f037082 - Fix the Sphinx build

Author: Aaron Ballman Date: 2022-02-14T09:43:47-05:00 New Revision: f037082714a0fd48568a1f10ef3e4db8919e1523 URL: https://github.com/llvm/llvm-project/commit/f037082714a0fd48568a1f10ef3e4db8919e1523 DIFF: https://github.com/llvm/llvm-project/commit/f037082714a0fd48568a1f10ef3e4db8919e1523.diff

[PATCH] D119063: [SemaCXX] Properly scope ArgumentPackSubstitutionIndex when expanding base types

colavitam added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119063/new/ https://reviews.llvm.org/D119063 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D114421: [asan] Add support for disable_sanitizer_instrumentation attribute

melver added a comment. I think we dropped the ball on this - was it ever re-reverted? Is it still worth trying to land this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114421/new/ https://reviews.llvm.org/D114421 __

[PATCH] D119670: [clang] Warn on unqualified calls to std::move and std::forward

erichkeane added a comment. I'm not sure this is a 'good' enough warning (by design?) to allow in -Wall either, Wall seems to be only "this is definitely a mistake" type issues, and I don't think this issue rises to that requirement (though others are likely more qualified than I to judge). I

[PATCH] D118753: [PowerPC] Fix __builtin_pdepd and __builtin_pextd to be 64-bit and P10 only.

amyk added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118753/new/ https://reviews.llvm.org/D118753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D119462: [analyzer][NFCi] Use the correct BugType in CStringChecker.

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. I think yes, go ahead! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119462/new/ https://reviews.llvm.org/D119462 _

[PATCH] D119716: [clang][lex] NFC: De-duplicate some #include_next logic

jansvoboda11 created this revision. jansvoboda11 added reviewers: ahoppen, Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch addresses a FIXME and de-duplicates some `#include_next` logic Depend

[PATCH] D119612: [clang] Pass more flags to ld64.lld

lgrey added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:242 } else if (D.getLTOMode() == LTOK_Thin) // If we are using thin LTO, then create a directory instead. TmpPathName = D.GetTemporaryDirectory("thinlto"); thakis w

[PATCH] D119528: [Clang][Sema] Add a missing regression test about Wliteral-range

junaire updated this revision to Diff 408407. junaire added a comment. Add triple info to avoid tests failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119528/new/ https://reviews.llvm.org/D119528 Files: clang/test/Sema/warn-literal-range.c

[PATCH] D119719: [Docs][OpenCL] Update OpenCL 3.0 status on release 14

Anastasia created this revision. Anastasia added reviewers: svenvh, azabaznov. Herald added subscribers: Naghasan, ebevhan, yaxunl. Anastasia requested review of this revision. This update only includes what is available on the release 14 branch. Note that this table might need to be updated to a

[PATCH] D119528: [Clang][Sema] Add a missing regression test about Wliteral-range

junaire added a comment. In D119528#3318913 , @aaron.ballman wrote: > In D119528#3316311 , @junaire wrote: > >>> I think we should probably have test coverage for `long double` as well, >>> but I also wonder whe

[PATCH] D117566: [clang][lex] Introduce `SearchDirIterator`

jansvoboda11 updated this revision to Diff 408411. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117566/new/ https://reviews.llvm.org/D117566 Files: clang/include/clang/Lex/HeaderSearch.h clang/include/clan

[clang] 6745b6a - [analyzer][NFCi] Use the correct BugType in CStringChecker.

Author: phyBrackets Date: 2022-02-14T20:54:59+05:30 New Revision: 6745b6a0f18523d6b871f627ceb46a92b7c2c43d URL: https://github.com/llvm/llvm-project/commit/6745b6a0f18523d6b871f627ceb46a92b7c2c43d DIFF: https://github.com/llvm/llvm-project/commit/6745b6a0f18523d6b871f627ceb46a92b7c2c43d.diff L

[PATCH] D119462: [analyzer][NFCi] Use the correct BugType in CStringChecker.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6745b6a0f185: [analyzer][NFCi] Use the correct BugType in CStringChecker. (authored by phyBrackets). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119462/new

[PATCH] D119462: [analyzer][NFCi] Use the correct BugType in CStringChecker.

phyBrackets added a comment. In D119462#3319031 , @steakhal wrote: > I think yes, go ahead! Thanks ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119462/new/ https://reviews.llvm.org/D119462 ___

[PATCH] D119721: [clang][lex] Use `ConstSearchDirIterator` in lookup cache

jansvoboda11 created this revision. jansvoboda11 added reviewers: ahoppen, Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch starts using the new iterator type in `ConstSearchDirIterator`. Depen

[PATCH] D119722: [clang][lex] Use `SearchDirIterator` types in for loops

jansvoboda11 created this revision. jansvoboda11 added reviewers: ahoppen, Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch replaces a lot of index-based loops with iterators and ranges. Depend

[PATCH] D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum

lenary added a comment. @kparzysz I've tagged you due to the changes in RDFGraph, which I believe you are the owner of. The asserts are hit in `llvm/test/CodeGen/ARM/inlineasm-error-t-toofewregs.ll` - the Register Allocator Chokes on the test due to not having enough registers for the inline a

[PATCH] D119710: [Docs][OpenCL] Release 14 notes

svenvh added inline comments. Comment at: clang/docs/ReleaseNotes.rst:262 +- Added parsing support for optionality of device side enqueue and blocks (not + fully incomplete yet!). +- Added missing support for optionality of various builtin functions: incomplete

[PATCH] D119670: [clang] Warn on unqualified calls to std::move and std::forward

Quuxplusone added a comment. Tangential data point: I hacked up this check to find //all// unqualified `std` functions and ran it on libc++'s tests and also on some of my own codebase (including re2, asio, protobuf). I'm fixing the issues it turned up in libc++'s tests. In the other codebases,

[clang] 744745a - [analyzer] Add failing test case demonstrating buggy taint propagation

Author: Balazs Benics Date: 2022-02-14T16:55:55+01:00 New Revision: 744745ae195f0997e5bfd5aa2de47b9ea156b6a6 URL: https://github.com/llvm/llvm-project/commit/744745ae195f0997e5bfd5aa2de47b9ea156b6a6 DIFF: https://github.com/llvm/llvm-project/commit/744745ae195f0997e5bfd5aa2de47b9ea156b6a6.diff

[clang] b099e1e - [analyzer] Fix taint propagation by remembering to the location context

Author: Balazs Benics Date: 2022-02-14T16:55:55+01:00 New Revision: b099e1e562555fbc67e2e0abbc15074e14a85ff1 URL: https://github.com/llvm/llvm-project/commit/b099e1e562555fbc67e2e0abbc15074e14a85ff1 DIFF: https://github.com/llvm/llvm-project/commit/b099e1e562555fbc67e2e0abbc15074e14a85ff1.diff

[clang] bf5963b - [analyzer] Fix taint rule of fgets and setproctitle_init

Author: Balazs Benics Date: 2022-02-14T16:55:55+01:00 New Revision: bf5963bf19670ea58facdf57492e147c13bb650f URL: https://github.com/llvm/llvm-project/commit/bf5963bf19670ea58facdf57492e147c13bb650f DIFF: https://github.com/llvm/llvm-project/commit/bf5963bf19670ea58facdf57492e147c13bb650f.diff

[PATCH] D118987: [analyzer] Add failing test case demonstrating buggy taint propagation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG744745ae195f: [analyzer] Add failing test case demonstrating buggy taint propagation (authored by steakhal). Herald added a project: clang. Herald ad

[PATCH] D119128: [analyzer] Fix taint propagation by remembering to the location context

This revision was automatically updated to reflect the committed changes. Closed by commit rGb099e1e56255: [analyzer] Fix taint propagation by remembering to the location context (authored by steakhal). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM G

[PATCH] D119129: [analyzer] Fix taint rule of fgets and setproctitle_init

This revision was automatically updated to reflect the committed changes. Closed by commit rGbf5963bf1967: [analyzer] Fix taint rule of fgets and setproctitle_init (authored by steakhal). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[clang] a31d00d - Fix test failure for targets with varying uwtable defaults

Author: Momchil Velikov Date: 2022-02-14T15:59:26Z New Revision: a31d00ddceb057291ef3a094c57ae36975e804fe URL: https://github.com/llvm/llvm-project/commit/a31d00ddceb057291ef3a094c57ae36975e804fe DIFF: https://github.com/llvm/llvm-project/commit/a31d00ddceb057291ef3a094c57ae36975e804fe.diff LO

[PATCH] D119724: Fix test failure for targets with varying uwtable defaults

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa31d00ddceb0: Fix test failure for targets with varying uwtable defaults (authored by chill). Herald added a project: clang. Herald added a subscribe

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

Quuxplusone added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:4007 + * ``bool AfterRequiresKeywordInRequiresClause`` If ``true``, put space between requires keyword in a requires clause and +opening parentheses, if there is one. cu

[PATCH] D119670: [clang] Warn on unqualified calls to std::move and std::forward

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:6437 + NamedDecl *D = dyn_cast_or_null(Call->getCalleeDecl()); + if (!D || !D->isInStdNamespace()) +return; Quuxplusone wrote: > erichkeane wrote: > > Do we really want this? I guess

[PATCH] D119726: [asan] Add support for disable_sanitizer_instrumentation attribute

glider created this revision. glider added a reviewer: melver. Herald added a subscriber: hiraditya. glider requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. For ASan this will effectively serve as a synonym for __attribute_

[PATCH] D119541: [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-ISA features back after implication

rogfer01 added inline comments. Comment at: clang/test/Driver/riscv-default-features.c:4 +// RV32: "target-features"="+a,+c,+m,+relax,-save-restore" +// RV64: "target-features"="+64bit,+a,+c,+m,+relax,-save-restore" + I think we may be missing are missing a `RUN`

[PATCH] D119670: [clang] Warn on unqualified calls to std::move and std::forward

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:6437 + NamedDecl *D = dyn_cast_or_null(Call->getCalleeDecl()); + if (!D || !D->isInStdNamespace()) +return; erichkeane wrote: > Quuxplusone wrote: > > erichkeane wrote: > > > Do we real

[PATCH] D119727: [RISCV] Add the policy operand for nomask vector Multiply-Add IR intrinsics.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, frasercrmck, kito-cheng, arcbbb, monkchiang, eopXD. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewe

[PATCH] D114543: Extend the `uwtable` attribute with unwind table kind

durin42 added a comment. As far as I can tell this patch broke the Rust compiler, but from the commit message it sounds like it shouldn't have? https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/builds/8358#e85ad6f3-9992-4ea1-9cd3-d8db9f45f33e fails with Attribute 'uwtable' sho

[PATCH] D119670: [clang] Warn on unqualified calls to std::move and std::forward

Quuxplusone added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:6437 + NamedDecl *D = dyn_cast_or_null(Call->getCalleeDecl()); + if (!D || !D->isInStdNamespace()) +return; cor3ntin wrote: > erichkeane wrote: > > Quuxplusone wrote: > > > erichkean

[clang] 528deed - [clang] [test] Fix an apparent typo in SemaCXX/consteval-return-void.cpp.

Author: Arthur O'Dwyer Date: 2022-02-14T11:28:23-05:00 New Revision: 528deedd582f6f11cf1bba478e5e4645f4baf04f URL: https://github.com/llvm/llvm-project/commit/528deedd582f6f11cf1bba478e5e4645f4baf04f DIFF: https://github.com/llvm/llvm-project/commit/528deedd582f6f11cf1bba478e5e4645f4baf04f.diff

[clang] 3c8d2aa - [clang] Don't emit redundant warnings for 'return; '

Author: Arthur O'Dwyer Date: 2022-02-14T11:28:32-05:00 New Revision: 3c8d2aa87c1701ca16e13f06aea484637e03d005 URL: https://github.com/llvm/llvm-project/commit/3c8d2aa87c1701ca16e13f06aea484637e03d005 DIFF: https://github.com/llvm/llvm-project/commit/3c8d2aa87c1701ca16e13f06aea484637e03d005.diff

[PATCH] D119094: [clang] Don't emit redundant warnings for 'return;'

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c8d2aa87c17: [clang] Don't emit redundant warnings for 'return;' (authored by arthur.j.odwyer). Changed prior to commit: https://reviews.llvm.org/D119094?vs=406838&id=408434#toc Repository: rG LLVM

[PATCH] D119670: [clang] Warn on unqualified calls to std::move and std::forward

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:6437 + NamedDecl *D = dyn_cast_or_null(Call->getCalleeDecl()); + if (!D || !D->isInStdNamespace()) +return; Quuxplusone wrote: > cor3ntin wrote: > > erichkeane wrote: > > > Quuxplusone

[PATCH] D119707: [C2x] Implement WG14 N2764 the [[noreturn]] attribute

jyknight added inline comments. Comment at: clang/lib/Headers/stdnoreturn.h:19 +/* The noreturn macro is deprecated in C2x. */ +#pragma clang deprecated(noreturn) + Is this actually useful? Isn't it sufficient to have the include-time warning for this header?

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:4007 + * ``bool AfterRequiresKeywordInRequiresClause`` If ``true``, put space between requires keyword in a requires clause and +

[PATCH] D119716: [clang][lex] NFC: De-duplicate some #include_next logic

ahoppen added inline comments. Comment at: clang/include/clang/Lex/Preprocessor.h:2207 + const FileEntry *&LookupFromFile) const; + /// Install the standard preprocessor pragmas: I there a reason why this uses an out parameter instead

[PATCH] D114543: Extend the `uwtable` attribute with unwind table kind

chill added a comment. In D114543#3319347 , @durin42 wrote: > As far as I can tell this patch broke the Rust compiler, but from the commit > message it sounds like it shouldn't have? > > https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/bu

[PATCH] D114543: Extend the `uwtable` attribute with unwind table kind

durin42 added a comment. In D114543#3319576 , @chill wrote: > In D114543#3319347 , @durin42 wrote: > >> As far as I can tell this patch broke the Rust compiler, but from the commit >> message it sounds like it sh

[PATCH] D119574: [clang] Expose -fprofile-use in clang-cl

paulkirth added a comment. Sorry, that bot is green now as of 437d4e01fe4c057509dff30efd560049ad07bc99 , so it looks like it was just bad timing that led me to suspect your commit, since it touched the test file. I'm not sure

[PATCH] D119721: [clang][lex] Use `ConstSearchDirIterator` in lookup cache

ahoppen added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:710 + CacheLookup.HitIt = HitIt; + noteLookupUsage(&*HitIt - &*search_dir_begin(), Loc); } I haven’t looked into this in total details but `&*` looks a little awkward to me. Dereference

[clang] 00cd6c0 - [Preprocessor] Reduce the memory overhead of `#define` directives (Recommit)

Author: Alex Lorenz Date: 2022-02-14T09:27:44-08:00 New Revision: 00cd6c04202acf71f74c670b2dd4343929d1f45f URL: https://github.com/llvm/llvm-project/commit/00cd6c04202acf71f74c670b2dd4343929d1f45f DIFF: https://github.com/llvm/llvm-project/commit/00cd6c04202acf71f74c670b2dd4343929d1f45f.diff L

[PATCH] D119707: [C2x] Implement WG14 N2764 the [[noreturn]] attribute

aaron.ballman added inline comments. Comment at: clang/lib/Headers/stdnoreturn.h:19 +/* The noreturn macro is deprecated in C2x. */ +#pragma clang deprecated(noreturn) + jyknight wrote: > Is this actually useful? Isn't it sufficient to have the include-time warni

[PATCH] D114543: Extend the `uwtable` attribute with unwind table kind

chill added a comment. In D114543#3319587 , @durin42 wrote: > > Is the parameter optional if uwtable is set programmatically, or only when > we're reading IR streams? No, it's not optional, the attribute is added by https://github.com/llvm/llvm-pro

[PATCH] D119722: [clang][lex] Use `SearchDirIterator` types in for loops

ahoppen added a comment. Nice. I think this reads a lot better than the index-based implementation. Comment at: clang/lib/Lex/HeaderSearch.cpp:1450 Optional HeaderSearch::searchDirIdx(const DirectoryLookup &DL) const { - for (unsigned I = 0; I < SearchDirs.size(); ++I) -

[PATCH] D114543: Extend the `uwtable` attribute with unwind table kind

durin42 added a comment. In D114543#3319638 , @chill wrote: > In D114543#3319587 , @durin42 wrote: > >> > > > >> Is the parameter optional if uwtable is set programmatically, or only when >> we're reading IR str

[PATCH] D119509: [analyzer] Fix a crash in NoStateChangeVisitor with body-farmed stack frames.

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119509/new/ https://reviews.llvm.org/D119509 ___ cfe-commits mailing list cfe-co

[PATCH] D119708: [clang][lex] Remove `PPCallbacks::FileNotFound()`

ahoppen accepted this revision. ahoppen added a comment. This revision is now accepted and ready to land. Assuming that this is indeed never used, removing dead code always sounds good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119708/new

  1   2   3   >