simon_tatham added a comment.
I gave this patch a test against our downstream code, and found that it doesn't
stop me needing the change I suggested in D119199
<https://reviews.llvm.org/D119199>: in `clang/tools/driver/CMakeLists.txt`, I
had to change
if(CLANG_PLUGIN_SUPPORT)
export_executable_symbols_for_plugins(clang)
endif()
``` so that the if statement reads
```if(CLANG_PLUGIN_SUPPORT OR LLVM_EXPORT_SYMBOLS_FOR_PLUGINS)
because otherwise, the clang/examples builds will still try to link against the
clang executable target, which needs its symbols to have been exported.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119591/new/
https://reviews.llvm.org/D119591
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
