[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3299-3301 +: Warning<" %0 byte requested alignment for a struct member used as an" + " argument is 16 bytes or greater which is not binary" + " compatible wit

[PATCH] D119184: [clang] [concepts] Check constrained-auto return types for void-returning functions

Quuxplusone updated this revision to Diff 406847. Quuxplusone added a comment. Update one additional test where the expected output has changed: auto& f() { } now produces "can't make a reference to void" instead of "can't deduce `auto&` from no return statements." I think this is a mild regr

[PATCH] D117994: [Clang] Implement multidimentional subscript operator

cor3ntin added a comment. @erichkeane Thanks for the review! I had to rebase. I also updated the cxx_status page. @aaron.ballman If it looks good to you to, feel free to commit whenever you can. Thanks :D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain

qiucf added a comment. In D112906#3304340 , @jwakely wrote: >> GCC 12 should have proper support for IEEE-754 compliant 128-bit floating >> point in libstdc++. > > Yes, but it's unconditionally disabled when including the headers with Clang. Is that bec

[PATCH] D118977: [NVPTX] Add more FMA intriniscs/builtins

jchlanda updated this revision to Diff 406851. jchlanda added a comment. Add sm/ptx version guard to f16{x2} builtins. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118977/new/ https://reviews.llvm.org/D118977 Files: clang/include/clang/Basic/Bu

[PATCH] D118977: [NVPTX] Add more FMA intriniscs/builtins

jchlanda added a comment. In D118977#3302158 , @tra wrote: > In D118977#3299974 , @jchlanda > wrote: > >>> Target ISA Notes >>> Requires sm_53 or higher. > > I think we do need this constraint applied to the new

[PATCH] D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests

vtjnash updated this revision to Diff 406856. vtjnash added a comment. ensure CLANG_PLUGIN_SUPPORT setting is compatible with llvm_add_library Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119199/new/ https://reviews.llvm.org/D119199 Files: cl

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

aaron.ballman added a comment. I still have some naming issues that need to be corrected, but functionally I think this is good to go. I presume you don't have commit privileges @steffenlarsen? If that's accurate, what name and email address would you like me to use for patch attribution after

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118350/new/ https://reviews.llvm.org/D118350 _

[clang] 620d99b - Revert "[analyzer] Prevent misuses of -analyze-function"

Author: Balazs Benics Date: 2022-02-08T17:42:46+01:00 New Revision: 620d99b7edc64ee87b1ce209f179305e6a919006 URL: https://github.com/llvm/llvm-project/commit/620d99b7edc64ee87b1ce209f179305e6a919006 DIFF: https://github.com/llvm/llvm-project/commit/620d99b7edc64ee87b1ce209f179305e6a919006.diff

[PATCH] D118690: [analyzer] Prevent misuses of -analyze-function

steakhal reopened this revision. steakhal added a comment. This revision is now accepted and ready to land. Ah, it seems like pinning the target triple was not enough. I'm stuck at this point. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118690/new

[PATCH] D119256: [OpenMP][Clang] Move partial support of reverse offload to a future version

saiislam created this revision. saiislam added reviewers: ABataev, jdoerfert, JonChesterfield. Herald added subscribers: guansong, yaxunl. saiislam requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. OpenMP Spec 5.2

[PATCH] D119216: [AMDGPU] replace hostcall module flag with function attribute

sameerds updated this revision to Diff 406860. sameerds added a comment. further simplified the callback return value; moved hostcall info out of the subtarget Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119216/new/ https://reviews.llvm.org/D119

[PATCH] D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain

jwakely added a comment. In D112906#3304925 , @qiucf wrote: > Is that because clang lacks something required by this feature? (for example. > clang-12 doesn't have `__ibm128` and many builtins) If so, clang-14 should > have these fixed. When I implemen

[PATCH] D119250: [RISCV][NFC] Refactor RISCVISAInfo.

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119250/new/ https://reviews.llvm.org/D119250 ___

[clang] 5d8d3a1 - [NFC] Increase initial size of FoldingSets used in ASTContext and CodeGenTypes

Author: Dawid Jurczak Date: 2022-02-08T17:54:04+01:00 New Revision: 5d8d3a11c4d4ed8bb610f60f8fa37b8043a40acd URL: https://github.com/llvm/llvm-project/commit/5d8d3a11c4d4ed8bb610f60f8fa37b8043a40acd DIFF: https://github.com/llvm/llvm-project/commit/5d8d3a11c4d4ed8bb610f60f8fa37b8043a40acd.diff

[PATCH] D118608: [NFC] Increase initial size of FoldingSets used in ASTContext and CodeGenTypes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d8d3a11c4d4: [NFC] Increase initial size of FoldingSets used in ASTContext and CodeGenTypes (authored by yurai007). Repository: rG LLVM Github Mo

[PATCH] D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain

qiucf added a comment. In D112906#3305014 , @jwakely wrote: > In D112906#3304925 , @qiucf wrote: > >> Is that because clang lacks something required by this feature? (for >> example. clang-12 doesn't have `__ibm1

[PATCH] D113319: [clang-format] Improve require and concept handling

Mordante added inline comments. Comment at: clang/lib/Format/Format.cpp:1212 LLVMStyle.ReferenceAlignment = FormatStyle::RAS_Pointer; + // This is open for discussions! When will LLVM adapt C++20? + LLVMStyle.RequiresClausePositionForClasses = FormatStyle::RCPS_OwnLine;

[PATCH] D119216: [AMDGPU] replace hostcall module flag with function attribute

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:198 +const auto *STI = TM.getMCSubtargetInfo(); +return llvm::AMDGPU::getHostcallImplicitArgPosition(STI); + } arsenm wrote: > The ABI should not be a property of the s

[PATCH] D119216: [AMDGPU] replace hostcall module flag with function attribute

sameerds added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:198 +const auto *STI = TM.getMCSubtargetInfo(); +return llvm::AMDGPU::getHostcallImplicitArgPosition(STI); + } arsenm wrote: > The ABI should not be a property of the

[PATCH] D119216: [AMDGPU] replace hostcall module flag with function attribute

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:198 +const auto *STI = TM.getMCSubtargetInfo(); +return llvm::AMDGPU::getHostcallImplicitArgPosition(STI); + } arsenm wrote: > sameerds wrote: > > arsenm wrote: > > > T

[clang] 2ecda9e - [Hexagon] Alter meaning of versionless -mhvx

Author: Krzysztof Parzyszek Date: 2022-02-08T09:06:15-08:00 New Revision: 2ecda9ec9cc89b87ce2e56452229c9444beabf21 URL: https://github.com/llvm/llvm-project/commit/2ecda9ec9cc89b87ce2e56452229c9444beabf21 DIFF: https://github.com/llvm/llvm-project/commit/2ecda9ec9cc89b87ce2e56452229c9444beabf21

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

nickdesaulniers added inline comments. Comment at: llvm/lib/Target/X86/X86FrameLowering.cpp:595 +continue; + XorOp = X86::PXORrr; +} else if (X86::VR256RegClass.contains(Reg)) { void wrote: > nickdesaulniers wrote: > > Is there any way to figure

[PATCH] D118690: [analyzer] Prevent misuses of -analyze-function

NoQ added a comment. Can you post a link to a specific buildbot failure so that we could look at it together? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118690/new/ https://reviews.llvm.org/D118690 _

[clang-tools-extra] c151225 - [C++2b] Implement multidimentional subscript operator

Author: Corentin Jabot Date: 2022-02-08T12:10:47-05:00 New Revision: c1512250960bd247519a9f959ad4af202402dcc4 URL: https://github.com/llvm/llvm-project/commit/c1512250960bd247519a9f959ad4af202402dcc4 DIFF: https://github.com/llvm/llvm-project/commit/c1512250960bd247519a9f959ad4af202402dcc4.diff

[PATCH] D117994: [Clang] Implement multidimentional subscript operator

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks! I've commit on your behalf in c1512250960bd247519a9f959ad4af202402dcc4 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D119256: [OpenMP][Clang] Move partial support of reverse offload to a future version

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119256/new/ https://reviews.llvm.org/D119256 ___

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 updated this revision to Diff 406867. tianshilei1992 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116261/new/ https://reviews.llvm.org/D116261 Files: clang/include/clang/AST/OpenMPClause.h clang/include/

[PATCH] D119234: [clang] [MinGW] Recognize -lcrtdll as a library replacing -lmsvcrt

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119234/new/ https://reviews.llvm.org/D119234 ___ cfe-c

[PATCH] D118690: [analyzer] Prevent misuses of -analyze-function

steakhal added a comment. In D118690#3305086 , @NoQ wrote: > Can you post a link to a specific buildbot failure so that we could look at > it together? Sure! I received these three mails: https://lab.llvm.org/buildbot#builders/67/builds/5824 https://la

[PATCH] D119201: [clang][Fuchsia] Ensure static sanitizer libs are only linked in after the -nostdlib check

leonardchan updated this revision to Diff 406871. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119201/new/ https://reviews.llvm.org/D119201 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/lib/Driver/ToolChains/Fuchsia.cpp Index: clang

[PATCH] D119257: Revert "Re-land [LLD] Remove global state in lldCommon"

krzysz00 created this revision. krzysz00 added reviewers: aganea, MaskRay. Herald added subscribers: sdasgup3, wenzhicui, wrengr, Chia-hungDuan, ormris, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, csig

[PATCH] D119201: [clang][Fuchsia] Ensure static sanitizer libs are only linked in after the -nostdlib check

leonardchan marked an inline comment as done. leonardchan added a comment. In D119201#3303275 , @phosek wrote: > Have you checked if all the tests are still passing? All the clang tests seem to be passing, but I'll run the llvm and runtimes tests also.

[PATCH] D84225: [CFE] Add nomerge function attribute to inline assembly.

rnk added a comment. In D84225#3304189 , @pengfei wrote: > It's not a workaround. We do need to avoid the merging sometime. For example, > given we have 2 branches begin with inline asm of `endbr`. We have to use > `nomerge` to stop them been merged out

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

steffenlarsen updated this revision to Diff 406868. steffenlarsen added a comment. Recent changes: - Renamed `isArgMemberExprHolder` to `isParamExpr` and added the comment suggested by @aaron.ballman . - Made `checkASCIIStringLiteralExpr` an overload of `checkStringLiteralArgumentAttr`. CHANG

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:2277 +/// clauses. +class OMPCompareCaptureClause : public OMPClause { +public: `final` Comment at: clang/lib/AST/OpenMPClause.cpp:1804 +void OMPClausePrinter::Vi

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

steffenlarsen added a comment. Thanks, @aaron.ballman ! I have applied the new suggestions. > I presume you don't have commit privileges @steffenlarsen? If that's > accurate, what name and email address would you like me to use for patch > attribution after you've fixed the last few bits? That

[PATCH] D119178: Add support for generating debug-info for structured bindings of structs and arrays

aprantl added a comment. I think this looks pretty good! I have a few questions inside. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4667 + + SmallVector Expr; + AppendAddressSpaceXDeref(AddressSpace, Expr); 13 seems to be unnecessarily high. Shouldn't 1 be

[PATCH] D119201: [clang][Fuchsia] Ensure static sanitizer libs are only linked in after the -nostdlib check

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:158-160 +bool NeedsXRayDeps = addXRayRuntime(ToolChain, Args, CmdArgs); if (NeedsXRayDeps) linkXRayRu

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Thank you for all the good discussion and work on this! I'll commit on your behalf once the precommit CI pipeline comes back green. CHANGES SINCE LAST ACTION https://rev

[PATCH] D119215: [clang] Properly cache member pointer LLVM types

rnk added a comment. Seems reasonable Comment at: clang/lib/CodeGen/CodeGenTypes.cpp:776 + auto *C = MPTy->getClass(); + auto I = RecordsWithOpaqueMemberPointers.find(C); + if (I == RecordsWithOpaqueMemberPointers.end()) { Can this use something

[PATCH] D72404: [ThinLTO/FullLTO] Support Os and Oz

steven_wu added a comment. I just saw this. I know it is a good idea to have choice during link time for the pipeline configuration and from your benchmark it also has size impact on the output. I also feel like this is going in the wrong direction as if I have part of the object files built wi

[PATCH] D118862: [clang][driver] add clang driver support for emitting macho files with two build version load commands

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118862/new/ https://reviews.llvm.org/D118862 _

[PATCH] D72404: [ThinLTO/FullLTO] Support Os and Oz

mehdi_amini added a comment. In D72404#3304205 , @aykevl wrote: > I would be very interested in this patch, because for me to use ThinLTO > without size regressions I need to set the optimization size level in the > linker (`PassManagerBuilder.SizeLevel`

[PATCH] D119257: Revert "Re-land [LLD] Remove global state in lldCommon"

krzysz00 added a comment. @aganea Can we expect fixes for both the issues with this revision (the HIP-on-Windows problems noted last night and the MLIR breakage) shortly or should we revert while y'all work out fixes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

rjmccall added a comment. I'm not sure your new wording is any clearer; a In D118804#3304337 , @urnathan wrote: > In D118804#3304280 , @aaron.ballman > wrote: > >> In D118804#3304261

[PATCH] D118428: [clang-cl] Support the /JMC flag

hans added inline comments. Comment at: llvm/lib/CodeGen/JMCInstrumenter.cpp:180 + "JMC instrument more than once?"); + FunctionCallee Fn = + M.getOrInsertFunction(CheckFunctionName, getCheckFunctionType(Ctx)); might as well get the Func

[PATCH] D119216: [AMDGPU] replace hostcall module flag with function attribute

sameerds updated this revision to Diff 406889. sameerds added a comment. added tests for i128 load. hostcall position is now independent of subtarget. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119216/new/ https://reviews.llvm.org/D119216 Files

[PATCH] D119216: [AMDGPU] replace hostcall module flag with function attribute

jdoerfert added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:566 + return false; +}; + sameerds wrote: > jdoerfert wrote: > > jdoerfert wrote: > > > sameerds wrote: > > > > jdoerfert wrote: > > > > > You can use AAPointerInfo

[PATCH] D119216: [AMDGPU] replace hostcall module flag with function attribute

jdoerfert requested changes to this revision. jdoerfert added a comment. This revision now requires changes to proceed. @kpyzhov Usually people don't accept without comment, especially if there is clearly ongoing discussion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[clang] ead1690 - Allow parameter pack expansions and initializer lists in annotate attribute

Author: Steffen Larsen Date: 2022-02-08T13:38:07-05:00 New Revision: ead1690d31f815c00fdd2bc23db4766191bbeabc URL: https://github.com/llvm/llvm-project/commit/ead1690d31f815c00fdd2bc23db4766191bbeabc DIFF: https://github.com/llvm/llvm-project/commit/ead1690d31f815c00fdd2bc23db4766191bbeabc.diff

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit on your behalf in ead1690d31f815c00fdd2bc23db4766191bbeabc , thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114439/new/ https:/

[clang] 4ac58b6 - [clang][Fuchsia] Ensure static sanitizer libs are only linked in after the -nostdlib check

Author: Leonard Chan Date: 2022-02-08T10:53:22-08:00 New Revision: 4ac58b61022d128d60ffea06c20611b8eaf8601a URL: https://github.com/llvm/llvm-project/commit/4ac58b61022d128d60ffea06c20611b8eaf8601a DIFF: https://github.com/llvm/llvm-project/commit/4ac58b61022d128d60ffea06c20611b8eaf8601a.diff

[PATCH] D119201: [clang][Fuchsia] Ensure static sanitizer libs are only linked in after the -nostdlib check

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. leonardchan marked an inline comment as done. Closed by commit rG4ac58b61022d: [clang][Fuchsia] Ensure static sanitizer libs are only linked in after the… (authored by

[PATCH] D119257: Revert "Re-land [LLD] Remove global state in lldCommon"

aganea added a comment. @krzysz00 I will revert and re-land with both fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119257/new/ https://reviews.llvm.org/D119257 ___ cfe-commits mailing list cfe-co

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

MaskRay added a comment. In D118804#3304261 , @urnathan wrote: > While C2X has blessed such smaller alignments, the x86_64 ABI (in > particular), has not. However, using that ABI to justify 'It. Is. 16. > Bytes.', is really an exercise in reality denia

[clang] 424e850 - [clang][ARM] Re-word PACBTI warning.

Author: Amilendra Kodithuwakku Date: 2022-02-08T19:13:02Z New Revision: 424e850f1ebc3e7011cb4af44cb2d62c02a58fbe URL: https://github.com/llvm/llvm-project/commit/424e850f1ebc3e7011cb4af44cb2d62c02a58fbe DIFF: https://github.com/llvm/llvm-project/commit/424e850f1ebc3e7011cb4af44cb2d62c02a58fbe.d

[PATCH] D119166: [clang][ARM] Re-word PACBTI warning.

This revision was automatically updated to reflect the committed changes. Closed by commit rG424e850f1ebc: [clang][ARM] Re-word PACBTI warning. (authored by amilendra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119166/new/ https://reviews.llvm.o

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

eugenis added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:475 def err_stack_tagging_requires_hardware_feature : Error< - "'-fsanitize=memtag' requires hardware support (+memtag)">; + "'-fsanitize=memtag-stack' requires hardware support (+mem

[PATCH] D119268: avoid the warning of assignment operation inside the if statement

phyBrackets created this revision. Herald added a subscriber: martong. phyBrackets requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D119268 Files: clang/lib/StaticAnalyzer/Ch

[PATCH] D119051: Fix pod-packed functionality to use the C++11 definition of pod-ness

dblaikie updated this revision to Diff 406904. dblaikie added a comment. - Change the definition of C++03 POD to include defaulted functions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119051/new/ https://reviews.llvm.org/D119051 Files: clang/

[PATCH] D119051: Fix pod-packed functionality to use the C++11 definition of pod-ness

dblaikie added a comment. Yeah, looks like GCC believes `cxx11_pod::t1` to be C++03 POD even though it doesn't quite follow the letter of the standard - but since teh "= default" is an extension, I guess they get to define what that extension means. Here's an example: struct t1 { int i; };

[PATCH] D119215: [clang] Properly cache member pointer LLVM types

aeubanks updated this revision to Diff 406908. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119215/new/ https://reviews.llvm.org/D119215 Files: clang/lib/CodeGen/CodeGenTypes.cpp clang/lib/CodeGen/CodeGenTypes

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9545976ff160: Revert "[Clang] Propagate guaranteed alignment for malloc and others" (authored by jyknight). Repository: rG LLVM Github Monorepo C

[clang] 9545976 - Revert "[Clang] Propagate guaranteed alignment for malloc and others"

Author: James Y Knight Date: 2022-02-08T14:34:44-05:00 New Revision: 9545976ff160e19805a84a06a7e59d446f9994d9 URL: https://github.com/llvm/llvm-project/commit/9545976ff160e19805a84a06a7e59d446f9994d9 DIFF: https://github.com/llvm/llvm-project/commit/9545976ff160e19805a84a06a7e59d446f9994d9.diff

[PATCH] D119215: [clang] Properly cache member pointer LLVM types

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119215/new/ https://reviews.llvm.org/D119215 ___ cfe-c

[PATCH] D119271: CGCall: also emit LLVM `allocalign` attribute when handling AllocAlign

durin42 created this revision. Herald added a subscriber: jdoerfert. durin42 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. LLVM is growing knowledge of this, so we should inform it when we have the information available. Depends on D1182

[clang] 079b6d0 - [clang] [MinGW] Recognize -lcrtdll as a library replacing -lmsvcrt

Author: Martin Storsjö Date: 2022-02-08T21:57:07+02:00 New Revision: 079b6d02d1f52301e2d3276fadba822bf87b75b2 URL: https://github.com/llvm/llvm-project/commit/079b6d02d1f52301e2d3276fadba822bf87b75b2 DIFF: https://github.com/llvm/llvm-project/commit/079b6d02d1f52301e2d3276fadba822bf87b75b2.diff

[PATCH] D119234: [clang] [MinGW] Recognize -lcrtdll as a library replacing -lmsvcrt

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG079b6d02d1f5: [clang] [MinGW] Recognize -lcrtdll as a library replacing -lmsvcrt (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D119271: CGCall: also emit LLVM `allocalign` attribute when handling AllocAlign

xbolva00 added inline comments. Comment at: clang/test/CodeGen/alloc-align-attr.c:14 // CHECK-NEXT:[[CASTED_ALIGN:%.*]] = zext i32 [[TMP0]] to i64 // CHECK-NEXT:call void @llvm.assume(i1 true) [ "align"(i32* [[CALL]], i64 [[CASTED_ALIGN]]) ] // CHECK-NEXT:[[TMP1:%

[PATCH] D119231: [clang][lex][minimizer] Ensure whitespace between squashed lines

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LG, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119231/new/ https://reviews.llvm.org/D119231

[PATCH] D118428: [clang-cl] Support the /JMC flag

ychen marked an inline comment as done. ychen added inline comments. Comment at: llvm/lib/CodeGen/JMCInstrumenter.cpp:180 + "JMC instrument more than once?"); + FunctionCallee Fn = + M.getOrInsertFunction(CheckFunctionName, getCheckFunctionType(Ctx)); --

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void added inline comments. Comment at: llvm/lib/Target/X86/X86FrameLowering.cpp:595 +continue; + XorOp = X86::PXORrr; +} else if (X86::VR256RegClass.contains(Reg)) { nickdesaulniers wrote: > void wrote: > > nickdesaulniers wrote: > > > Is there

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 406924. void added a comment. Move register clearning to after the "pop"s. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 Files: clang/include/clang/Basic/Attr.td c

[PATCH] D118428: [clang-cl] Support the /JMC flag

ychen updated this revision to Diff 406927. ychen marked an inline comment as done. ychen added a comment. - address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118428/new/ https://reviews.llvm.org/D118428 Files: clang/docs/ReleaseNot

[clang] f2c2e92 - Fix a typo (occured => occurred)

Author: Sylvestre Ledru Date: 2022-02-08T21:35:26+01:00 New Revision: f2c2e924e73a76562b7cc6d8fd96df5b177eaf18 URL: https://github.com/llvm/llvm-project/commit/f2c2e924e73a76562b7cc6d8fd96df5b177eaf18 DIFF: https://github.com/llvm/llvm-project/commit/f2c2e924e73a76562b7cc6d8fd96df5b177eaf18.dif

[PATCH] D119257: Revert "Re-land [LLD] Remove global state in lldCommon"

aganea added a comment. All things considered I think in the short term it is better to aim for small patches/fixes that can be transplanted to `release/14.x` if need be. I've posted D119277 for the issue you were seeing @krzysz00, but I am still planning on p

[clang] d379ec9 - [AArch64] ACLE feature macro for Armv8.8-A MOPS

Author: tyb0807 Date: 2022-02-08T21:07:49Z New Revision: d379ec99085e33ace51740f2b93bda5e5c72326f URL: https://github.com/llvm/llvm-project/commit/d379ec99085e33ace51740f2b93bda5e5c72326f DIFF: https://github.com/llvm/llvm-project/commit/d379ec99085e33ace51740f2b93bda5e5c72326f.diff LOG: [AArc

[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd379ec99085e: [AArch64] ACLE feature macro for Armv8.8-A MOPS (authored by tyb0807). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 406948. void added a comment. Remove obsolete change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Ba

[clang] f05a63f - [clang] Properly cache member pointer LLVM types

Author: Arthur Eubanks Date: 2022-02-08T13:22:24-08:00 New Revision: f05a63f9a09bdacab6a98683c5a4fc3f1f2a9149 URL: https://github.com/llvm/llvm-project/commit/f05a63f9a09bdacab6a98683c5a4fc3f1f2a9149 DIFF: https://github.com/llvm/llvm-project/commit/f05a63f9a09bdacab6a98683c5a4fc3f1f2a9149.diff

[PATCH] D119215: [clang] Properly cache member pointer LLVM types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf05a63f9a09b: [clang] Properly cache member pointer LLVM types (authored by aeubanks). Changed prior to commit: https://reviews.llvm.org/D119215?v

[PATCH] D119257: Revert "Re-land [LLD] Remove global state in lldCommon"

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. Thanks to @aganea for working on this. I agree that lld/ELF is not ready for library usage. So far the arguments have always been "the library usage is easy since lld headers happe

[clang] f16cc5d - [test] Remove -fno-experimental-new-pass-manager -O1 from sanitize-address-field-padding.cpp

Author: Arthur Eubanks Date: 2022-02-08T13:22:43-08:00 New Revision: f16cc5df2288ef4637de29cd878627967b0fee3b URL: https://github.com/llvm/llvm-project/commit/f16cc5df2288ef4637de29cd878627967b0fee3b DIFF: https://github.com/llvm/llvm-project/commit/f16cc5df2288ef4637de29cd878627967b0fee3b.diff

[PATCH] D118936: [test] Remove -fno-experimental-new-pass-manager -O1 from sanitize-address-field-padding.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf16cc5df2288: [test] Remove -fno-experimental-new-pass-manager -O1 from sanitize-address… (authored by aeubanks). Repository: rG LLVM Github Mono

[PATCH] D119257: Revert "Re-land [LLD] Remove global state in lldCommon"

mehdi_amini added a comment. (The discussion seems to be happening in two places: https://github.com/llvm/llvm-project/issues/53475 ) You can break downstream users, the relationship inside the monorepo is different as far as I know: I believe we will have to live with revert like the one abov

[PATCH] D119257: Revert "Re-land [LLD] Remove global state in lldCommon"

aganea added a comment. @mehdi_amini Just to unblock users, I've posted https://reviews.llvm.org/D119277 which fixes the issue originally raised by @krzysz00 I'm also working on a more long term solution in https://reviews.llvm.org/D119049 Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D119257: Revert "Re-land [LLD] Remove global state in lldCommon"

mehdi_amini added a comment. Yes, I saw these, thanks a lot @aganea !! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119257/new/ https://reviews.llvm.org/D119257 ___ cfe-commits mailing list cfe-commits@

[PATCH] D119257: Revert "Re-land [LLD] Remove global state in lldCommon"

krzysz00 added a comment. (Since it looks like the discussion moved here) @MaskRay We can't spawn lld as a subprocess due to customer requirements around having the kernel generator/compiler delivered as a static library in some cases. (And there's LLVM version compatibility concerns, but those

[PATCH] D118977: [NVPTX] Add more FMA intriniscs/builtins

tra added inline comments. Comment at: llvm/lib/Target/NVPTX/NVPTXIntrinsics.td:937 +class FMA_TUPLE Preds = [hasPTX70, hasSM80]> { + string Variant = V; I think the default should be the most useful/common and the least surprising value. I'd argue that in thi

[PATCH] D119289: [Clang] Add lowering for _C complex arithmetic to complex intrinsics.

jcranmer-intel created this revision. Herald added subscribers: dexonsmith, dang, pengfei. jcranmer-intel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds a new guard flag, -fuse-complex-intrinsics, that is defaulted to on for the

[PATCH] D119290: [Clang] Add support for -fcx-limited-range, -fcx-fortran-rules options.

jcranmer-intel created this revision. Herald added a subscriber: dang. jcranmer-intel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These are built on top of, and require, the complex intrinsics definitions to work with. They are intended

[PATCH] D119291: [Clang] Add support for STDC CX_LIMITED_RANGE pragma.

jcranmer-intel created this revision. Herald added a subscriber: dexonsmith. jcranmer-intel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This pragma is defined in the C specification. Notably, the C specification makes the "DEFAULT" valu

[PATCH] D119257: Revert "Re-land [LLD] Remove global state in lldCommon"

krzysz00 added a comment. Having checked with other folks more familiar with the context of our project, it looks like we might actually be fine using lld as a subprocess, since we'll always be sitting on top of a ROCm installation, which includes lld, and since "take this object file and wrap

[clang] 6ba68a5 - [clang][Driver] Use a VersionTuple for darwin linker version checks.

Author: Ahmed Bougacha Date: 2022-02-08T14:30:39-08:00 New Revision: 6ba68a5fc34271c85f438217f50e165cb0158c04 URL: https://github.com/llvm/llvm-project/commit/6ba68a5fc34271c85f438217f50e165cb0158c04 DIFF: https://github.com/llvm/llvm-project/commit/6ba68a5fc34271c85f438217f50e165cb0158c04.diff

[clang] ca9f0ec - [clang] Document objc_unsafeClaimAutoreleasedReturnValue.

Author: Ahmed Bougacha Date: 2022-02-08T14:30:39-08:00 New Revision: ca9f0ec1a30b899ce9df3d2173aa9a295b510509 URL: https://github.com/llvm/llvm-project/commit/ca9f0ec1a30b899ce9df3d2173aa9a295b510509 DIFF: https://github.com/llvm/llvm-project/commit/ca9f0ec1a30b899ce9df3d2173aa9a295b510509.diff

[PATCH] D118525: [modules] Merge ObjC interface ivars with anonymous types.

vsapsai updated this revision to Diff 406977. vsapsai added a comment. Herald added a project: clang. Rebase and address clang-format comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118525/new/ https://reviews.llvm.org/D118525 Files: clan

[PATCH] D119257: Revert "Re-land [LLD] Remove global state in lldCommon"

MaskRay added a comment. In D119257#3306151 , @krzysz00 wrote: > Having checked with other folks more familiar with the context of our > project, it looks like we might actually be fine using lld as a subprocess, > since we'll always be sitting on top o

[PATCH] D116861: [UBSan] Fix incorrect alignment reported when global new returns an offset pointer

rjmccall added a comment. If we want to assume a weaker alignment, we should change the calculation of `allocationAlign` rather than just changing this point downstream of that computation. But replacements of the standard `operator new` are restricted and cannot simply choose to return less-a

<    1   2   3   >