[PATCH] D119215: [clang] Properly cache member pointer LLVM types

[Reid Kleckner via Phabricator via cfe-commits]

rnk added a comment.

Seems reasonable



================
Comment at: clang/lib/CodeGen/CodeGenTypes.cpp:776
+      auto *C = MPTy->getClass();
+      auto I = RecordsWithOpaqueMemberPointers.find(C);
+      if (I == RecordsWithOpaqueMemberPointers.end()) {
----------------
Can this use something like the `insert` get-or-create pattern?
  auto Insertion = RecordsWithOpaqueMemberPointers.insert({C, StructType*{}});
  if (Insertion.second) Insertion.first->second = llvm::StructType::create(...);
  return Insertion.first->second;


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119215/new/

https://reviews.llvm.org/D119215

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits