[PATCH] D118969: [clang-format][NFC] Fix a bug in setting type FunctionLBrace

owenpan updated this revision to Diff 405881. owenpan added a comment. Added a test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118969/new/ https://reviews.llvm.org/D118969 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/TokenAnnotatorTest.cpp Index

[PATCH] D118969: [clang-format][NFC] Fix a bug in setting type FunctionLBrace

owenpan added a comment. In D118969#3295909 , @curdeius wrote: > Well, I thought about this approach but actually a macro line should never be > merged together with a preceding line, so I went for a generic approach. That's why I didn't say yours would

[PATCH] D118935: [SYCL] Disallow explicit casts between mismatching address spaces

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118935/new/ https://reviews.llvm.org/D118935

[PATCH] D118927: [clang-tidy] Fix invalid fix-it for cppcoreguidelines-prefer-member-initializer

simon.giesecke added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-prefer-member-initializer.cpp:537 +struct PR53515 { + int M; Can this be renamed to something describing the test case? E.g. `AlreadyHasInitializer

[clang] 2189960 - [pseudo] Rename Tests.cpp => Test.cpp

Author: Haojian Wu Date: 2022-02-04T09:48:14+01:00 New Revision: 2189960e65a9c4a7056d1f07f8de5c3fda1888c3 URL: https://github.com/llvm/llvm-project/commit/2189960e65a9c4a7056d1f07f8de5c3fda1888c3 DIFF: https://github.com/llvm/llvm-project/commit/2189960e65a9c4a7056d1f07f8de5c3fda1888c3.diff LO

[PATCH] D118969: [clang-format][NFC] Fix a bug in setting type FunctionLBrace

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118969/new/ https://reviews.llvm.org/D118969 ___ cfe-commits mailing list cfe-comm

[clang] b94f095 - [pseudo] NFC, clangSyntaxPsuedo => clangToolingSyntaxPseudo

Author: Haojian Wu Date: 2022-02-04T09:57:20+01:00 New Revision: b94f09524efe2789598eb8c1bf5f44f5b17148d6 URL: https://github.com/llvm/llvm-project/commit/b94f09524efe2789598eb8c1bf5f44f5b17148d6 DIFF: https://github.com/llvm/llvm-project/commit/b94f09524efe2789598eb8c1bf5f44f5b17148d6.diff LO

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

ivanmurashko updated this revision to Diff 405886. ivanmurashko added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118755/new/ https://reviews.llvm.org/D118755 Files: clang-tools-extra/clangd/test/repeated_includes.test clan

[PATCH] D114790: [syntax][pseudo] Add grammar facilities for the pseudo-parser

hokein added inline comments. Comment at: clang/lib/Tooling/Syntax/Pseudo/CMakeLists.txt:3 + +add_clang_library(clangSyntaxPseudo + Grammar.cpp thakis wrote: > (i think the usual name would be "clangToolingSyntaxPseudo") (the name is too verbose, and we have a

[PATCH] D118875: [compiler-rt][builtins] build the macOS compiler-rt built-ins with Mac Catalyst support

bc-lee added a comment. Hi, I built and tested clang using this patch and https://reviews.llvm.org/D118862. It works great. The current patch adds the -darwin-target-variant flag to all object files for MacOS targets in the compiler_rt's builtin library. However, users building compiler_rt may

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void added a comment. In D110869#3295912 , @craig.topper wrote: > In D110869#3295906 , @void wrote: > >> In D110869#3295578 , >> @nickdesaulniers wrote: >> >>> In D11086

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

craig.topper added a comment. In D110869#3296031 , @void wrote: > In D110869#3295912 , @craig.topper > wrote: > >> In D110869#3295906 , @void wrote: >> >>> In D110869#329

[PATCH] D118976: clangd: Set a diagnostic on a code action resulting from a tweak

ckandeler created this revision. ckandeler added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. ... if there is a

[PATCH] D118782: clangd: Add a break for every case in the PopulateSwitch tweak

ckandeler updated this revision to Diff 405893. ckandeler added a comment. Improved code as per review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118782/new/ https://reviews.llvm.org/D118782 Files: clang-tools-extra/clangd/refactor/t

[PATCH] D118977: [NVPTX] Add more FMA intriniscs/builtins

jchlanda created this revision. jchlanda added reviewers: tra, csigg, bkramer. Herald added subscribers: asavonic, hiraditya, jholewinski. jchlanda requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert. Herald added projects: clang, LLVM. This patch adds

[PATCH] D118044: [ARM] Undeprecate complex IT blocks

dmgreen added a comment. The actual code change looks fine to me, providing we can clean up these test changes a bit and no-one else has any other comments. Comment at: llvm/test/CodeGen/ARM/2013-05-05-IfConvertBug.ll:196 ; Hard-coded registers comes from the ABI. ; CHECK-LA

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

sammccall added a comment. Thanks! This fix makes sense to me. Comment at: clang-tools-extra/clangd/test/repeated_includes.test:1 +# RUN: rm -rf %/t +# RUN: mkdir -p %t && touch %t/t.h && touch %t/t2.h && touch %t/t3.h This should be tested more directly rather

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 405897. void added a comment. Only need to zero out 32-bit registers with xor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 Files: clang/include/clang/Basic/Attr.td

[clang] 31fa3a4 - [OpenCL] Move OpenCL 2.0 atomics into multiclass; NFC

Author: Sven van Haastregt Date: 2022-02-04T10:17:48Z New Revision: 31fa3a4d44316fd36e11f92729ea9596ee3bf3f8 URL: https://github.com/llvm/llvm-project/commit/31fa3a4d44316fd36e11f92729ea9596ee3bf3f8 DIFF: https://github.com/llvm/llvm-project/commit/31fa3a4d44316fd36e11f92729ea9596ee3bf3f8.diff

[PATCH] D118976: clangd: Set a diagnostic on a code action resulting from a tweak

sammccall added a comment. This is assuming a semantic connection that we don't know exists. Without any more specific reason to draw this connection, this seems like a heuristic that could equally be applied by the client. Is there a particular action/diagnostic pair you want this for? Reposi

[PATCH] D118980: Don't dllexport reference temporaries

hans created this revision. hans added reviewers: thakis, mstorsjo, rnk. hans requested review of this revision. Herald added a project: clang. Even if the reference itself is dllexport, the temporary should not be -- in fact, we're already giving it internal linkage, so dllexporting it is not ju

[PATCH] D118782: clangd: Add a break for every case in the PopulateSwitch tweak

sammccall added a comment. FWIW I prefer the existing behaviour (reasons below). @kadircet, thoughts? - The output with `break` is harder to visually scan. (In styles where `break` goes on its own line) - The output is annoying to edit when you *do* want to deal with blocks of cases at once. Wh

[PATCH] D118976: clangd: Set a diagnostic on a code action resulting from a tweak

ckandeler added a comment. > This is assuming a semantic connection that we don't know exists. > Without any more specific reason to draw this connection, this seems like a > heuristic that could equally be applied by the client. The difference being that the client would have to poke around in

[clang] ffe8720 - Reduce dependencies on llvm/BinaryFormat/Dwarf.h

Author: serge-sans-paille Date: 2022-02-04T11:44:03+01:00 New Revision: ffe8720aa060d66297500f30bb8ad02114e40326 URL: https://github.com/llvm/llvm-project/commit/ffe8720aa060d66297500f30bb8ad02114e40326 DIFF: https://github.com/llvm/llvm-project/commit/ffe8720aa060d66297500f30bb8ad02114e40326.d

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth added a comment. In D54943#3292552 , @0x8000- wrote: > @aaron.ballman - can this land for Clang14, or does it have wait for 15? > > Are there any other reviewers that can approve this? Sadly, cherry-picking to 14 is very unlikely, as this is

[PATCH] D118781: Reduce dependencies on llvm/BinaryFormat/Dwarf.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGffe8720aa060: Reduce dependencies on llvm/BinaryFormat/Dwarf.h (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D115856: [syntax][pseudo] Introduce the spec C++ grammar.

hokein updated this revision to Diff 405904. hokein marked 2 inline comments as done. hokein added a comment. rebase and address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115856/new/ https://reviews.llvm.org/D115856 Files: clang/li

[PATCH] D118976: clangd: Set a diagnostic on a code action resulting from a tweak

sammccall added a comment. TL;DR: I think this makes sense to add, but we should make it slightly more restrictive. In D118976#3296182 , @ckandeler wrote: >> This is assuming a semantic connection that we don't know exists. >> Without any more specific

[clang] e1db505 - [syntax][pseudo] Introduce the C++ spec grammar.

Author: Haojian Wu Date: 2022-02-04T11:58:50+01:00 New Revision: e1db505b42f4d0799640988bbdf1ab83a661a46c URL: https://github.com/llvm/llvm-project/commit/e1db505b42f4d0799640988bbdf1ab83a661a46c DIFF: https://github.com/llvm/llvm-project/commit/e1db505b42f4d0799640988bbdf1ab83a661a46c.diff LO

[PATCH] D115856: [syntax][pseudo] Introduce the spec C++ grammar.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe1db505b42f4: [syntax][pseudo] Introduce the C++ spec grammar. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D118904: [clang][CodeGen] Use memory type representation in `va_arg`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG42afaf7f472c: [clang][CodeGen] Use memory type representation in `va_arg` (authored by jansvoboda11). Changed prior to commit: https://reviews.llv

[clang] 42afaf7 - [clang][CodeGen] Use memory type representation in `va_arg`

Author: Jan Svoboda Date: 2022-02-04T12:10:57+01:00 New Revision: 42afaf7f472ce8ae14f1aa3858f1a8f3abc4ac67 URL: https://github.com/llvm/llvm-project/commit/42afaf7f472ce8ae14f1aa3858f1a8f3abc4ac67 DIFF: https://github.com/llvm/llvm-project/commit/42afaf7f472ce8ae14f1aa3858f1a8f3abc4ac67.diff L

[PATCH] D118921: [Format] Don't derive pointers right based on space before method ref-qualifiers

sammccall marked an inline comment as done. sammccall added a comment. Thanks! Comment at: clang/unittests/Format/FormatTest.cpp:9689-9692 + // There's always a space between the function and its trailing qualifiers. + // This isn't evidence for PAS_Right (or for PAS_Left). +

[clang] acc3ce9 - [Format] Don't derive pointers right based on space before method ref-qualifiers

Author: Sam McCall Date: 2022-02-04T12:13:58+01:00 New Revision: acc3ce945c32a71ec077df379c99d859f31cc741 URL: https://github.com/llvm/llvm-project/commit/acc3ce945c32a71ec077df379c99d859f31cc741 DIFF: https://github.com/llvm/llvm-project/commit/acc3ce945c32a71ec077df379c99d859f31cc741.diff LO

[PATCH] D118921: [Format] Don't derive pointers right based on space before method ref-qualifiers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rGacc3ce945c32: [Format] Don't derive pointers right based on space before method ref-qualifiers (authored

[clang] cc8ed7b - [Format] Also test rvalue-qualified functions

Author: Sam McCall Date: 2022-02-04T12:17:25+01:00 New Revision: cc8ed7b5aaa4ab9d11cb8a5bc97222df966e0f58 URL: https://github.com/llvm/llvm-project/commit/cc8ed7b5aaa4ab9d11cb8a5bc97222df966e0f58 DIFF: https://github.com/llvm/llvm-project/commit/cc8ed7b5aaa4ab9d11cb8a5bc97222df966e0f58.diff LO

[PATCH] D118976: clangd: Set a diagnostic on a code action resulting from a tweak

ckandeler updated this revision to Diff 405911. ckandeler added a comment. Formatting & logic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118976/new/ https://reviews.llvm.org/D118976 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp Index

[PATCH] D118976: clangd: Set a diagnostic on a code action resulting from a tweak

ckandeler added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1011 // We never consider refactorings etc as preferred. CodeAction *OnlyFix = nullptr; for (auto &Action : Actions) { sammccall wrote: > This loo

[PATCH] D118980: Don't dllexport reference temporaries

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM, seems reasonable! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118980/new/ https://reviews.llvm.org/D118980

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

awarzynski created this revision. awarzynski added reviewers: rovka, kiranchandramohan, clementval, schweitz. Herald added subscribers: sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, dang, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aar

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

awarzynski added a comment. `fir-dev` PR: https://github.com/flang-compiler/f18-llvm-project/pull/1008. I've also incorporated a few small changes from the subsequent PRs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118985/new/ https://reviews.l

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

njames93 added a subscriber: sammccall. njames93 added a comment. In D54943#3296191 , @JonasToth wrote: > In D54943#3292552 , @0x8000- > wrote: > >> @aaron.ballman - can this land for Clang14, or does it have w

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

salman-javed-nz added a comment. In D118104#3292862 , @JesApp wrote: > Well, since this was more of source of confusion than actual incorrect > behaviour, I don't think there should be a test for it. > > In general though, I think the script is complex e

[PATCH] D118927: [clang-tidy] Fix invalid fix-it for cppcoreguidelines-prefer-member-initializer

JonasToth added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-prefer-member-initializer.cpp:550 + // CHECK-FIXES-NEXT: } + PR53515(PR53515 &&Other) : M() { +M = Other.M; could you please add a test-case for initi

[PATCH] D118927: [clang-tidy] Fix invalid fix-it for cppcoreguidelines-prefer-member-initializer

njames93 updated this revision to Diff 405919. njames93 added a comment. Rename test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118927/new/ https://reviews.llvm.org/D118927 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMem

[PATCH] D118927: [clang-tidy] Fix invalid fix-it for cppcoreguidelines-prefer-member-initializer

njames93 marked 2 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-prefer-member-initializer.cpp:550 + // CHECK-FIXES-NEXT: } + PR53515(PR53515 &&Other) : M() { +M = Other.M;

[clang] ae9c074 - [OpenMP][Clang] Allow ancestor device modifier only with reverse offloading

Author: Saiyedul Islam Date: 2022-02-04T12:10:14Z New Revision: ae9c0740648fd8f7010c895ddcf78380da94dd57 URL: https://github.com/llvm/llvm-project/commit/ae9c0740648fd8f7010c895ddcf78380da94dd57 DIFF: https://github.com/llvm/llvm-project/commit/ae9c0740648fd8f7010c895ddcf78380da94dd57.diff LOG

[PATCH] D118887: [OpenMP][Clang] Allow ancestor device modifier only with reverse offloading

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae9c0740648f: [OpenMP][Clang] Allow ancestor device modifier only with reverse offloading (authored by saiislam). Repository: rG LLVM Github Monor

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

njames93 added a comment. In D118104#3296340 , @salman-javed-nz wrote: > In D118104#3292862 , @JesApp wrote: > >> Well, since this was more of source of confusion than actual incorrect >> behaviour, I don't thin

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

azabaznov updated this revision to Diff 405921. azabaznov added a comment. Reimplement with checking language options only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118605/new/ https://reviews.llvm.org/D118605 Files: clang/include/clang/Bas

[PATCH] D118986: [clang][deps] Return the whole TU command line

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The dependency scanner already generates canonical -cc1 command lines that can be used to

[PATCH] D118986: [clang][deps] Return the whole TU command line

jansvoboda11 updated this revision to Diff 405925. jansvoboda11 added a comment. Undo one test change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118986/new/ https://reviews.llvm.org/D118986 Files: clang/include/clang/Tooling/DependencyScanni

[PATCH] D118986: [clang][deps] Return the whole TU command line

jansvoboda11 added inline comments. Comment at: clang/test/ClangScanDeps/modules-inferred-explicit-build.m:15 // RUN: %clang @%t.system.cc1.rsp -pedantic -Werror -// RUN: %clang -x objective-c -fsyntax-only %t.dir/modules_cdb_input.cpp \ -// RUN: -F%S/Inputs/frameworks -fmodul

[PATCH] D118976: clangd: Set a diagnostic on a code action resulting from a tweak

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1011 // We never consider refactorings etc as preferred. CodeAction *OnlyFix = nullptr;

[PATCH] D118257: [AArch64] Generate fcmps when appropriate for neon intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbca998ed3c9a: [AArch64] Generate fcmps when appropriate for neon intrinsics (authored by john.brawn). Repository: rG LLVM Github Monorepo CHANGES

[clang] bca998e - [AArch64] Generate fcmps when appropriate for neon intrinsics

Author: John Brawn Date: 2022-02-04T12:55:38Z New Revision: bca998ed3c9a2e520724baa5d9395f6a5d8ca49d URL: https://github.com/llvm/llvm-project/commit/bca998ed3c9a2e520724baa5d9395f6a5d8ca49d DIFF: https://github.com/llvm/llvm-project/commit/bca998ed3c9a2e520724baa5d9395f6a5d8ca49d.diff LOG: [A

[PATCH] D118976: clangd: Set a diagnostic on a code action resulting from a tweak

ckandeler updated this revision to Diff 405929. ckandeler added a comment. Simplified code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118976/new/ https://reviews.llvm.org/D118976 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp Index: c

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

salman-javed-nz added a comment. My bad. Test should have called clang-tidy with `--checks` in one test case, and with `--config` in the second. In both cases, the disabled check should not appear in the `Enabled checks:` printout. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118104/n

[PATCH] D118965: [OpenMP] Add search path for llvm-strip

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LG, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118965/new/ https://reviews.llvm.org/D118965 __

[PATCH] D110445: [NFC] Avoid some AttrBuilder redundant initialization

nikic added a comment. This one can probably be abandoned after the AttrMask/AttrBuilder changes that have been made? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110445/new/ https://reviews.llvm.org/D110445 _

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

luismarques added a comment. Assuming this will be merged soon, do you want to submit a backport request for the 14.0 branch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 ___

[PATCH] D118782: clangd: Add a break for every case in the PopulateSwitch tweak

kadircet added a comment. I agree with Sam on this one and remember having some (possibly offline) discussions around not having those breaks explicitly (we should've documented the reasoning, sorry). As pointed out, I believe the main benefit is not spelling out each enum value (it's usually

[PATCH] D118782: clangd: Add a break for every case in the PopulateSwitch tweak

ckandeler abandoned this revision. ckandeler added a comment. Fair enough. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118782/new/ https://reviews.llvm.org/D118782 ___ cfe-commits mailing list cfe-comm

[PATCH] D118990: [pseudo] Add first and follow set computation in Grammar.

hokein created this revision. hokein added a reviewer: sammccall. hokein requested review of this revision. Herald added a project: clang. These will be used when building parsing table for LR parsers. Separate from https://reviews.llvm.org/D118196. Repository: rG LLVM Github Monorepo https:

[PATCH] D118782: clangd: Add a break for every case in the PopulateSwitch tweak

njames93 added a comment. The only way I'd suggest supporting this is via an option in config(like we do with the add using tweak), but I don't think even then it would get much use. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118782/new/ https:

[PATCH] D118196: [syntax][pseudo] Implement LR parsing table.

hokein marked 7 inline comments as done. hokein added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Pseudo/Grammar.h:130 + + // Returns the SymbolID of the augmented symbol '_' + SymbolID augmentedSymbol() const { return 0; } sammccall wrote:

[PATCH] D118922: [ASTMatchers] The `isInline` matcher now accepts inline variables

njames93 added a comment. I had the same idea in D118900 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118922/new/ https://reviews.llvm.org/D118922 ___ cfe-commits mail

[PATCH] D118990: [pseudo] Add first and follow set computation in Grammar.

hokein updated this revision to Diff 405939. hokein added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118990/new/ https://reviews.llvm.org/D118990 Files: clang/include/clang/Tooling/Syntax/Pseudo/Grammar.h clang/lib/Tooling

[PATCH] D118964: Fix broken 2-stage build when -tblgen tools may depend on runpath that is not yet built

arcivanov added a comment. So this change is insufficient as additional tools (lldb-tblgen and clang-ast-dump) will fail thereafter. Since all those tools depend on libc++ being available for stage2-bins, the libc++ needs to be built on stage two (along with unwind and compiler-rt in my case).

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

ABataev added inline comments. Comment at: clang/test/OpenMP/atomic_ast_print.cpp:10 +// RUN: %clang_cc1 -DOMP51 -verify=omp51 -fopenmp -fopenmp-version=51 -ast-print %s | FileCheck --check-prefixes=CHECK,CHECK-51 %s + +// RUN: %clang_cc1 -DOMP51 -verify=omp51 -fopenmp-simd -fop

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

erichkeane added a comment. 1 question, otherwise happy. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:8153 + + bool AttrHasVariadicArg = AL.hasVariadicArg(); + unsigned AttrNumArgs = AL.getNumArgMembers(); This still doesn't work if the VariadicExprArgument is

[PATCH] D118991: [clang-format][docs] Fix incorrect 'clang-format 14' configuration options markers

kuzkry created this revision. kuzkry added a reviewer: MyDeveloperDay. kuzkry requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [clang-format][docs] Fix incorrect 'clang-format 14' configuration options markers Introduced by 23a5090c6

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

steffenlarsen marked 2 inline comments as done. steffenlarsen added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:8153 + + bool AttrHasVariadicArg = AL.hasVariadicArg(); + unsigned AttrNumArgs = AL.getNumArgMembers(); erichkeane wrote: > This sti

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:8153 + + bool AttrHasVariadicArg = AL.hasVariadicArg(); + unsigned AttrNumArgs = AL.getNumArgMembers(); steffenlarsen wrote: > erichkeane wrote: > > This still doesn't work if the Var

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_ast_print.cpp:10 +// RUN: %clang_cc1 -DOMP51 -verify=omp51 -fopenmp -fopenmp-version=51 -ast-print %s | FileCheck --check-prefixes=CHECK,CHECK-51 %s + +//

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

ABataev added inline comments. Comment at: clang/test/OpenMP/atomic_ast_print.cpp:10 +// RUN: %clang_cc1 -DOMP51 -verify=omp51 -fopenmp -fopenmp-version=51 -ast-print %s | FileCheck --check-prefixes=CHECK,CHECK-51 %s + +// RUN: %clang_cc1 -DOMP51 -verify=omp51 -fopenmp-simd -fop

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

jyknight added a comment. In D110869#3295477 , @nathanchance wrote: > Rather interesting function to have problems with as a result of this patch > but it seems like this function is being used in a very specific way further > down the file with the `_

[PATCH] D118924: [clang-format] Fix formatting of macro definitions with a leading comment.

curdeius added a comment. Indeed, I get the hash on the 2nd line merged into the first one in this test case: verifyFormat("/* comment */ #define A (parentheses)\n" "#"); But! It's unrelated to whether `PreviousWasComment` is updated inside the loop or not. Actually it should n

[PATCH] D118520: [clang-tidy] Output currently processing check and nodes on crash

njames93 added a subscriber: thakis. njames93 added a comment. @thakis I tried to test this on the gn build and got no issues, however I'm aware that the CTCrashTestTrace plugin isn't even compiled on the gn build. Not sure its worth the effort fixing that. The lit test should be disabled anyway

[clang] d4e4ef2 - [HIP] Support code object v5

Author: Yaxun (Sam) Liu Date: 2022-02-04T09:55:08-05:00 New Revision: d4e4ef2e81e03246e29e9b6eaa2929ebd4e77784 URL: https://github.com/llvm/llvm-project/commit/d4e4ef2e81e03246e29e9b6eaa2929ebd4e77784 DIFF: https://github.com/llvm/llvm-project/commit/d4e4ef2e81e03246e29e9b6eaa2929ebd4e77784.dif

[PATCH] D118949: [HIP] Support code object v5

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd4e4ef2e81e0: [HIP] Support code object v5 (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/

[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

balazske created this revision. Herald added subscribers: carlosgalvezp, steakhal, martong, gamesh411, Szelethus, dkrupp, xazax.hun. balazske requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Check `bugprone-signal-handler` is im

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

jyknight added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:6271 +This attribute, when attached to a function, causes the compiler to zero a +subset of all call-used registers before the function returns. It's used to +increase program security by either mit

[PATCH] D118999: [OpenCL] Adjust diagnostic for subgroup support.

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: Naghasan, ldrumm, yaxunl. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. OpenCL C 3.0 __opencl_c_subgroups feature is slight

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

Anastasia added inline comments. Comment at: clang/include/clang/Basic/Builtins.h:39 + COR_LANG = 0x80, // builtin requires use of 'fcoroutine-ts' option. + OCLC2P_LANG = 0x100, // builtin for OpenCL C 2.0+ versions. + OCLC1X_LANG = 0x200, // builtin for OpenCL C 1.x only.

[clang] 853e0aa - Don't dllexport reference temporaries

Author: Hans Wennborg Date: 2022-02-04T16:31:51+01:00 New Revision: 853e0aa424e40b80d0bda1dd8a3471a361048e4b URL: https://github.com/llvm/llvm-project/commit/853e0aa424e40b80d0bda1dd8a3471a361048e4b DIFF: https://github.com/llvm/llvm-project/commit/853e0aa424e40b80d0bda1dd8a3471a361048e4b.diff

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

steffenlarsen updated this revision to Diff 405963. steffenlarsen added a comment. Added check restricting variadic expression arguments to the last argument of attributes set to support parameter packs. Added release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114439/new/ htt

[PATCH] D118980: Don't dllexport reference temporaries

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG853e0aa424e4: Don't dllexport reference temporaries (authored by hans). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 updated this revision to Diff 405967. tianshilei1992 added a comment. add TODO for PCH test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116637/new/ https://reviews.llvm.org/D116637 Files: clang/include/clang/Basic/DiagnosticSema

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

ABataev added inline comments. Comment at: clang/test/OpenMP/atomic_ast_print.cpp:40 +#ifdef OMP51 +// omp51-error@+1 2 {{atomic compare is not supported for now}} +#pragma omp atomic compare Try to add `-fsyntax-only` in RUN to avoid error message in the test

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

steffenlarsen added inline comments. Comment at: clang/include/clang/Basic/Attr.td:545 + // Set to true if this attribute accepts parameter pack expansion expressions. + bit AcceptsExprPack = 0; // Lists language options, one of which is required to be true for the

[PATCH] D99436: [OPENMP]Fix PR49366: crash on VLAs in task untied regions.

ABataev updated this revision to Diff 405968. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99436/new/ https://reviews.llvm.org/D99436 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/

[PATCH] D117306: [clang-tidy] Add new check 'shared-ptr-array-mismatch'.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SmartPtrArrayMismatchCheck.h:40 + /// in this class. + virtual SmartPtrClassMatcher getSmartPointerClassMatcher() const = 0; + njames93

[PATCH] D118999: [OpenCL] Adjust diagnostic for subgroup support.

Anastasia added a comment. Btw can you point us to the spec reference please, I can't seem to find anything related to this: https://www.khronos.org/registry/OpenCL/specs/3.0-unified/html/OpenCL_C.html#subgroup-functions. It would be nice to add the reference in the code comment too. ===

[PATCH] D117306: [clang-tidy] Add new check 'shared-ptr-array-mismatch'.

balazske updated this revision to Diff 405971. balazske added a comment. Code simplification. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117306/new/ https://reviews.llvm.org/D117306 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyMod

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_ast_print.cpp:40 +#ifdef OMP51 +// omp51-error@+1 2 {{atomic compare is not supported for now}} +#pragma omp atomic compare ABataev wrote:

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

ABataev added inline comments. Comment at: clang/test/OpenMP/atomic_ast_print.cpp:40 +#ifdef OMP51 +// omp51-error@+1 2 {{atomic compare is not supported for now}} +#pragma omp atomic compare tianshilei1992 wrote: > ABataev wrote: > > Try to add `-fsyntax-only` i

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_ast_print.cpp:40 +#ifdef OMP51 +// omp51-error@+1 2 {{atomic compare is not supported for now}} +#pragma omp atomic compare ABataev wrote:

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

ABataev added inline comments. Comment at: clang/test/OpenMP/atomic_ast_print.cpp:40 +#ifdef OMP51 +// omp51-error@+1 2 {{atomic compare is not supported for now}} +#pragma omp atomic compare tianshilei1992 wrote: > ABataev wrote: > > tianshilei1992 wrote: > > >

[PATCH] D118999: [OpenCL] Adjust diagnostic for subgroup support.

azabaznov added a comment. It seems hard to find a direct mention in the spec, but in the API spec: //CL_DEVICE_SUB_GROUP_INDEPENDENT_FORWARD_PROGRESS: Is CL_TRUE if this device supports independent forward progress of sub-groups, CL_FALSE otherwise. This query must return CL_TRUE for devices t

  1   2   3   >