owenpan added a comment.

In D118969#3295909 <https://reviews.llvm.org/D118969#3295909>, @curdeius wrote:

> Well, I thought about this approach but actually a macro line should never be 
> merged together with a preceding line, so I went for a generic approach.

That's why I didn't say yours would be obsolete. :)

> That's because one never knows what's in a macro, it can well be a function 
> brace after all depending on what goes before...

This is exactly why we should //not// set the type to `FunctionLBrace`.

> Apart from that, could you add an annotator test please?

Done.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118969/new/

https://reviews.llvm.org/D118969

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to