[PATCH] D117795: [AArch64] Add some missing strict FP vector lowering

dmgreen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1484 + // of the vector comparison instructions. + setOperationAction(ISD::STRICT_FSETCCS, VT, Expand); + // FIXME: We could potentially make use of the vector comparison instructions --

[PATCH] D118734: Added early exit for defaulted FunctionDecls. This prevents matching of defaulted comparison operators. fixes #53355

Febbe created this revision. Herald added a subscriber: carlosgalvezp. Febbe requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D118734 Files: clang-tools-extra/cla

[PATCH] D118313: [Driver] Remove -fno-experimental-new-pass-manager

kda added a comment. This looks like it is breaking the sanitizer buildbot for android: https://lab.llvm.org/buildbot/#/builders/77/builds/13756/steps/21/logs/stdio Failed Tests (1): HWAddressSanitizer-aarch64 :: TestCases/stack-uas.c Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D118313: [Driver] Remove -fno-experimental-new-pass-manager

MaskRay added a comment. In D118313#3288651 , @kda wrote: > This looks like it is breaking the sanitizer buildbot for android: > https://lab.llvm.org/buildbot/#/builders/77/builds/13756/steps/21/logs/stdio > > Failed Tests (1): > HWAddressSanitizer

[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

tyb0807 updated this revision to Diff 405080. tyb0807 marked an inline comment as done. tyb0807 added a comment. Update tests with `clang_cc1 -verify` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118199/new/ https://reviews.llvm.org/D118199 Files

[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

tyb0807 added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:229 MacroBuilder &Builder) const { + // FIXME: this does not handle the case where MOPS is disabled using +nomops + Builder.defineMacro("__ARM_FEATURE

[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

tyb0807 updated this revision to Diff 405083. tyb0807 added a comment. Update tests with `clang -Xclang -verify` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118199/new/ https://reviews.llvm.org/D118199 Files: clang/lib/Basic/Targets/AArch64.cp

[clang] 676ddba - Add ClangLinkerWrapper to the TOC to appease the Sphinx build bot

Author: Aaron Ballman Date: 2022-02-01T16:37:43-05:00 New Revision: 676ddba12021f513b24fe4af960f9ff21f5b73e6 URL: https://github.com/llvm/llvm-project/commit/676ddba12021f513b24fe4af960f9ff21f5b73e6 DIFF: https://github.com/llvm/llvm-project/commit/676ddba12021f513b24fe4af960f9ff21f5b73e6.diff

[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

tyb0807 updated this revision to Diff 405085. tyb0807 added a comment. Remove prefix from tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118199/new/ https://reviews.llvm.org/D118199 Files: clang/lib/Basic/Targets/AArch64.cpp clang/test/Co

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

arphaman added a comment. Thanks, that feedback makes sense. I'll update the patch today. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117348/new/ https://reviews.llvm.org/D117348 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D118739: Revert "[ASan] Not linking asan_static library for DSO."

kstoimenov created this revision. kstoimenov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It turned out that this change is causing segfaults in some situations. This reverts commit cf730d8ce1341ba593144df2e2bc8411238e04c3

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

arphaman updated this revision to Diff 405103. arphaman marked 4 inline comments as done. arphaman added a comment. Update to address review feedback, remove `appendToken` which is not needed as we're can just `setTokens` instead (it's a new macro info) CHANGES SINCE LAST ACTION https://revie

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

arphaman added inline comments. Comment at: clang/lib/Lex/MacroInfo.cpp:33 + +// MacroInfo is expected to take 40 bytes on platforms with an 8 byte pointer. +template class MacroInfoSizeChecker { aaron.ballman wrote: > dexonsmith wrote: > > aaron.ballman wrote:

[clang-tools-extra] 84f137a - Reland "enable plugins for clang-tidy"

Author: Jameson Nash Date: 2022-02-01T17:37:24-05:00 New Revision: 84f137a590e7de25c4105303e5938c40566c2dfb URL: https://github.com/llvm/llvm-project/commit/84f137a590e7de25c4105303e5938c40566c2dfb DIFF: https://github.com/llvm/llvm-project/commit/84f137a590e7de25c4105303e5938c40566c2dfb.diff

[PATCH] D111100: enable plugins for clang-tidy

vtjnash updated this revision to Diff 405105. vtjnash added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 Files: clang-tools-extra/clang-tidy/tool/CMakeLists.txt clang-tools-extra/

[PATCH] D111100: enable plugins for clang-tidy

vtjnash closed this revision. vtjnash added a comment. Closed by rG84f137a590e7de25c4105303e5938c40566c2dfb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://rev

[PATCH] D118520: [clang-tidy] Output currently processing check and nodes on crash

njames93 updated this revision to Diff 405111. njames93 added a comment. Added release notes. Remove AST dump of bound nodes, typically isn't very helpful Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118520/new/ https://reviews.llvm.org/D118520 F

[clang] 46add49 - [Driver][test] Fix fatal-warnings.c CHECK lines and fold the test into as-warnings.c

Author: Fangrui Song Date: 2022-02-01T15:11:17-08:00 New Revision: 46add4901fb08dcca14c4caaef908f86a108c27f URL: https://github.com/llvm/llvm-project/commit/46add4901fb08dcca14c4caaef908f86a108c27f DIFF: https://github.com/llvm/llvm-project/commit/46add4901fb08dcca14c4caaef908f86a108c27f.diff

[clang] d7dd7ad - Revert "[ASan] Not linking asan_static library for DSO."

Author: Kirill Stoimenov Date: 2022-02-01T23:58:04Z New Revision: d7dd7ad827a0a78314f3c9b55f4778a6059840f3 URL: https://github.com/llvm/llvm-project/commit/d7dd7ad827a0a78314f3c9b55f4778a6059840f3 DIFF: https://github.com/llvm/llvm-project/commit/d7dd7ad827a0a78314f3c9b55f4778a6059840f3.diff L

[PATCH] D118739: Revert "[ASan] Not linking asan_static library for DSO."

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd7dd7ad827a0: Revert "[ASan] Not linking asan_static library for DSO." (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

Izaron created this revision. Izaron added reviewers: alexfh, rsmith, LegalizeAdulthood. Herald added subscribers: carlosgalvezp, xazax.hun, mgorny. Izaron requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. C++17 `inline variables`

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

Izaron added a comment. For example, Google Code Style strongly advises C++17 `inline variables`. There are company guides how to use them: `https://abseil.io/tips/168`, `https://abseil.io/tips/140`. I believe other codestyles also use the feature. //P.S. If this review is eventually approved,

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

arsenm added inline comments. Comment at: llvm/lib/CodeGen/PrologEpilogInserter.cpp:1259 + +for (const MCPhysReg &SReg : + TRI.sub_and_superregs_inclusive(MO.getReg())) No reference Comment at: llvm/lib/CodeGen/PrologEpilogI

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 405117. void added a comment. - Don't use "llvm::for_each" or "auto" as much. - Don't zero out registers that are restored before exit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llv

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 405119. void marked 5 inline comments as done. void added a comment. Remove debugging instruction. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 Files: clang/include

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void added inline comments. Comment at: llvm/lib/CodeGen/PrologEpilogInserter.cpp:1269 + const TargetFrameLowering &TFI = *MF.getSubtarget().getFrameLowering(); + for (auto RestoreBlock : RestoreBlocks) +TFI.emitZeroCallUsedRegs(RegsToZero, *RestoreBlock);

[PATCH] D118700: Add support to --gcc-toolchain flag for GCC compiled with --enable-version-specific-runtime-libs.

MaskRay added a comment. Can you dump the gcc search paths (include search paths and -L library search paths) with and without `--enable-version-specific-runtime-libs`, like the following? % gcc a.c -v -xc /dev/null |& sed -E 's/ "?-[iIL]/\n&/ ... #include "..." search starts here: #inc

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void added a comment. In D110869#3288485 , @nickdesaulniers wrote: > Hey! Looks like Diff 404763 for an x86 defconfig plus > CONFIG_ZERO_CALL_USED_REGS=y starts booting! Looks like it panics though > trying to launch `init`(pid 1) though. > > [0.

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

nickdesaulniers added a comment. Diff 405119 still kernel panics for me. This is building the linux-next tree. $ qemu-system-x86_64 --version QEMU emulator version 6.2.0 (Debian 1:6.2+dfsg-1) Comment at: llvm/lib/Target/X86/X86FrameLowering.cpp:516 + } + return MBBI = Fi

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood added a comment. Ping. This check has gone for a week without review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117522/new/ https://reviews.llvm.org/D117522 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D118744: [clang] Don't cache function type after clearing clang->llvm type cache

aeubanks created this revision. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We clear the type cache when SkippedLayout is true and we're converting a function type. However, we then immediately put the computed entry in the cac

[PATCH] D118744: [clang] Don't cache function type after clearing clang->llvm type cache

aeubanks updated this revision to Diff 405129. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118744/new/ https://reviews.llvm.org/D118744 Files: clang/lib/CodeGen/CodeGenTypes.cpp clang/test/CodeGenCXX/type-cac

[PATCH] D118311: [Clang][ModuleMap] Add conditional parsing via requires block declaration

Bigcheese added a comment. > Is it possible to reference external module map from requires block? I mean > that in one context the module has some extra requirements but in a different > context doesn't have them. Can you provide an example where this would cause issues? > It would be nice to

[PATCH] D118744: [clang] Don't cache function type after clearing clang->llvm type cache

aeubanks planned changes to this revision. aeubanks added a comment. I'm seeing a similar crash with struct z { static z dc(z); z (*di)(z); }; z bar = z::dc({}); going to try to fix that here as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D118428: [clang-cl] Support the /JMC flag

ychen added inline comments. Comment at: llvm/lib/CodeGen/JMCInstrumenter.cpp:145 + LLVMContext &Ctx = M.getContext(); + bool UseX86FastCall = Triple(M.getTargetTriple()).getArch() == Triple::x86; + ychen wrote: > hans wrote: > > I still worry a bit about the t

[PATCH] D118311: [Clang][ModuleMap] Add conditional parsing via requires block declaration

Bigcheese updated this revision to Diff 405133. Bigcheese added a comment. Add testing of empty blocks and nested blocks and make the missing `{` error clearer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118311/new/ https://reviews.llvm.org/D11

[PATCH] D118311: [Clang][ModuleMap] Add conditional parsing via requires block declaration

dexonsmith added a comment. Drive-by comment on the docs; otherwise this sounds awesome; as long as `else` is easy to add later this SGTM (I'll let others do the code review). (Although, if `else {}` and `else requires {}` would be easy to add now/soon, I feel like it'd be worth it. Modelling a

[PATCH] D118311: [Clang][ModuleMap] Add conditional parsing via requires block declaration

iana added inline comments. Comment at: clang/include/clang/Basic/Module.h:249 + /// language options has the given feature. + static bool hasFeature(StringRef Feature, const LangOptions &LangOpts, + const TargetInfo &Target); Is `static

[PATCH] D118070: Make lld-link work in a non-MSVC shell

ychen added a comment. Thanks for doing this! Update the release note? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://reviews.llvm.org/D118070 ___ cfe-commits mailing list cfe-commits@

[PATCH] D118070: Make lld-link work in a non-MSVC shell

MaskRay added subscribers: compnerd, MaskRay. MaskRay added a comment. I know that you want a place to be accessed by both clang driver and lld-link but I am a bit nervous about the MSVC library sitting inside llvm/lib/Support/. Is there a better place? @compnerd Repository: rG LLVM Github M

[PATCH] D118311: [Clang][ModuleMap] Add conditional parsing via requires block declaration

dexonsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:722 +def err_mmap_expected_lbrace_requires : Error< + "expected '{' to start rquires block">; def err_mmap_expected_rbrace : Error<"expected '}'">; Bigcheese wrote: >

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

dexonsmith added a comment. LGTM once @aaron.ballman is happy. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117348/new/ https://reviews.llvm.org/D117348 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseInlineConstVariablesInHeadersCheck.h:33 +/// declarations in header files. True by default. +/// For the user-facing documentation see: +/// http://clang.llvm.org/extra/clang-tidy/ch

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 405137. void added a comment. Remove dead assign. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/

[PATCH] D118311: [Clang][ModuleMap] Add conditional parsing via requires block declaration

Bigcheese added a comment. > Drive-by comment on the docs; otherwise this sounds awesome; as long as else > is easy to add later this SGTM (I'll let others do the code review). > (Although, if else {} and else requires {} would be easy to add now/soon, I > feel like it'd be worth it. Modelling a

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro added a comment. Ping? It's been a week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118021/new/ https://reviews.llvm.org/D118021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D118753: [PowerPC] Fix __builtin_pdepd and __builtin_pextd to be 64-bit and P10 only.

amyk created this revision. amyk added reviewers: PowerPC, nemanjai, lei, kamaub, quinnp. amyk added projects: LLVM, PowerPC. Herald added subscribers: shchenz, kbarton. amyk requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `__builtin_pd

[clang] e188aae - Cleanup header dependencies in LLVMCore

Author: serge-sans-paille Date: 2022-02-02T06:54:20+01:00 New Revision: e188aae406f3fecaed65a1f7e6562205f0de937e URL: https://github.com/llvm/llvm-project/commit/e188aae406f3fecaed65a1f7e6562205f0de937e DIFF: https://github.com/llvm/llvm-project/commit/e188aae406f3fecaed65a1f7e6562205f0de937e.d

[PATCH] D118652: Cleanup header dependencies in LLVMCore

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe188aae406f3: Cleanup header dependencies in LLVMCore (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D112181: [docs] Remove hard-coded version numbers from sphinx configs

This revision was automatically updated to reflect the committed changes. Closed by commit rGe80c52986e1b: [docs] Remove hard-coded version numbers from sphinx configs (authored by tstellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112181/new/

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

ivanmurashko created this revision. ivanmurashko added reviewers: alexfh, DmitryPolukhin, sammccall, bruno. ivanmurashko added projects: clang, clang-tools-extra. Herald added subscribers: usaxena95, kadircet, arphaman. ivanmurashko requested review of this revision. Herald added subscribers: cfe-c

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

ivanmurashko added inline comments. Comment at: clang/lib/Tooling/Inclusions/HeaderIncludes.cpp:328 ExistingIncludes.try_emplace(trimInclude(IncludeToAdd.Name)).first; Iter->second.push_back(std::move(IncludeToAdd)); auto &CurInclude = Iter->second.back(); --

[PATCH] D116052: [clang] fix out of bounds access in an empty string when lexing a _Pragma with missing string token

arphaman updated this revision to Diff 405155. arphaman added a reviewer: egorzhdan. arphaman added a comment. Fix test failure with asserts enabled. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116052/new/ https://reviews.llvm.org/D116052 Files: clang/lib/Frontend/PrintPreprocessed

[PATCH] D110280: [modules] Fix IRGen assertion on accessing ObjC ivar inside a method.

SharonXu added a comment. Hi @vsapsai, I checked out the apple `stable/20211026` llvm-project branch at https://github.com/apple/llvm-project/tree/stable/20211026, and ran check-clang locally, but the tested added in the patch `clang/test/Modules/merge-objc-interface.m` failed with the error

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

tbaeder updated this revision to Diff 405156. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117888/new/ https://reviews.llvm.org/D117888 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp clang/lib/Driver/ToolChains/WebAssembly.h clang/test

<    1   2